From patchwork Thu Feb 9 19:20:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13134994 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5EA3C61DA4 for ; Thu, 9 Feb 2023 19:20:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 34F5A6B0072; Thu, 9 Feb 2023 14:20:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2FEE96B0078; Thu, 9 Feb 2023 14:20:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1EDE86B007B; Thu, 9 Feb 2023 14:20:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 0E5C06B0072 for ; Thu, 9 Feb 2023 14:20:19 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id DEFF780B9E for ; Thu, 9 Feb 2023 19:20:18 +0000 (UTC) X-FDA: 80448719316.19.90EFC44 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id 36090C0022 for ; Thu, 9 Feb 2023 19:20:16 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GzFX5MPf; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675970417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mkZoK0/aAqvT+1zrAd5/4wcBd4tA7+DHKtF9ign+pSA=; b=vhEVlpGlFpBV3o6nTyNG+Mj+dtFqu04nem16eRLfw33vH9Uu2F/sqKACq4Tis5I3WFebgQ Q8EXoQjN9lIKcGjs8ARAG5JiwLz+OIDfp5a7qcjIO6js15Fm7cUXmcCZKXVl+Ajj3xHYob 63d4Jh2ibW9S810s6jIH8eb1rVTbMDw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=GzFX5MPf; spf=pass (imf22.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675970417; a=rsa-sha256; cv=none; b=1dhUb0kfAXYTAopGBPbrh0YbtWlYWoJuirVB/W+Pizc1ccTVtwp2si1QzpMt+VscyoRT6x QxBcbZdqnHOMnZD4BmAjdb4vDmKv2Drk546lifp5fh3N+WJOGUTUjZ10HWJe/HLnJIE1av satAcqKBPboosZacAkljdRerhR0XIm0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 4B25161BAF; Thu, 9 Feb 2023 19:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 27BDCC4339C; Thu, 9 Feb 2023 19:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675970415; bh=x39PRc/T046lvvssIPKrbvAhJnKd48hEXRslXo6G51Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=GzFX5MPfuSPK29Lom5JhsbHaaPcgjVVf1YkoJfatDQvxT5JmnDvRrVYrsiJRGiXTK L2Pe4kmbM4k/370TpVO1iWj1l5UpsBTyojfgcZice2Ge5QrYw5xcSt9xvsFixlggAT 01IJkraGTY4i3MaiKeoiBoklVgJwQqvr8lALW54YozE9TnHdqgC77AbXHHlGtEUH5k ig1KK8mmIgy5hjL/Rpehj3X6amPuwwYe2gV1NClvixj/EL1PV6LanqN4qivaSBtGmy kUJp6CL33PK925drX8e4s92T8z+AfPtOpzjgRBJhQgT1lwJzPyb+0i9jP/jaKTJysf dSNNcCw/cXYbQ== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/3] Docs/admin-guide/mm/damon/usage: add DAMON debugfs interface deprecation notice Date: Thu, 9 Feb 2023 19:20:07 +0000 Message-Id: <20230209192009.7885-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209192009.7885-1-sj@kernel.org> References: <20230209192009.7885-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 36090C0022 X-Stat-Signature: ww9mq681jxg856w5y58ijm9fafx8nkwo X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675970416-737478 X-HE-Meta: U2FsdGVkX1+AYHoI0vHiZBCZ4FaCGbH/Nu514syAa1y+zNbgdPr7Fbj27ajGNir5R8/39kr8WOazY/2GueOISJslk3P4+zjXyOKDlNUIkfte9mQIoll410osMXYoFFucQrZB5jiMz7VsmQ5WvlXdNqOB/6FpD+C8ZdftKN3zlEhDOcg9QJBmf1GxMne4Ub52Z58w02eHIl8O+Sue2xOyg7Abe5RoqAVcn0hg/Ad1uHuf4d98Mcc4GFi2H/OMzwZ3RGwgGAVHVX2OpRtMNFYRtZII0mAIJwzjtqjHiB4vxdLVklKkW2f3Z6iDq4p5ekUBNR5i/8riA5Sx7b4VcgTsHINXheIAnJXBTzM78iA+hPmQMbc8U5+qignbHFAz+ms7o42WtwfvgRCvYHXDui6H91+owD8HXZG0pKrOkQnOrb/tMO5+5xACHj56wxcUmop+EDePVA76yuOj3r2ngWkcosCKqeBuX5jjhQkfsLM4/DXlxzFjDZd80lYOFlIaqvdKulI0hT5v6wy/YtR3q3qixD65XschxrQIrTkfrEc96UE4nDOdUK8nmcSuXLV9VPqXQzRqQz+O9DXQGWS6fP8Lwbme+mmi0/kw+o5zOnaDxGbUAjmAQrGVX1NM1Nrhl41Pwo7OsP1Pf4bHEugsfsSBAtXakJ6ZFz3ZBy0u22MuvVfLbM64K5WjNDcI+JMI+VloKZYAuPzvwwhkTVbbRDRJCkg60MZ9qfOZ6TBKxh+t5P2XkIYMxv1CkgWRzkf6jiPSWz6FHpsFShkwDRkuFgCEjDu+3NOKQagzYV246tU4zUZogc2Uw+tGafcMrXMKVvrHq8YztXy3QQeoxeJc81ZHcg6Bn8aqb/VJIY2oS5auifnTsOfQz8o9/GQ9amKzFgntnP8+CpeBbTVwuT4Lwm/wOoqcMCE+uTHQth6FlXeDHc94L7ccFNx9e14fOPs3Dgt1B3toY3z3pkr6kGGjrhP K4HewYl+ X+W+IPuI7WhUMMjl39BvM/n/OzuEnrXaQBJ2jS7Z9hM2g1aCNK5B3UWk1FdGfaechY/8UsfMb5dkIRxFaH79YP7nn2rH55lDRoPkVnQZszHaRF+jitOLSUTH41HdaKSJtj420RsQPXpb6aHZTr5+A3E8kSElxm6CvibTnr4foRF1mVPjUhp/R6/e6byin7RE+RQzpqGaig5TChLYAe/DY4L+9xWtHx5JyB62ZRwcUWEZfB3cu67WInULvwo/FETgqQntBpPn1kc8xP/EFA1/GeIN4TxXOEirkbMTFcgtSdjunbYDTMmJKQ0z9x+ZWCwBbQvqwqmZrCNXF7MH/TYLmljGl7PbfjodUSrg/OucIntAzhTLEbJyUTbpkj2o5aV7wL8gSNfMPZrOp1nbhrlRAAUnAZYjsF/K/5KQR X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the document. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 9237d6a25897..9b823fec974d 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -25,10 +25,12 @@ DAMON provides below interfaces for different users. interface provides only simple :ref:`statistics ` for the monitoring results. For detailed monitoring results, DAMON provides a :ref:`tracepoint `. -- *debugfs interface.* +- *debugfs interface. (DEPRECATED!)* :ref:`This ` is almost identical to :ref:`sysfs interface - `. This will be removed after next LTS kernel is released, - so users should move to the :ref:`sysfs interface `. + `. This is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. - *Kernel Space Programming Interface.* :doc:`This ` is for kernel space programmers. Using this, users can utilize every feature of DAMON most flexibly and efficiently by @@ -487,13 +489,17 @@ the files as above. Above is only for an example. .. _debugfs_interface: -debugfs Interface -================= +debugfs Interface (DEPRECATED!) +=============================== .. note:: - DAMON debugfs interface will be removed after next LTS kernel is released, so - users should move to the :ref:`sysfs interface `. + THIS IS DEPRECATED! + + DAMON debugfs interface is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. DAMON exports eight files, ``attrs``, ``target_ids``, ``init_regions``, ``schemes``, ``monitor_on``, ``kdamond_pid``, ``mk_contexts`` and From patchwork Thu Feb 9 19:20:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13134996 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 04856C636D3 for ; Thu, 9 Feb 2023 19:20:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 684986B007B; Thu, 9 Feb 2023 14:20:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 57A4E6B0080; Thu, 9 Feb 2023 14:20:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 216076B007D; Thu, 9 Feb 2023 14:20:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id DC5986B0078 for ; Thu, 9 Feb 2023 14:20:19 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 805811C68E0 for ; Thu, 9 Feb 2023 19:20:19 +0000 (UTC) X-FDA: 80448719358.17.B9722C0 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf21.hostedemail.com (Postfix) with ESMTP id CB36C1C0012 for ; Thu, 9 Feb 2023 19:20:17 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="rA9v/IlA"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675970417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GMhQv0JeYHPs+Hm+FPEG1Rx/DU8HSBna4LuCCkQZS2A=; b=pU4Xkq81uwiheCl5rcW8qh11Fv7UUDcRwOTnLNTvSdHEisU6T+WVX9EObSm44NP+NeDYte 9tj33fb0TETRCah5CvXd/ELkVeu/FqViB0pz/BEGWxfdAp3JyaCD0UhHTORoJgQ1x02QpM edJnzLVRz4khsTwt9qeuiMX0UnIz0aA= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="rA9v/IlA"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf21.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675970417; a=rsa-sha256; cv=none; b=gCsRAUm12B7YtMstMX/7Ryw+rNmpmH+8UL2dDMdSj+CiPHATj+OJlO4oqSmHGrQal1N+Ip Kc1ry+bkJGWMDtEQCBbO4p7A2mVz9a1A+7h6tI0oZV1YqO2/YEEqujRa8K8xKVWPOQEoeR UNSe3/tVICqzlD+r4A+29z7yen+JLe8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D420161BAA; Thu, 9 Feb 2023 19:20:16 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E2561C433A0; Thu, 9 Feb 2023 19:20:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675970416; bh=3ZPhytsG6MoiFI71uMGAzjRAm4p3c/2mkgqWantxo+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rA9v/IlAimkmQzJd9fC7BNDYoPRQfdmYdGr+BsMUvy6S1DlXT51Ze4eoQXL+sPJej saLINvtg1Ytlv865eJ5j2Tv8XVxFNX6a+4wtC9SaFulcqmopRSukl9hmpf11dKstlN +QYIu/tzbD+w+BSs7eqEOgDdxDn5MExI0Gzhea5qwmoaSOzQNpgt68WwOdoOD7/OH0 bEIifYbc7ua2i4DE53Awy0TLV7o64OPnHiwTruOuFRURpYproX4HVWe/wBmJTG5yM2 e7UvDENGm8vA0b/rWFcbw/96jTHVryPSdrKOSnhIl69NwvCEDoXV2m+URReTq6okbt dFDxxllM6tZRA== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] mm/damon/Kconfig: add DAMON debugfs interface deprecation notice Date: Thu, 9 Feb 2023 19:20:08 +0000 Message-Id: <20230209192009.7885-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209192009.7885-1-sj@kernel.org> References: <20230209192009.7885-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: CB36C1C0012 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: pms7rjw7387pk5qruneghp7jz1qowf7j X-HE-Tag: 1675970417-890811 X-HE-Meta: U2FsdGVkX1/9KldLfUUAcxfUJNK6QnajO1VfBtzINwF6zlUrFqMBGdMjtvGVaPSy2ywulGeUZK5U02yeEbn3tmXczpFulg1iEcf5fqbEspgTRUeyoJU0d+HCf8Xiu1J6GUepgJs6nBDXvaapn/fK+LslFdWZC24FZ9Vy53CNTvxU7AiL26HrIk3wHQ+pF4KaTGbe6KFcE1CHbHH49a1tPGJG0cuLSGRyeQtHejRJFYdfySNyndiiaMDbvP4eNG8xSMew778Dh8f4DVCrDSeZ6SSdzeYN+qkinKRQmFfwVzBK+3Um/qAOVmiixHNkoRjtZd6+TUnva8OeoujxTGNPkd+nuqUDPKrnR3M97qOU4JlcBds6GgWyJaWvq2HzHte8IOdH41PTfrmkiouaHaLuuJqfglvPonwWiuB55NYbobTEb+rDsyYFpAfaNVKnhVHTncDRdUWmpvr1bOwL/iIAyNialFoZBpE756N7ucILfCumlS9q7bnWNnvHnk2WibpBsn/yCvstA4N1MrLKYtaDXWwmamCjjX5sybGFoSjIhCVoJl0oEyhRxoPcQbUNIh5jBtT11kQlF6ZtiOwHc/Zl48uf0pigck6Vrjuj54gGLvC3o4JDL5MnpraDMReduQqn/DkxRy1Sgxby74nC1ZjDd4PzOL/w565DxVmDjiFP9a5yIdYOSaWahsT5jmFgMaugVkWu3ltA7vZ8Hi7va9BkYLfMGrSQ+JdQRl7n0u5lYZP+v8Tb3/3l3qBrNAHC2WffX/JCR7DhGOLwwwUYdYVhNpH/Nvprua6Qh0pV+upFIXFbR1eEvuqar5Guo5Xwx0RA8SzF1YJ4RNHsowfvgAXced0epmu7D5rtqox+Pfz7TBEf1ktvUSI3nXpzTtx8YC+5ume1XQpj2eIhNX05cUgj5J4bZo623OZeNZvbVPgBqUAiYLVWjtZIfzYGyOpy3IyhjfP6/qNdeynjJc1aX32 0cl/A6Co YKVyZHnXy8vtHTe41/KhrF0W3k03xvvWkdP0Ys36jAKap3WaESB/8VSFZ+tOJzkB/lniDcGFhn09Ic7H5RKwdawqMfKnAOZfXBRlPUcphnD0KyNVzTIpvF4ArQRH51wrJEVJ8VP9akr5Skdtlpydb5xJTDoeJC1Q9dOmfkjEeYs6jdQP3umr1BW5eAiwja7ByQiEXSJFmg5QFw4zE48hHHvchXutN2mE7MUGvphtkqbyEcaUD+h+blJeKAunOIALG0cRGW7UOtp173W5Fj3vu4H2zgZjISLdlY7VBPjZ5D/9HF3F8wN9VzdM8bqgpxtOHS5a//iYOywuUzKpaBnPLE7tVJ2qbdTgD/Tml0hdPniJ3f0uIMDamf+RMg/va6uzU+lKeg8xyAKm5KoxLPyrQDWab0sPhSYJQABtr X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the Kconfig. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- mm/damon/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig index 7821fcb3f258..436c6b4cb5ec 100644 --- a/mm/damon/Kconfig +++ b/mm/damon/Kconfig @@ -60,7 +60,7 @@ config DAMON_SYSFS the interface for arbitrary data access monitoring. config DAMON_DBGFS - bool "DAMON debugfs interface" + bool "DAMON debugfs interface (DEPRECATED!)" depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS help This builds the debugfs interface for DAMON. The user space admins @@ -68,8 +68,9 @@ config DAMON_DBGFS If unsure, say N. - This will be removed after >5.15.y LTS kernel is released, so users - should move to the sysfs interface (DAMON_SYSFS). + This is deprecated, so users should move to the sysfs interface + (DAMON_SYSFS). If you depend on this and cannot move, please report + your usecase to damon@lists.linux.dev and linux-mm@kvack.org. config DAMON_DBGFS_KUNIT_TEST bool "Test for damon debugfs interface" if !KUNIT_ALL_TESTS From patchwork Thu Feb 9 19:20:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13134995 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BDDBC64EC4 for ; Thu, 9 Feb 2023 19:20:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 39E356B0078; Thu, 9 Feb 2023 14:20:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 34E686B007B; Thu, 9 Feb 2023 14:20:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 105DB6B007E; Thu, 9 Feb 2023 14:20:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id E4DAB6B007B for ; Thu, 9 Feb 2023 14:20:19 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 81BE2C0FB0 for ; Thu, 9 Feb 2023 19:20:19 +0000 (UTC) X-FDA: 80448719358.16.81215A6 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf07.hostedemail.com (Postfix) with ESMTP id D803A40009 for ; Thu, 9 Feb 2023 19:20:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YNwNncax; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675970417; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=v/ZbcDDyGp1GCgR/7hYyVbx4tuFen8J1znyyD4wVL8g=; b=5i8Db7CYeEbIeFnbSdSJS8m/kixJDyen3QYWfkDef+cG8lWr5clXUTJ7fmu4KxUtHY91LQ nv1NocBZLxyAwtouJQvyvrOE0HOrA788jdG53E0nVQ50B8F31CMqYzHGXLYwBnKJbUkGWL ZBz993dIjq3ufDH+PcckVBge65eHZ24= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=YNwNncax; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675970417; a=rsa-sha256; cv=none; b=n4d6VpWJljs4plOPl7ABmv+Ltsoe5pASg22v6qLJY/9hQ144GTCUpRYB63VHtBevPBJLLc 2WA4ffDCzb3zmmOraG21XOFKnxCkKzOEDP6zry3a4ynON2OLNDwugWVw85TPLX86K9j7je WSMFkThyb1VA8fGd5jgT5opEx5wbYKU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0F0C461BB3; Thu, 9 Feb 2023 19:20:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7C11FC433A1; Thu, 9 Feb 2023 19:20:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675970416; bh=YKnuEvRI6qfPAJO2dUUkfnH+bQPuZPD2yzEq+Lx0+z4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YNwNncaxqJtNLK1jiU8L7oyV++uilfm1Jne4U3kLLB385NSqtdiYkJ9f+YuB4rOdK r8irMblAq+as8w9prFXzUhRqT+sN+Q8MUOX4T2Cct1ET47M1Wj8YGIxL9yvdIt+GQX tJrmah8kxg9jC8ep0z3I06JWRIl1Y652uHmKIWsjWEVZ6cbkf3A7U5L3N//AQDz4Xf FbHuAgyGYxo05IvYJnqmOh72HjluzjCiL/YsfqTdGsa9yqVhZU0WXMzbM5FtgWLRj/ 7SfnQPPzftZC0eIW4SR3pZgk8QhRJV6q5mTmj6nX2NU2shlUhkKAdA36QETg86+6oi wWowqMT+cl1zw== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] mm/damon/dbgfs: print DAMON debugfs interface deprecation message Date: Thu, 9 Feb 2023 19:20:09 +0000 Message-Id: <20230209192009.7885-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230209192009.7885-1-sj@kernel.org> References: <20230209192009.7885-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: D803A40009 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: gagma4hceom8r3cu31cxksmsyngjhts6 X-HE-Tag: 1675970417-943846 X-HE-Meta: U2FsdGVkX19ixdKU/PRpsvyuLcdaLIozRK4yyKKkkH57UnsS9MJVSx/DyKpT+DCf19Y/5KrcdBt6AHjXLhahk3XBLTuCQNVizuU2LOYLLqg8gfwXCBapkZZd3f+MQhK5PWvFO9EduswQXeWwWqsWH8ECSSvD7Qvm6fCMyWIIvn6TWR43/95NjGpSPs+47s6fDjGpMlikUxBIzWFb4VG6Qf6EZYSCMvD5AI4aGbNYCsb1Zcq1EW6Qm+Kw4O/g+sq1WP28z8OMdRwwThyPs2nJGdRDvpdI91O9oD6KAQMEBNkR3XLe2zGuttcdav1RMg3I9o+JS3GuyYj7uV+9N3YFDlC8rC8oCyuybGe+3xR0iuY7Z0IeHL+PgM2Kl+FaU1Qp+/UEZp3EbzNvA3nUI27Z/uvwsm+UwQ4oUTn6msXhkrJwkoH0JGdIfv04DYE1vueAz61Il5NiJMHtsMr9Wy/xzD6V0im9hN5/7Om88x8Cxz89ktneZWigwC1aqW7Csvut6/ji9riLgQwpctX2fK6A7B2Zam9o27WI+1nV16kE79rJeWurK/+VeEtUaIp++P6Bu+pyYSxVpJjO9AWblE4uanMHASv6vsNOEqTXV8uhfrJMXTH7W8B77nZ7pTwV3r83z0EuX/JNGRSvDKkRp/ef9T3AoCCh36ZQds7ofUj/WkwF/QqaclzIQyDRmPWs9X8blQRbYgGE1s16XuBJIaFe0E5MleZz7m4X/NXBy3UUmbX4ra6HJf3qrvGyMZSMeq94POTfaYQxfjNrrR+QQuR3e5NVyI4CTbY8A91Q5mXnl7Lp53OK4iORJ3TFBIo9pX+b94i7uGaTsCvngWOmcLWDMv04lwXADNv0zURZaRozvpED32dLeW+77o1NtDuSS5r2wdGU9UcCf5OWbCLXnxYkpTjNYFjLSHUlZ8k1dzzlxoJYdSGH1Gpq23o7VZXLpaV2ZDoNAB14a8wYoTeZufd 5IvCrlpG 6Cw+InoNVnAyvnyzVzzsA6wkiD+gE366oxLIVWY8MAgeXtez14Zu7dSOR4pfs17SIx2sqi/dxfnaqt9jgPYYDki1TvmO3wkuy3zVmr4xPPJk3CI33QNm1iFsUIRxuIezI2wCd5N2xI8g2TyYb/z9IAnw/IgaeFmaaGXKjlcwlEuAIAdA4QNymhYfIU9nStNLV1OgM22zK8+JeG8BnaIIh0tG2r/hVeqgABKOAV/e6Cn06Y3lK/j79D3jjbwAiDDUtS0XdJRcMaIn89sg59tWXT9Z+GpMOUna8crEZtHZCtKehaNJRBPxtpgrVy6Hly8VCdcJU35bBPdI94kgEV++y7F+H6Za0yLMUq0uUc1IpcOPcv1SeerRuRO82rkJm/6vWvF4Cb7V11Dz1nZonjtVL4kUQ8IB8GM85scY6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, warn DAMON debugfs interface deprecation with contacts to ask helps when any DAMON debugfs interface file is opened. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- mm/damon/dbgfs.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index b3f454a5c682..e551a20b35e3 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -20,6 +20,11 @@ static int dbgfs_nr_ctxs; static struct dentry **dbgfs_dirs; static DEFINE_MUTEX(damon_dbgfs_lock); +static void damon_dbgfs_warn_deprecation(void) +{ + pr_warn_once("DAMON debugfs interface is deprecated, so users should move to the sysfs interface (DAMON_SYSFS). If you depend on this and cannot move, please report your usecase to damon@lists.linux.dev and linux-mm@kvack.org.\n"); +} + /* * Returns non-empty string on success, negative error code otherwise. */ @@ -711,6 +716,8 @@ static ssize_t dbgfs_kdamond_pid_read(struct file *file, static int damon_dbgfs_open(struct inode *inode, struct file *file) { + damon_dbgfs_warn_deprecation(); + file->private_data = inode->i_private; return nonseekable_open(inode, file); @@ -1039,15 +1046,24 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, return ret; } +static int damon_dbgfs_static_file_open(struct inode *inode, struct file *file) +{ + damon_dbgfs_warn_deprecation(); + return nonseekable_open(inode, file); +} + static const struct file_operations mk_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_mk_context_write, }; static const struct file_operations rm_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_rm_context_write, }; static const struct file_operations monitor_on_fops = { + .open = damon_dbgfs_static_file_open, .read = dbgfs_monitor_on_read, .write = dbgfs_monitor_on_write, };