From patchwork Fri Feb 10 04:48:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13135370 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00E05C636CD for ; Fri, 10 Feb 2023 04:48:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8A9A46B00EF; Thu, 9 Feb 2023 23:48:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 85A7A6B00F1; Thu, 9 Feb 2023 23:48:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6AC216B00F2; Thu, 9 Feb 2023 23:48:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 4CEAB6B00EF for ; Thu, 9 Feb 2023 23:48:50 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 2D8CF1A1263 for ; Fri, 10 Feb 2023 04:48:50 +0000 (UTC) X-FDA: 80450152020.16.D5C6A51 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf06.hostedemail.com (Postfix) with ESMTP id 669A6180004 for ; Fri, 10 Feb 2023 04:48:48 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FMLebj8I; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676004528; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mkZoK0/aAqvT+1zrAd5/4wcBd4tA7+DHKtF9ign+pSA=; b=buvjHQ9256X3fFn4zfRUn2aR5evJ+zI57atbePyuNY9CXBiH2GtL2kSLqwYuTPqYlwcFqK ks58CNO7HJ6HMAVhQKTfzg1FUEXsNSB9s+bH0b0D8Df0LPOikcER+G3uZUIWKz74CUMzdd Wn66Ek9kNcMTAwrnIFvbFQpZwiEy4QY= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FMLebj8I; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676004528; a=rsa-sha256; cv=none; b=WP7bY3nAYaSBjh1xUGlas/SVAtowjvhK9VEKEwJTYY03AVyUq1WKPByWrsiDB2j/43INmg hUEGvD2kfhw0XSKnSPzNJkyjdtouhWy+dv/O1W1NID7eiM2zFRa/Ndo9h5UqfskhL6OedO NUiNp5ZDrxYm98SIVHWadPut5FlPSF8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ECB7EB823B6; Fri, 10 Feb 2023 04:48:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20213C433EF; Fri, 10 Feb 2023 04:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676004525; bh=x39PRc/T046lvvssIPKrbvAhJnKd48hEXRslXo6G51Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FMLebj8IqIs5vo3DVpcyJ7/HYGRcBna7bSZLxkCSGshx/DP4CdpuHOVAaOReZtRS+ mvg6Lcq2EvaItJZPKIFui4VtCK8HVABM7HJGyxpj5ZGGmKpXW0kQyBXfY2fUYKtXOc b5aOsOV2S2N6G4fwtA249ibOtNcjB+m3qgzqcTtlLBnImql24nHqtawmTX0sBceEtc OB2CmTl4Auf+1ifxMouvM7y9Es+WBzZOujAgRbNQ1TSfqoSz/PizZds/CK1iJm0L85 Hw3gZtC98Ki9w3YCcHiUvF58EOttEltnfi8IHvB2yQjDSobfBf1fgqIaLvbwZDEOQl tZieONTUe/zXA== From: SeongJae Park To: SeongJae Park , Andrew Morton Cc: Jonathan Corbet , damon@lists.linux.dev, linux-mm@kvack.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] Docs/admin-guide/mm/damon/usage: add DAMON debugfs interface deprecation notice Date: Fri, 10 Feb 2023 04:48:36 +0000 Message-Id: <20230210044838.63723-2-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230210044838.63723-1-sj@kernel.org> References: <20230210044838.63723-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 669A6180004 X-Rspam-User: X-Stat-Signature: sarp5qkwrqfdcynugghjpkjtto665sy1 X-HE-Tag: 1676004528-240783 X-HE-Meta: U2FsdGVkX19zsBqy9fVS/PJzyzDMU4e9LOC9eA70iseddaGyV5V64LZfFrkvwjHPPbQlgnOFVYLwjhgzJ6hMsgQz3F0KLSSm45KATHYQypPUvUmKmQYxBdgXWDLZwaF/7v9f+xXVg2brsIP72yiV5ga7nZzgLL2SMxSI7GQDNLP+nW1b2nMEdzGx42aadQnu/yE15Fpickf2ann/QHXY4n23blEPxWMB1jtld4AeMyzT6eBucESHYSyDg2VD4smOfE9t5ZRTIb+YmF41I7YR8cpR8hd9i8GRd3h2mWMCvlIOvBj8pvUCwaC02JLYbPKdun/9lMZGLFNruqqtsFvJW7TZWzyjYucuBWO/Z8jEP5hhDKteEp+y2IMG/MAf+XYJ4oPmKmuCDszkJH9Z+R+pUub8WXoYztbkyiHEVMb2TTRb3q3agbEr1CDVYWJ8zv432ey4YYRitQZ0uFfSc4mSTAUXAr/muHoAYvuZr4CyVexjMuwL1zOe4VekSv5FjSKTSbpG/iReUoz5ffp9Rgjb5/LtH88BcDIxFP06plsvHgJoinAMro4uEPSu+KpJ85Rf4HjwxIRdrkyN8UqjylF9D7AYQm+GNnXVogaNjXiMSM4WffudxWQ90J8YyjVuWiQwYcXamcI40VcyDHFe4FSytl5Hbxla6BC8FHLQDV4lqXDTCdxDTqqrf5KaV/R+tnpFOQmOR0jg53Ef/cU5Ybek4H/musvNGfyZoubpfs83mSGYR4qqwwtdn7GdYVfqjUQLT9ngGovvdhRt6PONdNQDv03fPTG3mn5AA+wfUm+bx8J9opsi92JYE57I6NI7iNs8RN3dITUXyySnld7Cck1AjtdEc51IvxeA1+W1H3Szt/4CfgGPwtdyQY5mT3eLoXj4cfP+6KGbIPyDFelHsnL1Ehx4Hnd0btuoggGVl1lbxWW75CIpPsUqMA4RV64JdBNu9AZOR6cYP61hwzFYsMx nZ/pJETc TM989pERKZUTQptqTRyuG6aB4rZbeP5rr9vOpVnbF89g0hnNc62TcrJz0MEFuSYCh36C8VknbNEHvg1nj7Jt2ehZtrPoegfXF7voySr+Wqbx08sk4+4SVe3zySbn+NI4MB7naRV+/79EEnkkNSkv4JKbuad52wUQGKxM5njIdB2rPgkqTXL2r8eJ9PzAvVEDPrIs++/ksEku1qkqr0QYJwmLszltv+GGaj/ULiN8aPgIO9Xn29S+wzTMktB8NPjCGnvT7pn/315C39fJ6/NNytk4MvP9MJWQ1H9CXLgSxC9IyXTKtLjChQ0qHChBUcktFWyG48GCCEsaJ2UkQFSODpwLbAAKcs9aDfRgszxIVake9cQnp6PERNQdB9js5gOwPZM89yx8iFPxkPYwWZ4ZW2sKePtgmbuYlahBB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the document. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- Documentation/admin-guide/mm/damon/usage.rst | 20 +++++++++++++------- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/Documentation/admin-guide/mm/damon/usage.rst b/Documentation/admin-guide/mm/damon/usage.rst index 9237d6a25897..9b823fec974d 100644 --- a/Documentation/admin-guide/mm/damon/usage.rst +++ b/Documentation/admin-guide/mm/damon/usage.rst @@ -25,10 +25,12 @@ DAMON provides below interfaces for different users. interface provides only simple :ref:`statistics ` for the monitoring results. For detailed monitoring results, DAMON provides a :ref:`tracepoint `. -- *debugfs interface.* +- *debugfs interface. (DEPRECATED!)* :ref:`This ` is almost identical to :ref:`sysfs interface - `. This will be removed after next LTS kernel is released, - so users should move to the :ref:`sysfs interface `. + `. This is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. - *Kernel Space Programming Interface.* :doc:`This ` is for kernel space programmers. Using this, users can utilize every feature of DAMON most flexibly and efficiently by @@ -487,13 +489,17 @@ the files as above. Above is only for an example. .. _debugfs_interface: -debugfs Interface -================= +debugfs Interface (DEPRECATED!) +=============================== .. note:: - DAMON debugfs interface will be removed after next LTS kernel is released, so - users should move to the :ref:`sysfs interface `. + THIS IS DEPRECATED! + + DAMON debugfs interface is deprecated, so users should move to the + :ref:`sysfs interface `. If you depend on this and cannot + move, please report your usecase to damon@lists.linux.dev and + linux-mm@kvack.org. DAMON exports eight files, ``attrs``, ``target_ids``, ``init_regions``, ``schemes``, ``monitor_on``, ``kdamond_pid``, ``mk_contexts`` and From patchwork Fri Feb 10 04:48:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13135369 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E061C636D4 for ; Fri, 10 Feb 2023 04:48:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AA5446B00ED; Thu, 9 Feb 2023 23:48:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A559E6B00EF; Thu, 9 Feb 2023 23:48:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 91D996B00F0; Thu, 9 Feb 2023 23:48:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 825516B00ED for ; Thu, 9 Feb 2023 23:48:49 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 4DBEC1612ED for ; Fri, 10 Feb 2023 04:48:49 +0000 (UTC) X-FDA: 80450151978.17.E0679DB Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id A2C0818000B for ; Fri, 10 Feb 2023 04:48:47 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XdilebEY; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676004527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GMhQv0JeYHPs+Hm+FPEG1Rx/DU8HSBna4LuCCkQZS2A=; b=tAmgxjb2NHMvWwub4B0yjeZuruaYRZaMXfsS/qWuN9m22egvH04sH45xwnb5+CZdsI20Xt ONlHtmYa6sjKP03V0bDmN7ZuYNjLN7zHIulBe92oXWBf+x+fUh58/1x996HYqIR/Piz98J RjHxmcWNgnyQelqjx6n//P7PiqN65u0= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=XdilebEY; spf=pass (imf06.hostedemail.com: domain of sj@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676004527; a=rsa-sha256; cv=none; b=MNHq8Dmmd6RXbMpatAzZTcMf9Z+aZdrRkdbyni0GS7yUQsI4HD4WOnxIZIDy51925O13Yv JcriCuE9nA4FBcd2Ap06uDYHZwxacypJ3zyKSXi3TkY8yCh2pW5tXG5AMWZAwRvr3Mb31v aM0t6sQZAHV4+8jlpSN8gU8T2iAklqw= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id CEF1A61C1D; Fri, 10 Feb 2023 04:48:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5971C433A0; Fri, 10 Feb 2023 04:48:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676004526; bh=3ZPhytsG6MoiFI71uMGAzjRAm4p3c/2mkgqWantxo+I=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XdilebEYHnliIo6ccsozIn8z310XX+J4YeoCbW7rHQ02/iln2iXxE9EPvQfBjxLax t3ysfYwi4WsuohmRqftPzIgku530OlwXFpf3XyzBHQjyXWftPiGot3pG6gJwcCoJK3 NTluwuUy5cBGGi1P7UEcU1ZMFeY8ED+DIAgqZw4WjDJqwj+DJOuSP/4PUQmO8Uz265 5KTyBUZzr1t7Oe9UxIM5csHGF8Q8jf6WQe7xmnzaI9a1Se2LloVN9qnQ1LJckDykx6 x4HSp+SsZ6xYd8rw6ZiBjPcRKEaoRozmHkbJ8dttfY+EZtSAVlxs9CZAaveKCXb81/ UzFACfqLtzIRg== From: SeongJae Park To: SeongJae Park , Andrew Morton Cc: damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/3] mm/damon/Kconfig: add DAMON debugfs interface deprecation notice Date: Fri, 10 Feb 2023 04:48:37 +0000 Message-Id: <20230210044838.63723-3-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230210044838.63723-1-sj@kernel.org> References: <20230210044838.63723-1-sj@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: A2C0818000B X-Stat-Signature: 1hxw73wm8nyaz9x3amz7h9iy6kec8hyh X-HE-Tag: 1676004527-228359 X-HE-Meta: U2FsdGVkX18CYjMj6RuCrzRA3PQvDsNVMdsIEpmmO3blMFZHuebFIHWuXPjklqWjd2uIcCd1Jaq24GH+Go4Lq2XVrgVtxnUaJdGomDExM/QvULlc6ZlwQoo8aDy38fc3u5CcarAe4Qm75yMNofzTHwPlrM3eRSqS9J/qDsYup4BYDUgwXpggIarePSS+zG97LvZ/TJbFeyWyucrM4oy4B461tBRuE2+O2e8kz7jwinH1kYEgfh3sELeYFP4ypwR9O8Bq1w35EtKTI+lHJvm9wEglGGcMg1o8fSjIJYdxrv/UmPVLk5AUIQOAbH34xJWx+a1osr7eOkDdiMN43r8NdLUwyswcvXlJrGzxVL8RUtacw9xHACRXFFTSkQTxS5YGe6rLjKc0PRGyJaq2/tArzJdkd4St+AmF6yhQRzz/ovRHW4xJXc6YmpMV5vPBkF+x8v0jDHlcYkLTLQIm03BPo7LpvNwdDGeHPDYFZxnlRmCzHRi1+kGgC7oM3nfmCgL3bt2vURR5kz3D9OAiyU75sXdcWTtwwn+8Y9X27rk2HznM2x/uLQzF+YXnZDSrPrVch5l2AlIbhGdaXiDzb59mbd5MAIiSLwHdcStSh34CffN6Aoq8jiHpjdedO/6CUR93iw2F9Du9+w+VLkmUEQBPYDBCr8a0fvqw+iuKVWbEKfybf7ci1YwQP5hnZH075lRgMNRdB72NRem1yKU3vvfUieQyHGeK0G7QCjNnjeNY4kdepfIRxrO/89qu7cLMxVeMIVXFpNB9neneuoRqbArggOyHU4Q+QjCufCu4O2STHeZW99jybYT11e8zHWx/jBWHWNNWbp5eEyxWjpbgtlLbp/qYAS1qZ+uCVyej6bZv6lgwljugMw8j8hothKedAG/e6ZX4dqpze2Yvs8kzhoXiZBW7r301RmyI4uqbzOZZmeEpQjHTWdJqVWUSMqyybA4WaQFXbYVfZCH7xeyqc/s xejuFWB9 rt4Y6LSsctJ5MRqauJD1cTl8ABBtusZNT6TDB0hZ5GKP9FIKeAdcTEbIWzazxxIXezIOfs3TVvKlRSYzGNzWSuwFCygD9dIDWuXK2fjaC/+zw/aWMyuGrJzjfR4uH+fvihxLOUvNAn3V6dj75l3QjKOCE/hCCbQDVIVyTZwOIgQEBbx1bT/ZqwLh3uORJnw7xLF3mZb2dUpu1/g3dp4pdFjs8ymZBMmC+uDGgXpGJEIaCbVMvA5jykjDe0UwT1yy7jAqdFA6MSm1gS17raKswRmLuEZDMM0dc5EKSSdKMp+prkkt1GsLKXSBxSi04NVY1JuAgDRne4VEwnKtceC5mcfgcjtJxqy4vFbLVDJuAErjqhDjMn5Bc/tXWkUkF5Gs3rZa2sQevVc3R7yhY7vL8MKREqFp+hn9rO5pW X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, note DAMON debugfs interface as deprecated, and contacts to ask helps on the Kconfig. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Signed-off-by: SeongJae Park --- mm/damon/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/mm/damon/Kconfig b/mm/damon/Kconfig index 7821fcb3f258..436c6b4cb5ec 100644 --- a/mm/damon/Kconfig +++ b/mm/damon/Kconfig @@ -60,7 +60,7 @@ config DAMON_SYSFS the interface for arbitrary data access monitoring. config DAMON_DBGFS - bool "DAMON debugfs interface" + bool "DAMON debugfs interface (DEPRECATED!)" depends on DAMON_VADDR && DAMON_PADDR && DEBUG_FS help This builds the debugfs interface for DAMON. The user space admins @@ -68,8 +68,9 @@ config DAMON_DBGFS If unsure, say N. - This will be removed after >5.15.y LTS kernel is released, so users - should move to the sysfs interface (DAMON_SYSFS). + This is deprecated, so users should move to the sysfs interface + (DAMON_SYSFS). If you depend on this and cannot move, please report + your usecase to damon@lists.linux.dev and linux-mm@kvack.org. config DAMON_DBGFS_KUNIT_TEST bool "Test for damon debugfs interface" if !KUNIT_ALL_TESTS From patchwork Fri Feb 10 04:48:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: SeongJae Park X-Patchwork-Id: 13135371 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A30C636D4 for ; Fri, 10 Feb 2023 04:48:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 689546B00F1; Thu, 9 Feb 2023 23:48:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5C3336B00F3; Thu, 9 Feb 2023 23:48:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3EEE56B00F4; Thu, 9 Feb 2023 23:48:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 21CFD6B00F1 for ; Thu, 9 Feb 2023 23:48:52 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 56ABD1A127B for ; Fri, 10 Feb 2023 04:48:51 +0000 (UTC) X-FDA: 80450152062.09.C9579E6 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id 741B1160002 for ; Fri, 10 Feb 2023 04:48:49 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="osoBk/p5"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676004529; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=PwwzsY/51csXNOOx4GzPgkxCySUu+mfViXO0wUCKyK0=; b=lsWa7yPsQ7VDlAgiZtGgnX2CawdR2QzRU0/LU143tmaWjPyQNP9GHZE7UJy1c95UYdwhFU Z0/Npq5yKgPo4yJCC5q7n6Eant0l7PHL5JJGYtdeWRPDvH3SdnA7JbpcyJCNOEtKEKKXcA Jfj3WxLdRKG+JN+uzBghKvg1E8SWVEo= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="osoBk/p5"; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of sj@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676004529; a=rsa-sha256; cv=none; b=NYiiVNK952Ib02C3+ecbNYaDAZpV2yNQ+VDYagMobZCa+ceclJy/FL5q0Nx4QVBe4nE8yS 8hrB7UIJOWjWBitHB2W65nNtUjYc8aBjSYgQOEZphTTylTvBb2WlahWm03mvz+46aERKx0 puvuhqosc6GsQXzyVYIAAxfSICUv25k= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 32468B822F0; Fri, 10 Feb 2023 04:48:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 786BEC433A1; Fri, 10 Feb 2023 04:48:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1676004527; bh=GHjXtEXAs/907P6A+4MUMIxpIxGv/uFwCu4RPtNwvv4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=osoBk/p5fti365hKvBevvfZpAfFjjBuRvv90yf+hbzGZGnr44zGzfMzevZBF1G5W+ 0cZp6p4OTOl29Rq8NHb+4yhgbo8Dduwr/YXYSUYSaJfAIuLSRgmDs6O0hUYP3PvxqA lnnI3TiTC1gQpj6NnQM4FpQwlGgEiexU4MJHePwMijo+PLyb1i04CdpxtINd6AHV+t iDshdB/9WNtDhnYuAiB7CBh1adRpmRDEgHAOFRS5ChWfCZGD0kOJAV2osSEbuacspk /OtFQ0ujR1NeVbbBb8i0JhTrOBz2jn7zCDH/hnK7mivL/KBsapzZBsQf3lecRBPt1G cR/odiYu7eU/g== From: SeongJae Park To: Andrew Morton Cc: SeongJae Park , damon@lists.linux.dev, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jonathan Corbet Subject: [PATCH v2 3/3] mm/damon/dbgfs: print DAMON debugfs interface deprecation message Date: Fri, 10 Feb 2023 04:48:38 +0000 Message-Id: <20230210044838.63723-4-sj@kernel.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230210044838.63723-1-sj@kernel.org> References: <20230210044838.63723-1-sj@kernel.org> MIME-Version: 1.0 X-Rspamd-Queue-Id: 741B1160002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: nfxu4mq93kiww1m3hotmirxx4gbbf8ya X-HE-Tag: 1676004529-128156 X-HE-Meta: U2FsdGVkX18sU7IdCQBFu6/uJ06pYHMWzCT4TgMP0Th7gWY/OTTEdCIWYPmklWYEpaBzCo9iQ6KmTg8AbJxXTNKchGOWDDJst7nhA8W0Gi1TuCvfuTW4glKoyslzd842GTm7dz0mn+2c9t0IhSeIU+z6V4pr9JRPfnAmZJUAs0MrHWe+QqLiv7hhCERa0UEnOP4VGzFj4eAafDYmRXRp8QDdkxFjXzq/slx3BnnS1xCi340hjelrFUlvs4tTNJzyLRQr5UgA7s5X6meZTKeBSb+T0rI3VPMu/22niJm8ain1SziQEI8t6mjpssqpsrq4na0LqtBnEVK9mfQrUweNTYO1UTaooRZmb9/WYmvqJ0nFU6oNWXc65S3i55UdiQpgHEMQIbObspaZJMVoBctgV8wo5tXkPorUdTPlhSPbBS5UETOrHXdi81RKd2f8s6U2DMddR2HpmCQnHoOI4VFxCo/FwCvUqcOIylQdbYKjdlT3FJLyBZ6mXzZzntYQJZHXH/MlJDzUBLygcmvI4Yjyev9F4QqWA5DZmh5mVjULYo/bahXd1kv0vsvXAdYHGv6932OiPD/uJJcgeomSWSUXcWuvDf6BoP6ERbr5zHm5qTbSuGBWI2AJ2MaoG5M6HceShE9HGnSbrKmBEFyA6PmK16XtvTtEFQoQH+dj+E3ScMzFkJZ1ulAqXCYgAjHhPi/NfKxGiaBRSxifvjIdOVWdQYEgGZd+4VMyNpxCRZEa+vlm+Vhsct4uiM/221bjnIldpv2hKRbLrw1dU70mvFa7RTmGeKcaBAw15bBAA/Cl3FUfq7WDKyp6ezsBnfuj0sLbPfZKzxW0gv70JZs3kV3w+Z/gfxQSyGYkvo9RBNJnNGaOCwolLVG4dH4Bd5yKrXhOBdlJ46r1ueo+a2pJjiwu1DRyzhMGwanl9UTcBYjkjgn/Lz77mD1PR7/qwMHR3qkJiSftFZOQugJ1+ggT+7G yKyMGCe8 NjgecMzBmc1W8cYSDYlz1IJFld1E5WoBaURzF3fcgjzSJZxYNaBwjcrisNh7AXMv8tFVIZSavHpBvCK8obbFRx6ikgKw8bdH0kHDbDcUv/sF5DeL8DRp/irv/tPn85xNxdTByhWDuJyz5J7GU9sLzgaErNvcWego4v1U6FadnaZgN9cxYeFA+8LCVqRbXmW1MuATKbTMaFEFm+8O+CYG2z3CLYXSsjJWg+UWWPODyVcCEXGohNm5HGlWQknsVIm1FuDKif8UviRB+xs6LjiaQVp5Vwa4Jihnvix8gNzFbxJbIL+ZYRMAtdlK7JMSVJghQY7YjAPXQscUJ4Q946+H6YvtpdtFu30fVEE1n8g3cbW7ERSK5wywQ+4Sa9enOuQmoWsdk6je0FrWPNO5yJGFIaAWXznwIHc4PScVPUp1rGK5CtZXScf3mRVlNwBtxg056Y4MlN39rV9V/AV68LbHqmMrN5rxUDsEnwsx+7451fP3R2hRATpcfA6+HpRj+VtI40EgTdO9a4+k136qvs8bjdGlQjg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: DAMON debugfs interface has announced to be deprecated after >v5.15 LTS kernel is released. And, v6.1.y has announced to be an LTS[1]. Though the announcement was there for a while, some people might not noticed that so far. Also, some users could depend on it and have problems at movng to the alternative (DAMON sysfs interface). For such cases, warn DAMON debugfs interface deprecation with contacts to ask helps when any DAMON debugfs interface file is opened. [1] https://git.kernel.org/pub/scm/docs/kernel/website.git/commit/?id=332e9121320bc7461b2d3a79665caf153e51732c Link: https://lkml.kernel.org/r/20230209192009.7885-4-sj@kernel.org Signed-off-by: SeongJae Park Cc: Jonathan Corbet Signed-off-by: Andrew Morton --- mm/damon/dbgfs.c | 19 +++++++++++++++++++ 1 file changed, 19 insertions(+) diff --git a/mm/damon/dbgfs.c b/mm/damon/dbgfs.c index b3f454a5c682..124f0f8c97b7 100644 --- a/mm/damon/dbgfs.c +++ b/mm/damon/dbgfs.c @@ -20,6 +20,14 @@ static int dbgfs_nr_ctxs; static struct dentry **dbgfs_dirs; static DEFINE_MUTEX(damon_dbgfs_lock); +static void damon_dbgfs_warn_deprecation(void) +{ + pr_warn_once("DAMON debugfs interface is deprecated, " + "so users should move to DAMON_SYSFS. If you cannot, " + "please report your usecase to damon@lists.linux.dev and " + "linux-mm@kvack.org.\n"); +} + /* * Returns non-empty string on success, negative error code otherwise. */ @@ -711,6 +719,8 @@ static ssize_t dbgfs_kdamond_pid_read(struct file *file, static int damon_dbgfs_open(struct inode *inode, struct file *file) { + damon_dbgfs_warn_deprecation(); + file->private_data = inode->i_private; return nonseekable_open(inode, file); @@ -1039,15 +1049,24 @@ static ssize_t dbgfs_monitor_on_write(struct file *file, return ret; } +static int damon_dbgfs_static_file_open(struct inode *inode, struct file *file) +{ + damon_dbgfs_warn_deprecation(); + return nonseekable_open(inode, file); +} + static const struct file_operations mk_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_mk_context_write, }; static const struct file_operations rm_contexts_fops = { + .open = damon_dbgfs_static_file_open, .write = dbgfs_rm_context_write, }; static const struct file_operations monitor_on_fops = { + .open = damon_dbgfs_static_file_open, .read = dbgfs_monitor_on_read, .write = dbgfs_monitor_on_write, };