From patchwork Mon Jan 28 09:49:30 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 10783473 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A87A159A for ; Mon, 28 Jan 2019 09:49:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88DB92A790 for ; Mon, 28 Jan 2019 09:49:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7DDD42A79D; Mon, 28 Jan 2019 09:49:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C25EB2A7A3 for ; Mon, 28 Jan 2019 09:49:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726661AbfA1Jtw (ORCPT ); Mon, 28 Jan 2019 04:49:52 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:41669 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbfA1Jtv (ORCPT ); Mon, 28 Jan 2019 04:49:51 -0500 Received: by mail-lf1-f68.google.com with SMTP id c16so11327884lfj.8; Mon, 28 Jan 2019 01:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ojc4LVaSgZvQCAKegN4dIOYy2YW2Fe7BAEkqaOnlWy8=; b=ULyCdkRiYNVcfeDs+MmNtSSjIXlFkoh86p4CFDI5NLo2AfucipTtS0ygQngu0eZoLa xfVjShm4hPcA+3HsGu14iJwNab+MlxM7paZMOI5CTI3iAKVzu3Jfwz7+0fRcaI+Pzbm5 1xSN4TFnYI9bgShgnYwZAlN2LM0sGVgIIpYclHuJYU+gWm8MGZ+rpixFPngyA9I89A94 EIPZyAfl3JNz5fezApxGawpYyLSPdMUWg1g0wCgTiTX7k5685dsRIN34+JBQB6vvJVNP 4+0ujRZvdgQRxBb4klYUT3P63m4gLybzqIQD9iKqTymVnhsLJS9Ijcbe68nwtjQpTqW8 kIrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=ojc4LVaSgZvQCAKegN4dIOYy2YW2Fe7BAEkqaOnlWy8=; b=Dm0iPRiKOwsuhdym/7yYL4/Thc9PwHlrxcvWyKWrtV3J2dnHKX5QCQsc26vfMj70PY 4nVRmZhzufGRUpP9xJUAoreQMFSS562NPyp79AaXXSC1dNjH6y1cSSQDtsIdlXgh75dt BoggLCDz29I1oeKw7LR9Ohp822/6Q+92A5K3jGZkqwSE9yJiV+SNssEonnRpowoakCfX dzU6nNAYe9dKr1eDPa6RHSr5GS0wKZ3ySIWDbH1vZArsgHEBTcoB8OrYF9pe7deXs9n/ +x/54ej3hrBQTx6/LvrXUUDim6Y5JPBkcQ/kBRqNY2UA8Etd9lMVvKprrmg+f6QvhiBJ PMTA== X-Gm-Message-State: AJcUukdaFf7x+GP/kdIKNgFM9ZdCXSiC9otr3yfN06rOUkZYG+dxui8N /fM1W9LnfXbh9P/JDd1BDX2UWeBU X-Google-Smtp-Source: ALg8bN5M1dn1a9/QHR3NOpW6VSPAObHjKr7M6I3LxlH+5avYiJYE9R6FByXdyvlE0zW11p1e3H4emw== X-Received: by 2002:ac2:4194:: with SMTP id z20mr15511995lfh.74.1548668988602; Mon, 28 Jan 2019 01:49:48 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id r29-v6sm2859053ljd.44.2019.01.28.01.49.47 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 01:49:47 -0800 (PST) From: Ricardo Ribalda Delgado To: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v3 1/2] iio:dac:ti-dac7612: Add driver for Texas Instruments DAC7612 Date: Mon, 28 Jan 2019 10:49:30 +0100 Message-Id: <20190128094931.4430-1-ricardo@ribalda.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It is a driver for Texas Instruments Dual, 12-Bit Serial Input Digital-to-Analog Converter. Datasheet of this chip: http://www.ti.com/lit/ds/sbas106/sbas106.pdf Signed-off-by: Ricardo Ribalda Delgado --- v3: Changes by Jonathan Cameron - Include OF compatible strings - Rename RESOLUTION define - Create defines for BIT positions - Support DMA - Rename gpio - Remove scantype - Fix scale - Use iio_priv at variable definition - (Ab)use ARRAY_SIZE for number of channels (love the idea) MAINTAINERS | 6 ++ drivers/iio/dac/Kconfig | 10 ++ drivers/iio/dac/Makefile | 1 + drivers/iio/dac/ti-dac7612.c | 173 +++++++++++++++++++++++++++++++++++ 4 files changed, 190 insertions(+) create mode 100644 drivers/iio/dac/ti-dac7612.c diff --git a/MAINTAINERS b/MAINTAINERS index d039f66a5cef..30ba5435906b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14877,6 +14877,12 @@ F: Documentation/devicetree/bindings/clock/ti,sci-clk.txt F: drivers/clk/keystone/sci-clk.c F: drivers/reset/reset-ti-sci.c +Texas Instruments' DAC7612 DAC Driver +M: Ricardo Ribalda +L: linux-iio@vger.kernel.org +S: Supported +F: drivers/iio/dac/ti-dac7612.c + THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER M: Hans Verkuil L: linux-media@vger.kernel.org diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index f28daf67db6a..fbef9107acad 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -375,6 +375,16 @@ config TI_DAC7311 If compiled as a module, it will be called ti-dac7311. +config TI_DAC7612 + tristate "Texas Instruments 12-bit 2-channel DAC driver" + depends on SPI_MASTER && GPIOLIB + help + Driver for the Texas Instruments DAC7612, DAC7612U, DAC7612UB + The driver hand drive the load pin automatically, otherwise + it needs to be toggled manually. + + If compiled as a module, it will be called ti-dac7612. + config VF610_DAC tristate "Vybrid vf610 DAC driver" depends on OF diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile index f0a37c93de8e..1369fa1d2f0e 100644 --- a/drivers/iio/dac/Makefile +++ b/drivers/iio/dac/Makefile @@ -41,4 +41,5 @@ obj-$(CONFIG_STM32_DAC) += stm32-dac.o obj-$(CONFIG_TI_DAC082S085) += ti-dac082s085.o obj-$(CONFIG_TI_DAC5571) += ti-dac5571.o obj-$(CONFIG_TI_DAC7311) += ti-dac7311.o +obj-$(CONFIG_TI_DAC7612) += ti-dac7612.o obj-$(CONFIG_VF610_DAC) += vf610_dac.o diff --git a/drivers/iio/dac/ti-dac7612.c b/drivers/iio/dac/ti-dac7612.c new file mode 100644 index 000000000000..a2f58256a784 --- /dev/null +++ b/drivers/iio/dac/ti-dac7612.c @@ -0,0 +1,173 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * DAC7612 Dual, 12-Bit Serial input Digital-to-Analog Converter + * + * Copyright 2019 Qtechnology A/S + * 2019 Ricardo Ribalda + * + * Licensed under the GPL-2. + */ +#include +#include +#include +#include +#include + +#define DAC7612_RESOLUTION 12 +#define DAC7612_ADDRESS 4 +#define DAC7612_START 5 + +struct dac7612 { + struct spi_device *spi; + struct gpio_desc *loaddacs; + uint16_t cache[2]; + + // DMA + uint8_t data[2] ____cacheline_aligned; +}; + +static int dac7612_cmd_single(struct dac7612 *priv, int channel, u16 val) +{ + int ret; + + priv->data[0] = BIT(DAC7612_START) | (channel << DAC7612_ADDRESS); + priv->data[0] |= val >> 8; + priv->data[1] = val & 0xff; + + priv->cache[channel] = val; + + ret = spi_write(priv->spi, priv->data, sizeof(priv->data)); + if (ret) + return ret; + + gpiod_set_value(priv->loaddacs, 1); + gpiod_set_value(priv->loaddacs, 0); + + return 0; +} + +#define dac7612_CHANNEL(chan, name) { \ + .type = IIO_VOLTAGE, \ + .channel = (chan), \ + .indexed = 1, \ + .output = 1, \ + .datasheet_name = name, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ +} + +static const struct iio_chan_spec dac7612_channels[] = { + dac7612_CHANNEL(0, "OUTA"), + dac7612_CHANNEL(1, "OUTB"), +}; + +static int dac7612_read_raw(struct iio_dev *iio_dev, + const struct iio_chan_spec *chan, + int *val, int *val2, long mask) +{ + struct dac7612 *priv; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + priv = iio_priv(iio_dev); + *val = priv->cache[chan->channel]; + return IIO_VAL_INT; + + case IIO_CHAN_INFO_SCALE: + *val = 1; + return IIO_VAL_INT; + + default: + return -EINVAL; + } +} + +static int dac7612_write_raw(struct iio_dev *iio_dev, + const struct iio_chan_spec *chan, + int val, int val2, long mask) +{ + struct dac7612 *priv = iio_priv(iio_dev); + int ret; + + if (mask != IIO_CHAN_INFO_RAW) + return -EINVAL; + + if ((val >= BIT(DAC7612_RESOLUTION)) || val < 0 || val2) + return -EINVAL; + + if (val == priv->cache[chan->channel]) + return 0; + + mutex_lock(&iio_dev->mlock); + ret = dac7612_cmd_single(priv, chan->channel, val); + mutex_unlock(&iio_dev->mlock); + + return ret; +} + +static const struct iio_info dac7612_info = { + .read_raw = dac7612_read_raw, + .write_raw = dac7612_write_raw, +}; + +static int dac7612_probe(struct spi_device *spi) +{ + struct iio_dev *iio_dev; + struct dac7612 *priv; + int i; + int ret; + + iio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*priv)); + if (!iio_dev) + return -ENOMEM; + + priv = iio_priv(iio_dev); + priv->loaddacs = devm_gpiod_get_optional(&spi->dev, "loaddacs", + GPIOD_OUT_LOW); + if (IS_ERR(priv->loaddacs)) + return PTR_ERR(priv->loaddacs); + priv->spi = spi; + spi_set_drvdata(spi, iio_dev); + iio_dev->dev.parent = &spi->dev; + iio_dev->info = &dac7612_info; + iio_dev->modes = INDIO_DIRECT_MODE; + iio_dev->channels = dac7612_channels; + iio_dev->num_channels = ARRAY_SIZE(priv->cache); + iio_dev->name = spi_get_device_id(spi)->name; + + for (i = 0; i < ARRAY_SIZE(priv->cache); i++) { + ret = dac7612_cmd_single(priv, i, 0); + if (ret) + return ret; + } + + return devm_iio_device_register(&spi->dev, iio_dev); +} + +static const struct spi_device_id dac7612_id[] = { + {"ti-dac7612"}, + {} +}; +MODULE_DEVICE_TABLE(spi, dac7612_id); + +static const struct of_device_id dac7612_of_match[] = { + { .compatible = "ti,dac7612" }, + { .compatible = "ti,dac7612u" }, + { .compatible = "ti,dac7612b" }, + { }, +}; +MODULE_DEVICE_TABLE(of, dac7612_of_match); + +static struct spi_driver dac7612_driver = { + .driver = { + .name = "ti-dac7612", + .of_match_table = dac7612_of_match, + }, + .probe = dac7612_probe, + .id_table = dac7612_id, +}; +module_spi_driver(dac7612_driver); + +MODULE_AUTHOR("Ricardo Ribalda "); +MODULE_DESCRIPTION("Texas Instruments DAC7612 DAC driver"); +MODULE_LICENSE("GPL v2"); From patchwork Mon Jan 28 09:49:31 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 10783475 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7A01F186D for ; Mon, 28 Jan 2019 09:50:03 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 67A322A79F for ; Mon, 28 Jan 2019 09:50:03 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 5A62E2A7A8; Mon, 28 Jan 2019 09:50:03 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C93E62A7A2 for ; Mon, 28 Jan 2019 09:50:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726798AbfA1Jt4 (ORCPT ); Mon, 28 Jan 2019 04:49:56 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42109 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726521AbfA1Jt4 (ORCPT ); Mon, 28 Jan 2019 04:49:56 -0500 Received: by mail-lj1-f195.google.com with SMTP id l15-v6so13639930lja.9; Mon, 28 Jan 2019 01:49:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=+eBajr5sUT1GDkyX+f0iiPV/RgW5JIHLA40sMvxhUEo=; b=PKIsjDUMgb9Un4bJIAzhManLg8R5iDjxUNw9HRZSNp1SxTGrgpYrrUg75vyVB9MZud dQGrgUKLDAEXL8PDBn0756VwGwRTmTz3X4QxT9rCreMqMY7Qk+zMF1vJkor/0Q85rsZp M8rjsxiROe1JNVG/1KZ39rMv8ggNpIKGkdhMOgybB3JEO2P04+BKAUZP0YvOQZVjJSaz d/TaEab+CxDl7vZ3roYTvjlgYqv3oz+E7ZoSwuPgtPn5mM7sNiqNXfMP4wfLoBfN8WmT g/7UUfjnAn8quXLsofsi0/MMZ41RsYDEylUQFwZD7WFtRsLOi2ggPbpYDgcQ7W9nmC5x Wyrw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=+eBajr5sUT1GDkyX+f0iiPV/RgW5JIHLA40sMvxhUEo=; b=KGcWimghtTClYCa8fJ1aBXas4cwIK31pYDMWnUZKGwXNwSyrRkwOZuK/b+YG+viKt6 OtJO1t1I0TAw1LlaSwAsqr0uSNY+1l54zW8vljPhJyJXVRpoAa34hbk56LqS4B7OoRvV FDHQdwlm58flem6E+zAjVEwS5bpbzuHc+jffjmuYlSgfneGxD3bvbASLg2tk7O2b60xc 7uJrRyso9xn4OLZX7DGwtEjkY1IT9g3+T9/gmeDr31VegMn7slkB5mG/q52cN4uyWC+U Po80Tu3xWn9QXDUubeB0MDDvw1BMdIScV+Guasqbq9wxBnUvSH0uUY+U9XmmzzsOOYNF i3/w== X-Gm-Message-State: AJcUuke1Jd5v11ZYxg4woeRqz5dscK9mSgvhMOSc+RsUEW9deGaJhat5 HzebgE1LD/KM3PzDopjL7SY= X-Google-Smtp-Source: ALg8bN4g2ndzto95A+QrlgbsEzDbWlRWAt43DZaEmZQK3x9RZQ7CzLWypSOfnj9yNsWz6xqo/trPfA== X-Received: by 2002:a2e:612:: with SMTP id 18-v6mr16414441ljg.125.1548668993676; Mon, 28 Jan 2019 01:49:53 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id r29-v6sm2859053ljd.44.2019.01.28.01.49.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 01:49:52 -0800 (PST) From: Ricardo Ribalda Delgado To: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado , devicetree@vger.kernel.org Subject: [PATCH v3 2/2] iio:dac:dac7612: device tree bindings Date: Mon, 28 Jan 2019 10:49:31 +0100 Message-Id: <20190128094931.4430-2-ricardo@ribalda.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190128094931.4430-1-ricardo@ribalda.com> References: <20190128094931.4430-1-ricardo@ribalda.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Bindings for dac7612. Cc: devicetree@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- .../bindings/iio/dac/ti,dac7612.txt | 29 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt new file mode 100644 index 000000000000..e1b8158fab35 --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt @@ -0,0 +1,29 @@ +* Texas Instruments Dual, 12-Bit Serial Input Digital-to-Analog Converter + +The DAC7612 is a dual, 12-bit digital-to-analog converter (DAC) with guaranteed +12-bit monotonicity performance over the industrial temperature range. +Is is programmable through an SPI interface. + +The internal DACs are loaded when the LOADDACS pin is pulled down. + +http://www.ti.com/lit/ds/sbas106/sbas106.pdf + +Required Properties: +- compatible: Should be one of: + "ti,dac7612" + "ti,dac7612u" + "ti,dac7612b" +- reg: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt + +Optional Properties: +- loaddacs-gpios: GPIO descriptor for the LOADDACS pin. +- spi-*: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt + +Example: + + dac7612@1 { + compatible = "ti,dac7612"; + reg = <0x1>; + loaddacs-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>; + }; + diff --git a/MAINTAINERS b/MAINTAINERS index 30ba5435906b..e28e5afaae16 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14882,6 +14882,7 @@ M: Ricardo Ribalda L: linux-iio@vger.kernel.org S: Supported F: drivers/iio/dac/ti-dac7612.c +F: Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER M: Hans Verkuil