From patchwork Tue Feb 14 17:15:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13140610 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AD5A9C05027 for ; Tue, 14 Feb 2023 17:18:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232921AbjBNRSq (ORCPT ); Tue, 14 Feb 2023 12:18:46 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42080 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229496AbjBNRSO (ORCPT ); Tue, 14 Feb 2023 12:18:14 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 661AA2B095 for ; Tue, 14 Feb 2023 09:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676394925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jeEdpXATs9xAq3Ic1YKNwPFKV8iOmXM6rM7COSxPs48=; b=cqfH8VvGilGbvoXCA7el8rurPobmOfl7Bfl6JJdIVUnuYfLaVPRML1gYAw/qCklSQLKQv8 HPndOwOylEFvu4/vNw7tgGjBYEwaRabRm4DpNc7bviNwLYUDKjDnjnG4F56MI1rRCBakws SbSULU8TLKoqb5mk5B5STCp5Jp51iwU= Received: from mail-ot1-f69.google.com (mail-ot1-f69.google.com [209.85.210.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-563-kECsDq5bNv-lHyE7rttKuQ-1; Tue, 14 Feb 2023 12:15:12 -0500 X-MC-Unique: kECsDq5bNv-lHyE7rttKuQ-1 Received: by mail-ot1-f69.google.com with SMTP id r6-20020a056830448600b0068d5c6e86easo8129861otv.10 for ; Tue, 14 Feb 2023 09:15:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jeEdpXATs9xAq3Ic1YKNwPFKV8iOmXM6rM7COSxPs48=; b=KxuFbbKew4fc2ElA2fea1zyWsSxc3vJNJxzaQKHqHVB1P6GL0tbuwwfdqifAvfdD3b 6OvUeK/5jh3CTqRIey6AU3/luSuSBVVEbjAVSJ3w4fPiTQ0F3X1zylf1v371m1mhnTat uAwF1kMMw+f4MASbTdNAkX+CBwfygN/YZKgBmbwR9+taSgMCjaEo7hdccJadMXnt3MwN QoOSpp/oKl9ygB6KAtUbwoEumYyYaqQDqyeJ75qJWxfD97wbU/M0xSoxrfp2VQgTiLZy dJGq4+WhGg/03SRVWFycUwONMDcZF4ssbhSieNr4FbTmWuTMXBddzMZsPaktpzExXn/a VNPw== X-Gm-Message-State: AO0yUKXWAvMqQkOHNZ6weBkx0fAe9rmWD7KqLWJro0ZyOFg+SRsik8KF aaH698jae1e4RXmoYYJiweM4MebdfypU4R65GJKYDOx2vylY5K1yjwYtgLYuxGSMhCqaILZGY/W 1239sVycpIYHtpkaw X-Received: by 2002:a54:4511:0:b0:364:eafd:2697 with SMTP id l17-20020a544511000000b00364eafd2697mr1473596oil.58.1676394910600; Tue, 14 Feb 2023 09:15:10 -0800 (PST) X-Google-Smtp-Source: AK7set8ckzBSvYvKffHSR9kx+MhjoJN8bdYl7WQAW88sdJYAf1ZjAuXtQj8VAA9ciHNcY8zcaNqPDA== X-Received: by 2002:a54:4511:0:b0:364:eafd:2697 with SMTP id l17-20020a544511000000b00364eafd2697mr1473585oil.58.1676394910338; Tue, 14 Feb 2023 09:15:10 -0800 (PST) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id h18-20020a9d6a52000000b00688449397d3sm6581786otn.15.2023.02.14.09.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 09:15:09 -0800 (PST) From: Andrew Halaney To: devicetree@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, mripard@kernel.org, shenwei.wang@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Halaney , Krzysztof Kozlowski Subject: [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency Date: Tue, 14 Feb 2023 11:15:04 -0600 Message-Id: <20230214171505.224602-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The actual property is called snps,reset-delays-us, so fix this to catch any devicetree defining snsps,reset-delays-us without snps,reset-gpio. Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andrew Halaney --- Changes since v1: * collected Krzysztof's review Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index e88a86623fce..16b7d2904696 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -552,7 +552,7 @@ required: dependencies: snps,reset-active-low: ["snps,reset-gpio"] - snps,reset-delay-us: ["snps,reset-gpio"] + snps,reset-delays-us: ["snps,reset-gpio"] allOf: - $ref: "ethernet-controller.yaml#" From patchwork Tue Feb 14 17:15:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13140609 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A3596C6379F for ; Tue, 14 Feb 2023 17:18:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233052AbjBNRSP (ORCPT ); Tue, 14 Feb 2023 12:18:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41486 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232930AbjBNRRt (ORCPT ); Tue, 14 Feb 2023 12:17:49 -0500 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 539AD2FCFF for ; Tue, 14 Feb 2023 09:15:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676394916; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n5Xftcuk/SSD+V/l0GWpcX6zdIVXO92U2DSCgVqWJgE=; b=c0WmU3W8GF6U72BgqoPvALKyJffKCtAOEvtmrjphfSzJwoTcgty/WAHZnQxKue83ydm+Q6 RuEOAbWr5l9pLKd3f/IM/1JGziuIb5+u/mQpvqv4LTY9iwOrkErzyKPPNjmH8hozY9uhvP s+RdWtfL1j1933EIHYaJbAShaic9Do0= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-594-na3fshbtP1KkPiZMlsDptg-1; Tue, 14 Feb 2023 12:15:15 -0500 X-MC-Unique: na3fshbtP1KkPiZMlsDptg-1 Received: by mail-oi1-f198.google.com with SMTP id s4-20020a05680810c400b0037890be175fso3189138ois.14 for ; Tue, 14 Feb 2023 09:15:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n5Xftcuk/SSD+V/l0GWpcX6zdIVXO92U2DSCgVqWJgE=; b=pDu0/D2G4Yt4PcL1I52rcUcL6zr/4x99QzVayumRAAjK6LE9Z6ZUmwLsAxcvATtKxl FA+LDLZV5+b6H8U7yiHRliU164zebbgreRz6zeffl7ILQN6u7cxjxU9uB/YcXNWKPjng rq4CpsJZyo9vSOI963S+E0CbPBLfK7FSaiEjPPXmjrR2fUuO8Z0KGWoHG1lz9WJ0x88j /yX005NSI8YVSGPtVIjS9/jMBDmSIFCBM4YFEuk+pRwFJGnnRwu9QGR0Zp84C1BrwDAZ n4W/bcTds6pdSK8RVqkBINcTDIO9XYUFlJMVhE5IhVXdwsGW6OKBF6euuGHXUtl0l0fU Dnrw== X-Gm-Message-State: AO0yUKUOvalELkXqckIdLWFCBchlWCacR77E4qa0QoZr7eZMNlwDMtRx BAXHvR1hKGJp59RdKibZSVE8Ug1ad0I3kSU0N81wOcpliRGK8xabbuulP2wEP25g7VVhlffiR6m S2yd53FGxqg+nA7tG X-Received: by 2002:a05:6870:9a1e:b0:16e:23e5:5b65 with SMTP id fo30-20020a0568709a1e00b0016e23e55b65mr1210900oab.7.1676394914502; Tue, 14 Feb 2023 09:15:14 -0800 (PST) X-Google-Smtp-Source: AK7set8MrMmgViCnPoo/Cyzeh/QLl1zgh3Dd4LDFZA4q8Hj6ALu8f1u78rAjAarpF/d1TfQ/qvZVrw== X-Received: by 2002:a05:6870:9a1e:b0:16e:23e5:5b65 with SMTP id fo30-20020a0568709a1e00b0016e23e55b65mr1210882oab.7.1676394914258; Tue, 14 Feb 2023 09:15:14 -0800 (PST) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id h18-20020a9d6a52000000b00688449397d3sm6581786otn.15.2023.02.14.09.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 09:15:13 -0800 (PST) From: Andrew Halaney To: devicetree@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, mripard@kernel.org, shenwei.wang@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Halaney Subject: [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Date: Tue, 14 Feb 2023 11:15:05 -0600 Message-Id: <20230214171505.224602-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214171505.224602-1-ahalaney@redhat.com> References: <20230214171505.224602-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The deprecated property is named snps,reset-gpio, but this devicetree used snps,reset-gpios instead which results in the reset not being used and the following make dtbs_check error: ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml Use the preferred method of defining the reset gpio in the phy node itself. Note that this drops the 10 us pre-delay, but prior this wasn't used at all and a pre-delay doesn't make much sense in this context so it should be fine. Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") Signed-off-by: Andrew Halaney Acked-by: Krzysztof Kozlowski --- Changes since v1: * Moved the reset into the ethernet-phy node itself instead of fixing the deprecated usage (for that reason I did not collect Fabio's review tag) arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts index 1bcf228a22b8..852420349c01 100644 --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts @@ -121,8 +121,6 @@ &eqos { phy-handle = <ðphy0>; nvmem-cells = <&fec_mac1>; nvmem-cell-names = "mac-address"; - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; - snps,reset-delays-us = <10 20 200000>; status = "okay"; mdio { @@ -136,6 +134,9 @@ ethphy0: ethernet-phy@0 { eee-broken-1000t; qca,disable-smarteee; qca,disable-hibernation-mode; + reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; + reset-assert-us = <20>; + reset-deassert-us = <200000>; vddio-supply = <&vddio0>; vddio0: vddio-regulator {