From patchwork Tue Feb 14 17:15:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13140642 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 234AAC6379F for ; Tue, 14 Feb 2023 17:16:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=c9bLOCPF7oAA1r6XxlzTYfLRy8kfSKU+UV/3RevlL8I=; b=dKFH1gJipXCvBl evOXznpNEu4Kbt/NavY5dk+WGEF8etzLKOSNqyN6Hf8SCVCntJaIkqknjW/kJASUB85TItbycUMm9 Q5WBjvZ0x0n8JhPWEbkjaux0Ajwz2ijqIfZwMUnvesHV3ulNMjcmvBnZD9SSB1qHcYOCkk7uwpKaY zxDmujq2QltWPfz9Oo4m8X57fFwVOJx7RHSbmTmI98KUoiEuSDYy12xy3NrnrV9lIyac8RsA5Yuo8 mJzZCuoWxlcZOVp874ZhUnYYdjTEEHVUmXNPzFsr52lNxB/3AfGMbA2moUeU8/U5I2JD05/AYu4K3 7nf+vdabMcft8GkWeBAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRyti-002xu0-6w; Tue, 14 Feb 2023 17:15:18 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRyte-002xsE-SD for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 17:15:16 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676394913; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=jeEdpXATs9xAq3Ic1YKNwPFKV8iOmXM6rM7COSxPs48=; b=VykLS2WzlXkZfq4IB2Kp59+LLU6jooe4eu7S1BlWphrFqLa/1sCR9FUBAnZTHdtTsvXjOy Uxkml1ey7XUe3/pqsx15+uTTxdG3zdDAgd6R68SwnXeovxxSHhyZwIkfC7Goccf/JKZGbT Kxm7Ql/82d6w4A6IaaL2xozUSoX/D+4= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-20-JQg9gYyqO3aPCcCPdRHNYQ-1; Tue, 14 Feb 2023 12:15:11 -0500 X-MC-Unique: JQg9gYyqO3aPCcCPdRHNYQ-1 Received: by mail-ot1-f72.google.com with SMTP id 66-20020a9d04c8000000b0068d48d4e873so8287493otm.22 for ; Tue, 14 Feb 2023 09:15:11 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=jeEdpXATs9xAq3Ic1YKNwPFKV8iOmXM6rM7COSxPs48=; b=QNjCwGzEJ1xTyT+yv4vescC7v8DakhImwYtuxVGTSrHOuxGxPKgl84mEckZk6puaTK AerDczbLjRx4QmEPaDit4D775TN9mhTU1ikSVb0V87CTTgBi+FSOhd9K5guiR9tbwRfA 4sNBl7i9bZ+3uY5zaIU6Ql2tIPZOh/Oi2Sq1TIyCjRHxMRU+TORmib52UVf6i1nTaGoH jRDNIZN+UnoQProz1SJo/Wt71FOXNKOGeH8KLTKBRzOyxDPJJxGUbIo+Cz7toSEb3nNA PggxsjMD1qCACSi3466YOKFiTF4FOTl34hk1rgtjmxhXSX+sjhhrEbDYEt5XpBeNCM85 FRaA== X-Gm-Message-State: AO0yUKVPkqpSw37MNKwtdCf+q0SAAi+cJy+HNzkLMUz9YC6fa48vFdSz UlocF2Y7nsCHSEVtAw+wT3uRjoQUR62bio02mRw9gFcNaBtc5nGHCAQrFzMhpXo9W7gFxnKvanf HBVhBUoZbPW3sWD7qXIsnsqsS/MpqmPv38io= X-Received: by 2002:a54:4511:0:b0:364:eafd:2697 with SMTP id l17-20020a544511000000b00364eafd2697mr1473601oil.58.1676394910600; Tue, 14 Feb 2023 09:15:10 -0800 (PST) X-Google-Smtp-Source: AK7set8ckzBSvYvKffHSR9kx+MhjoJN8bdYl7WQAW88sdJYAf1ZjAuXtQj8VAA9ciHNcY8zcaNqPDA== X-Received: by 2002:a54:4511:0:b0:364:eafd:2697 with SMTP id l17-20020a544511000000b00364eafd2697mr1473585oil.58.1676394910338; Tue, 14 Feb 2023 09:15:10 -0800 (PST) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id h18-20020a9d6a52000000b00688449397d3sm6581786otn.15.2023.02.14.09.15.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 09:15:09 -0800 (PST) From: Andrew Halaney To: devicetree@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, mripard@kernel.org, shenwei.wang@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Halaney , Krzysztof Kozlowski Subject: [PATCH v2 1/2] dt-bindings: net: snps,dwmac: Fix snps,reset-delays-us dependency Date: Tue, 14 Feb 2023 11:15:04 -0600 Message-Id: <20230214171505.224602-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230214_091515_048394_F46D8154 X-CRM114-Status: GOOD ( 11.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The schema had snps,reset-delay-us as dependent on snps,reset-gpio. The actual property is called snps,reset-delays-us, so fix this to catch any devicetree defining snsps,reset-delays-us without snps,reset-gpio. Fixes: 7db3545aef5f ("dt-bindings: net: stmmac: Convert the binding to a schemas") Reviewed-by: Krzysztof Kozlowski Signed-off-by: Andrew Halaney --- Changes since v1: * collected Krzysztof's review Documentation/devicetree/bindings/net/snps,dwmac.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml index e88a86623fce..16b7d2904696 100644 --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml @@ -552,7 +552,7 @@ required: dependencies: snps,reset-active-low: ["snps,reset-gpio"] - snps,reset-delay-us: ["snps,reset-gpio"] + snps,reset-delays-us: ["snps,reset-gpio"] allOf: - $ref: "ethernet-controller.yaml#" From patchwork Tue Feb 14 17:15:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13140643 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C57DCC64ED6 for ; Tue, 14 Feb 2023 17:16:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=lg54s+V5Q+N2qaDAafet0fLez7O1bVuyeECJJDu0bwY=; b=bcJ9KTTVnp42A/ NU7lMNIf4Fw21HZ+XJ5pOm8UoTjbHsmNyZsFWpCm9Mf/BgAMOPrAsAkuoilSJmRDbSWBvNZUSnL1V Fk1sOPWzrMkFRtecQM+I5ALHjS0lLv710oMbLeJerFqe5ukveid2xHrz51DjTn3pavxZt46TLDn/3 j9nQiF2bfW+MMgVy4ZvR2QaEXN1jnGR7sO/JE3ypZ9r23h3g040RoasWt5NWTkjzuwm+eX6m/Ig99 nyYFHoVObX7pkERz4h8khD5Y2STg/vKHQLPNbMsklRTT+F6+o04eUtWsqGCpM9Idhwxgl4QCxTaWB JA+zqRLBpE8RqzVCJ1XQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRytq-002xwV-5Z; Tue, 14 Feb 2023 17:15:26 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pRytj-002xuQ-VQ for linux-arm-kernel@lists.infradead.org; Tue, 14 Feb 2023 17:15:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1676394919; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=n5Xftcuk/SSD+V/l0GWpcX6zdIVXO92U2DSCgVqWJgE=; b=Iy4/qcd1qxJS3I7GzSzCodK33+iRCsqOuUlyKspfXstayxsH5g4Xu3iNv4bYIdnoroMO0t UpylrY5Oi0I1QFfGVc7VUlIUjPuon6a5ZJK1dZ7sL8UVfpZRCgzXVQD9ShFUZOvCBYJTXm WMtG8OHSdSFexwD1i9ImBg2aDoR68qE= Received: from mail-oi1-f199.google.com (mail-oi1-f199.google.com [209.85.167.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-50-ZVA42fE2MKWV-Z4dvkOT5A-1; Tue, 14 Feb 2023 12:15:15 -0500 X-MC-Unique: ZVA42fE2MKWV-Z4dvkOT5A-1 Received: by mail-oi1-f199.google.com with SMTP id s30-20020a056808209e00b003786ebea977so3170197oiw.10 for ; Tue, 14 Feb 2023 09:15:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=n5Xftcuk/SSD+V/l0GWpcX6zdIVXO92U2DSCgVqWJgE=; b=0I324bhdReFGghP1dUjn9ieKx4uqlqIhYoFiFuSIXFLQsYg+mj+myRxqIHlvsnZIwG mj8xR/7zChLRknfm8bCWPQGPFOCXuS9IO8TCi2rgX1GpqIhW2D+cccJXA5bG2sTaTgxF NdqGXGXyxr9+s15C5YwlmwkPtNm03qmnQ+WrnGT25IwQR1GXELSZUThkwZnXBRXXd7DS ei0vxvusleKpEI2WMoPLaelzfpx3/XbX99kuMaaoX8KzbMzCvYc0XQy1ipYeFXCde1c+ O8b1LuKDsndMgZO+T/A5yKkbGOBHZ2dCCS12wkKZn6FwHWcPKo/+ew9/h5aRcgtUuUk8 Yg7g== X-Gm-Message-State: AO0yUKXwvdZmsZr+myoc/gF2EU8bi4JGyLr+ZUEBGPxRjJBD4bkrVpqc vRWMWzeOkDdG4PAfmDZZncVlvJTaWin3cqtzAfVs6PuvkFqftE4VLzrnF8UeYvTYv2QfGeTMw5k rcxEIaUZm4h8PN0umDzMQ5x1FqZUaYxNoCmQ= X-Received: by 2002:a05:6870:9a1e:b0:16e:23e5:5b65 with SMTP id fo30-20020a0568709a1e00b0016e23e55b65mr1210903oab.7.1676394914505; Tue, 14 Feb 2023 09:15:14 -0800 (PST) X-Google-Smtp-Source: AK7set8MrMmgViCnPoo/Cyzeh/QLl1zgh3Dd4LDFZA4q8Hj6ALu8f1u78rAjAarpF/d1TfQ/qvZVrw== X-Received: by 2002:a05:6870:9a1e:b0:16e:23e5:5b65 with SMTP id fo30-20020a0568709a1e00b0016e23e55b65mr1210882oab.7.1676394914258; Tue, 14 Feb 2023 09:15:14 -0800 (PST) Received: from halaney-x13s.redhat.com ([2600:1700:1ff0:d0e0::21]) by smtp.gmail.com with ESMTPSA id h18-20020a9d6a52000000b00688449397d3sm6581786otn.15.2023.02.14.09.15.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 14 Feb 2023 09:15:13 -0800 (PST) From: Andrew Halaney To: devicetree@vger.kernel.org Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, alexandre.torgue@foss.st.com, peppe.cavallaro@st.com, joabreu@synopsys.com, mripard@kernel.org, shenwei.wang@nxp.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Andrew Halaney Subject: [PATCH v2 2/2] arm64: dts: imx8dxl-evk: Fix eqos phy reset gpio Date: Tue, 14 Feb 2023 11:15:05 -0600 Message-Id: <20230214171505.224602-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230214171505.224602-1-ahalaney@redhat.com> References: <20230214171505.224602-1-ahalaney@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230214_091520_111190_1DBC8EF4 X-CRM114-Status: GOOD ( 14.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The deprecated property is named snps,reset-gpio, but this devicetree used snps,reset-gpios instead which results in the reset not being used and the following make dtbs_check error: ./arch/arm64/boot/dts/freescale/imx8dxl-evk.dtb: ethernet@5b050000: 'snps,reset-gpio' is a dependency of 'snps,reset-delays-us' From schema: ./Documentation/devicetree/bindings/net/snps,dwmac.yaml Use the preferred method of defining the reset gpio in the phy node itself. Note that this drops the 10 us pre-delay, but prior this wasn't used at all and a pre-delay doesn't make much sense in this context so it should be fine. Fixes: 8dd495d12374 ("arm64: dts: freescale: add support for i.MX8DXL EVK board") Signed-off-by: Andrew Halaney Acked-by: Krzysztof Kozlowski --- Changes since v1: * Moved the reset into the ethernet-phy node itself instead of fixing the deprecated usage (for that reason I did not collect Fabio's review tag) arch/arm64/boot/dts/freescale/imx8dxl-evk.dts | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts index 1bcf228a22b8..852420349c01 100644 --- a/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts +++ b/arch/arm64/boot/dts/freescale/imx8dxl-evk.dts @@ -121,8 +121,6 @@ &eqos { phy-handle = <ðphy0>; nvmem-cells = <&fec_mac1>; nvmem-cell-names = "mac-address"; - snps,reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; - snps,reset-delays-us = <10 20 200000>; status = "okay"; mdio { @@ -136,6 +134,9 @@ ethphy0: ethernet-phy@0 { eee-broken-1000t; qca,disable-smarteee; qca,disable-hibernation-mode; + reset-gpios = <&pca6416_1 2 GPIO_ACTIVE_LOW>; + reset-assert-us = <20>; + reset-deassert-us = <200000>; vddio-supply = <&vddio0>; vddio0: vddio-regulator {