From patchwork Wed Feb 15 13:23:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Shevchenko X-Patchwork-Id: 13141656 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09B80C6379F for ; Wed, 15 Feb 2023 13:24:37 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 0C3EC847; Wed, 15 Feb 2023 14:23:45 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 0C3EC847 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1676467475; bh=WUgNwUhbHaN9HZCnYj8+XtWA1iYsv49O9uBI9FvhwpY=; h=From:To:Subject:Date:CC:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=tcwrytw14TxISzhnsCCkpUE4mJY8aXAcsCFQHoad9gPxEAkkR/hcygJpDildrYFel UEJRm8IpkcZoD0JBJxOYpxHKh3sgxd9Jd0GF1/LPMWsEYP+9toc9Cc2cFUYZYRMRVZ Xdc/U/jp2P8RFUwYS0u/B5CtTTmV/T/64NGU65XY= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id 940EBF800B6; Wed, 15 Feb 2023 14:23:21 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 2BF43F800E4; Wed, 15 Feb 2023 14:23:18 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id E4951F800E4 for ; Wed, 15 Feb 2023 14:23:10 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz E4951F800E4 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=IYuEuJgu DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1676467392; x=1708003392; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=WUgNwUhbHaN9HZCnYj8+XtWA1iYsv49O9uBI9FvhwpY=; b=IYuEuJgu15WKXhurMBeZCF/Zxd/lLN2UYvSBFnOIX8pVqN9wZui97oqC b5+5fo80zwxI4LER6g9FdzlmLzAhEuuY7aZTUj7bkj7R0j09PU3hHllA1 HSW6s9IT8gi7Z8RASGXA91Kk7S9d8AVjyvxgGkW0b32taNxUwDj3v1vOE Kodph3cgYqch54Rg+qaGaSpvqiaQtY/RywQKo5w1sZRJxBanhJO8UyE+i gtDfZ5TC35VfWZX+f6wEx/CFRl3zCXBdrOW+CHWIMc9c2CRuimE+NU/LU dhGquU6Bs2xKUrLMg+Edj43iZyzcqQ8Xw9tMxJKlGXIjtQ5gYSErDOg57 Q==; X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="333563902" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="333563902" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Feb 2023 05:23:08 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10621"; a="733281649" X-IronPort-AV: E=Sophos;i="5.97,299,1669104000"; d="scan'208";a="733281649" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga008.fm.intel.com with ESMTP; 15 Feb 2023 05:23:05 -0800 Received: by black.fi.intel.com (Postfix, from userid 1003) id 56FC51A6; Wed, 15 Feb 2023 15:23:45 +0200 (EET) From: Andy Shevchenko To: Andy Shevchenko , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/1] ASoC: soc-ac97: Return correct error codes Date: Wed, 15 Feb 2023 15:23:43 +0200 Message-Id: <20230215132343.35547-1-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.39.1 MIME-Version: 1.0 Message-ID-Hash: EUWLNQLOTDXFK2VHORHOF6ROBQNN7XHD X-Message-ID-Hash: EUWLNQLOTDXFK2VHORHOF6ROBQNN7XHD X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Liam Girdwood , Mark Brown , Takashi Iwai , kernel test robot , Dan Carpenter X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: With the switching to dev_err_probe(), during the conversion of GPIO calls, the return code is passed is a paratemer to it. At the same time a copy'n'paste mistake was made, so the wrong variable has been taken for the error reporting. Fix this. Fixes: 3ee0d39c50dc ("ASoC: soc-ac97: Convert to agnostic GPIO API") Reported-by: kernel test robot Reported-by: Dan Carpenter Signed-off-by: Andy Shevchenko --- sound/soc/soc-ac97.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/sound/soc/soc-ac97.c b/sound/soc/soc-ac97.c index 40051f513c6a..4e4fe29ade50 100644 --- a/sound/soc/soc-ac97.c +++ b/sound/soc/soc-ac97.c @@ -336,12 +336,12 @@ static int snd_soc_ac97_parse_pinctl(struct device *dev, cfg->sdata_gpio = devm_gpiod_get_index(dev, "ac97", 1, GPIOD_ASIS); if (IS_ERR(cfg->sdata_gpio)) - return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-sdata gpio\n"); + return dev_err_probe(dev, PTR_ERR(cfg->sdata_gpio), "Can't find ac97-sdata gpio\n"); gpiod_set_consumer_name(cfg->sdata_gpio, "AC97 link sdata"); cfg->reset_gpio = devm_gpiod_get_index(dev, "ac97", 2, GPIOD_ASIS); if (IS_ERR(cfg->reset_gpio)) - return dev_err_probe(dev, PTR_ERR(cfg->sync_gpio), "Can't find ac97-reset gpio\n"); + return dev_err_probe(dev, PTR_ERR(cfg->reset_gpio), "Can't find ac97-reset gpio\n"); gpiod_set_consumer_name(cfg->reset_gpio, "AC97 link reset"); return 0;