From patchwork Fri Feb 17 13:59:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Bornyakov X-Patchwork-Id: 13144754 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58DA0C05027 for ; Fri, 17 Feb 2023 14:02:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=N3R/Ev+O0bBWrWDvhp2uYbxQAKjgIuoEEJqjMKqtBts=; b=dAlZWt4/0HiFHL b7mhxmlGi31jKaD2JjUGXwmzAcMiS8Nl3o98kc+SyayjHk0SgeY8OqXQuYiCJfeoJxfkLoXgv+Q6G yQT8EiraEmeyNpnE9fUk6l8jNFDezb4JJLnWTCBt7lzkFnYDvO+Gx50EHJbhZmhzqQS8iFI05pDMe HTQn3JmhI7aaBXsIQpg/7sR7iWgCT6QtaFS+W/bDL0kX5ojT3laoxnoJbCXP1UfikJDzOORpDtwh/ 9RKn/UxXquJXIrlerfbp99DRbfcstpeJFUDuQjFA+DyBpiVJFx4skgCbJxLV20hg2g8NK+myUQIpT qyhnRUtqy7n/YZFTDd9Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT1II-00ER5o-IX; Fri, 17 Feb 2023 14:00:58 +0000 Received: from mail.pr-group.ru ([178.18.215.3]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pT1IF-00ER4O-1C for linux-arm-kernel@lists.infradead.org; Fri, 17 Feb 2023 14:00:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding; bh=c/4vBN3nQqBWLIIsDr6bAnmepObZf4pgFEzfOBLDMG0=; b=R/tER2zMUKHtPFfCpbDT3N+K0DGf2KcDXFSKxn6892pcYpCzd6VjpnOYAc1SL+/JZKR3r5TnyAKO8 J+XRZcVeJcfdRu9ylMJSwi2AmmrdERZtXCiBNvHzfpgCt/22lKcupFMCjJYKyjVwXiosC9qJ4tqyrO 9YEVjHl+pPujGfQbKf3wZtqnQGhq5tWM9wmDYikTujayK0sa/quATXYrqySXDCh7zr174S3yOANuRY 14lEzroCsH33HbuVmUQuivEbk0iPoVjcU1UYdgSCx5toFRewBMU6W8uR3QuTaavzw8OJeDJ1o4jnx3 X3d5dmMKfX8jJTBHaIzuw5FKh2keMzw== X-Kerio-Anti-Spam: Build: [Engines: 2.17.1.1470, Stamp: 3], Multi: [Enabled, t: (0.000009,0.008089)], BW: [Enabled, t: (0.000023,0.000001)], RTDA: [Enabled, t: (0.410493), Hit: No, Details: v2.47.0; Id: 15.bhp4c.1gpfqqp4j.2fr; mclb], total: 0(700) X-Footer: bWV0cm90ZWsucnU= Received: from localhost.localdomain ([78.37.166.219]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Fri, 17 Feb 2023 17:00:41 +0300 From: Ivan Bornyakov To: linux-imx@nxp.com Cc: Ivan Bornyakov , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH] bus: imx-weim: fix branch condition evaluates to a garbage value Date: Fri, 17 Feb 2023 16:59:50 +0300 Message-Id: <20230217135950.19469-1-i.bornyakov@metrotek.ru> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230217_060055_625149_0102A1D7 X-CRM114-Status: GOOD ( 11.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If bus type is other than imx50_weim_devtype and have no child devices, variable 'ret' in function weim_parse_dt() will not be initialized, but will be used as branch condition and return value. Fix this by initializing 'ret' with 0. This was discovered with help of clang-analyzer, but the situation is quite possible in real life. Signed-off-by: Ivan Bornyakov Cc: stable@vger.kernel.org --- drivers/bus/imx-weim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 828c66bbaa67..55d917bd1f3f 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev) const struct of_device_id *of_id = of_match_device(weim_id_table, &pdev->dev); const struct imx_weim_devtype *devtype = of_id->data; + int ret = 0, have_child = 0; struct device_node *child; - int ret, have_child = 0; struct weim_priv *priv; void __iomem *base; u32 reg;