From patchwork Thu Mar 2 02:53:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 13156660 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B1C14C7EE2F for ; Thu, 2 Mar 2023 02:54:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4961E6B0074; Wed, 1 Mar 2023 21:54:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4463A6B0075; Wed, 1 Mar 2023 21:54:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3348F6B0078; Wed, 1 Mar 2023 21:54:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 2455A6B0074 for ; Wed, 1 Mar 2023 21:54:14 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E470CC0FCC for ; Thu, 2 Mar 2023 02:54:13 +0000 (UTC) X-FDA: 80522439186.08.3C5DAF0 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf21.hostedemail.com (Postfix) with ESMTP id 69ED91C000C for ; Thu, 2 Mar 2023 02:54:11 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677725651; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=LYdVFiXyrkB9NcocTarduO727og0tRge5Fc5hlFCSMc=; b=rqNi4nby1bjCvVsBPv8Hf4MXH7fAyWN27CLcc9r/a7Qm689AMgHv0RBHo/h/T14NUCtplU 0/iC84wpTK5/g+J79mYNGhxCh/rLHie6wxibCukb9d2ESjmoAL8qi7kULA61uFcOy1mLE/ Q8fBjgxtUb1wQW9CG0h51dxf4448BZg= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf21.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677725651; a=rsa-sha256; cv=none; b=fvGKTMt58XmaO3n+caXssEYarJb3CCE6GxQHjsJHxZJKxsgmm9q/HtU12GqR2y9uaNngn4 Yc9TZ5Ac1JcErknUdwhjYpz9y8hh1TiaZ/xD6Kc2N5ArSLqmpQnfUFE8Uu7LL3j2DlAaZd JLqP9MPn9AokimxgUYekkvRNj0WX/ZY= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 99FCB1FB; Wed, 1 Mar 2023 18:54:53 -0800 (PST) Received: from a077893.blr.arm.com (unknown [10.162.41.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id C7E9A3F99C; Wed, 1 Mar 2023 18:54:07 -0800 (PST) From: Anshuman Khandual To: linux-mm@kvack.org Cc: david@redhat.com, mike.kravetz@oracle.com, Anshuman Khandual , Andrew Morton , linux-kernel@vger.kernel.org, Christophe Leroy Subject: [PATCH] mm/migrate: Drop pte_mkhuge() in remove_migration_pte() Date: Thu, 2 Mar 2023 08:23:49 +0530 Message-Id: <20230302025349.358341-1-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 69ED91C000C X-Stat-Signature: zqf4h7u7ezuciddhk4oh1i8jt9t7h5ij X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1677725651-733050 X-HE-Meta: U2FsdGVkX18YRLnDXF0HqWnHziOb7w+vMFDb2kz1mh2GlnriJTpmK38jY44Q4fm00PgZRrlef047bOQVc4eiaTl7ivNSpK0pVrlsyH4F49bK8PA3x9XWUhz8QmM7R0bkPvXTqt54KUaCyhyXeesJb2ruTIUSPW6sAE6hJb4+lFDrL5qtJ23DVWmZ1bQ7sscXlwZ0F2qeja2+OFIx0OF9GsVfk8z7immdwysWeVTzbvzxZUOphMbJMlDVAjSBip4Ct8hRS/r/HHjhCD7O6Bg6ZKog3f3wtgbnY0IykJH3rS1obPNGjBmK5fOpuC0Rpcznm6uZErRoFzV0wIOzCce/Fkd2Lzs65LPxRtAHsokKLWQV4iJTLDtqOHP8Rc7ek+6LRKqQhsFIb0j79M70BGow0OhlxQdXdqlwZX0slp52Kbgm0zheqKpq5yfK+Bv4NP+W/nUO5hgLt3BHjqg47JG2c/etcvmsLKRyWnhXCDe9VGnWjVfvrMSrZOGhZFs5fhGLUZIAL6tdMUhL2z4WIOCJmQaWgxrlXnTxLA5g461rE4RzChuQ6nhwXY1bE5YJgook19p05B+vpapv+aU8DS+V5osvqWayKJhF2wO63rkFHwORPDXez2+ndp1h4dylryhRP+LjE2EFD+c9GPcee9YrBEh86BVY7VOWvBuXjAkBa/T7Gbh9I2YyzKg2zPiBCSBxSIXCwcFqjBGpWf+h8DXqBPsZrTxmGtN/I0aLXF7brsn8ZkY310kiclA9Hly6pSYdVlb+F9it34RUZCAfIS2IBJwefCKNUJd9sBa+CNLAdfQTonYlnSIf47DlyM7OLBjz/gCOOqDnk7oLMDn1pCMonprExbc9nEeUPqZmVD3mLxuLVbbSKuwQRmu1knboQ+Mp1A0xRtDigu4HjMI3fp2G5oqNHuh2nRYzAZWsyCfWiiFpWuNXhfvua7TFbgenq7w11+Pbd7P9tlMPW+gXtmu R2sic9Id rHqTLS1wI5xd9sHEtfmOTsZrzfNiB2gzDeGrdbPXFM/cGvRwgOKDjtyGy4nyRGJ4t7mSn7H56qMAYcyyXIxDtoXXkD287+Jq8trhTJh73Tbn9Twa//VIbhqjDajrdRPFmtXOmstxfKgSFlgjk/mtA4+1VWlUDAUAjhO7k6EgP3EXW8/gSdMmwO3Up+5y6MLPmhxGQl+bPfBpp6omafU11jkqQHQv6W0MoLuEXUEQBxRsNQBSYgvB4lkftcdwmF8Wx9dLWpTbHbCFz1aU9nlmTmXj6i+nvO+akYp2BSpi4wQT0fQIhV5YZVFN6V4xoqrHR3GvldA4mBQAhYQmD3H4zn2Jy0x9DiDHFAh0MHXbHzXOWbrqydQXNlUu+HdTJZZjPS3bUUy+sgaq6q9csj2KzUnPciRXB8EZT35adz/1z6CYCte77hHOaXQsAT3dFML2ejMwFhKsTxziiCME= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since the following commit, arch_make_huge_pte() should be used directly in generic memory subsystem as a platform provided page table helper, instead of pte_mkhuge(). This just drops pte_mkhuge() from remove_migration_pte(), which has now become redundant. 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' Cc: Andrew Morton Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Reported-by: Christophe Leroy Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ Signed-off-by: Anshuman Khandual Reviewed-by: David Hildenbrand --- This applies on latest mainline. mm/migrate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/migrate.c b/mm/migrate.c index 37865f85df6d..d3964c414010 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -249,7 +249,6 @@ static bool remove_migration_pte(struct folio *folio, if (folio_test_hugetlb(folio)) { unsigned int shift = huge_page_shift(hstate_vma(vma)); - pte = pte_mkhuge(pte); pte = arch_make_huge_pte(pte, shift, vma->vm_flags); if (folio_test_anon(folio)) hugepage_add_anon_rmap(new, vma, pvmw.address,