From patchwork Fri Mar 3 18:54:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13159400 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36975C7EE2D for ; Fri, 3 Mar 2023 18:58:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O/ViXFA01gzyE+LzgFOKpdw1QtwJudr+lH447+oAeu4=; b=L5enNAOftsic9g XztG/GlC5ChnVi2jkTLPQcgKpBts6uHEVlnrKmBA6U1kcOR66s5TJjCvRekPqfnRgKgKRpQXb+tME T3vYbXmbixItm3BTDREQThUjI8EUWunf/c3oIcJY5vYNFhVtiPwPv40RtFIei0mxs8ORjugbY8DYB zbGX1nRUvYecrR8MFyHwzFfvi7+CXDpvL3CQx917wxsHmTKsaTYIiaIvfURqgMGJpJZ/Sl9B6Fer8 0WcsOXJ1qQecA00wOED7Tj8G9MIP95LvGdDL1rj3YSUIODPcgWxJAXZKgoCHM8zTuhExMW3S2mngV Qh5+x/gpaMIpCwPe1uRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAbV-007EN9-KD; Fri, 03 Mar 2023 18:58:05 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pYAYf-007CrW-PT for linux-rockchip@lists.infradead.org; Fri, 03 Mar 2023 18:55:11 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pYAYZ-0006OB-Pd; Fri, 03 Mar 2023 19:55:03 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pYAYZ-001cV1-1y; Fri, 03 Mar 2023 19:55:03 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pYAYW-001ukg-RA; Fri, 03 Mar 2023 19:55:00 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Thierry Reding , Heiko Stuebner Cc: kernel@pengutronix.de, linux-pwm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org Subject: [PATCH 18/30] pwm: rockchip: Convert to platform remove callback returning void Date: Fri, 3 Mar 2023 19:54:33 +0100 Message-Id: <20230303185445.2112695-19-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> References: <20230303185445.2112695-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1721; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=BA5tBz3RDO+orps9Y8Wko0quf5LMj8+YSMYVNzVlmtU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkAkI/53UCg8nISaMHiQ4+6ZzNDpKtLgpeheIWj JXmDV1274mJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAJCPwAKCRDB/BR4rcrs CRYnB/956EuHuoq0uYM1tAohD8oJ5deZmHNw5BQU3ZYryxd5Qgo/oR3pqM+6lVF1esDKM5dP07h 9HcJngDvvnuZ09M+m1HvcrgBIe/1mF9b+y7qKwO7vGfXZHR+CA39vVepDQa0WbIG5bWo8JFF4wd RbtnaijBEOZVb3fApvM7qeGW+nFWrr9Fvx17XDNAIlXIHtf2BnFPAgJ4NVuugGhTJdp6epBAouY 2pskEFCFb4W+0zKrrdo1c+ezjfqW6EFWdDSwLOSvCtoxfxHKesGBcbq63iOvcTtWltA7/FHuVPo awIhMIyGoxrrBBbAth5LDK1TGe6WqTEiASb0IqRH9IKGA6Ke X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230303_105509_861027_7B03F943 X-CRM114-Status: GOOD ( 15.42 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König --- drivers/pwm/pwm-rockchip.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c index 7f084eb34092..c1a1f2d864b5 100644 --- a/drivers/pwm/pwm-rockchip.c +++ b/drivers/pwm/pwm-rockchip.c @@ -376,7 +376,7 @@ static int rockchip_pwm_probe(struct platform_device *pdev) return ret; } -static int rockchip_pwm_remove(struct platform_device *pdev) +static void rockchip_pwm_remove(struct platform_device *pdev) { struct rockchip_pwm_chip *pc = platform_get_drvdata(pdev); @@ -384,8 +384,6 @@ static int rockchip_pwm_remove(struct platform_device *pdev) clk_unprepare(pc->pclk); clk_unprepare(pc->clk); - - return 0; } static struct platform_driver rockchip_pwm_driver = { @@ -394,7 +392,7 @@ static struct platform_driver rockchip_pwm_driver = { .of_match_table = rockchip_pwm_dt_ids, }, .probe = rockchip_pwm_probe, - .remove = rockchip_pwm_remove, + .remove_new = rockchip_pwm_remove, }; module_platform_driver(rockchip_pwm_driver);