From patchwork Mon Mar 6 06:05:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ivan Bornyakov X-Patchwork-Id: 13160506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2470C61DA3 for ; Mon, 6 Mar 2023 06:06:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=N3R/Ev+O0bBWrWDvhp2uYbxQAKjgIuoEEJqjMKqtBts=; b=qTUxGPcdWJ86Z8 LfzO9r3aUFFq8ARCn6PtWJEpn8rcwJdPyyobkJbiMjhZI7KdMU03t1DezWbK/7qkxUzCEtGXHBoyB 5UG6L2Lqa1p2VM1S/k3PWohYbzBjM3MIajAS0uKDsGAaZCpQsKHtnksw4c9ej2k4T4NGCIvTyhUkF 6BtygXc/b9yrhiWfWjWfcp4yZHNk55Yc9WlascnG5MYG9uANZttUi/qQMPnIsnKnSMa4DbqoPv73s aXzL3EcpS4WSi+ve1aYnEMYZ3KuIN+xt14EGHhbHlSw88qvBtxDcwqcBbigF3IdtnJNFxU5SyHZj2 o8qG94fogtDYGCot0Qmw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ3ym-00BTDv-V8; Mon, 06 Mar 2023 06:05:49 +0000 Received: from mail.pr-group.ru ([178.18.215.3]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ3yi-00BTBi-EN for linux-arm-kernel@lists.infradead.org; Mon, 06 Mar 2023 06:05:46 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=metrotek.ru; s=mail; h=from:subject:date:message-id:to:cc:mime-version:content-transfer-encoding; bh=c/4vBN3nQqBWLIIsDr6bAnmepObZf4pgFEzfOBLDMG0=; b=kyyTIpPE3XvCJ7L1R2x3j76VwU6GDJauqTMQSnPSl+GfeghsVSF2NbQM85Y4F9aovY14NRPdmrLi4 ky5BO6y6f85B8AHFlwJqBTrOj+FjZTfL2Ax4CLY14HWBpLIjnCdC7p44oPOjv18dw0y/NKcMehf9j/ B+mZbg8kABSVLBTr4JSoqK6vVPK8xyzJ1/fHTC5us47RwAd3VtnYMA4vT00U/JdcH6S1NLvvvqNMg3 MRvP4OXj5RPSiha4x//yJ5zKwm+wCZqduUAY3vfoldKEuY7s8ocQUwMBNM/6/fkWbbe7eYwuMP9pdS asaU/lOxtgX3ZbPWlyz3g9IDabmG5/A== X-Kerio-Anti-Spam: Build: [Engines: 2.17.1.1470, Stamp: 3], Multi: [Enabled, t: (0.000009,0.007108)], BW: [Enabled, t: (0.000024,0.000001)], RTDA: [Enabled, t: (0.510061), Hit: No, Details: v2.48.0; Id: 15.gc9bg.1gqqocp1s.2i7; mclb], total: 0(700) X-Footer: bWV0cm90ZWsucnU= Received: from localhost.localdomain ([78.37.166.219]) (authenticated user i.bornyakov@metrotek.ru) by mail.pr-group.ru with ESMTPSA (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256 bits)); Mon, 6 Mar 2023 09:05:26 +0300 From: Ivan Bornyakov To: linux-imx@nxp.com Cc: Ivan Bornyakov , shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH RESEND] bus: imx-weim: fix branch condition evaluates to a garbage value Date: Mon, 6 Mar 2023 09:05:05 +0300 Message-Id: <20230306060505.11657-1-i.bornyakov@metrotek.ru> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230305_220545_046451_F1FC66CE X-CRM114-Status: GOOD ( 10.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org If bus type is other than imx50_weim_devtype and have no child devices, variable 'ret' in function weim_parse_dt() will not be initialized, but will be used as branch condition and return value. Fix this by initializing 'ret' with 0. This was discovered with help of clang-analyzer, but the situation is quite possible in real life. Signed-off-by: Ivan Bornyakov Cc: stable@vger.kernel.org Reviewed-by: Fabio Estevam --- drivers/bus/imx-weim.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 828c66bbaa67..55d917bd1f3f 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -204,8 +204,8 @@ static int weim_parse_dt(struct platform_device *pdev) const struct of_device_id *of_id = of_match_device(weim_id_table, &pdev->dev); const struct imx_weim_devtype *devtype = of_id->data; + int ret = 0, have_child = 0; struct device_node *child; - int ret, have_child = 0; struct weim_priv *priv; void __iomem *base; u32 reg;