From patchwork Mon Mar 6 07:34:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13160571 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 685CDC678D4 for ; Mon, 6 Mar 2023 07:35:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc: To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=lTWfjSP0roG5sdqQJHUb70dFUyTMFEIue5pDrsyqG8A=; b=v/6lc/va8uka8sR9lCo34p3QRc ZfJ+/Z9TM37tZssnt15z56X4fJuJjb4a42i6ypEOdlaw4V7bSiVq/LD6zQ393idHNtLxxiAyQlLx2 ytNAIwjBaGhed7Mny0titbNebtF2erDlhHKUl3B0mieUHMeZiHDB8KUk1Ce0pvmdzhZrKJw9nC5zr rMW1xbxzuUyXasSMm7zKdeSGDJD5eKUb2esd56txxr6qTVCsukc7E6K43FtEXSQnhpVKRJh3LR+Li NheAhSB80jQEbCZaF/pwQe72t3gFNRCiYoFoRQ/qQ5V2tJRTGffYA4JDTwYuaYo+hqiO1j30V3fBv Ye/Tqv/g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ5NL-00BfSd-A0; Mon, 06 Mar 2023 07:35:15 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZ5N8-00BfNi-KE for linux-mediatek@lists.infradead.org; Mon, 06 Mar 2023 07:35:04 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZ5N2-0008Ou-ND; Mon, 06 Mar 2023 08:34:56 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002C0t-Sx; Mon, 06 Mar 2023 08:34:55 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZ5N1-002bas-4i; Mon, 06 Mar 2023 08:34:55 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Stephen Boyd , Matthias Brugger Cc: AngeloGioacchino Del Regno , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 2/3] spmi: mtk-pmif: Convert to platform remove callback returning void Date: Mon, 6 Mar 2023 08:34:45 +0100 Message-Id: <20230306073446.2194048-3-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> References: <20230306073446.2194048-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1827; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5a+AWwYSnblGSgN1CjlLhD5ySXt5UsbCdNXjzOaMDCo=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBZeNw+Op0YHpL7jeNZglJdgk4+HUUAM9Syky4 ZopRHF9SD6JATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAWXjQAKCRDB/BR4rcrs CRFuB/4rWilHuRqmsO6Tvne6ucKbjyP6e/oEpCNTWXJi4wAQWy/PA01KR1+U4isqwbFlNKhj7MA 6ZzMRG7JvPk4LMS2YiKoyNCMTsBpibuaptG5ltsCFYUQ+/3PMyp7E9Kcgpec516fuIzGQFHEfRK D+pFr7HQCuxvrtD/bq/M72MaWx3efZecUWPJPYKYSJnoBAuN5hrdJtme7HPk2F6+jZcTIysvkh1 P7gklleW9mNP1MRoeLgwiR4D246K8biZWLVsck6rihhzWDwyqWHpH6Jvsmk7TNtVcPPM6BBNzKm RQcw6r/w9FU222K3hwnXdWfUtd618Wppjt7aJInqUfWyDP45 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-mediatek@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230305_233503_541226_00D3162F X-CRM114-Status: GOOD ( 15.75 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: AngeloGioacchino Del Regno --- drivers/spmi/spmi-mtk-pmif.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/spmi/spmi-mtk-pmif.c b/drivers/spmi/spmi-mtk-pmif.c index ad511f2c3324..fbcb3921e70c 100644 --- a/drivers/spmi/spmi-mtk-pmif.c +++ b/drivers/spmi/spmi-mtk-pmif.c @@ -503,7 +503,7 @@ static int mtk_spmi_probe(struct platform_device *pdev) return err; } -static int mtk_spmi_remove(struct platform_device *pdev) +static void mtk_spmi_remove(struct platform_device *pdev) { struct spmi_controller *ctrl = platform_get_drvdata(pdev); struct pmif *arb = spmi_controller_get_drvdata(ctrl); @@ -511,7 +511,6 @@ static int mtk_spmi_remove(struct platform_device *pdev) clk_bulk_disable_unprepare(arb->nclks, arb->clks); spmi_controller_remove(ctrl); spmi_controller_put(ctrl); - return 0; } static const struct of_device_id mtk_spmi_match_table[] = { @@ -533,7 +532,7 @@ static struct platform_driver mtk_spmi_driver = { .of_match_table = of_match_ptr(mtk_spmi_match_table), }, .probe = mtk_spmi_probe, - .remove = mtk_spmi_remove, + .remove_new = mtk_spmi_remove, }; module_platform_driver(mtk_spmi_driver);