From patchwork Tue Mar 7 11:58:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163276 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E72BC6FD1B for ; Tue, 7 Mar 2023 12:00:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=64mquFfGCNHC9R1KRkr0jjkx24kHd1pIp2GXEEnxj4U=; b=VZlBZC3uIfvDM/ zKmUaYEWVynDop9MvQeenbzDmd/ivUo5ywJXzrNmfLr9npZ0ow3y5bq/QY8UW1IJ7smkvC+8IWSYH uDZchdBaCIrRCIWRSgDvdu5EOjzMFfG0dXMzj8UEMUkzfnlclyEFi7TeDRnvq3pCHTEM9MRnrJDai 6ouKV5+wP2yFyKqtEbYcsOJsjU5yN6AXfSxM+QPUq82PGAEN93HPEQSvIm29kWfcRMJhOoaoiBqvg HMGWwc1c90zL8dsy4aO4M6FuRlW208/Y6qSvwYa0vnykEzOPK9bWKtXwCwPfdVWyaFzW1uXbBlj8V eqj/QsjaM3Smd07S4ctg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVz8-00HZRv-ES; Tue, 07 Mar 2023 12:00:02 +0000 Received: from metis.ext.pengutronix.de ([85.220.165.71]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyZ-00HZ5H-6v for linux-rockchip@lists.infradead.org; Tue, 07 Mar 2023 11:59:30 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006Xr-A1; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TFt-Bn; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjl-0C; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 19/31] phy: rockchip: phy-rockchip-inno-csidphy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:48 +0100 Message-Id: <20230307115900.2293120-20-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1823; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=rKB6vQSyEOcEB6Yn09C9wyfvQ7PzuQTyGnWZzQK5XLU=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybNVprDdkO8rBIC9F9dBj8xmmgLxeNLSySC1 guLTVnTEQmJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcmzQAKCRDB/BR4rcrs CUhmCACPB/d3JbmiA0MSXVBX8o7WtNePiXmVM4dNzpOw2CpLnzx9O7YgLKntZ88orU6AZcfJcKH U163C93zc3dgj3AYyNDH9OT3WQUffx/9qdIUBlfVa7A7qtl4LQfPmzhjvObuGyFwqd2zWQUaxkt JbScAyliEQNn7+oqIuqw0//piqCv0taM9giuMh7oSQHOSju2Cc01TKjb/9wbqNRX4+XCTnA68wP rqfwh1i9GF5mrzcVN0zw8Sfv3UayGPJFibOZYrxE1ZLj+L3KDgNnCeuZwLvxWutgIGuZcnUUrRA k3z7iA9Q76ztl3IncymOw2g1lGHYxEKUGaWYhZCwGdXW2do0 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035927_330976_A80CFE38 X-CRM114-Status: GOOD ( 15.54 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-inno-csidphy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c index 75f948bdea6a..98c92d6c482f 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-csidphy.c @@ -459,13 +459,11 @@ static int rockchip_inno_csidphy_probe(struct platform_device *pdev) return 0; } -static int rockchip_inno_csidphy_remove(struct platform_device *pdev) +static void rockchip_inno_csidphy_remove(struct platform_device *pdev) { struct rockchip_inno_csidphy *priv = platform_get_drvdata(pdev); pm_runtime_disable(priv->dev); - - return 0; } static struct platform_driver rockchip_inno_csidphy_driver = { @@ -474,7 +472,7 @@ static struct platform_driver rockchip_inno_csidphy_driver = { .of_match_table = rockchip_inno_csidphy_match_id, }, .probe = rockchip_inno_csidphy_probe, - .remove = rockchip_inno_csidphy_remove, + .remove_new = rockchip_inno_csidphy_remove, }; module_platform_driver(rockchip_inno_csidphy_driver); From patchwork Tue Mar 7 11:58:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41360C678D4 for ; Tue, 7 Mar 2023 12:01:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=s0DzPkR10LR5944/OhIRyt4snKLOW9+WFInqOLI9zrk=; b=t1ANLwu2PGCJB3 fX0726MOlss8voW6TqPIh40bjpw5mtQf51iZMsYUzit6BqyhBJFPHST2fPI8hf7V3HmK2qs0owzBa N+mL4VSljddSbpwM+tO4Z0iRAupcX9v1ouHAezWiAw+/sWEzsOfOssH6FKK8bbGPMHVHVoyqAUMoQ 1c/CCVAGCexrEOBtwz0IiA5TXiXqD5YTJqCm5dk2XsM/r4NRdEfMpZT6KvRVBegipPISUn6xV0d0X I1fInNdVmzr/99m9sspVUcwNM6C51X9M4+LcmxjLuMgP32wB8KvnyJswm7xqPYQKVnw5+Ee8n2hI8 6IwOnxY+ULe/NGzmGF/w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZW0F-00HaBX-Sp; Tue, 07 Mar 2023 12:01:11 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyn-00HZFC-2N for linux-rockchip@bombadil.infradead.org; Tue, 07 Mar 2023 11:59:41 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:References:In-Reply-To:Message-Id:Date:Subject:Cc:To:From: Sender:Reply-To:Content-ID:Content-Description; bh=g1vqvTlUAhfbA/a07juXwrOrwoUg5CF3Bj8lXsjOs3k=; b=TuzRIaZqG5tCoKR9Am8N/ORDZG o7LbLEzjCqxibmbJ/slqtvtRTAKnoWh2xWFPwp2rmfDV/TpqxUYOLp4EdrURqD5dZpkqXVWqpHGgh BWdEttHBHLOf3FUzEMMlBGAK3FjM4peXL3e4IdI1fjhxs1vqVeLfcbEkE3PoiKGTFWCMAEhmg6kKz tSxVF3dXT65ZQoVbyoxNgfmllMpDLRvGzZivRa0h9ONHk8N+8vcJ9PUjqmY9XbSigW1Ax9BgGVrVK MOU9bQmft9L7rd4EHCQ/fADyMtN8pW2VVfA1+q/aHAkA1a1pdlLEsZAAjO8jzImEIfLvB25z+zAwX JIVl25Qg==; Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pZVyd-00H2CY-24 for linux-rockchip@lists.infradead.org; Tue, 07 Mar 2023 11:59:39 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006XQ-9l; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TFm-6X; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjo-6I; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 20/31] phy: rockchip: phy-rockchip-inno-dsidphy: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:49 +0100 Message-Id: <20230307115900.2293120-21-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1745; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=lehOlgnny9s9YCry74LCGOZ0ZUh8mvbpw5s20/s1D2E=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybRLBReKv+70Ss8u3GHrR3lrh0qQpW+itAX6 fM01umsxBWJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm0QAKCRDB/BR4rcrs Ca6RCACDNdLE05biV9TVjBa1dw1Ho9bE39CgUqssJyw3KsPPTc/ieVj9irScI+gV4ZCrnG2VA1C PnOsgncF1VGtyqrpDGJ5qody35ck8N2hwL7skAm3UhcGk0RQEVZETeKPXKmbYx0YNgHCsgRoxCY MU7pFmXtlXL545NtYaqX0UymSo1MpUCcG8ImDRxRp1rXL6jpPpYbccpJHLJZ0dkWJ7dOHIqBnts CsZeH7L1nTqVabd3DP12ZuEUcOwo0ibzhzSi2ANKyWvQpzVFKxtLWLlvWEC7ERS9Qf+DGFPs/XE B9vz6+mUnWYCreFafvt6imG75rIrQtQz7F4QI1F9066t4rJK X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_115932_738033_1C784E3F X-CRM114-Status: GOOD ( 15.61 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c index 2c5847faff63..726928ff1273 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-dsidphy.c @@ -755,13 +755,11 @@ static int inno_dsidphy_probe(struct platform_device *pdev) return 0; } -static int inno_dsidphy_remove(struct platform_device *pdev) +static void inno_dsidphy_remove(struct platform_device *pdev) { struct inno_dsidphy *inno = platform_get_drvdata(pdev); pm_runtime_disable(inno->dev); - - return 0; } static const struct of_device_id inno_dsidphy_of_match[] = { @@ -788,7 +786,7 @@ static struct platform_driver inno_dsidphy_driver = { .of_match_table = of_match_ptr(inno_dsidphy_of_match), }, .probe = inno_dsidphy_probe, - .remove = inno_dsidphy_remove, + .remove_new = inno_dsidphy_remove, }; module_platform_driver(inno_dsidphy_driver); From patchwork Tue Mar 7 11:58:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163278 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77AFEC678D5 for ; Tue, 7 Mar 2023 12:00:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zEM3wvoRF6I2LutmxrSWLR80ZIqePEnQGhYr9HRTeuQ=; b=lY+5qSsrcDygY8 zAx8LrP/Bo1yNOLBYAvqeEkL16hb/4kQLJPzEmXnZkfLkjxnXaHljJfYwpScxDIlYKWcHoSUkfHDg qWxVuZ7V1DtMM+OgzhhkQYrAM6zdt4AyEIxJOuEUy5ngsPqxn2viNqnANLy8yvCkplHNnkcA9ufWQ o4oROvnv4eTEhuaxJtEqGftakmfUISrkAFdbLFhQMRdeonc2kJmAU4fY2IGV+2izkLzzqCkdWGksO h1jni4//LmpH7Zdlj6xibOCYcE6LO2Fpoz1EwiEvRr8N9ar1rayrpLiAi7QiKzt9TvylLhV3vZLiz iicswKVOioeB7JKanHnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVze-00HZmY-77; Tue, 07 Mar 2023 12:00:34 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVyc-00HZ9U-Eg for linux-rockchip@lists.infradead.org; Tue, 07 Mar 2023 11:59:33 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006Zc-Hn; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TG5-Qk; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjt-D5; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 21/31] phy: rockchip: phy-rockchip-inno-hdmi: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:50 +0100 Message-Id: <20230307115900.2293120-22-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1741; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=aTRs7YiQ1a+7kK0P1WOZZiXEEjnBAy1vmBRa+WG7UPE=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybV3L1Dd9AGvegJYwUQZ5NxkwVVEGm6pZSsb LzqF38wCSiJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm1QAKCRDB/BR4rcrs CWIxCACcWZnkd/l9nWEAp/E6XOnXQklrsB5Szy/o/BxNY+Jmd1pDG5nsSsCq5zcLd8//GsGZpqV YpBlpqd+sq4BecUPOFSp/UfxqrJoa6GbgtiNnssv5vF5pE6MJp6Iu/qbAP4u1oJ5yeuouW8FODv 1HJlz6AAkdakrQB+llwS7QF9OtCtaY9PhjHVYv9thSK0EdXZDB5abHZERQVy/xRaFwln1Ikji6/ sSK7bSIGYfhnZZJSKnfypGFYkhxysYcKt2YunaPbME1EW/kbr+I0UddaIYhqSjMmXIlHfYGfo2K mjUrvgga7sk0qzjo0VpZJ6iO2BiQJ8InJJPsfRdNhUVHp6aI X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035930_518911_982EAFFC X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-inno-hdmi.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c index 80acca4e9e14..1e1563f5fffc 100644 --- a/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c +++ b/drivers/phy/rockchip/phy-rockchip-inno-hdmi.c @@ -1246,11 +1246,9 @@ static int inno_hdmi_phy_probe(struct platform_device *pdev) return PTR_ERR_OR_ZERO(phy_provider); } -static int inno_hdmi_phy_remove(struct platform_device *pdev) +static void inno_hdmi_phy_remove(struct platform_device *pdev) { of_clk_del_provider(pdev->dev.of_node); - - return 0; } static const struct of_device_id inno_hdmi_phy_of_match[] = { @@ -1266,7 +1264,7 @@ MODULE_DEVICE_TABLE(of, inno_hdmi_phy_of_match); static struct platform_driver inno_hdmi_phy_driver = { .probe = inno_hdmi_phy_probe, - .remove = inno_hdmi_phy_remove, + .remove_new = inno_hdmi_phy_remove, .driver = { .name = "inno-hdmi-phy", .of_match_table = inno_hdmi_phy_of_match, From patchwork Tue Mar 7 11:58:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13163277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67738C678D5 for ; Tue, 7 Mar 2023 12:00:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=G5xZqtF3gUgRCOAdvdGQaIrXcibF08MUt+i1JoINgkw=; b=woM6muQAYae7Yp kKCakezmNVk+TbAISm7Xcw+Lzdui7r3G5NMPKPPIMoSkZsGp8QWKUU1R6JBx27XVsE74K1T2zrnEq d4Lly+KdLqeuaFDBykr/ydFhEF4W0Sr2iwDUl2ZXzpIOa+UnIfPduspft4nxaaainK7m72ZkVI7PG vATUJyrmvbJfiWmrySnNRcOFc/0LtIRZJbRT966k16QhK9CmlPXZbvIqbK0lkPLjy0K+XIGuJ3Jjx jioMpur2w+oFXgS+4/7uSk633QV9a9osnSZKhlBAjUEkWxjU4FHEkSUDmK5+faSDNyGdaslfm1Y5F 0wng4ZfuBBtfUErWnCog==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVzM-00HZah-18; Tue, 07 Mar 2023 12:00:16 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pZVya-00HZ7t-E2 for linux-rockchip@lists.infradead.org; Tue, 07 Mar 2023 11:59:31 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pZVyK-0006Ze-IP; Tue, 07 Mar 2023 12:59:12 +0100 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pZVyJ-002TG6-RJ; Tue, 07 Mar 2023 12:59:11 +0100 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pZVyI-002yjy-JL; Tue, 07 Mar 2023 12:59:10 +0100 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Vinod Koul , Kishon Vijay Abraham I , Heiko Stuebner Cc: linux-phy@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 22/31] phy: rockchip: phy-rockchip-typec: Convert to platform remove callback returning void Date: Tue, 7 Mar 2023 12:58:51 +0100 Message-Id: <20230307115900.2293120-23-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> References: <20230307115900.2293120-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1736; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=0SUGPfok3tQB4A0ITBzAkq4+prG7Ts411Ut+16Tw0IY=; b=owEBbQGS/pANAwAKAcH8FHityuwJAcsmYgBkBybZ3YLBj5r2BWZEkEDfzAu3GR/hqL/rVcKar qszkPo4OieJATMEAAEKAB0WIQR+cioWkBis/z50pAvB/BR4rcrsCQUCZAcm2QAKCRDB/BR4rcrs CVYRB/9Y6kEMwwc/lyj4lQFyg9u4AFHjGIytRfG/uKS97fyy268AEkXOwu3jdYyJOd098l83jlC dP27PQ/qan4BjOFD6aoE72dEM7RHOxGOCpDE/diW8jWXzaAKXcvQAOznfeLhkCua8X9vpq+krTz zFAAC1Z9+Rcy1fLoCLECi9GEyhFGSzEUEt7MVRLf51HZIECkQ3SM0qHOZCx1wMsLgQlHjJrLJJ1 SMayPApQxFYNy+j8mZpZu4jrBYQ30yKOW7VLn0DsNDwEE0tLsYzxLkWDHInKol8+0ylg/yz3fzd 2qAK2ITRskiLBgXAJFi4RZA43O0N2q7+vAaerwdu8CgQiwEb X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230307_035928_496023_497F4788 X-CRM114-Status: GOOD ( 16.05 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/phy/rockchip/phy-rockchip-typec.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/phy/rockchip/phy-rockchip-typec.c b/drivers/phy/rockchip/phy-rockchip-typec.c index 39db8acde61a..8b1667be4915 100644 --- a/drivers/phy/rockchip/phy-rockchip-typec.c +++ b/drivers/phy/rockchip/phy-rockchip-typec.c @@ -1194,11 +1194,9 @@ static int rockchip_typec_phy_probe(struct platform_device *pdev) return 0; } -static int rockchip_typec_phy_remove(struct platform_device *pdev) +static void rockchip_typec_phy_remove(struct platform_device *pdev) { pm_runtime_disable(&pdev->dev); - - return 0; } static const struct of_device_id rockchip_typec_phy_dt_ids[] = { @@ -1213,7 +1211,7 @@ MODULE_DEVICE_TABLE(of, rockchip_typec_phy_dt_ids); static struct platform_driver rockchip_typec_phy_driver = { .probe = rockchip_typec_phy_probe, - .remove = rockchip_typec_phy_remove, + .remove_new = rockchip_typec_phy_remove, .driver = { .name = "rockchip-typec-phy", .of_match_table = rockchip_typec_phy_dt_ids,