From patchwork Fri Mar 10 23:18:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Minwoo Im X-Patchwork-Id: 13170393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D078AC6FA99 for ; Fri, 10 Mar 2023 23:18:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5D4386B0072; Fri, 10 Mar 2023 18:18:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 583E56B0074; Fri, 10 Mar 2023 18:18:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 44BC08E0001; Fri, 10 Mar 2023 18:18:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 323786B0072 for ; Fri, 10 Mar 2023 18:18:10 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 02854A5FDF for ; Fri, 10 Mar 2023 23:18:09 +0000 (UTC) X-FDA: 80554553940.24.8A101FA Received: from mail-pl1-f174.google.com (mail-pl1-f174.google.com [209.85.214.174]) by imf30.hostedemail.com (Postfix) with ESMTP id 3C9C480019 for ; Fri, 10 Mar 2023 23:18:08 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IkTv3XFE; spf=pass (imf30.hostedemail.com: domain of minwoo.im.dev@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=minwoo.im.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1678490288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=Xz51x4A7Eu2J8EAn+UJRgtV0WTJYDaCqLo8gQb4mjo8=; b=xyy41WmHQr8sy/2+FTlzWnsPKUpcZ8VnvdxSIE63nT2si6KmAb4mVELW8x5uD0a2Vc3x4X JPaPPklg1rh95Rzj6eFGvBcbnGwvyc84yuETJae56AUBL9Q/bGwx/yVCaxgD6SA5zStL9y rVb5zDhYRGCQvevndsiDQiP3QNIJBXE= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=IkTv3XFE; spf=pass (imf30.hostedemail.com: domain of minwoo.im.dev@gmail.com designates 209.85.214.174 as permitted sender) smtp.mailfrom=minwoo.im.dev@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1678490288; a=rsa-sha256; cv=none; b=zozqQIJYIuB3vbJ0JIjREsp2edltf6yczb34HlL59oH4Y+SnmnwhLnbmz/iiT8O18sKx2I XYNn2bh60F5EoPw29C7gbWmpyEaDxs2yKUV+6t3I9BFBJsI1toXiIVH2yNgqj3CYCUAGdg pLbg5+nDhMySoYBgHtx+urqE+rNyu4A= Received: by mail-pl1-f174.google.com with SMTP id i10so7222612plr.9 for ; Fri, 10 Mar 2023 15:18:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; t=1678490286; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=Xz51x4A7Eu2J8EAn+UJRgtV0WTJYDaCqLo8gQb4mjo8=; b=IkTv3XFEIPNwy4r9MsPML+H2ITnf/hCMh/ExSQ5fRUWO2YF0FXQbGYUBvPFIsaAp/V ExZwHOD9QBnhtikHQFevhWxsi2uzrNwqaec2d2sIU3WW07Wr3buOynStkbZ1yrMaO7C9 XdW5YJT6L/BJM0LwxaLn7iQt16DGI/8UxcchwXSAtqUZkgU6CkBLIQzS6DLTfJBElshv zVSG1L3VeBMEZe/o3MtLXJX0W+kxJf6N5GkUAWNtyrN/gxdK6X280V66GzTi0j0V/fzk 8t3kHXQ4eU7zlU/aIB7MnkkJlalPRBy8aTFY2kKQGoOyDfJTkkqwy9w2AT12aH26ZJee b9mw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678490286; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Xz51x4A7Eu2J8EAn+UJRgtV0WTJYDaCqLo8gQb4mjo8=; b=qKgxzvtkhrLaFzP3HlWI0Hz1JBpJ9PK3NeYXiqxE3dD2+CBik+6i0vt54zOIiHEWIq gyOmUBsEQ6ZkyR1v0OG4a3oG2K2O6a4WrOqKFvQ8VwE0J40STSw2drEIGuvTLGn+B+WM t9VXoQoH1aAHCSbf1+9cEJn+/6+5QCHb1IVl2rvlsEEmu/DVFdn10pUjug2kQRkIFNpP PXFXh9DKKR8Zj0DnuagYIbcosyRPwRWUoIZm6AiPY123YuKS8apx6g7ncvFN9J8xBNq4 KebYOTWYT90pGxJ2HSOV0TxniEdePPAP/8aE02dh/oc4t9GfAttYn41lmpfHVAHNMOc/ rbJA== X-Gm-Message-State: AO0yUKUYnW71UsvGTXjWSVQnrDwSA6dzEVPlM5KfeGMZyuaouKPFjd0G wP6dPhsRybGX+TYqyOyFR0WzOBBQPmY= X-Google-Smtp-Source: AK7set/Iz59s/NdeXOmRSALJuBKpSAOu9yMJGeQkSDCuRCUm52bWvdDU5u6oYbAy83whlCfN/Id08w== X-Received: by 2002:a05:6a20:3ca5:b0:cc:50de:a2be with SMTP id b37-20020a056a203ca500b000cc50dea2bemr4018231pzj.14.1678490286291; Fri, 10 Mar 2023 15:18:06 -0800 (PST) Received: from minwoo-desktop ([1.237.94.73]) by smtp.gmail.com with ESMTPSA id g19-20020a62e313000000b005813f365afcsm291741pfh.189.2023.03.10.15.18.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 15:18:05 -0800 (PST) Date: Sat, 11 Mar 2023 08:18:00 +0900 From: Minwoo Im To: linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org Cc: Steven Rostedt , Masami Hiramatsu , "Matthew Wilcox (Oracle)" Subject: [PATCH] mm: mmap: remove newline at the end of the trace Message-ID: MIME-Version: 1.0 Content-Disposition: inline X-Rspamd-Queue-Id: 3C9C480019 X-Stat-Signature: cdndi5q7wskqiztz3sw6beopu3pqd61w X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1678490288-640798 X-HE-Meta: U2FsdGVkX1/jNuXJ9wucwPXedKAbtmHfTMSSBrGwA4lW6jweqATci5+JDEhBjhs9n9coKlpBrfd2y65fPA837roZ/8Dpk96qemiWmo2MJLDKEXeRdKleZZj64eAA+PSCcON5EcpIsM5PsEkSYuDI8l3UOoxBcCGKwrkbotglfxr9vcRj+Y6O5LZXs9PEVXJRB3QFRCQARN/wX3Xz63GWzQmcndRwIdtkFeEUVqAZBrBkwdzZxh6xxZSr46UvXjuOXyn/tGlL86mCohIiwlDLZyKCDoLwjxHDG8LnzxcJl+09wvJKEe1m2PUwdGQgvqmMzCmfr+7OsgxS8pY+LvBU3/u9iBuJvltVTHNrckfErlpQx08N56jG0dhXvRQ2fSw0HT6Y47qRQa21FP4wHXfBvFZi+Ja27LHQG/My0X4BjbdhKBMgpUtsmyOSk4RqEziJ5m+lHaAGYk3EMHfdy/NCdYF1RcYxiiUEnIVTgWyvARoUslZOq6LN5OLDB0eCacPi0eYFRO1sBBig4umw7TDM2lcXFDc5g4ZIOMyPnuFqliSVNA12jZA/SPJWKqNeTxOkveCURKv2+keouZF8CSiAdbB7FRrlO6n5Qp8VJJ/VoI1yA4ePf8vKKcZwKClggeP4+Q9NFyw/J90lq3F8Ayv3WGOQbQqxWv1ptnGqwZJ191NgOvs5ZhEqSbYazN60+d1bXIPtK1OSt/46Giv10GixN8Tx6Pq0yUD31LRPKloxdAnRgspFi9/nhuT4koTph8ypNs40wgeFS4wx2V8weDheQtkVl8fOMbdt+Yr/EeEVKVtIz9jQbR3rkYmJQOSq6VgdJeA2C15/t2KClBs1JgAs8+5P0ewTlD5JVHfX6wtLH1NqKU81rr2Or1cDDftaENCjAeX35T2haCLNtwJCEgIpn8s3AafK8Na3qsnKajPReKOvWL3TBnZ/mRb/oHLo1SExzDS+6ZmL6XnMcYU6R+Q gaZn3Urw +VHJWW5S1D2vX2KGl3eAGxMV+70CokMcTVRsGL3BD3w9Uu68SLmf3fW2EhPlAooCCW7XezI+0av4az/t7XkibOnG1QmOPvtxBQ08jtzGk3XFfHzsswNIVlZQYco/i23k6LKAoAmS2WHS98RM/rJFWPQmcfciJ4U3tsQVbH9rGP06xKolcoqTtD9rfy0zSzLvTm5zXAmjuwbhSNI5NZdZcZIp7CbttS5C2HSVrR9o+6F5i23cZ55s0F0crCfNaDV3EGIcR44FPCOaNYUbfZ6vSbfE57Oku8HQhXXzjxW6UrfXK/Aa+O0C6fsVqBeI3u1h3FzhankxIIo1qGPQJ82jgx16bYpQwbR5QFaPtQFahY1N8hJY1kXqB9IlBkplMKWriNY9gVksT/EDt+BLr6lUEQZNs2bDpPryqs3BpHOWtyAfFd2iH3t/TXy/nqfk/c9ZhC0uj4gX/3xf5Gn9o0ZCH10UNKB6FRIPsndzQmtbM70CKPLDrow3WGfcaFg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.001325, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: We already have newline in TP_printk so remove the redundant newline character at the end of the mmap trace. <...>-345 [006] ..... 95.589290: exit_mmap: mt_mod ... <...>-345 [006] ..... 95.589413: vm_unmapped_area: addr=... <...>-345 [006] ..... 95.589571: vm_unmapped_area: addr=... <...>-345 [006] ..... 95.589606: vm_unmapped_area: addr=... to <...>-336 [006] ..... 44.762506: exit_mmap: mt_mod ... <...>-336 [006] ..... 44.762654: vm_unmapped_area: addr=... <...>-336 [006] ..... 44.762794: vm_unmapped_area: addr=... <...>-336 [006] ..... 44.762835: vm_unmapped_area: addr=... Signed-off-by: Minwoo Im Acked-by: Steven Rostedt (Google) Reviewed-by: Mukesh Ojha Reviewed-by: David Hildenbrand --- include/trace/events/mmap.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/include/trace/events/mmap.h b/include/trace/events/mmap.h index 216de5f03621..f8d61485de16 100644 --- a/include/trace/events/mmap.h +++ b/include/trace/events/mmap.h @@ -35,7 +35,7 @@ TRACE_EVENT(vm_unmapped_area, __entry->align_offset = info->align_offset; ), - TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx\n", + TP_printk("addr=0x%lx err=%ld total_vm=0x%lx flags=0x%lx len=0x%lx lo=0x%lx hi=0x%lx mask=0x%lx ofs=0x%lx", IS_ERR_VALUE(__entry->addr) ? 0 : __entry->addr, IS_ERR_VALUE(__entry->addr) ? __entry->addr : 0, __entry->total_vm, __entry->flags, __entry->length, @@ -110,7 +110,7 @@ TRACE_EVENT(exit_mmap, __entry->mt = &mm->mm_mt; ), - TP_printk("mt_mod %p, DESTROY\n", + TP_printk("mt_mod %p, DESTROY", __entry->mt ) );