From patchwork Sun Mar 12 11:23:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13171313 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E1689C6FD1F for ; Sun, 12 Mar 2023 11:23:18 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id F294A10E105; Sun, 12 Mar 2023 11:23:16 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5D63110E105 for ; Sun, 12 Mar 2023 11:23:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678620194; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=MHyu4+8kPd35BCnU7In3CFdj9IYOtFD0P1pEdmm81PU=; b=hCC+g66KXF4Csj3PtNhQHGy07IOUY86AyoGz6ZS3+yZPk7Wa6sa99NRaMrJUGr8MoMAmAp d3SqS7Uv0Fdv6Es6kLvIfUoIqeBd64gOY1w1PjBIG/31eiMvP74zd1iRWVYSOJmuH8Z98/ fUmsCa1uGsdp6HnONPH8wl3u35ZWnUw= Received: from mail-qv1-f69.google.com (mail-qv1-f69.google.com [209.85.219.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-529-sEX-rmq7NfiV6kW7zxKxrA-1; Sun, 12 Mar 2023 07:23:11 -0400 X-MC-Unique: sEX-rmq7NfiV6kW7zxKxrA-1 Received: by mail-qv1-f69.google.com with SMTP id s18-20020a0cf792000000b00572c04240f1so5551585qvn.8 for ; Sun, 12 Mar 2023 04:23:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678620191; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MHyu4+8kPd35BCnU7In3CFdj9IYOtFD0P1pEdmm81PU=; b=haXuU+Lz4+RQuVM3gxBqXyJPX2zrgMxBPEVKdRDR/4sKJXaB1uIYNJiHdPpfTiyfRX uQl7zOCHw+NOUa1Xsz44XbPJpoXCIBA1+zyBRlgfrAj41NuqNovdpAdIUN8Woa0yD8/z INrXdCwSaLjnw4PUvO3TSmpVm12u+6Gnh/tSth9Cd0dCYG3Rvy5hr0Ig4Z9vEXEH8S1S mBGNBOi3MSicI48/qPamwGFnbi86izT7YDkRtjBIHG10fwH16wDyOkVfbjMXMUjWET7U dq+DxoQecnrGfBLfygFvlnIzWpXSGzJj9VUe/Xk9m0F9ir+GKxq4IMtnVHKllEf1y+bh 6GvQ== X-Gm-Message-State: AO0yUKXg/op6VA9smEP9UAzA/sT891xfOAiigZVxiT7Kg/dpIYERXjA7 hYwwG1QPUu5f2DiAjIBWj0ZJ41LyexE6e980TrDMkgsDTPZ069Xv17qrHpcEcOmRMRtgHQfkCNn oJM+aMGJeSws9dQgLZq1p0CE08rSB X-Received: by 2002:a05:622a:170b:b0:3b8:58d0:b4e4 with SMTP id h11-20020a05622a170b00b003b858d0b4e4mr21299710qtk.33.1678620191065; Sun, 12 Mar 2023 04:23:11 -0700 (PDT) X-Google-Smtp-Source: AK7set8rU61IoSMnz2NMxT0D++jddUTjwTZvD4aI/Ne3rhoCM5YcURCxzOjOJup/d6HqF9HM1D0JKg== X-Received: by 2002:a05:622a:170b:b0:3b8:58d0:b4e4 with SMTP id h11-20020a05622a170b00b003b858d0b4e4mr21299693qtk.33.1678620190755; Sun, 12 Mar 2023 04:23:10 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id o10-20020ac8428a000000b003b82a07c4d6sm3507928qtl.84.2023.03.12.04.23.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 12 Mar 2023 04:23:10 -0700 (PDT) From: Tom Rix To: bskeggs@redhat.com, kherbst@redhat.com, lyude@redhat.com, airlied@gmail.com, daniel@ffwll.ch Subject: [PATCH] drm/nouveau/mc: set ga100_mc_device storage-class-specifier to static Date: Sun, 12 Mar 2023 07:23:02 -0400 Message-Id: <20230312112302.466886-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: nouveau@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Rix Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" smatch reports drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c:51:1: warning: symbol 'ga100_mc_device' was not declared. Should it be static? ga100_mc_device is only used in ga100.c, so it should be static Signed-off-by: Tom Rix --- drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c index 1e2eabec1a76..5d28d30d09d5 100644 --- a/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c +++ b/drivers/gpu/drm/nouveau/nvkm/subdev/mc/ga100.c @@ -47,7 +47,7 @@ ga100_mc_device_enabled(struct nvkm_mc *mc, u32 mask) return (nvkm_rd32(mc->subdev.device, 0x000600) & mask) == mask; } -const struct nvkm_mc_device_func +static const struct nvkm_mc_device_func ga100_mc_device = { .enabled = ga100_mc_device_enabled, .enable = ga100_mc_device_enable,