From patchwork Mon Mar 13 17:02:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13173006 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5465EC61DA4 for ; Mon, 13 Mar 2023 17:21:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=BY93nFyV6e6peNnhzx4YAIkAOo3H0tw5vzhZVHLDa3k=; b=d2sD7C1SX5uedo 8lGdhWWmX6kIpeVJU6M30cIBYv/cYfhI4wxbxlVvso+YE+aYtxOhxizDVjMoa6jvLazwswGmBhbqR aeMCFTe8e8o7B3ZZpmxrfce75kZvfTBtx6seUKRgf4Lhr4cR0NDalMmmHLLLQqcX+WJqtcc4l4csE lWGiNUPkOTAwXTm/y2LVa+L5nQ6xBZTcVsTlPdgscMHZEY/bSevtMTM/KRtMxqraTsWFcmlxabWXg vGKBlV6Tz+eeuYp72THtCva+2cNrxovfNRA73t1dO6yjlw4W2g9WnwAawPBvwXOVoaeNhh9Xi8J2o hbeLiMO5FCsaMY00f4jg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblqR-0073Xv-OZ; Mon, 13 Mar 2023 17:20:25 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pbljv-0070t2-UF for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 17:13:41 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 786C861382; Mon, 13 Mar 2023 17:13:39 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id C3434C433EF; Mon, 13 Mar 2023 17:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678727618; bh=VQQHMfQI08CHIqPPov+coidO2k506v2YpxzAR1Asbws=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=B5XUSLN6KCOalBeoQw2MdjMOVgKbJeN2gZW04b1yMzFXknpV6v3wo1qM6LeWEfupG XBSJS3/Y1RzE8GYJyimlbLmEOQRcT0G8xtGywFU1ybi7pPVp5vypPiiKMu0YaIwo75 afPLg7DdMVXPmHbGczTNtX9fcBVCJT6k9lFFevYhqMUkmCCU0TMeSiQZAgBhd4hU+g 0cA++XBHRqtQqvlvQIcYJX6kB7EOG2cfASrcF/Sa1Z2B+r43fX8pxpZTrXvzYxkFCX TcrvLcbMc76zGn/b+CakmtgaKqWS5Hk2PHS+SctCckSsp4LPkhf45oPL8jF3ZDkqrH YfDGJlHmnv5AQ== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 1/5] dmaengine: dw-axi-dmac: Don't set chancnt Date: Tue, 14 Mar 2023 01:02:46 +0800 Message-Id: <20230313170250.815-2-jszhang@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313170250.815-1-jszhang@kernel.org> References: <20230313170250.815-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_101340_100652_0CD6B6C3 X-CRM114-Status: GOOD ( 10.43 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it outself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 4169e1d7d5ca..7f3a60e28e38 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev) dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask); /* DMA capabilities */ - dw->dma.chancnt = hdata->nr_channels; dw->dma.max_burst = hdata->axi_rw_burst_len; dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS; dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS; From patchwork Mon Mar 13 17:02:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13173007 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B663C6FD19 for ; Mon, 13 Mar 2023 17:22:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=LUb/fem6UGl+p0oljJ8+AVBGD1lUCurhPeIRmhXsZJc=; b=lGnQbsBIyyQCIr CwyTcsWlalm1B9oKfmFYRAlVlqJ/SEYJzuLXpjBJU/jADkvtizA4duaMHUThF8oqCR1WoH/O/ddsq jXh9HDe9LVM9XiekLj00z0wPx8aBriN4JCyLrpm8aFedK8+O6tX3IVVOohJYIGv6D0BymW9gDEIsf 6UseRHPfHS1Evyxkj2WR/xeJFN5uXoISOkZh7/oyMVmXqYMFygWXebjDxvEg0w8Wczjp3wC4g/AHJ zUoiMyoc/Zg4UIVAk1deZmC+epZNp9tSJWcKsgBoNHGTOS1yVoZxhs/LSfA82S9u7keJ8q5a+gSUu 9pnj6MlrGnZVTWTgwVDA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblr6-0073mO-Ot; Mon, 13 Mar 2023 17:21:05 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblk1-0070v0-By for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 17:13:46 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id EC2F9B810D8; Mon, 13 Mar 2023 17:13:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 5D613C433A1; Mon, 13 Mar 2023 17:13:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678727622; bh=+THSfPIwklUUC80eud55EQMNToM9c5KqOlS32WoC2XM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qTOal6KEg0SZVhRbX2h2CEBDzRGBr32VzO+RBaVn1hEGQzAM4zdovWfmhZyejwSHN AJ+VvrD7VN5fr/rrtHU1E+KDt8Jcow0fge06jycv1hJTscQcJyr7INs2UmOBhdmwTb 414DupFCmMvpm3lAhGnbmEqM2W/bL1MQnqHt1J8mRjpBije3IMDBN0OZOmBr19iTg/ HnkT9mnarEL3YWzew22rp48cAsdYlGSzuUxZnf5Xd67fL5bBrbMfgWmsFIeEt8GGXe kuhVYiFRaUf4Ir8CB8H1S+SDGvR+kZbVcQNjlmJ9VJLoYp+dt/TxLpe120yB39YdPx WJBIaHv3hxzzg== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 2/5] dmaengine: axi-dmac: Don't set chancnt Date: Tue, 14 Mar 2023 01:02:47 +0800 Message-Id: <20230313170250.815-3-jszhang@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313170250.815-1-jszhang@kernel.org> References: <20230313170250.815-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_101345_612056_A7F898E3 X-CRM114-Status: GOOD ( 10.57 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it outself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Lars-Peter Clausen --- drivers/dma/dma-axi-dmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index a812b9b00e6b..fc7cdad37161 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev) dma_dev->device_terminate_all = axi_dmac_terminate_all; dma_dev->device_synchronize = axi_dmac_synchronize; dma_dev->dev = &pdev->dev; - dma_dev->chancnt = 1; dma_dev->src_addr_widths = BIT(dmac->chan.src_width); dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); dma_dev->directions = BIT(dmac->chan.direction); From patchwork Mon Mar 13 17:02:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13173008 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2E3C6C6FD19 for ; Mon, 13 Mar 2023 17:22:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=oS/pdVjkGyhqCiJN2CKUalk1BjwQ1XRH64nTYqC4aQE=; b=wDwilo8ITQtoix wiBR101a9j9hltPYfWeKesaZKkXv8JcpnRdWTMZ5bi/F3e5RtIj+p6BvuWPx1tMU3a4IJYCatgXWk tiw/5yGPEvGmQriDHsOyLW3YOM/kl44EHB2+Hv+kz3ToiayCV9MhEt92t4K48APFwOQux9rlRuntk msXsbJlSAZsnHfq61ssiGgW9Cy9muqiPCBb37r0R8Fs8eWnuwJ4XnydTCFrl97/ld3lYqh7OXxMFR 0VqPVMNiUebzjH9W1o+f08Lu5GApst1aocOldPHmiFxWVTojRjkFspjChSZKhpVTTlcQu0H/g2lrc otac5MqfLYTWqljIfLeg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblrv-00748o-U6; Mon, 13 Mar 2023 17:21:56 +0000 Received: from ams.source.kernel.org ([145.40.68.75]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblk5-0070wD-4Y for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 17:13:50 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 704C7B811B1; Mon, 13 Mar 2023 17:13:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01845C433A4; Mon, 13 Mar 2023 17:13:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678727626; bh=MmQlG4bKX5zRhls8Ppg0KYbzYJ0yCTbRflxLRO/KTAQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MaxyiQm3zr++CxlIZQvcW00rgAI+9VUp45EuH39mSHwSJYNEN3erATeQQBmRAbDu4 cVAF7BjY731YkBIC0veCIoGxOy9TjxXtXygU7Dtk1Npl5Ayu4xhUdiBEKdLfSqk3+2 /E6GI7kiVSyhBBujStix0sb6kdj4ecpiaU0exXy4zUVucXDiEkeLdWhTIrM2khMzH8 tBP5VPdrF1QADqGTs7xKRL+lHSi3t0mdSNDibe6Uhs1lXcCeFYczD95hqoZExkOYNQ r/Tp1Ch88FT7gUE24U8Ajn7vz22H4nQj2DP1/9hZHty6kAixtFz8/BcoGKZ85yRAdW oKxHJ7Gc7jy2Q== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 3/5] dmaengine: plx_dma: Don't set chancnt Date: Tue, 14 Mar 2023 01:02:48 +0800 Message-Id: <20230313170250.815-4-jszhang@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313170250.815-1-jszhang@kernel.org> References: <20230313170250.815-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_101349_415690_61CF0140 X-CRM114-Status: GOOD ( 10.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it outself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/plx_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 12725fa1655f..34b6416c3287 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -517,7 +517,6 @@ static int plx_dma_create(struct pci_dev *pdev) plxdev->bar = pcim_iomap_table(pdev)[0]; dma = &plxdev->dma_dev; - dma->chancnt = 1; INIT_LIST_HEAD(&dma->channels); dma_cap_set(DMA_MEMCPY, dma->cap_mask); dma->copy_align = DMAENGINE_ALIGN_1_BYTE; From patchwork Mon Mar 13 17:02:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13173018 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EB96AC6FD19 for ; Mon, 13 Mar 2023 17:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=X3zoeXBboL3uLyY4z2YwG1UYZ1SREAQjq7j+yZYmn+o=; b=1BWEwkegbZnxf1 CbJRHSsKHgTJCJWGLFhxz5XnMbIhsrXHXqjNFwZw83vbQWOudMApLIcIlSf/2FevWblEYXv6CfnR3 Ac/7+vuU1locx83RXpE6kfHrr09KrkNE2Vv6KuadFhIF1YSYeYl0g6yYVwcVUB6dRqR7/ZQNJWE4h /0aKDV3NUREtiEkmO+nRV6/3mami2laFzVGiTPccTDzcmUYO1oy6gYooaaV2ZIxZWc2Q2YLb8yXCK 58+hEf896SLj7J7fYXqlOkvZiSUJ5M1YcTkAvY6TVUKlyuD/yQXoLZxpeiidYSq6+hyEeC5Wv0HhH vVvHm4HOz2TnFGMjjrNQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblsg-0074Tb-HX; Mon, 13 Mar 2023 17:22:42 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblk7-0070xR-6f for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 17:13:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6AD1861382; Mon, 13 Mar 2023 17:13:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5BCCC4339B; Mon, 13 Mar 2023 17:13:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678727629; bh=sheGLWSRVeZHY8o45gICU781ZznV4t/ae6HtpWxBx6U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=qf/UOe9YjBj6REsfrKde/wD39EkAWcypvQ3WAqT+0+FFqQ6Ffgx0TPeqPLDgy5NLe Vd0wn75BEOm3xW7xNHHJPZ/ZWX89ofjbTLlxFia0uvDGFDhl6DBdazT4iTCrwxJomQ Wew47qEoGgxKmOtPj4JGSHmIjz6GAMU5PG+E6LV4BqbZwCw2iR4Z0jtVL2XRCoVx37 je9F07HOoMrM8tI9Zvkc4sQOluGXL6M7MFWWb2JrMDbNxPEY8CmKwP0LbRv2JI8SGb jnN7zAE6TN0h1scWNriCZuy7jEz8ZB8ei+E4uDzu3K3gWhBE5NQ/Ra89Eg/gnpBjZn T1JWesBbzPsEQ== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 4/5] dmaengine: hidma: Don't set chancnt Date: Tue, 14 Mar 2023 01:02:49 +0800 Message-Id: <20230313170250.815-5-jszhang@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313170250.815-1-jszhang@kernel.org> References: <20230313170250.815-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_101351_338348_CB5AD2D1 X-CRM114-Status: UNSURE ( 9.99 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it outself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/qcom/hidma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 04d1c33afc12..344525c3a32f 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -214,7 +214,6 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig) spin_lock_init(&mchan->lock); list_add_tail(&mchan->chan.device_node, &ddev->channels); - dmadev->ddev.chancnt++; return 0; } From patchwork Mon Mar 13 17:02:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13173019 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6CFCDC61DA4 for ; Mon, 13 Mar 2023 17:24:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=hI3ORPNuIGFFdurMyBOEU+9N4VPhDAq2RCKkmnAtrp4=; b=iK9q0FbOOH9Ot+ Et2APVkdsi+AiM4udOLNb1nyK4n9BdU6/QTJn3Z2azOVRnCtcoI/pIdZfRtUrViSQqR3+w87HLZoE VNsoA3vyKc9xYFkoRBYS5AoDoeH2HoG3gdkfIKFLoFwcV1rPs6YDm28g+GmeJpW77GEoSFpEF7qGk qVpGSL0/iR7wUJh7mO/9yo1MIeWnlv7A/YvXrzPCgxUqrUJ+grmGhxdwbrHbIGgcJ/9l0Owf72MuJ YYprksKBj2WBWQ/wC+zXcUJye9o+0uEsXAw4tPWFcQSUH3Ji7lhokWjnN1AgGmOvyAosuQ0s0fzcy 4za7vtt+3DXw5Io/feAw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblti-0074re-4w; Mon, 13 Mar 2023 17:23:46 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pblkB-0070z4-0R for linux-arm-kernel@lists.infradead.org; Mon, 13 Mar 2023 17:13:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1409E6140C; Mon, 13 Mar 2023 17:13:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F7D2C433A4; Mon, 13 Mar 2023 17:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1678727633; bh=waygJoMsmEuzShbrfLKTmYsjXJJABs/ZjxmcAXxJrFo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MzHKXiczApY5CW+k510wfPoijOe94MAfIi9QUFi6zkEn4hI/btbZ9sLGreVlnKLeR bcpn7r6Kbv1A15fq6RMXqCj57/YTzz1VxBTzjijTyos35t5U4w2C3Hfe0CKPZxB5K4 IdRpfyr0xXHVSbQpqvMCLcMtQ8NFC/FLXCNK0PJkqeyybsMU7nOa0ibkMtJMOrLILJ 4rd+3N8Y2i196SbGbk/+aXTt003pva4/qKcLDo9FKe1GGvV48IS8yz23oY/JZLcDu2 A5NglNk2j5ouel+0hhQBzTq3AdpdF14O09x0v72BqY2pNuTklScLo/DhHHemSSAr15 kaAULm8lzRayQ== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH 5/5] dmaengine: sprd: Don't set chancnt Date: Tue, 14 Mar 2023 01:02:50 +0800 Message-Id: <20230313170250.815-6-jszhang@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230313170250.815-1-jszhang@kernel.org> References: <20230313170250.815-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230313_101355_197949_7B5D3AFF X-CRM114-Status: GOOD ( 10.36 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it outself is wrong. Signed-off-by: Jisheng Zhang Reviewed-by: Baolin Wang --- drivers/dma/sprd-dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 474d3ba8ec9f..2b639adb48ba 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev) dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask); sdev->total_chns = chn_count; - sdev->dma_dev.chancnt = chn_count; INIT_LIST_HEAD(&sdev->dma_dev.channels); INIT_LIST_HEAD(&sdev->dma_dev.global_node); sdev->dma_dev.dev = &pdev->dev;