From patchwork Fri Mar 17 23:23:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13179585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EBD8DC74A5B for ; Fri, 17 Mar 2023 23:24:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 237BB10E426; Fri, 17 Mar 2023 23:24:04 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id B6C8A10E285 for ; Fri, 17 Mar 2023 23:24:02 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 192B260C89; Fri, 17 Mar 2023 23:24:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 94C75C433A8; Fri, 17 Mar 2023 23:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679095440; bh=40wNAXlyIA7VZKGyZ/AHWKvTBQOSewOxuHR9874XOtk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Bauausuf+Ul8D8hrfy65CjeljDX2wWvOW6qAhSVR5rYKj1kHYlu8T/Xx0vjoL83/7 32m5/aiJgEOnjaXRFLmkDgMGfi5ciY4zYYyfGjqePOvx8BhM1oAiUcfvTjzCygmfD4 kaCGhSV6JtLc2UtEXmBPSzTBUWfHYoLGQba4bxXCH/ltjpl6MWcG9cP2RYOoo5EXy5 w+nbRgUTZzgx//jvoGqOycoARkE8InRm2qNQqfhsdD+kfzhuDcP6YwZ8r4df7KHdoa +r6hX/dldX6AGFFB02Z50wQq5j+KKeFk/FcxerW5Ljmp8TrewfKa3sBIe1yFvcTz8V vzfbu8L1RWIvw== Received: by mercury (Postfix, from userid 1000) id DA45A10620F5; Sat, 18 Mar 2023 00:23:57 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Subject: [PATCHv1 1/7] dt-bindings: vendor-prefixes: add Inanbo Date: Sat, 18 Mar 2023 00:23:49 +0100 Message-Id: <20230317232355.1554980-2-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317232355.1554980-1-sre@kernel.org> References: <20230317232355.1554980-1-sre@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Gerald Loacker , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Michael Riesch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Shenzhen INANBO Electronic Technology Co., Ltd. manufacturers TFT/OLED LCD panels. Signed-off-by: Sebastian Reichel Acked-by: Krzysztof Kozlowski --- Documentation/devicetree/bindings/vendor-prefixes.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Documentation/devicetree/bindings/vendor-prefixes.yaml b/Documentation/devicetree/bindings/vendor-prefixes.yaml index ed64e06ecca4..33e1d65cf4b2 100644 --- a/Documentation/devicetree/bindings/vendor-prefixes.yaml +++ b/Documentation/devicetree/bindings/vendor-prefixes.yaml @@ -609,6 +609,8 @@ patternProperties: description: Imagination Technologies Ltd. "^imi,.*": description: Integrated Micro-Electronics Inc. + "^inanbo,.*": + description: Shenzhen INANBO Electronic Technology Co., Ltd. "^incircuit,.*": description: In-Circuit GmbH "^inet-tek,.*": From patchwork Fri Mar 17 23:23:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13179591 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 38729C7618E for ; Fri, 17 Mar 2023 23:24:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 97CCA10E437; Fri, 17 Mar 2023 23:24:28 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by gabe.freedesktop.org (Postfix) with ESMTPS id 80D0310E2A0 for ; Fri, 17 Mar 2023 23:24:04 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 2B048B82722; Fri, 17 Mar 2023 23:24:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7E1F2C433A1; Fri, 17 Mar 2023 23:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679095440; bh=wMdj6XMSKvcrwZmlfjFE87Mo/K0QwNMqQP6DoUCEh10=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=V7WZLmN/f4vrQhvkHFIhjRas7Jj2UFY3UEQOixFtO03eD6fgNZwgj3qLzBq5nPt0/ kfevjrBRC3fVUwIO4ahdTus1s07972KBOWtqzDISoCpD+QxwEBpT1JOOGkCAjtPXsx JFjVd0k2GYo0RI2lVIV/f8nAQHzn/2ugP98XcdDvpIb9cge+klspr8KDeNNq2sG6ZT 1QeD3imwyqyOOuEQyYvoKYLmTPFqv37Oj0W4qI9ufDV9SSzLWml/QnI+rJlFrScbvO cj4O6fOjHZx4llqqyMArc8LsZNDP9PlV0DXO65dbt+gqxQZ8GrBsFhvQzanpNEhAU5 rxmIjQ3DYZ+0g== Received: by mercury (Postfix, from userid 1000) id DB22210620FF; Sat, 18 Mar 2023 00:23:57 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Subject: [PATCHv1 2/7] dt-bindings: display: st7789v: add Inanbo T28CP45TN89 Date: Sat, 18 Mar 2023 00:23:50 +0100 Message-Id: <20230317232355.1554980-3-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317232355.1554980-1-sre@kernel.org> References: <20230317232355.1554980-1-sre@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Gerald Loacker , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Michael Riesch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Add compatible value for Inanbo t28cp45tn89 and make reset GPIO non mandatory, since it might not be connected to the CPU. Signed-off-by: Sebastian Reichel --- .../devicetree/bindings/display/panel/sitronix,st7789v.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml index d984b59daa4a..4fc86f96b00f 100644 --- a/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml +++ b/Documentation/devicetree/bindings/display/panel/sitronix,st7789v.yaml @@ -15,7 +15,9 @@ allOf: properties: compatible: - const: sitronix,st7789v + enum: + - sitronix,st7789v + - inanbo,t28cp45tn89-v17 reg: true reset-gpios: true @@ -29,7 +31,6 @@ properties: required: - compatible - reg - - reset-gpios - power-supply unevaluatedProperties: false From patchwork Fri Mar 17 23:23:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13179588 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0D425C7618E for ; Fri, 17 Mar 2023 23:24:19 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5636D10E432; Fri, 17 Mar 2023 23:24:10 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 18F9010E285 for ; Fri, 17 Mar 2023 23:24:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id B8463B826FE; Fri, 17 Mar 2023 23:24:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20D6CC433D2; Fri, 17 Mar 2023 23:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679095440; bh=a2pmQKhWvqek1TX2Y5M9kp9YI0QTZuxBZ8Pn1du4Q14=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YswHAzC7nKZ15q/r11zI/x/msEanukF5qbiQVlo9kmxcb4imSfUdgxHC9nQVQlKmp htOtDJTCF5ahTyuAPLjbLuCZcsSLe3+oE2LiWMed61UxmDvDhmkr5hl3+eTrYiOaub hTjygRfkTY9+6NMGVsHon8iQHSS3RrNPdxFoCwzUKpfMfQ2uopFDRtv1CEbl7pLs6C Ddy41hsOte1nfpEaXYN55KkmWz2hG2+xQSyomJHDrBTDMuYc1o3QfVoc6vE+XbV20I BYB7NnV3phVhss+f+0IEh2lXGjap2VQbGX/pIzE9kdQTR+u+lfdpUB9MyHux/k1xWS 6QAvDo2OohBlw== Received: by mercury (Postfix, from userid 1000) id DD4561062101; Sat, 18 Mar 2023 00:23:57 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Subject: [PATCHv1 3/7] drm/panel: sitronix-st7789v: add SPI ID table Date: Sat, 18 Mar 2023 00:23:51 +0100 Message-Id: <20230317232355.1554980-4-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317232355.1554980-1-sre@kernel.org> References: <20230317232355.1554980-1-sre@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Gerald Loacker , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Michael Riesch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" SPI device drivers should also have a SPI ID table. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index bbc4569cbcdc..e4d8dea1db36 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -394,6 +394,12 @@ static void st7789v_remove(struct spi_device *spi) drm_panel_remove(&ctx->panel); } +static const struct spi_device_id st7789v_spi_id[] = { + { "st7789v" }, + { } +}; +MODULE_DEVICE_TABLE(spi, st7789v_spi_id); + static const struct of_device_id st7789v_of_match[] = { { .compatible = "sitronix,st7789v" }, { } @@ -403,6 +409,7 @@ MODULE_DEVICE_TABLE(of, st7789v_of_match); static struct spi_driver st7789v_driver = { .probe = st7789v_probe, .remove = st7789v_remove, + .id_table = st7789v_spi_id, .driver = { .name = "st7789v", .of_match_table = st7789v_of_match, From patchwork Fri Mar 17 23:23:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13179590 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BF19EC74A5B for ; Fri, 17 Mar 2023 23:24:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E3E5210E43B; Fri, 17 Mar 2023 23:24:27 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id AF56E10E2A0 for ; Fri, 17 Mar 2023 23:24:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6D73FB8271A; Fri, 17 Mar 2023 23:24:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2DE2CC4339C; Fri, 17 Mar 2023 23:24:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679095440; bh=7zeW/xv++SWINuXHU/MUsAajCSk6VKuZ5VI+UwjVzBY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Oon7fQ63+T04Zh46LzIjjMnKzu7RVWFkh401wjUBx9r8l/PuApGlc3X5C9u9a4pSL iVAXk2jEUlDuB9+ksE+jMWjijnlu8P6i8QsVuS9ZSqyDL3xCRFqNaDj4KXbFdDVwYu njEpU+HKW71wYj51XLz1lfkomURP/6Q7e+mOkhaVdKkcF6k0jirGWE/y8ExI/r0JUd Uq80Rd8QQQTLLecU2TG9uj9xEst35Y99/1JKs5INmdTRkxDIIyCMwJnwuKWTMhNhcp xR41+zNi5gMRqGINIlkQGBCHnbN/yQjdT7NC79IC1AWc6WhcXeHwFtsrQMq6Qet7e/ aNlvjAEkleF8A== Received: by mercury (Postfix, from userid 1000) id DF4BB1062104; Sat, 18 Mar 2023 00:23:57 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Subject: [PATCHv1 4/7] drm/panel: sitronix-st7789v: remove unused constants Date: Sat, 18 Mar 2023 00:23:52 +0100 Message-Id: <20230317232355.1554980-5-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317232355.1554980-1-sre@kernel.org> References: <20230317232355.1554980-1-sre@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Gerald Loacker , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Michael Riesch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" ST7789V_COLMOD_RGB_FMT_18BITS and ST7789V_COLMOD_CTRL_FMT_18BITS are unused in favour of MIPI_DCS_PIXEL_FMT_18BIT, remove them. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index e4d8dea1db36..f7566551b5e2 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -15,9 +15,6 @@ #include #include -#define ST7789V_COLMOD_RGB_FMT_18BITS (6 << 4) -#define ST7789V_COLMOD_CTRL_FMT_18BITS (6 << 0) - #define ST7789V_RAMCTRL_CMD 0xb0 #define ST7789V_RAMCTRL_RM_RGB BIT(4) #define ST7789V_RAMCTRL_DM_RGB BIT(0) From patchwork Fri Mar 17 23:23:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13179592 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B37FC6FD1D for ; Fri, 17 Mar 2023 23:24:32 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C1EE510E444; Fri, 17 Mar 2023 23:24:29 +0000 (UTC) Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 65AF010E285 for ; Fri, 17 Mar 2023 23:24:04 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 0C6C0B8271B; Fri, 17 Mar 2023 23:24:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8A925C4339B; Fri, 17 Mar 2023 23:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679095442; bh=qSwlGWERs1iLO9M6K70WivJnuxc3M3Ft0dJO8xZoQJg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=L1WGH2VKJyvt+F7JHvOFIyJ5SvuWReY+S9VwReaHbfTNZLQtXkyfHGqbUQto1YfUx x/kIM3OMLLVTzKOQx6Pg46IoCKgmzKzc2RgPRg2BWbwoJJCFiEJiQBcKUirI0GwPHB drtEdYfkMAea3oC2xqmKIq/XpOpT3KlCAv/SLuJVuU6v07AoKx2oTGip2mEX2128Yg Z89i0BOPSs+O32bGu+mjfAttK8qct9DkfVaCAd0DKN/fhYQgl72uKgW8xtVHaTzxsw fthTxzFDE/ov3bjmfy/S0zmyEAjmBBMVhy8FgbKwZiIMpqHvAIlF0cWK7zWx9i6UxK H/im055T+yKpQ== Received: by mercury (Postfix, from userid 1000) id E186E1062105; Sat, 18 Mar 2023 00:23:57 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Subject: [PATCHv1 5/7] drm/panel: sitronix-st7789v: make reset GPIO optional Date: Sat, 18 Mar 2023 00:23:53 +0100 Message-Id: <20230317232355.1554980-6-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317232355.1554980-1-sre@kernel.org> References: <20230317232355.1554980-1-sre@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Gerald Loacker , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Michael Riesch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The reset pin might not be software controllable from the SoC, so make it optional. Signed-off-by: Sebastian Reichel --- drivers/gpu/drm/panel/panel-sitronix-st7789v.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index f7566551b5e2..1d43b8cc1647 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -369,7 +369,7 @@ static int st7789v_probe(struct spi_device *spi) if (IS_ERR(ctx->power)) return PTR_ERR(ctx->power); - ctx->reset = devm_gpiod_get(&spi->dev, "reset", GPIOD_OUT_LOW); + ctx->reset = devm_gpiod_get_optional(&spi->dev, "reset", GPIOD_OUT_LOW); if (IS_ERR(ctx->reset)) { dev_err(&spi->dev, "Couldn't get our reset line\n"); return PTR_ERR(ctx->reset); From patchwork Fri Mar 17 23:23:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13179589 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F8D4C6FD1D for ; Fri, 17 Mar 2023 23:24:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8DADE10E439; Fri, 17 Mar 2023 23:24:11 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7C8AA10E285 for ; Fri, 17 Mar 2023 23:24:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DA5A060CA0; Fri, 17 Mar 2023 23:24:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 851AAC433D2; Fri, 17 Mar 2023 23:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679095442; bh=l3gCJjRiiH8i75zav01jlsVXcavJWkL4a1sUaY2PyTQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ch3C93OtIZhkM53WAD2mn+6i0iTaclyjwpkXOL9Hl3IIp8YtrEwCNTHcZFGQsaJLl lFSgxWierJ7EyYTUAkBJT+LwPKl4LiLIX4+SmT372Z6aF3hEz+jspgFg3hna1CQR8j 4lfa+yJrdnE2U+uUx/uxdWJuwUTA04kGLiecxgZiKUJbfXqssLLv+dqPk0rVkiasF5 Nd/I6t0SfXRBuUk7hFC1AR7rQOrkoajx+yV7e/TqyzxpC4udeXkfSpnHswxHG4O/2h V9SB+TMImB3XlEowIBAGTF7w1LfEl5NA+4Oo14MYipLmJZhKThWi/RWb1jmTzzFP36 PI8wOFobnjXtg== Received: by mercury (Postfix, from userid 1000) id E3D0E1062107; Sat, 18 Mar 2023 00:23:57 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Subject: [PATCHv1 6/7] drm/panel: sitronix-st7789v: prepare for additional panels Date: Sat, 18 Mar 2023 00:23:54 +0100 Message-Id: <20230317232355.1554980-7-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317232355.1554980-1-sre@kernel.org> References: <20230317232355.1554980-1-sre@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Gerald Loacker , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Michael Riesch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Prepare the driver for additional panels with different initialization. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c | 110 +++++++++++------- 1 file changed, 67 insertions(+), 43 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index 1d43b8cc1647..a62a2f5737e4 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -108,8 +108,16 @@ return val; \ } while (0) +struct st7789v; + +struct st7789_panel_info { + const struct drm_display_mode *mode; + int (*init_sequence)(struct st7789v *ctx); +}; + struct st7789v { struct drm_panel panel; + const struct st7789_panel_info *info; struct spi_device *spi; struct gpio_desc *reset; struct regulator *power; @@ -162,51 +170,13 @@ static const struct drm_display_mode default_mode = { .vsync_start = 320 + 8, .vsync_end = 320 + 8 + 4, .vtotal = 320 + 8 + 4 + 4, + .width_mm = 61, + .height_mm = 103, }; -static int st7789v_get_modes(struct drm_panel *panel, - struct drm_connector *connector) -{ - struct drm_display_mode *mode; - - mode = drm_mode_duplicate(connector->dev, &default_mode); - if (!mode) { - dev_err(panel->dev, "failed to add mode %ux%ux@%u\n", - default_mode.hdisplay, default_mode.vdisplay, - drm_mode_vrefresh(&default_mode)); - return -ENOMEM; - } - - drm_mode_set_name(mode); - - mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; - drm_mode_probed_add(connector, mode); - - connector->display_info.width_mm = 61; - connector->display_info.height_mm = 103; - - return 1; -} - -static int st7789v_prepare(struct drm_panel *panel) -{ - struct st7789v *ctx = panel_to_st7789v(panel); +static int init_sequence_default(struct st7789v *ctx) { int ret; - ret = regulator_enable(ctx->power); - if (ret) - return ret; - - gpiod_set_value(ctx->reset, 1); - msleep(30); - gpiod_set_value(ctx->reset, 0); - msleep(120); - - ST7789V_TEST(ret, st7789v_write_command(ctx, MIPI_DCS_EXIT_SLEEP_MODE)); - - /* We need to wait 120ms after a sleep out command */ - msleep(120); - ST7789V_TEST(ret, st7789v_write_command(ctx, MIPI_DCS_SET_ADDRESS_MODE)); ST7789V_TEST(ret, st7789v_write_data(ctx, 0)); @@ -313,6 +283,58 @@ static int st7789v_prepare(struct drm_panel *panel) return 0; } +struct st7789_panel_info default_panel = { + .mode = &default_mode, + .init_sequence = init_sequence_default, +}; + +static int st7789v_get_modes(struct drm_panel *panel, + struct drm_connector *connector) +{ + struct st7789v *ctx = panel_to_st7789v(panel); + struct drm_display_mode *mode; + + mode = drm_mode_duplicate(connector->dev, ctx->info->mode); + if (!mode) { + dev_err(panel->dev, "failed to add mode %ux%u@%u\n", + ctx->info->mode->hdisplay, ctx->info->mode->vdisplay, + drm_mode_vrefresh(ctx->info->mode)); + return -ENOMEM; + } + + drm_mode_set_name(mode); + + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED; + drm_mode_probed_add(connector, mode); + + connector->display_info.width_mm = ctx->info->mode->width_mm; + connector->display_info.height_mm = ctx->info->mode->height_mm; + + return 1; +} + +static int st7789v_prepare(struct drm_panel *panel) +{ + struct st7789v *ctx = panel_to_st7789v(panel); + int ret; + + ret = regulator_enable(ctx->power); + if (ret) + return ret; + + gpiod_set_value(ctx->reset, 1); + msleep(30); + gpiod_set_value(ctx->reset, 0); + msleep(120); + + ST7789V_TEST(ret, st7789v_write_command(ctx, MIPI_DCS_EXIT_SLEEP_MODE)); + + /* We need to wait 120ms after a sleep out command */ + msleep(120); + + return ctx->info->init_sequence(ctx); +} + static int st7789v_enable(struct drm_panel *panel) { struct st7789v *ctx = panel_to_st7789v(panel); @@ -362,6 +384,8 @@ static int st7789v_probe(struct spi_device *spi) spi_set_drvdata(spi, ctx); ctx->spi = spi; + ctx->info = device_get_match_data(&spi->dev); + drm_panel_init(&ctx->panel, &spi->dev, &st7789v_drm_funcs, DRM_MODE_CONNECTOR_DPI); @@ -392,13 +416,13 @@ static void st7789v_remove(struct spi_device *spi) } static const struct spi_device_id st7789v_spi_id[] = { - { "st7789v" }, + { "st7789v", (unsigned long) &default_panel }, { } }; MODULE_DEVICE_TABLE(spi, st7789v_spi_id); static const struct of_device_id st7789v_of_match[] = { - { .compatible = "sitronix,st7789v" }, + { .compatible = "sitronix,st7789v", .data = &default_panel }, { } }; MODULE_DEVICE_TABLE(of, st7789v_of_match); From patchwork Fri Mar 17 23:23:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sebastian Reichel X-Patchwork-Id: 13179587 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6D058C74A5B for ; Fri, 17 Mar 2023 23:24:15 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A3B7D10E2A0; Fri, 17 Mar 2023 23:24:09 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by gabe.freedesktop.org (Postfix) with ESMTPS id E055F10E285 for ; Fri, 17 Mar 2023 23:24:03 +0000 (UTC) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5C72E60C8B; Fri, 17 Mar 2023 23:24:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8C095C4339E; Fri, 17 Mar 2023 23:24:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679095442; bh=qL80OSKOjY+h3c9Ry29E/ayqErdLzYcV34ROf0tHBDY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=h8drLyvJkin6H/hSa2hYvg9l1/P54zrIrPm8BwDfjW2avtpx0qfDlsq/0CzB7fldt SfyMmtTUFZiyTNmUd0cjKygtSXGEMU1HRkoprJ4QX8PnCmZRI+v0K1Xk/vAEwU597T HlN7xp0SQRcariffFlcRIWK0+hWRMxzbDwV+dM7nIfH35gx+qVTQg6ksaDz/jZmmWy IVr3IF+25kO3PVYdKAGxfY4OgAjGwq8bg+BVv9J0ft50QXNQiuRKsqAl7j0cZ4ZA0s VbSkILd//S1S0A/MQ81wZpFhyBROikEng/CThsKCSoBDZcaYfvQI1hxyCfmdU8iPiZ QDK//KdENF6tQ== Received: by mercury (Postfix, from userid 1000) id E62431062108; Sat, 18 Mar 2023 00:23:57 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel Subject: [PATCHv1 7/7] drm/panel: sitronix-st7789v: add Inanbo T28CP45TN89 support Date: Sat, 18 Mar 2023 00:23:55 +0100 Message-Id: <20230317232355.1554980-8-sre@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230317232355.1554980-1-sre@kernel.org> References: <20230317232355.1554980-1-sre@kernel.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Krzysztof Kozlowski , Gerald Loacker , Sam Ravnborg , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Rob Herring , Thierry Reding , Michael Riesch Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" UNI-T UTi260b has a Inanbo T28CP45TN89 v17 panel. I could not find proper documentation for the panel apart from a technical drawing, but according to the vendor U-Boot it is based on a Sitronix st7789v chip. I generated the init sequence by modifying the default one until proper graphics output has been seen on the device. Signed-off-by: Sebastian Reichel --- .../gpu/drm/panel/panel-sitronix-st7789v.c | 137 ++++++++++++++++++ 1 file changed, 137 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c index a62a2f5737e4..90f70eb84f11 100644 --- a/drivers/gpu/drm/panel/panel-sitronix-st7789v.c +++ b/drivers/gpu/drm/panel/panel-sitronix-st7789v.c @@ -10,6 +10,7 @@ #include #include