From patchwork Tue Jan 29 23:12:01 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 10787303 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 3C0F113B4 for ; Tue, 29 Jan 2019 23:12:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 26A162D83B for ; Tue, 29 Jan 2019 23:12:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2240E2DCDB; Tue, 29 Jan 2019 23:12:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id BD8BB2DC30 for ; Tue, 29 Jan 2019 23:12:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=lzm9kRS5B+g93LtIVqwAUEiRaAxM8IGCLmlj2RfaxJk=; b=M65svidg63PxwI 6ykSIgnyoFMeSrRSmAxkCvOHUy9nuJtwnr6zlOPYDduOg3OZ2d+Yn+whavE8SkNDk8bObvoIU8Dfi Mr0n7jawEx6UzT/AhJNFfcRtpmZkIM74ru5ZzepAgu6mVDIvCf480A7XWrA7s1QkSecpTOoHbaATR zFRCifVv6yOL8DNoztzFbTuyxKJzxkV87eEVQhsExo3VOz0bCs05XziQEFJdpHxpNre1nIdw2hOFx wLZ8eyFU5QXFFupJ6hPBwYI3dtgzKuwLdLPszJF7Q4lDoPEaqvS6Jlg1yK1dB7/6w6sGLjYcIX9i2 ptnTezfn3jtYinBuwAqw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gocYB-0006Nx-2f; Tue, 29 Jan 2019 23:12:15 +0000 Received: from mail-pf1-x443.google.com ([2607:f8b0:4864:20::443]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gocY8-0006NZ-2C for ath10k@lists.infradead.org; Tue, 29 Jan 2019 23:12:13 +0000 Received: by mail-pf1-x443.google.com with SMTP id y126so10429755pfb.4 for ; Tue, 29 Jan 2019 15:12:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n5QI9SCQIVH2sd+cRwUOWax4a5NWTgXxRP/Hc68OVrQ=; b=YQUUiUBSHwmDWfSh6N7OjxAVwrzbdWTyxu4juK6HCDi9FZecOTFP7xBtOkWg+Eu35O XNyJlPQDbqeqDOXAIJBHC7Dncvf8H+ral7ymA/xDRd/9F8kQvv8rTeB/asLgmQzsxtbw V8pIIGDF2Vls4cRH/U1QWu+uBwGUeMMuWWehQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=n5QI9SCQIVH2sd+cRwUOWax4a5NWTgXxRP/Hc68OVrQ=; b=THb8HVsCDuv3uNpIl6KpKAET1wgj/mzZJyByWZw9Ahl0g40EkIAXtpZ8urhxkESJqL zVvzJ9Z4LD56WM+GVOaS1e8HBMiRn6WlB3l8UAg2kTQUN4N+g9nNzZawpEjjA5W/gK32 4GOOFAp3gCR6jjGSnGmIdYfiVRc3paTrRrT8apoJ2FmNRaQ8FzMGBZl8LoSWAxuBjlHR riR5RnzDmgAMXoFm/iTJM+N+A5V3bRP1NTv/uQ2XFVGkv7JZAHse8Bpq0gN9qHhAsNkt 48BQVpfjPP2gYqVz6zOp1aEJqVdKEYMwNzhHShRjeBDEC+1V3G4HAmfvzlVAA3G2A2G3 3C8A== X-Gm-Message-State: AJcUukceN9dCS5aRtxOsvae+nuCtQnLq+rS5cAf+lhEhsk+t81uOz/QJ tHswFNADk5ykw2M/1+rB4pGNn1usWos= X-Google-Smtp-Source: ALg8bN5hcrgKnk1iWV5DfqWkGd+kA9rqOlnjRdi2FYjS7j2cC25d1TdNfqqU7RcYCEIu7zzwe3W2CA== X-Received: by 2002:a63:2315:: with SMTP id j21mr25714008pgj.297.1548803531180; Tue, 29 Jan 2019 15:12:11 -0800 (PST) Received: from smtp.gmail.com ([2620:15c:202:1:534:b7c0:a63c:460c]) by smtp.gmail.com with ESMTPSA id m67sm64681055pfb.25.2019.01.29.15.12.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 29 Jan 2019 15:12:09 -0800 (PST) From: Brian Norris To: Kalle Valo Subject: [PATCH for-5.0] ath10k: correct bus type for WCN3990 Date: Tue, 29 Jan 2019 15:12:01 -0800 Message-Id: <20190129231201.42230-1-briannorris@chromium.org> X-Mailer: git-send-email 2.20.1.495.gaa96b0ce6b-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190129_151212_130262_F4BC4B3E X-CRM114-Status: UNSURE ( 9.66 ) X-CRM114-Notice: Please train this message. X-BeenThere: ath10k@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Govind Singh , Erik Stromdahl , Brian Norris , linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, ath10k@lists.infradead.org, Wen Gong Sender: "ath10k" Errors-To: ath10k-bounces+patchwork-ath10k=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP WCN3990 is SNOC, not PCI. This prevents probing WCN3990. Fixes: 367c899f622c ("ath10k: add bus type check in ath10k_init_hw_params") Signed-off-by: Brian Norris Reviewed-by: Bjorn Andersson --- This was a regression in 4.20. drivers/net/wireless/ath/ath10k/core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath10k/core.c b/drivers/net/wireless/ath/ath10k/core.c index 399b501f3c3c..e8891f5fc83a 100644 --- a/drivers/net/wireless/ath/ath10k/core.c +++ b/drivers/net/wireless/ath/ath10k/core.c @@ -548,7 +548,7 @@ static const struct ath10k_hw_params ath10k_hw_params_list[] = { { .id = WCN3990_HW_1_0_DEV_VERSION, .dev_id = 0, - .bus = ATH10K_BUS_PCI, + .bus = ATH10K_BUS_SNOC, .name = "wcn3990 hw1.0", .continuous_frag_desc = true, .tx_chain_mask = 0x7,