From patchwork Thu Mar 23 11:58:34 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13185583 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E542DC6FD1C for ; Thu, 23 Mar 2023 11:59:17 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 811B06B0075; Thu, 23 Mar 2023 07:59:17 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 7C2236B0078; Thu, 23 Mar 2023 07:59:17 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6B1906B007B; Thu, 23 Mar 2023 07:59:17 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5D4206B0075 for ; Thu, 23 Mar 2023 07:59:17 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 204141405E0 for ; Thu, 23 Mar 2023 11:59:17 +0000 (UTC) X-FDA: 80600017554.25.9C81542 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf01.hostedemail.com (Postfix) with ESMTP id 6177540003 for ; Thu, 23 Mar 2023 11:59:15 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tBTAYbPS; spf=pass (imf01.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679572755; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=ParquFYygbbuO9rRASghQvFuA9lGdMYqOAhC7AI0i5w=; b=iqRWw1hqQ+/vj5prgvBVNYDRsSmMeEqZvpw9dDMH+ZdYRbhk5ruzKaWpM8rXUPuFCxuO6L 2CgU6EfufYRmjHRueq87HqRa55rErRv/651RnRWRyfLc/4v2kPKsKPUGiMsUJogF32dV4D eyUIlO41oOWUQnzFvLuqNAUEcuQhmXY= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=tBTAYbPS; spf=pass (imf01.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679572755; a=rsa-sha256; cv=none; b=wb2W00pOxxPPjhwDnObIZDzXdPWxHeDWwwSN0YXDpYofJfNJRwPMzklN3uar7ylPKuVgEW Z2y+y9gsqUPLhFN74stqzbgemAwfdASTt8dSTb9n7xOfrBC3SUS5kxKvqk3SKenSws68yg yKn0GPG/d9XeFV+LPEhPLSy4qe0u7uk= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id A8398B820D4; Thu, 23 Mar 2023 11:59:13 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 99E6BC4339C; Thu, 23 Mar 2023 11:59:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679572752; bh=XWLuxoeuAjQ0mUCYpCvh//KdRJ/f4l5MIwreKshFoaM=; h=From:To:Cc:Subject:Date:From; b=tBTAYbPS1lzP8x3XUCu1oh/aQIAFffDcYizxUgHHLq8+EBr1yoibNnSB25Fjgqecq BQrgn/kTrTGTYYCiLC3wdTqsMpcdzsvIMUAXsqe/nbxZNXv9qg23we0idnZR5og2jw U82IGtiPy3aqbBXoeoXbiovfzpEKNaheKqs74TluFDlxXOQ/VIY075Tgv/VgseLhq9 rsGPMZLMQ8f5+DMBdly9fscK3PcZk1CxJ63dELFEirOgTTioOKx9JZI0haa1SzwLA5 WYEIGxSY4pZQZ8K5qAWsCWLcbGCpuRRkWVAmf8g7cWSLUHFpqLKqR3E7PYP68FXQct G6gsSvaoLWKCQ== From: Arnd Bergmann To: Andrew Morton , Lorenzo Stoakes Cc: Arnd Bergmann , Nathan Chancellor , Nick Desaulniers , Tom Rix , "Liam R. Howlett" , Vlastimil Babka , Suren Baghdasaryan , linux-mm@kvack.org, linux-kernel@vger.kernel.org, llvm@lists.linux.dev Subject: [PATCH 1/3] mm/mmap/vma_merge: actually set next to NULL if not applicable Date: Thu, 23 Mar 2023 12:58:34 +0100 Message-Id: <20230323115903.1483668-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6177540003 X-Rspam-User: X-Stat-Signature: g6ik54c6h9h7cg5mk1hs1enred37h9ge X-HE-Tag: 1679572755-818694 X-HE-Meta: U2FsdGVkX197V44xUQS00WfwYgmD5k86koXdW/zJWB/B9GhSh3rJpWVqVobSNkTWB3j25J8ix1jDGLVMpiXb/K5qFlF+sV1BK3oDM5GvfEM62kjYMddAA6JAFXJJh+ZWJ7SAET8jQzdfu1aR2r3qLjQR9y8MUyr1ysaFrCDqnyzYw40puzKDsFum0NfafQPsTgw0koOwTsnFndhq+RILr7hMAqBy6h6Nh01hLG5ly0asOIyf9rZkft5wYQ1b6hAuCGjkjU+zjQO2atqIF7PVW0anrDUXQa7ufucsXkitOnxg5h8m3p4FgKm2sJ1KxKLM9Q8s7sLYB9okxtHPPnrRmmPzu8W/nD+EK6WKmSrBc/Z1/1rueIWch2Rj0w4zgdryyoWNtwstvfzYyiW5pHKiE17RL0R8Z1QcJHBTFp7Brr8oa2E5fRF/qjzTOPXiunoUIdbRsOZErbHV64AEcUflvJ730UHhQD5UB9xL7DyRWCcn/TtRBAfkBAt83xSEHKYkKR3geW0MiFTckkNd+gy17X0Fe0GTO0aOBa+2zPBuCe6eBHuWfjKqy3vFFPEafCxwIKE1ItVVgJfKdmHjzFzlLETp6/KAQsJagveN52V/QPuUS4clP2KNxju6P0VUp7r6APbLnr/BtdFlzBEawcbU/PgAc3sI+8qiXmOuJQniqVawNEio5vCxmYl30V5q6AqQGuP5QYvCLefpHIImEP/kjPdzm3bN8Xo/KErQ4bgDcApYOdmSdntXazD2oZ4IxLGsZY/Qp2pXAfb5oSGhm+0UxXe0qbgOoeS4iOSlHwO5L56erXP5JJ4KBkUaoKOZHPSg8IoI95hqUVGiSF9iXgFNFur30yPke1paw60S5qisUTz+TwJnqpnmdbUFKtuFJ5Z1AKH0qQpWE/eOmXKcUvpP+U3zXld+EdvIJ5cVwR84tpczu94fiWKgmQbh5hDH/3IU7LG0IThQ7fHwgbfTPCM Yiew7DII HSbqTq9o+ee/n9y9U+9ICzkMKf3tvoh0mX0QKruuC/MC4HALcSrpTRToOfKyN/Sycue3X1Eo5icEZmbn1MVCc/N8E3AHsZd6zp/KlAGQ/6ZWQum1zpOqLg4zj1KG73G0J/ZOWt4ukxNotf74dQd5b8SzQcbLKFELSbgYW2ERBIKdirtyOB70Da26An8QjHojXpPL9a+z6JkjquuHAS9CK7objI69DPs8PfoE5wIob2PBJuj1eZYM6dmVG63oCZhXVeIE+jJqkKZV5XtkH+sdQU2PyFXaXefiIqV1V X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann As clang builds point out, the variable 'next' is now uninitialized in some conditions as a result of a previous patch that tried to rely on it being NULL here: mm/mmap.c:939:11: error: variable 'next' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] else if (!curr) ^~~~~ mm/mmap.c:952:15: note: uninitialized use occurs here merge_next = next && mpol_equal(policy, vma_policy(next)) && ^~~~ Fixes: e887ecae997e ("mm/mmap/vma_merge: set next to NULL if not applicable") Signed-off-by: Arnd Bergmann --- mm/mmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/mm/mmap.c b/mm/mmap.c index 54099a604cf8..c01d43bd694e 100644 --- a/mm/mmap.c +++ b/mm/mmap.c @@ -939,6 +939,8 @@ struct vm_area_struct *vma_merge(struct vma_iterator *vmi, struct mm_struct *mm, else if (!curr) /* Is there a VMA next to a hole (case 1 - 3) or prev (4)? */ next = vma_lookup(mm, end); + else + next = NULL; /* Can we merge the predecessor? */ if (prev && addr == prev->vm_end && mpol_equal(vma_policy(prev), policy) From patchwork Thu Mar 23 11:58:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13185584 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 724EBC6FD1D for ; Thu, 23 Mar 2023 11:59:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 15AA76B0075; Thu, 23 Mar 2023 07:59:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 10B5C6B0078; Thu, 23 Mar 2023 07:59:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F15336B007B; Thu, 23 Mar 2023 07:59:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id E49116B0075 for ; Thu, 23 Mar 2023 07:59:45 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id A232B1201A5 for ; Thu, 23 Mar 2023 11:59:45 +0000 (UTC) X-FDA: 80600018730.05.3AFE306 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf13.hostedemail.com (Postfix) with ESMTP id E8CDA20019 for ; Thu, 23 Mar 2023 11:59:43 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PoRZ7T4V; spf=pass (imf13.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679572784; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=N6D8EKximEeE1YEKZBEMXWtQ/lBAW7jUgCvTznvrqiM=; b=Mic5p73dyKII0OiR009PREc83v7QorYgIzeuGRenaowW/Lx42ykU2HDcp8AMK4iI03PhG6 AAMpipce/1TzL5LibETqULnL9+K29Bl123Q+kWtCiPudvUfKM5TV6KOM3Zmz6DqWQGUCqJ 5I38m6hLcXrb3v7Mz8IaxtGNvgMyBmc= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=PoRZ7T4V; spf=pass (imf13.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679572784; a=rsa-sha256; cv=none; b=Dk0Pwt52PkGsXnXjemDlqg4MSRql/qGp9TZ/mbjPJifLUo//raFxcSKhpv5xnKi1CrJOyC HjGm0NvqXj+3aau/Mf4YEVNWuo3bPra0uh+TahrPuBfOGshDY9KlEQhX1e7blsdddcw7sj j6BGuIARO8EgT/EHkjjZHCC+n+okEU0= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 88658B81FDA; Thu, 23 Mar 2023 11:59:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 1859EC433D2; Thu, 23 Mar 2023 11:59:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679572781; bh=me8lIKVzX4f4kEhtj/IZ/N62RywMeIeThO/YQFbwteI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=PoRZ7T4VeuvD6lVxWJCeAYNQqpd4RILWHk5vcprJ5zLlgoNJl7XH8sN9RE4DNe/6D Gm2fsLvFXKKAhi2TKnz5Y1QJj+hj2GePh81dWspUUTWCHpD6x6h3AntosNQLuaU49A pXS7jvc2FraInbauw8rpnt2muQaZpATfJfiv+TeJXMxwaXx9GwEE7+F9DYgjViQfDO KPiM+NOhvH3zhggkxDwkLvZFehojjyyBNwvyaUsyAvimIOKWwj/v9UM4bsFC/OwzVW BiADB8RPVYiMwojAeD5E7vnJSMNyVfscO1dP6vwSxljAyRbwtFyo0s1pPWVxvJGDA7 T5QhZQ8KyjN1g== From: Arnd Bergmann To: Andrew Morton , Lorenzo Stoakes Cc: Arnd Bergmann , Uladzislau Rezki , Christoph Hellwig , Baoquan He , David Hildenbrand , Andrey Konovalov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] mm: vmalloc: fix vmap_ram_vread_iter() return value Date: Thu, 23 Mar 2023 12:58:35 +0100 Message-Id: <20230323115903.1483668-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230323115903.1483668-1-arnd@kernel.org> References: <20230323115903.1483668-1-arnd@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: 1pwx5mg7xormpmwhnpz7qzez1d4bu1fs X-Rspamd-Queue-Id: E8CDA20019 X-HE-Tag: 1679572783-146716 X-HE-Meta: U2FsdGVkX19khcChOhhEyH857JkVw3HhnQN2XKbHJ20NaziGCDSNtmPQDg6fOj6bY0bh8uvXr7yDGjnd7PlD/u1+eNHljMkNnQq3r5W2r6GoHgJRD+QcPRVUkGCbM2ClwwtrPEXAgZOxVtIxYNulST9M6gC64yov2Wy08/ECUBMxQq6ZmRR6L89xRJHq0EIIJI1lVCPGNbKfvuTNwuIM2ZbEXan93Ph7OTBnsMktW4vTRu6QhYItyje/mZ/REmrsJSOTbaJj7YeLjbi0LURxukFz/3TpiumhZsyEVglhQFDUfJ+lFkTLdUlRU/FeEuVO40dO78/Q427rYZGYBEhbY35+oiC+tQmZpYVmxb0mvg12bz2CphncyV6AkHrDFoKGwrhbddEvaxPcaK8e83p+oWgdFDW8Yt1swfmZRLMHdhL+Ufoc/0CloMUAZiaVQ/PUhUEzWrZMhXu8xzhC1uI83ap+lghEH48teHo4d808hvpOffH4dvIw87zfx2hyb7oK5NW0q8gAKElvTyQmBCwCqZ0t0+l1G1QQQo+CzS6IyFwYc2DSQOrihgT22z/t0rc+NcWeIaD/xhpr0oNC7bg934jUAhjC7PrnXMoqL94Xwb1aQff4jJ1S+JI58SCWUfNOyIhAkBImi4d088y1Wru9DF3cuc/NT91EvX+BU6GuHzo0d4ZD7HttCBr3cUeBMVuonioJOW4d361TUE13jrOwpDa9c6xElBepkgPM5pvg2/nlIVU+PIEJ6N8W0KzsvrTit7uILPDS6ENcplIZSyRlfoxFt6U8kPlTAkzHFlzgJgetYauNa0hcKi887t1g7Gdg8XBc5JnZMwDfFtplo8vsmlWO1zilxI33EkiGIJkFeYOS9KroVPHIgjPcu+4zpKEz1cl+R0jTx2OAsnSEM6MrJl1Qlmor+oetBjQn7O0DuIEA7c8rvmbWAIyP/uvyS4FMrmQbMXpNLgYWfWGHuv2 Ma/siicS 9+3x70OFYoM6V1RpJBsnMqum/ZTa+riIhtguo+G5wnDJGIco7wsm87Y5xnxZjwUDNoW6X/Y9fWv9EVmgNSC3Xhys9SW0dGpEBJXGFkmNXIWi/96wFu3OjstXiDqW/mB3KwPrhSSKYWLWPPpFlsqaCoir/9tiUEpkbPxVlzZ4Y/8ZQA8pgE5mOqiILQUwpNLDi5e8tp0FVcF7K3XbLLhOKy7zH0yL4Km6dNuYiCc0ayu1emOjvUxn687hW9EhYL91jDua9iXTy6QvVkQKNBFfYOO42lgraqw1MF4vi X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann The error handling in vmap_ram_vread_iter() can return an uninitialized value in some cases: mm/vmalloc.c:3539:6: error: variable 'remains' is used uninitialized whenever 'if' condition is true [-Werror,-Wsometimes-uninitialized] if (!vb) ^~~ mm/vmalloc.c:3587:17: note: uninitialized use occurs here return count - remains + zero_iter(iter, remains); ^~~~~~~ Move the initialization up a few lines. Fixes: d9cab54f7737 ("mm: vmalloc: convert vread() to vread_iter()") Signed-off-by: Arnd Bergmann --- mm/vmalloc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index ebfa1e9fe6f9..fb216495fe5a 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3521,7 +3521,7 @@ static size_t vmap_ram_vread_iter(struct iov_iter *iter, const char *addr, struct vmap_block *vb; unsigned long offset; unsigned int rs, re; - size_t remains, n; + size_t remains = count, n; /* * If it's area created by vm_map_ram() interface directly, but @@ -3545,7 +3545,6 @@ static size_t vmap_ram_vread_iter(struct iov_iter *iter, const char *addr, goto finished_zero; } - remains = count; for_each_set_bitrange(rs, re, vb->used_map, VMAP_BBMAP_BITS) { size_t copied; From patchwork Thu Mar 23 11:58:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13185585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 934CEC6FD1D for ; Thu, 23 Mar 2023 11:59:55 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 06FDF6B007B; Thu, 23 Mar 2023 07:59:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 020826B007D; Thu, 23 Mar 2023 07:59:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E04316B007E; Thu, 23 Mar 2023 07:59:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id D05066B007B for ; Thu, 23 Mar 2023 07:59:54 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id A38A0140642 for ; Thu, 23 Mar 2023 11:59:54 +0000 (UTC) X-FDA: 80600019108.20.AF20BD5 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf08.hostedemail.com (Postfix) with ESMTP id D2D7116000D for ; Thu, 23 Mar 2023 11:59:52 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UdLQR8S7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679572793; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RAa6QYfhSECI92djUs3Jnn+lkRSHMYnA7QB58mfyffk=; b=oWacTqP4y7F3rlnPfy7wqUvcJwxz5R/ZZyX24Rgc7HbejrcR/U/WVxJ28hOIX9gj1X89OD UU3hyw7dsWxgSQZsx/56ZWhqVgGBFGu83+k9ktS8LHYyQWZfbVcBmKSmCZdx/bOJAQv5hC NUGnlLOaCBnCaxDruTH0K/ykCvd2rAQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=UdLQR8S7; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf08.hostedemail.com: domain of arnd@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=arnd@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679572793; a=rsa-sha256; cv=none; b=PGmgmNV8MOYUD7d6AaqGR7CzQcF+uP7m2RuAq/uCuBn/CM4uxObSOvcxqjovkWSsb67SJm LAa2htdW6Q1PQZ4GP7wnHjkXs+1ZMdfnvNlwTl0O8LicDEkZ5GSv4mz3LCr+VSW4p+T6H6 HP0lI1m9ePhugHEdAqVJs5X9mDAa53I= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 65DEEB820D7; Thu, 23 Mar 2023 11:59:51 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E96F1C433D2; Thu, 23 Mar 2023 11:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1679572790; bh=hhPbL79oPMdtDe7maqPTdafjDuPMITrYj4jgPoVH1Q4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=UdLQR8S7HwWTgjH50FDeeSUqXWGo4+fmBddMMbOGV8fam6vbmTsBm1LzANxUs1fkm TPBv/1tebFkcRlg08L0fIioLsQbG99cRIqtzhoFxLQ19qEmItnHCo/1T/Mx/Bbva83 iZl063I623DZhNP4k6nGPyUFFzg7MI/6tngGxcxH+RbQQuyx8b91Kdj9L9xhqvdTjq VyHP8zdPBWUWM5dRHA90ZVSmE7ssEMXP5WTICb8myhmdzKrCofE+WHVjFP46n5zryQ s8yiXAqPZvgJO8w+Rf++/GOnAKcBn9kLpYHLi5IQQKGKZ8ceGkA/HYqvKinawYfrtT uqmU9SAVV4bxA== From: Arnd Bergmann To: Andrew Morton , Lorenzo Stoakes Cc: Arnd Bergmann , Uladzislau Rezki , Christoph Hellwig , Baoquan He , David Hildenbrand , Andrey Konovalov , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH 3/3] mm: vmalloc: mark zero_iter() static Date: Thu, 23 Mar 2023 12:58:36 +0100 Message-Id: <20230323115903.1483668-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230323115903.1483668-1-arnd@kernel.org> References: <20230323115903.1483668-1-arnd@kernel.org> MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: D2D7116000D X-Stat-Signature: j57c5pmokchbzcuhje6a831k7bir375u X-HE-Tag: 1679572792-763648 X-HE-Meta: U2FsdGVkX1+hFQ15xEtLVLhtZsneDjSRA2aspK8+XHiX4KWCeJ7tm0BZ3iwW2bXfxfFVoZ+zNA6py40HPihllnPyZQWiMBPI7jFpy4lOTYUq3aTOKeTXij2g3jpCTVAA53BJj9w6kMjMCZF21edR/LB22JnBeFWyChGQBOzAZrcX1ldON80PhDISD/22CNd/ZL63G4MskRB73JMlUUpnOJnp6eSTnjwPQTiV8zWUeJwnjVeykDROoK4gqxpubsKbC1qbD7Qy4/coNedHpZwywxrd3JzSUmtQ6tHrXbFClkJcLRrPFxaOVvt1Zqkcp6dzSOLybykempPB5Tfn0bcqSkfKZmSAaIt2hpx5iPHTBErKtwG+oD27pcCJGrKelhC6aKyohBws7Yj/tp8MDSEwP6MR2yuaPabensTOh7xAzd0z7nZ9VMTKXn7sD0kbBaSQdy+uWFs0knuWAGRjnnnlAxk+Mf8qHC2g/t5jpUDnmCSojMxVS+UagPXYUrUyMbmCJGwA8VEx5Cq7s61g04Em/MgYElMiW2ak59yXVWKfxF0nndAqHACshN6EKc5cy8imtkhemrsZVlP5PgWm6/qJHkhSNWsK8i7W1e0kf7OIej6wafMiK/+q8ppGP21zu3KcUuQqgvEhgGVdQd30JMG+EI4rrdlGjJ7nDR53iQhKuixkamre3pvfPGvfTvxVHsy6EU148c6j92AtZ1DSV3zv6ZUKHOrgAvRaUr5XW8fYPiwFYpSRqpirLNhTC0r14lYKR+WPR6dNIr7VHxnTDvD2wTV3XODt6x2pk8a9EVGk4bgr2Y/bfkS9XaN++2dnmi9F4ATKyVdxvG2rvnsZ0oTKirbba5Zyxl0Dg7vN8f67EiT1OE8mypNzoP1mAdZKBI4vgQSIRmcrMPtETXwVyDN9mvZ1t3/4cEz2wWKxv+D4ngOdOtIbYFwLmPE5pOzhHt7hTIfz8sjrqfPn0V12ax9 a3LTQEKj uF0U2dFnIFjC4JR2m/Uzpbq40N5bwVgrl+5pr6BygJl/pfFImxBNV41yY7ekbNcZdpQZPQgcAL5luEt5xsW/y/MM5iQLpfUt1/N72wR6sa+2nKX4h/IK9GDNhjjXL3RH1PhzazuIYieKxPibesAZkS4k4dLnndV1W9RnOvO2ZdLe75mtsygUds9lDKYeuRcq+xwOrJpOV4/rgCn2aUCCJgxLF8Tgx1ASr05Nbi6Gidr52Kl6kGYMCMnu1yy1o4+FyPMHXBKSLtoDoMhrBMQCM9hu6PrWjgzBasBQj X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Arnd Bergmann The zero_iter() function was put into the global namespace, apparently by accident: mm/vmalloc.c:3448:8: error: no previous prototype for function 'zero_iter' [-Werror,-Wmissing-prototypes] size_t zero_iter(struct iov_iter *iter, size_t count) ^ mm/vmalloc.c:3448:1: note: declare 'static' if the function is not intended to be used outside of this translation unit size_t zero_iter(struct iov_iter *iter, size_t count) ^ Fixes: d9cab54f7737 ("mm: vmalloc: convert vread() to vread_iter()") Signed-off-by: Arnd Bergmann --- mm/vmalloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index fb216495fe5a..55f5d6fc8629 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -3445,7 +3445,7 @@ EXPORT_SYMBOL(vmalloc_32_user); * * Returns the number of zeroed bytes. */ -size_t zero_iter(struct iov_iter *iter, size_t count) +static size_t zero_iter(struct iov_iter *iter, size_t count) { size_t remains = count;