From patchwork Tue Mar 28 09:41:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiyang Ruan X-Patchwork-Id: 13190766 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A00DC76195 for ; Tue, 28 Mar 2023 09:42:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 143CE6B0074; Tue, 28 Mar 2023 05:42:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0C9696B007B; Tue, 28 Mar 2023 05:42:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC0E26B0075; Tue, 28 Mar 2023 05:42:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id C7CC56B0072 for ; Tue, 28 Mar 2023 05:42:30 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93FD3ABC8C for ; Tue, 28 Mar 2023 09:42:30 +0000 (UTC) X-FDA: 80617816860.02.83F4505 Received: from mail1.bemta37.messagelabs.com (mail1.bemta37.messagelabs.com [85.158.142.112]) by imf07.hostedemail.com (Postfix) with ESMTP id 270444000E for ; Tue, 28 Mar 2023 09:42:27 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b=Pa1LIuGf; spf=pass (imf07.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 85.158.142.112 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679996548; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NWTW4/kpXmg0Rl6jB3nA+9P+up6W+4F1Qd6JkH4PPnc=; b=Uie9ip4PiyVOoCcINHyaJi4yZe4jaNlnFFpfd+btmVUYu6w8krYSLAZ+O9U756RW5UKdnF dH+SXmC1TUnZzt4rblejJafXaEmq0CV3svbM/GIwR39v4lS6TXUJ9EwWO2q0KPIHikymHg LN4cCzwItlUIvOYcKJX6QAASsbNEEjM= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b=Pa1LIuGf; spf=pass (imf07.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 85.158.142.112 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679996548; a=rsa-sha256; cv=none; b=wNAzyPM+25v+DaFT4NxuCuNO8FMY7q5VxW+8yuENQgZbAWL93jyX/poOfXMbjXqVGGu/ru AXR4RxCm0C4124YJevek0ovJw2eTmJmquJxoyeEtHDjkG3XlShj5Wi31empxJV43dioSD1 UvxPgTcm764UMA8xAouLHOJDdcqBHm0= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com; s=170520fj; t=1679996545; i=@fujitsu.com; bh=NWTW4/kpXmg0Rl6jB3nA+9P+up6W+4F1Qd6JkH4PPnc=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Pa1LIuGfl6OXsOtMCyUaQCxmL78UatAYsSbK+3EIFk7IW6ZANlkmrmBfnxjze2UqK yn2/iBx8P0yBQmqyNSzIXtE33FygpkrY+JyIYEblVU2Yev0pjkAm5lPsFM1ETyrw0N EM/NHy9HltswQjb+YakmIR/7EhvU4YOjyczLbBGok956x3mTCWpDIipcnce9m8Ay69 j5KWa4h05fivetAJH6B+CR4JfYhmHCuuKFILcUlSzpKWODW5HW0C268OIwUkqx5Zf5 58Tf1mz9ImOHnycKJ2CDrM6giwmHSbhY1e0OGPfPaIRMB0mt8ERi8NnOmxhohJqQdW 8pCQkPO08JGzA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRWlGSWpSXmKPExsViZ8ORpNuwTSn FYNIpWYs569ewWUyfeoHR4vITPovZ05uZLPbsPclicW/Nf1aLXX92sFus/PGH1eL3jzlsDpwe m1doeSze85LJY9OqTjaPTZ8msXucmPGbxePF5pmMHmcWHGH3+LxJLoAjijUzLym/IoE148idb taCtXwV7e1LGRsY/3N3MXJxCAlsZJT4fOccE4SzhEni0uyrbBDOMUaJZafPsncxcnKwCehIXF jwlxXEFhEolNiz9B0LiM0sUCHRuOgfM4gtLOAsMWvFO7AaFgFViV339oDZvEDxaVs2gNkSAgo SUx6+B6vnFHCRePulBcjmAFrmLHGt2x6iXFDi5MwnUOMlJA6+eMEM0aokcfHrHagxQGunH2KC sNUkrp7bxDyBUXAWkvZZSNoXMDKtYjQvTi0qSy3SNTTRSyrKTM8oyU3MzNFLrNJN1Est1c3LL yrJ0DXUSywv1kstLtYrrsxNzknRy0st2cQIjKeU4sTjOxhf9f3VO8QoycGkJMrbz6mYIsSXlJ 9SmZFYnBFfVJqTWnyIUYaDQ0mCV2WLUoqQYFFqempFWmYOMLZh0hIcPEoivNdWA6V5iwsSc4s z0yFSpxh1OdY2HNjLLMSSl5+XKiXOm74VqEgApCijNA9uBCzNXGKUlRLmZWRgYBDiKUgtys0s QZV/xSjOwagkzBu4GWgKT2ZeCdymV0BHMAEd8a1AAeSIkkSElFQDk++Wjc03Ze8/TnfafT59b 0XR5gtr104NM66esGWmoar2vrt339js3pwSEiQRm6dTe+X6mjP+P0Tkd8/fwv+xrpzNyTBF9N icLV2fmk5umRe7UbfKh8cy/aN2a+GnFfIz/81n5F/dZBRcZnNkrk3ZpeDV++NNIrvPd87oKNr 26a4Lm51tS9qqQl/z8jMbfkRtY427YMPqn6OdI1Y1WehfXXNyJNei1a/Tq17ck5zsb/l2jSHn 5b3yzZvmzz28OnbblwyDxd7/xKqO8PqU7/7s+z7XrKJ1UcqpKqHGp97vvryLK3/NqmiveMBAR OXcmY9Xp0fHTVrsE6mp7Wy6OyJ6yje11p0veXz+2K25bsZxSomlOCPRUIu5qDgRAAs+n0iuAw AA X-Env-Sender: ruansy.fnst@fujitsu.com X-Msg-Ref: server-16.tower-732.messagelabs.com!1679996544!272759!1 X-Originating-IP: [62.60.8.98] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.104.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 12672 invoked from network); 28 Mar 2023 09:42:24 -0000 Received: from unknown (HELO n03ukasimr03.n03.fujitsu.local) (62.60.8.98) by server-16.tower-732.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 28 Mar 2023 09:42:24 -0000 Received: from n03ukasimr03.n03.fujitsu.local (localhost [127.0.0.1]) by n03ukasimr03.n03.fujitsu.local (Postfix) with ESMTP id C774E1B0; Tue, 28 Mar 2023 10:42:23 +0100 (BST) Received: from R01UKEXCASM121.r01.fujitsu.local (R01UKEXCASM121 [10.183.43.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by n03ukasimr03.n03.fujitsu.local (Postfix) with ESMTPS id BBD3B1AF; Tue, 28 Mar 2023 10:42:23 +0100 (BST) Received: from 692d629b0116.g08.fujitsu.local (10.167.234.230) by R01UKEXCASM121.r01.fujitsu.local (10.183.43.173) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 28 Mar 2023 10:42:20 +0100 From: Shiyang Ruan To: , , , CC: , , , , Subject: [PATCH v11 1/2] xfs: fix the calculation of length and end Date: Tue, 28 Mar 2023 09:41:45 +0000 Message-ID: <1679996506-2-2-git-send-email-ruansy.fnst@fujitsu.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1679996506-2-1-git-send-email-ruansy.fnst@fujitsu.com> References: <1679996506-2-1-git-send-email-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.234.230] X-ClientProxiedBy: G08CNEXCHPEKD07.g08.fujitsu.local (10.167.33.80) To R01UKEXCASM121.r01.fujitsu.local (10.183.43.173) X-Virus-Scanned: ClamAV using ClamSMTP X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: 270444000E X-Stat-Signature: way7ru3twbzgytmwoimn5snhqwiwj4ey X-HE-Tag: 1679996547-247983 X-HE-Meta: U2FsdGVkX19O2MpR5zmMfZtg+dBt+lRnWdM+m7dKAbFPyKjIYx4La6JldeiBBNoOv/q8jcABaKxxiMWW2FENdr5JFptsRdv8O+oFzT5hqAWIpS+JvHGZe4EGOUeHSKfa1d605pd3GlghAapI4XO9PSjBr2wc/bFLwzNYmtQMFeSimsBzBst9WNeGfLXvSkIMkCySHqvavvDOemx9LUIRP8hcKDgkEE2YklW0+W4Vw6few71CXFNgqeeXyvOA92iYo3chmj6j7CTQzoe58ZODPUESUKZtxv9jtsz/Vtbeb+sqZSPiqpOIpJ/BYMkpKf8YOwVho8FoFjnlyrO7UYJ3DiGvMp+z8zXmimd3KZkowDhNGAbZv7/gEoDBvK+UQZYj6KqT+laddXT3WaM98kd7Q3VJZc987mGaDwO7bZbHx99RAHRIMYKZA4k4Uoi7tyzEEUue68DHlTqCMKGRpu6oWYmalc/53PBfORE9aMSgDvI6QAk1KTyLz635NcWNkRM1jnXI7wpS1aI90efvisY/DjjL71RU66NFL6zRlJuI/dKP1aNI3i1vTyRofjjjwcT1g7e2vxbuqTqX6j1XL0fdz/Ovi6zSTrfpxRORat/uyHd9IfVQSmoc68VgrOMmM02k1dlejt8XdU5vahb8PCnKUoSIoo1bgUTwXlCmInEcInlSreDuaD94f6WGUqMGPvDJW6nn/h5j7Y/Q01dt0HMfRpkenfWCEtHNcmQqiMxtqFArK2MwCEHrwr+nZFomO8m0i4yBRAaYd3slNvcGoQTG+ixjXqeQtXA1cdrLHbBJyz5vd99b/wtz5Be3UfIEbuFooT4mb3uu7B7YeEVuzgsbiv8BWl+LljAMmFdVIncHxpGUC6np01yOfvwN1q3T/7WkU9MXu8QEnEmXDBnN2EHi/yjwhWJ/FnAnX1PsetJBR2MxfNoupzM+qMnH7s3hpdwdfiYDG80HbmUEceZckkV G8w9lN3B KDKY9Y1oY/vwtIQDhQ1BZbGS3tdsWJxFfyfmxkVZBsi65NRGVP0bCzfihEDBr4mcA7TwoG9PRmW1LpoI0ASF1nus1C101K4dYuPtKDpjihinyiy9FpXOxHpzFc8sdNPS18gbkIkvIDEspnPv3M4td7TekUN9TBjv/plO4f4GKp7E2FN04g+psPKVsydWiuow9ZcHAL3I/CZKXzkCeGJ1sSWOP5qk+JvKudgOx09/QSU78H3Eq7SQaMvMIpMvkOmOXt6PVdZ0Ep95fZRHadf2VvdeL590P+j8vC9SNdm/cSi6WJN8hSvzYSAbxB/AvpjfshRLPjUvRGv2EvTtfJqoyxjq9mA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The end should be start + length - 1. Also fix the calculation of the length when seeking for intersection of notify range and device. Signed-off-by: Shiyang Ruan Reviewed-by: Darrick J. Wong --- fs/xfs/xfs_notify_failure.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c index c4078d0ec108..1e2eddb8f90f 100644 --- a/fs/xfs/xfs_notify_failure.c +++ b/fs/xfs/xfs_notify_failure.c @@ -61,7 +61,7 @@ xfs_failure_pgcnt( end_notify = notify->startblock + notify->blockcount; end_cross = min(end_rec, end_notify); - return XFS_FSB_TO_B(mp, end_cross - start_cross) >> PAGE_SHIFT; + return XFS_FSB_TO_B(mp, end_cross - start_cross + 1) >> PAGE_SHIFT; } static int @@ -114,7 +114,7 @@ xfs_dax_notify_ddev_failure( int error = 0; xfs_fsblock_t fsbno = XFS_DADDR_TO_FSB(mp, daddr); xfs_agnumber_t agno = XFS_FSB_TO_AGNO(mp, fsbno); - xfs_fsblock_t end_fsbno = XFS_DADDR_TO_FSB(mp, daddr + bblen); + xfs_fsblock_t end_fsbno = XFS_DADDR_TO_FSB(mp, daddr + bblen - 1); xfs_agnumber_t end_agno = XFS_FSB_TO_AGNO(mp, end_fsbno); error = xfs_trans_alloc_empty(mp, &tp); @@ -210,7 +210,7 @@ xfs_dax_notify_failure( ddev_end = ddev_start + bdev_nr_bytes(mp->m_ddev_targp->bt_bdev) - 1; /* Ignore the range out of filesystem area */ - if (offset + len < ddev_start) + if (offset + len - 1 < ddev_start) return -ENXIO; if (offset > ddev_end) return -ENXIO; @@ -222,8 +222,8 @@ xfs_dax_notify_failure( len -= ddev_start - offset; offset = 0; } - if (offset + len > ddev_end) - len -= ddev_end - offset; + if (offset + len - 1 > ddev_end) + len = ddev_end - offset + 1; return xfs_dax_notify_ddev_failure(mp, BTOBB(offset), BTOBB(len), mf_flags); From patchwork Tue Mar 28 09:41:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Shiyang Ruan X-Patchwork-Id: 13190768 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6DA84C761A6 for ; Tue, 28 Mar 2023 09:42:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ADCF46B0075; Tue, 28 Mar 2023 05:42:33 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A6797900002; Tue, 28 Mar 2023 05:42:33 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8930D6B007B; Tue, 28 Mar 2023 05:42:33 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 683306B0075 for ; Tue, 28 Mar 2023 05:42:33 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 378D1C082C for ; Tue, 28 Mar 2023 09:42:33 +0000 (UTC) X-FDA: 80617816986.14.02C8B9E Received: from mail1.bemta34.messagelabs.com (mail1.bemta34.messagelabs.com [195.245.231.1]) by imf03.hostedemail.com (Postfix) with ESMTP id D4AC720006 for ; Tue, 28 Mar 2023 09:42:30 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b=KR0YlhLN; spf=pass (imf03.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 195.245.231.1 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1679996551; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DvG7cRSgB7lZ0BGGr7ietTdkp3pRAONypLIpc1jUDRI=; b=m0s77dzwI2gV8YQeBmE/Rj57l5bwbk2gUnDaeovIXN8cYgs+tYPn+WCMJSL9USzZFcHBOi UIp8j5MXhLSbhd0PdK/ajCg1dxD+S7tYhXOIvuuHk1hEFHfqoltad6IdF7CDUEWBYiSZ7H VWbhmjEeOiRl5kPQReby6AOaXJsGSdQ= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=fujitsu.com header.s=170520fj header.b=KR0YlhLN; spf=pass (imf03.hostedemail.com: domain of ruansy.fnst@fujitsu.com designates 195.245.231.1 as permitted sender) smtp.mailfrom=ruansy.fnst@fujitsu.com; dmarc=pass (policy=none) header.from=fujitsu.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1679996551; a=rsa-sha256; cv=none; b=ZrhNAKsXa9GJYyVNxIcAu+0j5c+BRjZD2bs8SQ4AHVdtZj0bGGDHraDzlJtHH135MmxnU6 48d06BV97qw980OspOM8G1QgCL2Y/r7DIzUwPACz4THobrTaLO+KrLwFq/hcGlZ5ZzlgNl rR1dUw8IyH3lUpufs/p9cRmxxJOrLW8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fujitsu.com; s=170520fj; t=1679996548; i=@fujitsu.com; bh=DvG7cRSgB7lZ0BGGr7ietTdkp3pRAONypLIpc1jUDRI=; h=From:To:CC:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=KR0YlhLNmfeznAU00X6GjQVPskhXJgBpe2kRJCkELzhua4FKlgt8jU7TjmBLmUdOK qjJ5VZQBp4kOj6faq2sBaV8MO6TGtx5J/yMfph67/epKcc5ZT47eb/fOvzIxGwaUal VSLYOnWhq7ENi9+e1m1B+kDagbpkorItL+qWMtqvBFDuC8UZxiIFbALzrCCr7MVqGs 3l0snwNXTw67zLZp8SWLqeot+dv9K3DzTSH5Khjq09L2zMiGj5jOiVToL7M+a60Lew +6clHi1DS21H1Bn2dIUawJUi9at+Znr1KrSq8/jEeFfNlKB8dGhIkunqE+tXK+1s/d LATvabOvf4Wuw== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprJKsWRWlGSWpSXmKPExsViZ8ORpNuyTSn FYO8dRos569ewWUyfeoHR4vITPovZ05uZLPbsPclicW/Nf1aLXX92sFus/PGH1eL3jzlsDpwe m1doeSze85LJY9OqTjaPTZ8msXucmPGbxePF5pmMHmcWHGH3+LxJLoAjijUzLym/IoE149/9f awFj20qDq/tZW1gnGvUxcjFISSwkVGidc9pxi5GTiBnCZPEoqPmEIljjBLffzxlBUmwCehIXF jwF8wWESiU2LP0HQuIzSxQIdG46B8ziC0s4CVx6eltsEEsAqoSn95uZwexeQWcJV7N6gGLSwg oSEx5+B6snlPAReLtlxYgmwNombPEtW57iHJBiZMzn0CNl5A4+OIFM0SrksTFr3dYIWygtdMP MUHYahJXz21insAoOAtJ+ywk7QsYmVYxmhWnFpWlFukamuglFWWmZ5TkJmbm6CVW6SbqpZbql qcWl+ga6SWWF+ulFhfrFVfmJuek6OWllmxiBMZSSrHKix2Mz/r+6h1ilORgUhLl7edUTBHiS8 pPqcxILM6ILyrNSS0+xCjDwaEkwauyRSlFSLAoNT21Ii0zBxjXMGkJDh4lEd5rq4HSvMUFibn FmekQqVOMuhxrGw7sZRZiycvPS5US503fClQkAFKUUZoHNwKWYi4xykoJ8zIyMDAI8RSkFuVm lqDKv2IU52BUEuYN3Aw0hSczrwRu0yugI5iAjvhWoAByREkiQkqqgelU5nHh2w5VZ54EMn5bc 7yXQyLk7785Nj/vfOeNjz3/n+dDcIqHqvLjO/5norgfqs0uDD9yaZcxE1tL9uZc5fA7kqxHeD w8bCSeKnuVcP51OPfHko1bxuLLw1bP/n+CLRaZwoWft37rdzLY3yB69E5ns7/Vrfqnl/Z/P60 +S9aoandL/O3ES54qPA9VGiNDs6oO3Jvm8WcKe7+C6G79JH1PCQa3sHfhU+R+/9BY3iBoH5zw 0oethftpoHHLiqbq3iKFzbGy34SsyyfNkZA5zhXjlvSsRMvix7K5SmcXa1/7VXG0cMU25UVi1 yd/9Lpz4r6C5H+XRtfEjvsCUg4HtR5J3Gtl2N9XVqc2XyVQiaU4I9FQi7moOBEADk8C/KwDAA A= X-Env-Sender: ruansy.fnst@fujitsu.com X-Msg-Ref: server-23.tower-571.messagelabs.com!1679996547!1164934!1 X-Originating-IP: [62.60.8.98] X-SYMC-ESS-Client-Auth: outbound-route-from=pass X-StarScan-Received: X-StarScan-Version: 9.104.1; banners=-,-,- X-VirusChecked: Checked Received: (qmail 10280 invoked from network); 28 Mar 2023 09:42:28 -0000 Received: from unknown (HELO n03ukasimr03.n03.fujitsu.local) (62.60.8.98) by server-23.tower-571.messagelabs.com with ECDHE-RSA-AES256-GCM-SHA384 encrypted SMTP; 28 Mar 2023 09:42:28 -0000 Received: from n03ukasimr03.n03.fujitsu.local (localhost [127.0.0.1]) by n03ukasimr03.n03.fujitsu.local (Postfix) with ESMTP id A43E51B3; Tue, 28 Mar 2023 10:42:27 +0100 (BST) Received: from R01UKEXCASM121.r01.fujitsu.local (R01UKEXCASM121 [10.183.43.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by n03ukasimr03.n03.fujitsu.local (Postfix) with ESMTPS id 9840C1AF; Tue, 28 Mar 2023 10:42:27 +0100 (BST) Received: from 692d629b0116.g08.fujitsu.local (10.167.234.230) by R01UKEXCASM121.r01.fujitsu.local (10.183.43.173) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Tue, 28 Mar 2023 10:42:23 +0100 From: Shiyang Ruan To: , , , CC: , , , , Subject: [PATCH v11 2/2] mm, pmem, xfs: Introduce MF_MEM_REMOVE for unbind Date: Tue, 28 Mar 2023 09:41:46 +0000 Message-ID: <1679996506-2-3-git-send-email-ruansy.fnst@fujitsu.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1679996506-2-1-git-send-email-ruansy.fnst@fujitsu.com> References: <1679996506-2-1-git-send-email-ruansy.fnst@fujitsu.com> MIME-Version: 1.0 X-Originating-IP: [10.167.234.230] X-ClientProxiedBy: G08CNEXCHPEKD07.g08.fujitsu.local (10.167.33.80) To R01UKEXCASM121.r01.fujitsu.local (10.183.43.173) X-Virus-Scanned: ClamAV using ClamSMTP X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: D4AC720006 X-Rspam-User: X-Stat-Signature: 31muroyb18i33pxokr5k7ywi6nhicbb5 X-HE-Tag: 1679996550-667158 X-HE-Meta: U2FsdGVkX18Ngo3VTJUSDsbMr8hYLnriYcs3M29/AUnwMFZvtXgRGvIeCtmTzazHS4L5IpuV09v8PkSl5qi4Z5dvEZ+SDPzMvGQ0zoX/hvcA+CvKS1oPbyDXwDjs+7cxSTHtv6iwAhFJT+wMiZ5zZ9Xv54gXbozdLl0oceBef1miwPXGcbHdQjFoniXhdMgUJzH2sRVDfGgL8o3FnUO8mxX6HdFgydaY1quj8GpB/R96e3hP1AHDMX/JKp7uokjlwlikHXuDiFLyXM1NofFA5So+qygAau56KCEPOx4z/GTXvgq4FU7vLuj8XDfJiE69U9QhRUlID9QxDzx31cZh92Q4lmXsZCK9c8kQEblqkaeL15R66vP8KtMHJnNa6kY5QUtbBFk8h8hUnGoneAGed+ZaqScOJYIIzKf4Q9hyzsgZc2Rpk7IQTv1bkExUi3D+tLQn5MpIXNiqCIi3twavCk4nHOq7ruZVsDH+qaZyHXf4bOVeBEecHHYd4bgxrPy5Ouq6XZdhNO3ogxwjbihatlBP0Q3Vk45vK8Nnshj6x58doxz3u9M3gxOS14UmyMYJdTsfz+umo1u0f74ArArjmtsZfUvFdJEBI9m3spTTDXfp8ETSQdmEe7HOjTqDmj/9J8X6h7to/jtpKYA9qy0IOZG3QzeTY46CGoE5WM9Ui9TW26DVz1GotikK/aMPpe3/wnIhfrDoRaM2lbuZRWyC5lpmfZn0MXwIX+a8b0yJkVP446TyGLCwvLggL+S9xWEyhLRbpEzKS9HjN+LjnPj0Ga1eMIVx/coUSGJSm9WbfXB/NHyD4/2tDE8AHHWIhKLihYpzibPyLpLHGKLCOKvKikdvxpn5WD9aFtKXTeDv8fTjJGMVwF4MrK3hsNXqt2pycb1giXc5Mij8nAITNbw58FJvIR4GvmdfGYuVVjM2VqZWPBaayblWLc9EL3djCjlAvjmCVmnCvK5Pi3gQ1Lk T99CrUKm YUHctvAuQSwn4LXZ3ajRmuLYslteUsdIJcY1o0WEDdNIaNRRTEN4QnXnGFwyFo4zens2eEQriTn/vTszVuIW54/C+aQr65YsIw7TIFOdRPvBaWWFlU9yDpguJXQ2Pq+5SEqNrvRpj85ibxIqURp52wD24LLB221MVwpgud36gUP0bABAgP3tF9Vebv09xS+w+PCY02dLCbwgNOUOwArY9gZs0LnHtl3BZFs5/UlynnGLqp+wI99yEL2YhUWn0cpekYjJevXKAI9EOPzz/tRgc+fpaJXjOx5fxVEEpt2Zgaeg/vTvcg8dCWC1gpUgQpOR4HzhM50mbQ1F4nUpCWrlcsTswe9ar99iPP40tMXBvE1Pe8yg0oZCWCL2DLyGmb+DDsxsMBR9mpSikY7rTxsedTjiDWG2RnPFhTblY X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This patch is inspired by Dan's "mm, dax, pmem: Introduce dev_pagemap_failure()"[1]. With the help of dax_holder and ->notify_failure() mechanism, the pmem driver is able to ask filesystem (or mapped device) on it to unmap all files in use and notify processes who are using those files. Call trace: trigger unbind -> unbind_store() -> ... (skip) -> devres_release_all() -> kill_dax() -> dax_holder_notify_failure(dax_dev, 0, U64_MAX, MF_MEM_PRE_REMOVE) -> xfs_dax_notify_failure() `-> freeze_super() `-> do xfs rmap ` -> mf_dax_kill_procs() ` -> collect_procs_fsdax() // all associated ` -> unmap_and_kill() ` -> invalidate_inode_pages2() // drop file's cache `-> thaw_super() Introduce MF_MEM_PRE_REMOVE to let filesystem know this is a remove event. Freeze the filesystem to prevent new dax mapping being created. And do not shutdown filesystem directly if something not supported, or if failure range includes metadata area. Make sure all files and processes are handled correctly. Also drop the cache of associated files before pmem is removed. [1]: https://lore.kernel.org/linux-mm/161604050314.1463742.14151665140035795571.stgit@dwillia2-desk3.amr.corp.intel.com/ Signed-off-by: Shiyang Ruan --- drivers/dax/super.c | 3 +- fs/xfs/xfs_notify_failure.c | 56 +++++++++++++++++++++++++++++++++---- include/linux/mm.h | 1 + mm/memory-failure.c | 17 ++++++++--- 4 files changed, 67 insertions(+), 10 deletions(-) diff --git a/drivers/dax/super.c b/drivers/dax/super.c index c4c4728a36e4..2e1a35e82fce 100644 --- a/drivers/dax/super.c +++ b/drivers/dax/super.c @@ -323,7 +323,8 @@ void kill_dax(struct dax_device *dax_dev) return; if (dax_dev->holder_data != NULL) - dax_holder_notify_failure(dax_dev, 0, U64_MAX, 0); + dax_holder_notify_failure(dax_dev, 0, U64_MAX, + MF_MEM_PRE_REMOVE); clear_bit(DAXDEV_ALIVE, &dax_dev->flags); synchronize_srcu(&dax_srcu); diff --git a/fs/xfs/xfs_notify_failure.c b/fs/xfs/xfs_notify_failure.c index 1e2eddb8f90f..1b4eff43f9b5 100644 --- a/fs/xfs/xfs_notify_failure.c +++ b/fs/xfs/xfs_notify_failure.c @@ -22,6 +22,7 @@ #include #include +#include struct xfs_failure_info { xfs_agblock_t startblock; @@ -73,10 +74,16 @@ xfs_dax_failure_fn( struct xfs_mount *mp = cur->bc_mp; struct xfs_inode *ip; struct xfs_failure_info *notify = data; + struct address_space *mapping; + pgoff_t pgoff; + unsigned long pgcnt; int error = 0; if (XFS_RMAP_NON_INODE_OWNER(rec->rm_owner) || (rec->rm_flags & (XFS_RMAP_ATTR_FORK | XFS_RMAP_BMBT_BLOCK))) { + /* The device is about to be removed. Not a really failure. */ + if (notify->mf_flags & MF_MEM_PRE_REMOVE) + return 0; notify->want_shutdown = true; return 0; } @@ -92,10 +99,18 @@ xfs_dax_failure_fn( return 0; } - error = mf_dax_kill_procs(VFS_I(ip)->i_mapping, - xfs_failure_pgoff(mp, rec, notify), - xfs_failure_pgcnt(mp, rec, notify), - notify->mf_flags); + mapping = VFS_I(ip)->i_mapping; + pgoff = xfs_failure_pgoff(mp, rec, notify); + pgcnt = xfs_failure_pgcnt(mp, rec, notify); + + /* Continue the rmap query if the inode isn't a dax file. */ + if (dax_mapping(mapping)) + error = mf_dax_kill_procs(mapping, pgoff, pgcnt, + notify->mf_flags); + + /* Invalidate the cache anyway. */ + invalidate_inode_pages2_range(mapping, pgoff, pgoff + pgcnt - 1); + xfs_irele(ip); return error; } @@ -164,11 +179,25 @@ xfs_dax_notify_ddev_failure( } xfs_trans_cancel(tp); + + /* Unfreeze filesystem anyway if it is freezed before. */ + if (mf_flags & MF_MEM_PRE_REMOVE) { + error = thaw_super(mp->m_super); + if (error) + return error; + } + + /* + * Determine how to shutdown the filesystem according to the + * error code and flags. + */ if (error || notify.want_shutdown) { xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_ONDISK); if (!error) error = -EFSCORRUPTED; - } + } else if (mf_flags & MF_MEM_PRE_REMOVE) + xfs_force_shutdown(mp, SHUTDOWN_FORCE_UMOUNT); + return error; } @@ -182,6 +211,7 @@ xfs_dax_notify_failure( struct xfs_mount *mp = dax_holder(dax_dev); u64 ddev_start; u64 ddev_end; + int error; if (!(mp->m_super->s_flags & SB_BORN)) { xfs_warn(mp, "filesystem is not ready for notify_failure()!"); @@ -196,6 +226,8 @@ xfs_dax_notify_failure( if (mp->m_logdev_targp && mp->m_logdev_targp->bt_daxdev == dax_dev && mp->m_logdev_targp != mp->m_ddev_targp) { + if (mf_flags & MF_MEM_PRE_REMOVE) + return 0; xfs_err(mp, "ondisk log corrupt, shutting down fs!"); xfs_force_shutdown(mp, SHUTDOWN_CORRUPT_ONDISK); return -EFSCORRUPTED; @@ -209,6 +241,12 @@ xfs_dax_notify_failure( ddev_start = mp->m_ddev_targp->bt_dax_part_off; ddev_end = ddev_start + bdev_nr_bytes(mp->m_ddev_targp->bt_bdev) - 1; + /* Notify failure on the whole device. */ + if (offset == 0 && len == U64_MAX) { + offset = ddev_start; + len = bdev_nr_bytes(mp->m_ddev_targp->bt_bdev); + } + /* Ignore the range out of filesystem area */ if (offset + len - 1 < ddev_start) return -ENXIO; @@ -225,6 +263,14 @@ xfs_dax_notify_failure( if (offset + len - 1 > ddev_end) len = ddev_end - offset + 1; + if (mf_flags & MF_MEM_PRE_REMOVE) { + xfs_info(mp, "device is about to be removed!"); + /* Freeze the filesystem to prevent new mappings created. */ + error = freeze_super(mp->m_super); + if (error) + return error; + } + return xfs_dax_notify_ddev_failure(mp, BTOBB(offset), BTOBB(len), mf_flags); } diff --git a/include/linux/mm.h b/include/linux/mm.h index 1f79667824eb..ac3f22c20e1d 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -3436,6 +3436,7 @@ enum mf_flags { MF_UNPOISON = 1 << 4, MF_SW_SIMULATED = 1 << 5, MF_NO_RETRY = 1 << 6, + MF_MEM_PRE_REMOVE = 1 << 7, }; int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, unsigned long count, int mf_flags); diff --git a/mm/memory-failure.c b/mm/memory-failure.c index fae9baf3be16..6e6acec45568 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -623,7 +623,7 @@ static void collect_procs_file(struct page *page, struct list_head *to_kill, */ static void collect_procs_fsdax(struct page *page, struct address_space *mapping, pgoff_t pgoff, - struct list_head *to_kill) + struct list_head *to_kill, bool pre_remove) { struct vm_area_struct *vma; struct task_struct *tsk; @@ -631,8 +631,15 @@ static void collect_procs_fsdax(struct page *page, i_mmap_lock_read(mapping); read_lock(&tasklist_lock); for_each_process(tsk) { - struct task_struct *t = task_early_kill(tsk, true); + struct task_struct *t = tsk; + /* + * Search for all tasks while MF_MEM_PRE_REMOVE, because the + * current may not be the one accessing the fsdax page. + * Otherwise, search for the current task. + */ + if (!pre_remove) + t = task_early_kill(tsk, true); if (!t) continue; vma_interval_tree_foreach(vma, &mapping->i_mmap, pgoff, pgoff) { @@ -1732,6 +1739,7 @@ int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, dax_entry_t cookie; struct page *page; size_t end = index + count; + bool pre_remove = mf_flags & MF_MEM_PRE_REMOVE; mf_flags |= MF_ACTION_REQUIRED | MF_MUST_KILL; @@ -1743,9 +1751,10 @@ int mf_dax_kill_procs(struct address_space *mapping, pgoff_t index, if (!page) goto unlock; - SetPageHWPoison(page); + if (!pre_remove) + SetPageHWPoison(page); - collect_procs_fsdax(page, mapping, index, &to_kill); + collect_procs_fsdax(page, mapping, index, &to_kill, pre_remove); unmap_and_kill(&to_kill, page_to_pfn(page), mapping, index, mf_flags); unlock: