From patchwork Fri Aug 10 18:04:24 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10562979 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 00D7A13BB for ; Fri, 10 Aug 2018 18:04:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id DC75621F61 for ; Fri, 10 Aug 2018 18:04:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CE75E2B65E; Fri, 10 Aug 2018 18:04:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 7C7AA21F61 for ; Fri, 10 Aug 2018 18:04:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 09B286E981; Fri, 10 Aug 2018 18:04:38 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw1-xc42.google.com (mail-yw1-xc42.google.com [IPv6:2607:f8b0:4864:20::c42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 393716E981 for ; Fri, 10 Aug 2018 18:04:36 +0000 (UTC) Received: by mail-yw1-xc42.google.com with SMTP id l189-v6so9212378ywb.10 for ; Fri, 10 Aug 2018 11:04:36 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Uki25nReRWpFjMe4lsD6sybIji3mrXrnjkga/9bUpjM=; b=KBjQ436j3ewv1HTmRPAcLY9z4SLnHgCC23tSmrmRe0zyjZ0qoalCnFVNFwn7ijutZl 4FbCxSyUPM6y4ZYn6UBydO4wQjtTUsT+IPh79OE8xFS33AjN1xaCWCkBEUW3cOypUjr2 fAu8CjqGtaw6xmVbIBfvWR3S0SWuve+KyPUtO2mEcYXrCyGsCgN32TMIhjGgCXK7BjqK T8ukfA/BeAZC7qy0pZU/nptseMs1B9ZLX31B5f3RNO0cLQr2mhYhMMyfC6TyTqXJhxF9 slpFpIriA6prXrQj91yuauPQyQgV6R4/k2P84lamL2vT40rEyUeQqxZt3BKlvH33g9sb USsg== X-Gm-Message-State: AOUpUlHwXWhiZcmVVB4+uqw/DJbiFlDvf/CPbTSQ3Wqn6jHsd1Jz2KpJ OzNgGENUA8eluUMeEPNmFILNl+bVk3c= X-Google-Smtp-Source: AA+uWPyamlDO2w2sglTGnxarmpUpcVULXg+kkJ+cL48KlTQaIdzraJvORPccCnCKuozit3AMPk4nPg== X-Received: by 2002:a25:ce44:: with SMTP id x65-v6mr4367358ybe.96.1533924275321; Fri, 10 Aug 2018 11:04:35 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id d185-v6sm7906204ywf.100.2018.08.10.11.04.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 11:04:34 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm/bridge: sn65dsi86: Move panel_prepare() to pre_enable() Date: Fri, 10 Aug 2018 14:04:24 -0400 Message-Id: <20180810180433.136501-1-seanpaul@chromium.org> X-Mailer: git-send-email 2.18.0.597.ga71716f1ad-goog MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sandeep Panda , Stephen Boyd , Laurent Pinchart Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP prepare() is the old-timey way to say pre_enable(). It should be called before modeset. This fixes an issue where the panel on cheza must have the regulator always-on/boot-on for it to work. Cc: Sandeep Panda Cc: Stephen Boyd Signed-off-by: Sean Paul --- drivers/gpu/drm/bridge/ti-sn65dsi86.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 1b6e8b72be58..36577cae0a20 100644 --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c @@ -448,8 +448,6 @@ static void ti_sn_bridge_enable(struct drm_bridge *bridge) struct ti_sn_bridge *pdata = bridge_to_ti_sn_bridge(bridge); unsigned int val; - drm_panel_prepare(pdata->panel); - /* DSI_A lane config */ val = (4 - pdata->dsi->lanes) << SN_DSIA_LANE_OFFSET; regmap_update_bits(pdata->regmap, SN_DSI_LANES_REG, @@ -507,6 +505,8 @@ static void ti_sn_bridge_pre_enable(struct drm_bridge *bridge) /* in case drm_panel is connected then HPD is not supported */ regmap_update_bits(pdata->regmap, SN_HPD_DISABLE_REG, SN_HPD_DISABLE_BIT, SN_HPD_DISABLE_BIT); + + drm_panel_prepare(pdata->panel); } static void ti_sn_bridge_post_disable(struct drm_bridge *bridge) From patchwork Fri Aug 10 18:04:25 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sean Paul X-Patchwork-Id: 10562981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B9DAA1057 for ; Fri, 10 Aug 2018 18:04:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A3BF521F61 for ; Fri, 10 Aug 2018 18:04:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9616B2BCCF; Fri, 10 Aug 2018 18:04:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 191DB21F61 for ; Fri, 10 Aug 2018 18:04:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 25D436E985; Fri, 10 Aug 2018 18:04:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw1-xc44.google.com (mail-yw1-xc44.google.com [IPv6:2607:f8b0:4864:20::c44]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8ACD56E982 for ; Fri, 10 Aug 2018 18:04:52 +0000 (UTC) Received: by mail-yw1-xc44.google.com with SMTP id q129-v6so9218493ywg.8 for ; Fri, 10 Aug 2018 11:04:52 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=avpy5jqkZBuqjTkX9RItImYAaK8Jem0WrZ1LZaO6bXA=; b=OiTsDoF5EVU1Io7+X4kuTHbdlK/vAq0wLInfluaoe8/BL3ZdWxjXxIfcOwIcYp3ivh VEUT4M0NsqkXRec/l4VfmFVG+eKW5pex0fhhskz09lzVHzPB+3RuocdvD4H28+U7fyPS 1auKPBTS4pV2o95CVKI1sLJUrnUO1SnUAeYlXlKpkO/8OG2gwu6kPtc3/UjB6pomvKIe Ows6Pw9SYSz+80ST/MWMsm9kqSZXQ1CofxRwUgYy/qORg9EE8fdURTiddJKNvv8iZjJA XRMk3jYOvUT3rrmkmKtzUkiMxPsEDfBtioVnDg/kgqIxQGgrpayqUrX0uFxM9O2R5MCC DyiA== X-Gm-Message-State: AOUpUlGp55tcgL2X7gWy+tRnXL5R0Z3y9t0ApQk6SdS4AqXp/GUpz11K wfMMHWpCWQr5Ts2e/QvXZRvC04G3RQY= X-Google-Smtp-Source: AA+uWPzLyyPfRMOAKqSK5Vkfp1r12G+O4J36XFLVZdBFA0vB/5jNSGgBh8mdTVfIlefxv1ASp1o5FA== X-Received: by 2002:a0d:cec1:: with SMTP id q184-v6mr4170237ywd.60.1533924291714; Fri, 10 Aug 2018 11:04:51 -0700 (PDT) Received: from rosewood.cam.corp.google.com ([2620:0:1013:11:ad55:b1db:adfe:3b9f]) by smtp.gmail.com with ESMTPSA id d185-v6sm7906204ywf.100.2018.08.10.11.04.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 10 Aug 2018 11:04:51 -0700 (PDT) From: Sean Paul To: dri-devel@lists.freedesktop.org Subject: [PATCH 2/2] drm/panel: simple: tv123wam: Add unprepare delay Date: Fri, 10 Aug 2018 14:04:25 -0400 Message-Id: <20180810180433.136501-2-seanpaul@chromium.org> X-Mailer: git-send-email 2.18.0.597.ga71716f1ad-goog In-Reply-To: <20180810180433.136501-1-seanpaul@chromium.org> References: <20180810180433.136501-1-seanpaul@chromium.org> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thierry Reding , Sandeep Panda , Stephen Boyd Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The panel datasheet specifies a 500ms delay after power-down before re-enabling. Cc: Sandeep Panda Cc: Stephen Boyd Signed-off-by: Sean Paul --- drivers/gpu/drm/panel/panel-simple.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index 5b5d0a24e713..97964f7f2ace 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1385,6 +1385,9 @@ static const struct panel_desc innolux_tv123wam = { .width = 259, .height = 173, }, + .delay = { + .unprepare = 500, + }, }; static const struct drm_display_mode innolux_zj070na_01p_mode = {