From patchwork Thu Mar 30 09:59:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13193751 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B309C761A6 for ; Thu, 30 Mar 2023 10:00:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BC57A10ED8E; Thu, 30 Mar 2023 10:00:01 +0000 (UTC) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6DE5010ED85 for ; Thu, 30 Mar 2023 09:59:51 +0000 (UTC) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id BE41920F4D; Thu, 30 Mar 2023 11:59:47 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Peter Ujfalusi , devicetree@vger.kernel.org Subject: [PATCH v1 1/6] dt-bindings: display: bridge: toshiba, tc358768: Fix typo Date: Thu, 30 Mar 2023 11:59:36 +0200 Message-Id: <20230330095941.428122-2-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it> References: <20230330095941.428122-1-francesco@dolcini.it> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francesco Dolcini , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Francesco Dolcini Correct Toshiba spelling. Signed-off-by: Francesco Dolcini Acked-by: Krzysztof Kozlowski --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index 0b6f5bef120f..d6dac186ac59 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -4,7 +4,7 @@ $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Toschiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge +title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge maintainers: - Peter Ujfalusi From patchwork Thu Mar 30 09:59:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13193752 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 70F43C761AF for ; Thu, 30 Mar 2023 10:00:09 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8E72210ED90; Thu, 30 Mar 2023 10:00:03 +0000 (UTC) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by gabe.freedesktop.org (Postfix) with ESMTPS id BFCF010ED86 for ; Thu, 30 Mar 2023 09:59:51 +0000 (UTC) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 493E420F59; Thu, 30 Mar 2023 11:59:48 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Peter Ujfalusi , devicetree@vger.kernel.org Subject: [PATCH v1 2/6] dt-bindings: display: bridge: toshiba, tc358768: Add TC9594 Date: Thu, 30 Mar 2023 11:59:37 +0200 Message-Id: <20230330095941.428122-3-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it> References: <20230330095941.428122-1-francesco@dolcini.it> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francesco Dolcini , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Francesco Dolcini Add TC9594, from the software point of view this is identical to TC358768 with the main difference being automotive qualified. Signed-off-by: Francesco Dolcini --- .../devicetree/bindings/display/bridge/toshiba,tc358768.yaml | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index d6dac186ac59..8f22093b61ae 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -4,19 +4,20 @@ $id: http://devicetree.org/schemas/display/bridge/toshiba,tc358768.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Toshiba TC358768/TC358778 Parallel RGB to MIPI DSI bridge +title: Toshiba TC358768/TC358778/TC9594 Parallel RGB to MIPI DSI bridge maintainers: - Peter Ujfalusi description: | - The TC358768/TC358778 is bridge device which converts RGB to DSI. + The TC358768/TC358778/TC9594 is bridge device which converts RGB to DSI. properties: compatible: enum: - toshiba,tc358768 - toshiba,tc358778 + - toshiba,tc9594 reg: maxItems: 1 From patchwork Thu Mar 30 09:59:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13193746 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6ED5DC6FD1D for ; Thu, 30 Mar 2023 09:59:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 42AB010ED9A; Thu, 30 Mar 2023 09:59:52 +0000 (UTC) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8D44B10ED7C for ; Thu, 30 Mar 2023 09:59:50 +0000 (UTC) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id C49C320F5A; Thu, 30 Mar 2023 11:59:48 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org, Rob Herring , Krzysztof Kozlowski , Peter Ujfalusi , devicetree@vger.kernel.org Subject: [PATCH v1 3/6] dt-bindings: display: bridge: toshiba, tc358768: add parallel input mode Date: Thu, 30 Mar 2023 11:59:38 +0200 Message-Id: <20230330095941.428122-4-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it> References: <20230330095941.428122-1-francesco@dolcini.it> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francesco Dolcini , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Francesco Dolcini Add new toshiba,input-rgb-mode property to describe the actual signal connection on the parallel RGB input interface. Signed-off-by: Francesco Dolcini --- .../bindings/display/bridge/toshiba,tc358768.yaml | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml index 8f22093b61ae..2638121a2223 100644 --- a/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml +++ b/Documentation/devicetree/bindings/display/bridge/toshiba,tc358768.yaml @@ -42,6 +42,21 @@ properties: clock-names: const: refclk + toshiba,input-rgb-mode: + description: | + Parallel Input (RGB) Mode. + + RGB inputs (PD[23:0]) color arrangement as documented in the datasheet + and in the table below. + + 0 = R[7:0], G[7:0], B[7:0] + 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[7:2], B[7:2] + 2 = 8’b0, R[4:0], G[5:0], B[4:0] + + $ref: /schemas/types.yaml#/definitions/uint32 + enum: [ 0, 1, 2 ] + default: 0 + ports: $ref: /schemas/graph.yaml#/properties/ports From patchwork Thu Mar 30 09:59:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13193749 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 624BDC6FD1D for ; Thu, 30 Mar 2023 10:00:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0203E10ED86; Thu, 30 Mar 2023 10:00:02 +0000 (UTC) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by gabe.freedesktop.org (Postfix) with ESMTPS id A459710ED9F for ; Thu, 30 Mar 2023 09:59:52 +0000 (UTC) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 471AB20755; Thu, 30 Mar 2023 11:59:49 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org Subject: [PATCH v1 4/6] drm/bridge: tc358768: Add TC9594 Date: Thu, 30 Mar 2023 11:59:39 +0200 Message-Id: <20230330095941.428122-5-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it> References: <20230330095941.428122-1-francesco@dolcini.it> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francesco Dolcini , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Francesco Dolcini Add TC9594 ids, from the software point of view this is fully compatible with tc358768, the only difference is the automotive qualification. Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 7c0cbe84611b..f4499ae7bee6 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -991,6 +991,7 @@ static const struct regmap_config tc358768_regmap_config = { static const struct i2c_device_id tc358768_i2c_ids[] = { { "tc358768", 0 }, { "tc358778", 0 }, + { "tc9594", 0 }, { } }; MODULE_DEVICE_TABLE(i2c, tc358768_i2c_ids); @@ -998,6 +999,7 @@ MODULE_DEVICE_TABLE(i2c, tc358768_i2c_ids); static const struct of_device_id tc358768_of_ids[] = { { .compatible = "toshiba,tc358768", }, { .compatible = "toshiba,tc358778", }, + { .compatible = "toshiba,tc9594", }, { } }; MODULE_DEVICE_TABLE(of, tc358768_of_ids); From patchwork Thu Mar 30 09:59:40 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13193748 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B97F5C77B60 for ; Thu, 30 Mar 2023 10:00:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 3697010ED85; Thu, 30 Mar 2023 10:00:00 +0000 (UTC) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C64610ED95 for ; Thu, 30 Mar 2023 09:59:52 +0000 (UTC) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id AD06E20FA7; Thu, 30 Mar 2023 11:59:49 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org Subject: [PATCH v1 5/6] drm/bridge: tc358768: Add parallel data format cfg Date: Thu, 30 Mar 2023 11:59:40 +0200 Message-Id: <20230330095941.428122-6-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it> References: <20230330095941.428122-1-francesco@dolcini.it> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francesco Dolcini , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Francesco Dolcini Add configuration for parallel data format register, tc358768 supports different mapping on the parallel input RGB interface, enable the configuration for it. Valid values, and the related meaning, are: 0 = R[7:0], G[7:0], B[7:0] 1 = R[1:0], G[1:0], B[1:0], R[7:2], G[7:2], B[7:2] 2 = 8’b0, R[4:0], G[5:0], B[4:0] Use 0 by default, consistently with the HW default. Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index f4499ae7bee6..4462264274af 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -854,6 +854,11 @@ static void tc358768_bridge_pre_enable(struct drm_bridge *bridge) if (mode->flags & DRM_MODE_FLAG_PHSYNC) tc358768_update_bits(priv, TC358768_PP_MISC, BIT(0), BIT(0)); + /* PDataF: Parallel Data Format */ + val = 0; + of_property_read_u32(bridge->of_node, "toshiba,input-rgb-mode", &val); + tc358768_update_bits(priv, TC358768_CONFCTL, BIT(8) | BIT(9), val << 8); + /* Start DSI Tx */ tc358768_write(priv, TC358768_DSI_START, 0x1); From patchwork Thu Mar 30 09:59:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Francesco Dolcini X-Patchwork-Id: 13193747 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 153EBC6FD1D for ; Thu, 30 Mar 2023 10:00:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C49910ED7C; Thu, 30 Mar 2023 09:59:59 +0000 (UTC) Received: from mail11.truemail.it (mail11.truemail.it [IPv6:2001:4b7e:0:8::81]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3BB6C10ED94 for ; Thu, 30 Mar 2023 09:59:52 +0000 (UTC) Received: from francesco-nb.pivistrello.it (93-49-2-63.ip317.fastwebnet.it [93.49.2.63]) by mail11.truemail.it (Postfix) with ESMTPA id 1F2CC20FAA; Thu, 30 Mar 2023 11:59:50 +0200 (CEST) From: Francesco Dolcini To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , dri-devel@lists.freedesktop.org Subject: [PATCH v1 6/6] drm/bridge: tc358768: Add atomic_get_input_bus_fmts() implementation Date: Thu, 30 Mar 2023 11:59:41 +0200 Message-Id: <20230330095941.428122-7-francesco@dolcini.it> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330095941.428122-1-francesco@dolcini.it> References: <20230330095941.428122-1-francesco@dolcini.it> MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Francesco Dolcini , linux-kernel@vger.kernel.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" From: Francesco Dolcini Add atomic_get_input_bus_fmts() implementation, tc358768 has a parallel RGB input interface with the actual bus format depending on the amount of parallel input data lines. Without this change when the tc358768 is used with less than 24bit the color mapping is completely wrong. Signed-off-by: Francesco Dolcini --- drivers/gpu/drm/bridge/tc358768.c | 44 +++++++++++++++++++++++++++++++ 1 file changed, 44 insertions(+) diff --git a/drivers/gpu/drm/bridge/tc358768.c b/drivers/gpu/drm/bridge/tc358768.c index 4462264274af..c41620409a39 100644 --- a/drivers/gpu/drm/bridge/tc358768.c +++ b/drivers/gpu/drm/bridge/tc358768.c @@ -9,6 +9,7 @@ #include #include #include +#include #include #include #include @@ -918,6 +919,44 @@ static void tc358768_bridge_enable(struct drm_bridge *bridge) } } +#define MAX_INPUT_SEL_FORMATS 1 + +static u32 * +tc358768_atomic_get_input_bus_fmts(struct drm_bridge *bridge, + struct drm_bridge_state *bridge_state, + struct drm_crtc_state *crtc_state, + struct drm_connector_state *conn_state, + u32 output_fmt, + unsigned int *num_input_fmts) +{ + struct tc358768_priv *priv = bridge_to_tc358768(bridge); + u32 *input_fmts; + + *num_input_fmts = 0; + + input_fmts = kcalloc(MAX_INPUT_SEL_FORMATS, sizeof(*input_fmts), + GFP_KERNEL); + if (!input_fmts) + return NULL; + + switch (priv->pd_lines) { + case 16: + input_fmts[0] = MEDIA_BUS_FMT_RGB565_1X16; + break; + case 18: + input_fmts[0] = MEDIA_BUS_FMT_RGB666_1X18; + break; + default: + case 24: + input_fmts[0] = MEDIA_BUS_FMT_RGB888_1X24; + break; + }; + + *num_input_fmts = MAX_INPUT_SEL_FORMATS; + + return input_fmts; +} + static const struct drm_bridge_funcs tc358768_bridge_funcs = { .attach = tc358768_bridge_attach, .mode_valid = tc358768_bridge_mode_valid, @@ -925,6 +964,11 @@ static const struct drm_bridge_funcs tc358768_bridge_funcs = { .enable = tc358768_bridge_enable, .disable = tc358768_bridge_disable, .post_disable = tc358768_bridge_post_disable, + + .atomic_duplicate_state = drm_atomic_helper_bridge_duplicate_state, + .atomic_destroy_state = drm_atomic_helper_bridge_destroy_state, + .atomic_reset = drm_atomic_helper_bridge_reset, + .atomic_get_input_bus_fmts = tc358768_atomic_get_input_bus_fmts, }; static const struct drm_bridge_timings default_tc358768_timings = {