From patchwork Thu Mar 30 10:33:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Rui X-Patchwork-Id: 13193805 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F8F3C761A6 for ; Thu, 30 Mar 2023 10:34:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229608AbjC3KeR (ORCPT ); Thu, 30 Mar 2023 06:34:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53950 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230348AbjC3KeL (ORCPT ); Thu, 30 Mar 2023 06:34:11 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6EDC240C8; Thu, 30 Mar 2023 03:34:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680172450; x=1711708450; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=aMBrQv3dD6HKKF5OK2mlzf/ElkqwSIasmpXMMURYf7c=; b=XdaD6IyJYXzHf1keZCkTAxzHr5vJSXNY/ftsJwBoRxBZYJ1pb7wwTZVs cthrIpjn9NNRPiplZkeuPKbKehjO2TaMOvs+sStHhQAPiRCyU0dQrTBu1 /Vca6AihNsKm1amdW6ENjJdeA8HBl4ANJ6VkBbnpKwPfgcCqVX4ryQi7G vDq3Bof9mEBDKN8aDr1WtM0IC2ca6jdfC+GkLjK/EDrF4Ua+gI76UVCZx HW3Q7DIYtgpXLZrfPLsuCquZlYMHlVmFTSYbFy4buNgLkrtaH7t3obNVY IE6iDF1IKkabLLHdgSQbNuGxcgW2bpL5k1NcqGGBsR84VTL1aTKwYtU6E A==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="368910788" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="368910788" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 03:34:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="634832281" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="634832281" Received: from junjiech-mobl.ccr.corp.intel.com (HELO rzhang1-DESK.intel.com) ([10.254.213.63]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 03:34:08 -0700 From: Zhang Rui To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, peter.ganzhorn@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/2] hwmon: (coretemp) Delete tjmax debug message Date: Thu, 30 Mar 2023 18:33:45 +0800 Message-Id: <20230330103346.6044-1-rui.zhang@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org After commit c0c67f8761ce ("hwmon: (coretemp) Add support for dynamic tjmax"), tjmax value is retrieved from MSR every time the temperature is read. This means that, with debug message enabled, the tjmax debug message is printed out for every single temperature read for any CPU. This spams the syslog. Ideally, as tjmax is package scope unique, the debug message should show once when tjmax is changed for one package. But this requires inventing some new per-package data in the coretemp driver, and this is overkill. To keep the code simple, delete the tjmax debug message. Signed-off-by: Zhang Rui --- drivers/hwmon/coretemp.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index 30d77f451937..fe3d4d0dcbed 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -286,10 +286,8 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev) * If the TjMax is not plausible, an assumption * will be used */ - if (val) { - dev_dbg(dev, "TjMax is %d degrees C\n", val); + if (val) return val * 1000; - } } if (force_tjmax) { From patchwork Thu Mar 30 10:33:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zhang Rui X-Patchwork-Id: 13193806 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 139EEC761AF for ; Thu, 30 Mar 2023 10:34:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230134AbjC3KeT (ORCPT ); Thu, 30 Mar 2023 06:34:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54204 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230397AbjC3KeM (ORCPT ); Thu, 30 Mar 2023 06:34:12 -0400 Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EB29661B8; Thu, 30 Mar 2023 03:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680172451; x=1711708451; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=whE1JWEEIbCYvxtx8pgmTqwGvrhSLFpbgGUYD65V//Q=; b=k3heUWsEIVlShvxiwZrU36to/WTqMen83G9hwqTTEfr1ON6lYYDGtbYo lxph9q8Awx9UNc3CT3Mcwp12WO0BGayHhn6w9wSp1Bx1Sj1kYHz3IUTgq 5TJxSZpLt2Tqn5DEs6O8nkyks/DHNOZKErTGjTVjDxA9de0FixR3AGTvN uWdSYX/KsRadGDsjZeBMLRkyoaRiygaudFRTKHeGBBiZZsWOG6o/dJw1O svRgHpJEOHCJ60zX9sgAqa597Cpa7/AbQ0Y+qWvWDLBzwglocN97t8cxS phNXtWmXHbbVrRxEZr9N72MiojIv3ejqn7oJiME+fgOAmz8sOe9IbMtaP w==; X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="368910798" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="368910798" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 03:34:11 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10664"; a="634832283" X-IronPort-AV: E=Sophos;i="5.98,303,1673942400"; d="scan'208";a="634832283" Received: from junjiech-mobl.ccr.corp.intel.com (HELO rzhang1-DESK.intel.com) ([10.254.213.63]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Mar 2023 03:34:10 -0700 From: Zhang Rui To: jdelvare@suse.com, linux@roeck-us.net Cc: linux-hwmon@vger.kernel.org, peter.ganzhorn@gmail.com, linux-kernel@vger.kernel.org Subject: [PATCH v2 2/2] hwmon: (coretemp) Delete an obsolete comment Date: Thu, 30 Mar 2023 18:33:46 +0800 Message-Id: <20230330103346.6044-2-rui.zhang@intel.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230330103346.6044-1-rui.zhang@intel.com> References: <20230330103346.6044-1-rui.zhang@intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org The refinement of tjmax value retrieved from MSR_IA32_TEMPERATURE_TARGET has been changed for several times. Now, the raw value from MSR is used without refinement. Thus remove the obsolete comment. Signed-off-by: Zhang Rui --- drivers/hwmon/coretemp.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c index fe3d4d0dcbed..eba94f68585a 100644 --- a/drivers/hwmon/coretemp.c +++ b/drivers/hwmon/coretemp.c @@ -282,10 +282,6 @@ static int get_tjmax(struct temp_data *tdata, struct device *dev) dev_warn(dev, "Unable to read TjMax from CPU %u\n", tdata->cpu); } else { val = (eax >> 16) & 0xff; - /* - * If the TjMax is not plausible, an assumption - * will be used - */ if (val) return val * 1000; }