From patchwork Sat Apr 1 12:00:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13196954 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79A5CC76196 for ; Sat, 1 Apr 2023 12:00:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229900AbjDAMAb (ORCPT ); Sat, 1 Apr 2023 08:00:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33662 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229441AbjDAMA3 (ORCPT ); Sat, 1 Apr 2023 08:00:29 -0400 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5873D24413 for ; Sat, 1 Apr 2023 05:00:20 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1piZty-0008Jk-WD; Sat, 01 Apr 2023 14:00:11 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1piZtv-008DGQ-JT; Sat, 01 Apr 2023 14:00:07 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1piZtu-009hNJ-SW; Sat, 01 Apr 2023 14:00:06 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Kees Cook Cc: Tony Luck , "Guilherme G. Piccoli" , linux-hardening@vger.kernel.org, kernel@pengutronix.de Subject: [PATCH] pstore/ram: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 14:00:00 +0200 Message-Id: <20230401120000.2487153-1-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1682; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=ZV4bC26dxUwofIABwwCtR03vphnH9lUv2WR8Lg3cC98=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKBy//ou+6tPzoXwpTH2gfg4NLwG4my3XjFHmD K6DotCOGAWJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZCgcvwAKCRCPgPtYfRL+ TqdyCACFkYP4bYfOdvzrvgt50OIPgO3mmGYKvyvJFb/AEIQM/eEMwmBM1wDf45QpT8tBOMlJzYl V5x6k0rvosSuHX2t8CRn10EQ+poA6xkmlikLhz3Iu72dBhfBQ/bVEHvYBb5rwFvPrpakwi5nNkO nnXLi3/QiwdhkTq7ZKSs2rYcY1VXumZ/EQN2C/M8v1IvAdYOK+psKEngihmKm+FxdSuazyliOYB hQpvofltnH/sFBA85vxXC4rXNgdIRctRdjAVKfw/Xd/Y8DWIPViLw0kn/Ac1JLBEgiQQ5RfKw0+ crzXvj78bG9PvgC+97SCRry3HKuR3cuQ+fF6dHDY/BdmDAVD X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-hardening@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-hardening@vger.kernel.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Guilherme G. Piccoli Acked-by: Kees Cook --- fs/pstore/ram.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6 diff --git a/fs/pstore/ram.c b/fs/pstore/ram.c index ade66dbe5f39..2f625e1fa8d8 100644 --- a/fs/pstore/ram.c +++ b/fs/pstore/ram.c @@ -875,7 +875,7 @@ static int ramoops_probe(struct platform_device *pdev) return err; } -static int ramoops_remove(struct platform_device *pdev) +static void ramoops_remove(struct platform_device *pdev) { struct ramoops_context *cxt = &oops_cxt; @@ -885,8 +885,6 @@ static int ramoops_remove(struct platform_device *pdev) cxt->pstore.bufsize = 0; ramoops_free_przs(cxt); - - return 0; } static const struct of_device_id dt_match[] = { @@ -896,7 +894,7 @@ static const struct of_device_id dt_match[] = { static struct platform_driver ramoops_driver = { .probe = ramoops_probe, - .remove = ramoops_remove, + .remove_new = ramoops_remove, .driver = { .name = "ramoops", .of_match_table = dt_match,