From patchwork Sat Apr 1 16:19:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= X-Patchwork-Id: 13197141 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3312BC77B62 for ; Sat, 1 Apr 2023 16:21:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VReS0pYbGQQDpGhG2T8E50AoOSFfe2I6XhbqTORW0tc=; b=WDOdUL09SmQEMF aqMc7gx3Tcv4uGDQ0xZxZW+sDPpojQkGIsuc+Mmeso/NK1IBCAPstr4HMgvDuXlFgI5dIphWLOEq2 mwbDYpnIfbrAoC+jdMbKUHxX/dmb2FbwczuvkUnKeoWKHATQMZCAOZfOg6/psATz4VLWHJhRyyRko Styhzir5OoXSOUg+oTOVUlvpg3GF6JpSd1mG+RLYaL8tgCCkQR1x1m2aNqCUVMshwNOdl53c3Lffw z7y+b3T/sEyop66RiV98Mt2YPX+oTZFMZPqDTM9gXB16iKiy//Pd7/23hbPq2pEHrLDtrO6KtJLpo ag9MG10sYLtBx/ZW79sw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pidyu-00AtAy-00; Sat, 01 Apr 2023 16:21:32 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pidxd-00As9G-09 for linux-rockchip@lists.infradead.org; Sat, 01 Apr 2023 16:20:14 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pidxM-000071-Of; Sat, 01 Apr 2023 18:19:56 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtp (Exim 4.94.2) (envelope-from ) id 1pidxL-008GSe-Ah; Sat, 01 Apr 2023 18:19:55 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1pidxK-009khe-Jg; Sat, 01 Apr 2023 18:19:54 +0200 From: =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= To: Miquel Raynal , Vignesh Raghavendra , Heiko Stuebner , Phil Edworthy Cc: Richard Weinberger , linux-mtd@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, kernel@pengutronix.de Subject: [PATCH 40/49] mtd: rawnand: rockchip: Convert to platform remove callback returning void Date: Sat, 1 Apr 2023 18:19:29 +0200 Message-Id: <20230401161938.2503204-41-u.kleine-koenig@pengutronix.de> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> References: <20230401161938.2503204-1-u.kleine-koenig@pengutronix.de> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=1838; i=u.kleine-koenig@pengutronix.de; h=from:subject; bh=5b0XHAUgin6YhP/t2Zk642ckRtz9ynLH1TjOf9h6WJk=; b=owEBbQGS/pANAwAKAY+A+1h9Ev5OAcsmYgBkKFlLKZ66exyKSWjWWPv7uJwM4AvwSe+dQqGRN rFNljS/ABGJATMEAAEKAB0WIQQ/gaxpOnoeWYmt/tOPgPtYfRL+TgUCZChZSwAKCRCPgPtYfRL+ Tqs+B/9BktD5yecoMur2/dGiT9krTJo3UN72YS1ieMgx8g55r7hlTahlQXa1TuHfAYJFUOufoVe au814z3dA45RnUTtHC4jsQ5EY7OuritRayjCfWRzh4lSp8mElLLDJA7qm3ty1+V16kp0iwDDxk6 jSa0tY5yjBAHdhCVVDNo31AEe4ThKEuWQOWWiNl6IbMZ6nRT9ph2zOhiQEfSMfSdcO7i3gvZW++ SCPDaDXLGdYeOlIg+hE1OhAm0tXJ2VsEz3fkO9KNACFRCcRzRc+2m9a0MYDOw/6yFOaZVMYC36l qgpj44JzTogpOXCA7OVjDUqtyvnKc+z0z3FMLUJv7k9suVh1 X-Developer-Key: i=u.kleine-koenig@pengutronix.de; a=openpgp; fpr=0D2511F322BFAB1C1580266BE2DCDD9132669BD6 X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-rockchip@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230401_092013_122585_9C0A42D6 X-CRM114-Status: GOOD ( 16.79 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is (mostly) ignored and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new() which already returns void. Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König Reviewed-by: Heiko Stuebner --- drivers/mtd/nand/raw/rockchip-nand-controller.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/mtd/nand/raw/rockchip-nand-controller.c b/drivers/mtd/nand/raw/rockchip-nand-controller.c index f133985cc053..2312e27362cb 100644 --- a/drivers/mtd/nand/raw/rockchip-nand-controller.c +++ b/drivers/mtd/nand/raw/rockchip-nand-controller.c @@ -1427,7 +1427,7 @@ static int rk_nfc_probe(struct platform_device *pdev) return ret; } -static int rk_nfc_remove(struct platform_device *pdev) +static void rk_nfc_remove(struct platform_device *pdev) { struct rk_nfc *nfc = platform_get_drvdata(pdev); @@ -1435,8 +1435,6 @@ static int rk_nfc_remove(struct platform_device *pdev) kfree(nfc->oob_buf); rk_nfc_chips_cleanup(nfc); rk_nfc_disable_clks(nfc); - - return 0; } static int __maybe_unused rk_nfc_suspend(struct device *dev) @@ -1476,7 +1474,7 @@ static const struct dev_pm_ops rk_nfc_pm_ops = { static struct platform_driver rk_nfc_driver = { .probe = rk_nfc_probe, - .remove = rk_nfc_remove, + .remove_new = rk_nfc_remove, .driver = { .name = "rockchip-nfc", .of_match_table = rk_nfc_id_table,