From patchwork Tue Apr 4 05:36:35 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Westerberg X-Patchwork-Id: 13199144 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9CFCC7618D for ; Tue, 4 Apr 2023 05:36:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233243AbjDDFgn (ORCPT ); Tue, 4 Apr 2023 01:36:43 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59706 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233160AbjDDFgl (ORCPT ); Tue, 4 Apr 2023 01:36:41 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DB72019BD for ; Mon, 3 Apr 2023 22:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680586599; x=1712122599; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=IcggdPKUPIsCGF6iqUTJpuPMOfnElR9IlWqVOAvqu1s=; b=JWP6Y5vMqGISJdOwfy3fkxxlPgkMzQzPORP+1IHTH4eS2wNTFO/evajP Elt5sfiAbCcAPLmtZnXywp5T1WCGRG1rAH1Cyud5qdnNYyisLgnSkgj8+ +dqO5XxrnbixkHRSuPUk1xOSG8Mk6j8zuILMQR5qyASHh5SZuVqgLiaKN NuhU4LR3mJIf0HZZWm5NLiiqSiVtENHuXySSs9DQ+J32Es2gZRi7wlzBv lW0XDcjdxpAAX+Memfmsq+KDkTyO/MfeqHMtd4GCn5Sx/7xvYDBOFqxhp lkgY++WYUM5fscs9I/wyKV9w9BAJbg/m8Ubh6naS24JoYrKD84+SS6Sa+ Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="340826310" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="340826310" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 22:36:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="688760548" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="688760548" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 03 Apr 2023 22:36:36 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 026C694; Tue, 4 Apr 2023 08:36:36 +0300 (EEST) From: Mika Westerberg To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Michael Jamet , Yehezkel Bernat , Andy Shevchenko , Mika Westerberg , netdev@vger.kernel.org Subject: [PATCH 1/2] net: thunderbolt: Fix sparse warnings Date: Tue, 4 Apr 2023 08:36:35 +0300 Message-Id: <20230404053636.51597-2-mika.westerberg@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404053636.51597-1-mika.westerberg@linux.intel.com> References: <20230404053636.51597-1-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Fixes the following warnings when the driver is built with sparse checks enabled: drivers/net/thunderbolt/main.c:767:47: warning: restricted __le32 degrades to integer drivers/net/thunderbolt/main.c:775:47: warning: restricted __le16 degrades to integer drivers/net/thunderbolt/main.c:776:44: warning: restricted __le16 degrades to integer drivers/net/thunderbolt/main.c:876:40: warning: incorrect type in assignment (different base types) drivers/net/thunderbolt/main.c:876:40: expected restricted __le32 [usertype] frame_size drivers/net/thunderbolt/main.c:876:40: got unsigned int [assigned] [usertype] frame_size drivers/net/thunderbolt/main.c:877:41: warning: incorrect type in assignment (different base types) drivers/net/thunderbolt/main.c:877:41: expected restricted __le32 [usertype] frame_count drivers/net/thunderbolt/main.c:877:41: got unsigned int [usertype] drivers/net/thunderbolt/main.c:878:41: warning: incorrect type in assignment (different base types) drivers/net/thunderbolt/main.c:878:41: expected restricted __le16 [usertype] frame_index drivers/net/thunderbolt/main.c:878:41: got unsigned short [usertype] drivers/net/thunderbolt/main.c:879:38: warning: incorrect type in assignment (different base types) drivers/net/thunderbolt/main.c:879:38: expected restricted __le16 [usertype] frame_id drivers/net/thunderbolt/main.c:879:38: got unsigned short [usertype] drivers/net/thunderbolt/main.c:880:62: warning: restricted __le32 degrades to integer drivers/net/thunderbolt/main.c:880:35: warning: restricted __le16 degrades to integer drivers/net/thunderbolt/main.c:993:23: warning: incorrect type in initializer (different base types) drivers/net/thunderbolt/main.c:993:23: expected restricted __wsum [usertype] wsum drivers/net/thunderbolt/main.c:993:23: got restricted __be32 [usertype] No functional changes intended. Signed-off-by: Mika Westerberg Reviewed-by: Simon Horman --- drivers/net/thunderbolt/main.c | 21 ++++++++++++--------- 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/drivers/net/thunderbolt/main.c b/drivers/net/thunderbolt/main.c index 26ef3706445e..6a43ced74881 100644 --- a/drivers/net/thunderbolt/main.c +++ b/drivers/net/thunderbolt/main.c @@ -764,7 +764,7 @@ static bool tbnet_check_frame(struct tbnet *net, const struct tbnet_frame *tf, */ if (net->skb && net->rx_hdr.frame_count) { /* Check the frame count fits the count field */ - if (frame_count != net->rx_hdr.frame_count) { + if (frame_count != le32_to_cpu(net->rx_hdr.frame_count)) { net->stats.rx_length_errors++; return false; } @@ -772,8 +772,8 @@ static bool tbnet_check_frame(struct tbnet *net, const struct tbnet_frame *tf, /* Check the frame identifiers are incremented correctly, * and id is matching. */ - if (frame_index != net->rx_hdr.frame_index + 1 || - frame_id != net->rx_hdr.frame_id) { + if (frame_index != le16_to_cpu(net->rx_hdr.frame_index) + 1 || + frame_id != le16_to_cpu(net->rx_hdr.frame_id)) { net->stats.rx_missed_errors++; return false; } @@ -873,11 +873,12 @@ static int tbnet_poll(struct napi_struct *napi, int budget) TBNET_RX_PAGE_SIZE - hdr_size); } - net->rx_hdr.frame_size = frame_size; - net->rx_hdr.frame_count = le32_to_cpu(hdr->frame_count); - net->rx_hdr.frame_index = le16_to_cpu(hdr->frame_index); - net->rx_hdr.frame_id = le16_to_cpu(hdr->frame_id); - last = net->rx_hdr.frame_index == net->rx_hdr.frame_count - 1; + net->rx_hdr.frame_size = hdr->frame_size; + net->rx_hdr.frame_count = hdr->frame_count; + net->rx_hdr.frame_index = hdr->frame_index; + net->rx_hdr.frame_id = hdr->frame_id; + last = le16_to_cpu(net->rx_hdr.frame_index) == + le32_to_cpu(net->rx_hdr.frame_count) - 1; rx_packets++; net->stats.rx_bytes += frame_size; @@ -990,8 +991,10 @@ static bool tbnet_xmit_csum_and_map(struct tbnet *net, struct sk_buff *skb, { struct thunderbolt_ip_frame_header *hdr = page_address(frames[0]->page); struct device *dma_dev = tb_ring_dma_device(net->tx_ring.ring); - __wsum wsum = htonl(skb->len - skb_transport_offset(skb)); unsigned int i, len, offset = skb_transport_offset(skb); + /* Remove payload length from checksum */ + u32 paylen = skb->len - skb_transport_offset(skb); + __wsum wsum = (__force __wsum)htonl(paylen); __be16 protocol = skb->protocol; void *data = skb->data; void *dest = hdr + 1; From patchwork Tue Apr 4 05:36:36 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Westerberg X-Patchwork-Id: 13199143 X-Patchwork-Delegate: kuba@kernel.org Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75E53C761A6 for ; Tue, 4 Apr 2023 05:36:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233184AbjDDFgl (ORCPT ); Tue, 4 Apr 2023 01:36:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232566AbjDDFgk (ORCPT ); Tue, 4 Apr 2023 01:36:40 -0400 Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C262C19A8 for ; Mon, 3 Apr 2023 22:36:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1680586599; x=1712122599; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=zINHbC/usNsuk082wrIK26y6e2wA1xg6pX6G62VaWkw=; b=LUiW4R6g37HRXF1hHLvS8Y3Eq6ByRl5aeeU13F5UlXOE2s0iWf80OEif Fo4kkcIClAI0QLimltZrK4+kRV4TnYEERQU3MDkf11I9F5WkxRK67dUlL 1Pt47LZ1u1Z9ED8W3kCHbrmN/ul8d2AA9Di1nJI5klccX2OW5bKddELZz B7Fty3UO5TQD0OZsfEafLoTEtv0k+Y/qj9rVvCp+ZvOyJDCgZ0b+Lavjx LArTJo8wRWSZCuaqVat0E3WdRQgDie/+sab0J5e0w57t73pJT8KJayfOC M7fciqpPBntf1+oTY0Ov6opU3Hks7RFnLFu5Emxh2T18yjNgC9kPhQhjG Q==; X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="340826304" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="340826304" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2023 22:36:38 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10669"; a="688760550" X-IronPort-AV: E=Sophos;i="5.98,316,1673942400"; d="scan'208";a="688760550" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga007.fm.intel.com with ESMTP; 03 Apr 2023 22:36:36 -0700 Received: by black.fi.intel.com (Postfix, from userid 1001) id 1470E14B; Tue, 4 Apr 2023 08:36:37 +0300 (EEST) From: Mika Westerberg To: "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Michael Jamet , Yehezkel Bernat , Andy Shevchenko , Mika Westerberg , netdev@vger.kernel.org Subject: [PATCH 2/2] net: thunderbolt: Fix typo in comment Date: Tue, 4 Apr 2023 08:36:36 +0300 Message-Id: <20230404053636.51597-3-mika.westerberg@linux.intel.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230404053636.51597-1-mika.westerberg@linux.intel.com> References: <20230404053636.51597-1-mika.westerberg@linux.intel.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Should be UDP not UPD. No functional changes. Signed-off-by: Mika Westerberg Reviewed-by: Simon Horman --- drivers/net/thunderbolt/main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/thunderbolt/main.c b/drivers/net/thunderbolt/main.c index 6a43ced74881..0ce501e34f3f 100644 --- a/drivers/net/thunderbolt/main.c +++ b/drivers/net/thunderbolt/main.c @@ -1030,7 +1030,7 @@ static bool tbnet_xmit_csum_and_map(struct tbnet *net, struct sk_buff *skb, /* Data points on the beginning of packet. * Check is the checksum absolute place in the packet. * ipcso will update IP checksum. - * tucso will update TCP/UPD checksum. + * tucso will update TCP/UDP checksum. */ if (protocol == htons(ETH_P_IP)) { __sum16 *ipcso = dest + ((void *)&(ip_hdr(skb)->check) - data);