From patchwork Tue Apr 4 08:46:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Zihao Wang X-Patchwork-Id: 13201217 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DA4D2C7619A for ; Wed, 5 Apr 2023 07:17:32 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id 29578208; Wed, 5 Apr 2023 09:16:40 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz 29578208 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1680679050; bh=Oq9s84jD2Laj3VuxTHu+m2JU5SEkzkZ7QLA+AD230Zg=; h=From:To:Subject:Date:CC:List-Id:List-Archive:List-Help:List-Owner: List-Post:List-Subscribe:List-Unsubscribe:From; b=l9bXA16SlH9zNtnuMY2jvsrIJX7rZwiN2mChS8TSV5cvRQxE6nWriXZZjRIc4fs6R ckysEK9ypM0sqjQrAS1IOfnzfrogMF/AtlBqEK67DBARCSFAcQfO5Sd0E3Mq8BJHtT EbQIewrgVPjlWcP0VMrPm/lUESlfivpLZ559uFd4= Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id EF37BF8024C; Wed, 5 Apr 2023 09:16:17 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id D6508F8024C; Tue, 4 Apr 2023 10:47:11 +0200 (CEST) Received: from hust.edu.cn (unknown [202.114.0.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id BDE62F80054 for ; Tue, 4 Apr 2023 10:47:02 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz BDE62F80054 Received: from localhost.localdomain ([10.12.176.39]) (user=u202012060@hust.edu.cn mech=LOGIN bits=0) by mx1.hust.edu.cn with ESMTP id 3348kqDV032411-3348kqDW032411 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 4 Apr 2023 16:46:57 +0800 From: Zihao Wang To: Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , Thierry Reding , Jonathan Hunter Subject: [PATCH] ASoC: tegra20_ac97: Add missing unwind goto in tegra20_ac97_platform_probe() Date: Tue, 4 Apr 2023 16:46:22 +0800 Message-Id: <20230404084622.1202-1-u202012060@hust.edu.cn> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-FEAS-AUTH-USER: u202012060@hust.edu.cn X-MailFrom: u202012060@hust.edu.cn X-Mailman-Rule-Hits: nonmember-moderation X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1 Message-ID-Hash: CDEE4MX3VH5KY2GNBVFGNUZA2NQKQ7V5 X-Message-ID-Hash: CDEE4MX3VH5KY2GNBVFGNUZA2NQKQ7V5 X-Mailman-Approved-At: Wed, 05 Apr 2023 07:13:24 +0000 CC: hust-os-kernel-patches@googlegroups.com, Zihao Wang , Dan Carpenter , alsa-devel@alsa-project.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Smatch Warns: sound/soc/tegra/tegra20_ac97.c:321 tegra20_ac97_platform_probe() warn: missing unwind goto? The goto will set the "soc_ac97_ops" and "soc_ac97_bus" operations to NULL. But they are already NULL at this point so it is a no-op. However, just for consistency, change the direct return to a goto. No functional change. Signed-off-by: Zihao Wang Reviewed-by: Dan Carpenter --- sound/soc/tegra/tegra20_ac97.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sound/soc/tegra/tegra20_ac97.c b/sound/soc/tegra/tegra20_ac97.c index d23d88a10899..d00449441e5e 100644 --- a/sound/soc/tegra/tegra20_ac97.c +++ b/sound/soc/tegra/tegra20_ac97.c @@ -318,7 +318,8 @@ static int tegra20_ac97_platform_probe(struct platform_device *pdev) ac97->reset = devm_reset_control_get_exclusive(&pdev->dev, "ac97"); if (IS_ERR(ac97->reset)) { dev_err(&pdev->dev, "Can't retrieve ac97 reset\n"); - return PTR_ERR(ac97->reset); + ret = PTR_ERR(ac97->reset); + goto err; } ac97->clk_ac97 = devm_clk_get(&pdev->dev, NULL);