From patchwork Thu Apr 6 12:54:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vladimir Oltean X-Patchwork-Id: 13203308 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DC939C7618D for ; Thu, 6 Apr 2023 13:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Zb3uySpx77y3aX5ruergWrYNfJusojpsGYbwaQb/K9E=; b=P5F2kASuJCqV6S rTzsTDyqulgKf1a72oN88O7Md81Z1jWHUDOHqGmv+s46oKbPd+7UN33S/r9YMyteQs6TpQXBzosU6 JgCspdVSoFFpLpo9nCv8X9oUNMvelAMxJLloWXWGDHtsx4nYP9R18NYMUPqpIbgeYZ9n6km5cp4xD LkkO2jkv0W1pUCKzai06VemrYUk2QuamauLBkhwe3gPAK1qZLdBxS5VTCiyLgp7KbqmiyVv3Qqr0/ 7R0Ysj+0FEguvNwlTfeW9ZSNx/XYGN/7t4kwnAO0ew5M3zmLObhGOL0D8xuBuhBHXZzDT/u+q6Kdf piI/UiaMxKMth+SmRHUg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkPMQ-007MC0-2c; Thu, 06 Apr 2023 13:09:06 +0000 Received: from mail-vi1eur04on0620.outbound.protection.outlook.com ([2a01:111:f400:fe0e::620] helo=EUR04-VI1-obe.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkPMO-007MBW-1x for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2023 13:09:05 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=S0iK6/Pa18XanQqYQhIwyI+EtY4Ka5TO72yhPTxYj+HtcaU8cs8hxrBuDNn7EIL8BKzOn910IdNIOzHmtmOaQ+FcyT5u/EMCLmy5ix7hC+s98QUrvs6sCgckXBY/bEnK710wthj1pUH9w+iLbaDFV1lEHnw7YARZOg56CBkRHlg9S7D74GbKdnsNkpltt66hZzKK2TftNWvV5fosePKvWIRfwdPWRkdZ6boAHdRkGAb+avO3t8O3flmw4nY5w83KBlHlzmiWdEcun6PNJB2wU/bQHiS4dTVQk7MllQQZ4f4h6qKP+i3dhQtT2wEIlAmUkTmVwoPc1qW+RRTDEaNotQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lnggLfUK1aetOJPiArlmCxjfN1eTCYhSJDWulsNRPd4=; b=oF4OgFiRztjeNxXMGW0dxm+UV8C/0UoP1mkdN48FpYTjpTRNZ5siVf8tejh4eSKKtbSvvo3Ja8M4Jp4mUiZV72ZfEbVDpZv6SSsyIqFpqdJyuaYR6jd6yLtVXw8E7jHz8vTtlWgXowvqNuTrLGdUA/4WNmhS+bGiF+i3RjI+xCM2WZ3JFBMCHfVyiiuyC4f7kS+3BkXbhbFUj8jH9SZsWODX3Jf4lhIwAcuhc7cgMBNQnwtQ8mhRETo3UJ5jIoLAvPPfFWJ8rlFBu/RioJhPz2Fh2vLDwM1ZubyKYek8ZysiER5BzPS0/noJqq+//hDHob7tJoTTQHEQjj+0JuPG2Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lnggLfUK1aetOJPiArlmCxjfN1eTCYhSJDWulsNRPd4=; b=C2m22m91dk/gs0EwsHmxT6JLm+LCLNJuz9WxKOud3/M70KmQRCOXFyjzs7PoUDjDVjx3MazZ4I1v0TXFXkk6O2yV49Faml7GAw9w0R8uNvxNpGuvY9w6+F5Fj4jkR4xOPa3nNJe3ln0K4w8p4kWwKgw7RIWsg8nK1X20mjEyLAU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DB8PR04MB6459.eurprd04.prod.outlook.com (2603:10a6:10:103::19) by AS8PR04MB8500.eurprd04.prod.outlook.com (2603:10a6:20b:343::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6277.30; Thu, 6 Apr 2023 12:54:30 +0000 Received: from DB8PR04MB6459.eurprd04.prod.outlook.com ([fe80::e555:cc9e:b278:15d9]) by DB8PR04MB6459.eurprd04.prod.outlook.com ([fe80::e555:cc9e:b278:15d9%7]) with mapi id 15.20.6254.035; Thu, 6 Apr 2023 12:54:30 +0000 From: Vladimir Oltean To: netdev@vger.kernel.org, Jakub Kicinski Cc: "David S. Miller" , Eric Dumazet , Paolo Abeni , Andrew Lunn , Florian Fainelli , Giuseppe Cavallaro , Alexandre Torgue , Jose Abreu , Maxime Coquelin , Heiner Kallweit , Russell King , linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH net-next] net: stmmac: remove set but unused mask in stmmac_ethtool_set_link_ksettings() Date: Thu, 6 Apr 2023 15:54:12 +0300 Message-Id: <20230406125412.48790-1-vladimir.oltean@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: FR2P281CA0099.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9c::9) To DB8PR04MB6459.eurprd04.prod.outlook.com (2603:10a6:10:103::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB8PR04MB6459:EE_|AS8PR04MB8500:EE_ X-MS-Office365-Filtering-Correlation-Id: 1f028e5a-4050-4703-7338-08db369e1010 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 8TXPyG+KigxHwN+zh0ewbf5ds0vjpVjD46eUDcl2SsRWbCS0TuOMnlyx+TQIy2bUFfNV092TVZ6dw9fiGn6L+zxx/V39lTv8qeRQAb8+dg9Wj5G6toOFAqzVTmVnjLNxssHxdFd0oR+vr5kIfMmOR+Ceh8XnPfQjFse9Pjx+pAHr3ViNTrG/TuuDX4zq5ppJw4HrstngbOiD+HKY+vGPmJ1uiNwyaZWb4NS/sUcK2858HdEAZOm6Be4fKe4F5p7PwRglpkSDvH7fKA44Zoh3k49Ib6OXZHxphUhN5U2aX7CzeTa3Ath1UE7KU4x83wtvYGE7R8nU2MW/WDgMDCiX3lWBtg1juTf+QU/waRlKxDdr0eW008OfUBSi2KKNyMBU4drr+o5hDZt+n6u16ycLtEzCmI2I5DkCB5PARk2CoLnlsZsK5AanfSW5mJkBQz/YQMTzq5HWL2IaBhyzMJxrn7HCHDI2xD0xIXuj5v0oSg0bmMYsShtNrKtyooDER3hDrPxKyVqcN45auPxC2OWjnlKGaVtDx3+tYTvfjSn4KO0lmP4SQfK9nbmlXIDIbDRW728tEOMt9FrikwAH8BJFbbg0oH6T0V1OjTT5SpOB04ZjWtaRINDpEQItrO7cGDMz X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR04MB6459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(366004)(136003)(346002)(451199021)(38100700002)(86362001)(36756003)(38350700002)(54906003)(6486002)(52116002)(478600001)(2616005)(186003)(6512007)(26005)(6506007)(1076003)(41300700001)(66476007)(66556008)(66946007)(5660300002)(316002)(4326008)(6916009)(7416002)(8936002)(83380400001)(6666004)(2906002)(44832011)(8676002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: PmKE66k0oYnlRd3Nlci7YDjfvzh73vpX2lNUwD/2rluwKlO1F+y5pfIFNyyKi201bRlPERdMQ2o6MX6tZySBYvrFovTLZTdnbVGzCnoi3CdA/G4h0CSoGMMh+y9wuWzyJZ9Pmq7VhCpOV1yRjWjoQtgmR20nr1etK2WqLmorUsZx5wRGzW7Uhu450Y9tKVG3sP8icvbHh+VayVKv8TG7fpdMzhnzp7IYlAUHHa21Z1hZYrIr9ylTXfoOqedbNhH/E/fzbCoTxgue0BYH7ISBcRwr75Qg1tDGfG2QJk54dd1XUcUfqAhCefrUxGWfxPXDZeQZaEjhurQpAEPFY6g/AeFPF6PbTFExs5jbFfVzHcdPdCwySnwRHB3pOGrNJ0rPTd9heQHEbM2DLk7fqqsLpfbJmXr4VFbyTL+4sLdq2TB8KC/2IF31jYidq1Zd1ngL+NyOsAn9SFcvIlVxMRqBOTwidTho/2oakk3rmZhT3kmnKnt4RbiruQgmTtPHvf6KnR6HBLnicfN0CA45QdoB47w98li1TH+PbhIsOEmeir4EAmrNyBNqmWJOO84BepoL1v+Lww3Sw7+1uv5LL3KZ3f1w7wGROkfwtnDiehOXgzXQqnZZTC689b+BYoXCiaTIXYscLX5izS64bNQUJL8DbDTJTi74r9rp8brJ/bAcCyZb37EYKuDkLf9z73T2tHA9hqwVM4i+GNRxhuWctHRPqA0Wtp5bUV1Qnz1jn818HRq3C51dJeLWGHPn/e7lQ6ke5/W+DxIUPFFKgS72lmVN7tvR2SNKx3QtwAkQo8B5Jru5AfL3ZI6vRzzZSyJFCz9JCAM3EpJxlXJ+WEfG7efDgmpP7rLEqSIvAX7o2d/5rxA3Amp/RWy0QGj9Ti36macKqBh+D/RAdYa51jHL/vk9+8VWIGO+JomB6GFakrLDGF8bBRDOGdmeGCTCmvJYW49wfmhejv+56bAH4wDy0pscAMU3qXlPE3fa4wpz3V/J8pIwu6syNiLD2uC0VImzgq5ULDuL64TMP0CpsyEezIa8QxH2O+dgLqM9kMN8Qo81Q12ZPX4F53pkZn8wFUKM9pN9jTF9Lzn1FzZXZw3v1yhNGxdaBq0UVkeYjlKq+oWKpmRxibOeAZbZcRlo67r5KdxpK3EFVwQTogNkp7O88fAN5e0jjReiWiB3xJLYPNdDIMt77N+WxJQvEGSo5W277N992U4XBuwxW40y6NRYXMryxwWex291HIv6J62nyMzaIRWAGyy1nJVXLA5m9LIb4jfJHX/q63K//11neHwB/++85WYjGV4Z2hFscISK19mzagnwfRS0kXo/e28jdQL5wIXLYIJHZefuF9mkLLQ0iaHcz+yfr99L99KoHVo2cewhnEEDKfDRCQfKvN4M2TNHvJ2DbftbOMzPV5eRiJcgmQnPaRItes/fRj59n+pNRT4r/SC/9NM13DAix0z4NHQP2X60c2AuDIOopLfk5J3eX5uArM8pDQ2TaLtRDok+/OfOVviGf2U8E1eQhNwhPN3oMtx6KDIJucSbYiCDk1+fCEZvUSnw9aboDDTTKfnnaO1fTXMItCRbTO6fsoQXx52SWcM1NW7GYH76Nr2vZprsAH2GCg== X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1f028e5a-4050-4703-7338-08db369e1010 X-MS-Exchange-CrossTenant-AuthSource: DB8PR04MB6459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Apr 2023 12:54:30.7783 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: HX8fKBsKhsX+daNVG9a8B6ftuI4wy885h01mbwhgvIlvNjllc9bjaoOzDCpU2lBl/lHls5fDHOvorfyVRoDI7Q== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS8PR04MB8500 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_060904_670133_CA6F0432 X-CRM114-Status: UNSURE ( 8.70 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This was never used since the commit that added it - e58bb43f5e43 ("stmmac: initial support to manage pcs modes"). Signed-off-by: Vladimir Oltean Reviewed-by: Simon Horman --- drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c index 35c8dd92d369..2ae73ab842d4 100644 --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c @@ -393,19 +393,10 @@ stmmac_ethtool_set_link_ksettings(struct net_device *dev, if (priv->hw->pcs & STMMAC_PCS_RGMII || priv->hw->pcs & STMMAC_PCS_SGMII) { - u32 mask = ADVERTISED_Autoneg | ADVERTISED_Pause; - /* Only support ANE */ if (cmd->base.autoneg != AUTONEG_ENABLE) return -EINVAL; - mask &= (ADVERTISED_1000baseT_Half | - ADVERTISED_1000baseT_Full | - ADVERTISED_100baseT_Half | - ADVERTISED_100baseT_Full | - ADVERTISED_10baseT_Half | - ADVERTISED_10baseT_Full); - mutex_lock(&priv->lock); stmmac_pcs_ctrl_ane(priv, priv->ioaddr, 1, priv->hw->ps, 0); mutex_unlock(&priv->lock);