From patchwork Thu Apr 6 18:44:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13203851 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D9D57C76196 for ; Thu, 6 Apr 2023 18:45:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=a2EV3isLZQclus5xtiwB5abPyWNamCCTB+1F0aU5YDI=; b=ClZvSllrROLr+o F+ntNFQPNg03CgWGKZygqnBqldOMYJR/GHwO3RYkXT7njawzLALppSWReV9OLWXeiF46P/j2gbgY4 jQ0p15P8KxwEzk+Lo0pv2NFhTXB+ZmbfQpFUqCFKbHCy7HBt3PCYBbJmypB9vA454eVllE66X/EmX b1flVuS+XGfgAI6MrjNNVjKIx9R46fvs+pYTPxjbxf5vhMxzt9K8bzmB2XoI0gfY1iOLSLhKzhoyv oe35dVMmB/i429ar4Houmfy0M+D6kvXSUv6eo5NN+PBrni9xHsNCTuxyk9dT9dF6/Bxv2V8XzD/FY WV91I+rBsqFAre9TLCfg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pkUai-008I4m-1N; Thu, 06 Apr 2023 18:44:12 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pkUaf-008I43-0b for linux-arm-kernel@lists.infradead.org; Thu, 06 Apr 2023 18:44:10 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680806647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=KuWqlFWscCHky7PklpK8/27+L+0fHpmQONWaBu1fu8I=; b=NdkoF3ycB6oGqkb8DFctBc/BSVYIk14/yhVBLlz4/mcdaLCrJHYq4s8CXglxKYl/9S8DA9 MKt3DbanqbZCIweQqF/43W+p2B6ugm6g18WaHPSQeMtKOKzFpA+Itc0567DdYxkZhpkg7i tf7Nd9UsDFBMEAZUWbGzsVOJB2ORk7I= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-379-v342D49aNtyfGXppCUE0sg-1; Thu, 06 Apr 2023 14:44:06 -0400 X-MC-Unique: v342D49aNtyfGXppCUE0sg-1 Received: by mail-qt1-f198.google.com with SMTP id c14-20020ac87d8e000000b003e38726ec8bso27288588qtd.23 for ; Thu, 06 Apr 2023 11:44:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680806646; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=KuWqlFWscCHky7PklpK8/27+L+0fHpmQONWaBu1fu8I=; b=vH9/o2V9a13JmqYxTkoZCZFT5zyibAlwrJ5dEjvAWkJGFVXLMeEp5nu6xmyhrko3+L mEbW35i5sQSHdG166YP8i0XGqgED1L2zzcJATu9WUebcdB7GxvULUpTEoM/Dys+JGWwT iGm+oVPZ6VZDWeeqxAsv2ly4gme5Mjpz7NiEy6VRNjvr+XXw3gbFSwtXzDrGkaxXFv/E 9pr12aBu81+Ue8wQCWQb5isOf/La0BWBYFIxjz6CWy1MIo6RYENjHn1HEJTv6vj59IJv WjtJ4t7ocba0X1CP7MEVmDVfnVWAZVbrbRL5gPvA+10Yz7dNvl/iS9BreePXfXA2aPdc 1oSw== X-Gm-Message-State: AAQBX9emPcjC0fKhBEEo6bjfOIelFUp0uHWw1eRlBLs5ipBOWqYeIDp7 vBdYb+4g50nzry6uzD2UYwWnUeoNjJgSN4rLwraM01G8E+fl9HiVBKieTWh0XBdmpvfGklAlXJV 1OgFCEkmnzMwLPc8stH5rmqNbYdRhDnTMqlg= X-Received: by 2002:a05:6214:e43:b0:56f:728:19d4 with SMTP id o3-20020a0562140e4300b0056f072819d4mr395407qvc.26.1680806645963; Thu, 06 Apr 2023 11:44:05 -0700 (PDT) X-Google-Smtp-Source: AKy350b2ByVQmJQEcdujhQzaXx6wnS67JdUovCAIB/18ORCzUQZUmTu9kF7vDna0IuEg2GJV05SvOw== X-Received: by 2002:a05:6214:e43:b0:56f:728:19d4 with SMTP id o3-20020a0562140e4300b0056f072819d4mr395378qvc.26.1680806645607; Thu, 06 Apr 2023 11:44:05 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id c79-20020ae9ed52000000b0074411b03972sm668481qkg.51.2023.04.06.11.44.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 11:44:05 -0700 (PDT) From: Tom Rix To: marcan@marcan.st, sven@svenpeter.dev, alyssa@rosenzweig.io, p.zabel@pengutronix.de Cc: asahi@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] soc: apple: apple-pmgr-pwrstate: set varaiable apple_pmgr_reset_ops storage-class-specifier to static Date: Thu, 6 Apr 2023 14:44:02 -0400 Message-Id: <20230406184402.1956429-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230406_114409_298659_29D0E2F5 X-CRM114-Status: GOOD ( 11.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org smatch reports drivers/soc/apple/apple-pmgr-pwrstate.c:180:32: warning: symbol 'apple_pmgr_reset_ops' was not declared. Should it be static? This variable is only used in one file so should be static. Signed-off-by: Tom Rix --- drivers/soc/apple/apple-pmgr-pwrstate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/soc/apple/apple-pmgr-pwrstate.c b/drivers/soc/apple/apple-pmgr-pwrstate.c index a3e2bc1d2686..e456f6e04658 100644 --- a/drivers/soc/apple/apple-pmgr-pwrstate.c +++ b/drivers/soc/apple/apple-pmgr-pwrstate.c @@ -177,7 +177,7 @@ static int apple_pmgr_reset_status(struct reset_controller_dev *rcdev, unsigned return !!(reg & APPLE_PMGR_RESET); } -const struct reset_control_ops apple_pmgr_reset_ops = { +static const struct reset_control_ops apple_pmgr_reset_ops = { .assert = apple_pmgr_reset_assert, .deassert = apple_pmgr_reset_deassert, .reset = apple_pmgr_reset_reset,