From patchwork Sat Apr 8 16:50:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13205787 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D8F2BC7619A for ; Sat, 8 Apr 2023 16:50:33 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5010710E15C; Sat, 8 Apr 2023 16:50:32 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id E5B1510E12C for ; Sat, 8 Apr 2023 16:50:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680972630; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=qy6SYd3f0i8ho8eow+vyxJgxXrM08wU7g/SGD1LI0yQ=; b=i1Gx6z0jy16VyqEUyKRFEYmd9wPWBp0MM3rjsYHxAUbDE8suZf9FnMrA/Gtli4K6hK0w1a BikDCdXGiFGWXclHQK71JzLbOS5OAQ615Rlz6MlZFezFB5GkwPfwaEKpGPzBCeTaLOJJeS l4jOPIKBcZUR4ybc8/257vuVzVW/Uco= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-55-Q-8cJqOUM_qEdJDBzCGuzQ-1; Sat, 08 Apr 2023 12:50:26 -0400 X-MC-Unique: Q-8cJqOUM_qEdJDBzCGuzQ-1 Received: by mail-qv1-f70.google.com with SMTP id f6-20020a0cc306000000b005a676b725a2so804709qvi.18 for ; Sat, 08 Apr 2023 09:50:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680972626; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qy6SYd3f0i8ho8eow+vyxJgxXrM08wU7g/SGD1LI0yQ=; b=hC/l1xPmYKcHxiengGvjre3B0awJI98vqE2CSGQCXw7NTtI7uSZM3X6RjP6ZbxrUF/ xVlLaS9enTVeEkGItrZCfbfbWkYp6q3QeUz1mbcxNQAXilJmhkY3S7Zo/KhgHf0ysw9k QUCnqjWtY1B5qty3JWD9zWZYvLSrIbrI4hxq5OXCizwfObTdjrV0Ujfaz7GhMpzXhLX0 prRr6VSA8eczf4xS7Fot6pFFWPw33hceqnLfuYYsnXSTkDAIMFef9Hu0TK3ET4V4A0K8 6tGW+vC5jdJJ8b9yefAt8FKQ7ARI2kfmrxkoQFkTH85lrYAb4qzYOwQ+YCbfEg9O/PB3 JWrg== X-Gm-Message-State: AAQBX9cHWfSfDEKtF6Ewi9O+VvZyLOr0uet1ZoAqcyfrU4K/LfLF7+7B a3CDYYyurEqCPrxueDix2GaPHkNMn9xa8dzu4dcJoDWUlFVsj10e0w+j8Oq1eZcTQSPJyVxn8Zg f+LGFgq0f4Pv7Tty+OI4OieGSvoYu X-Received: by 2002:a05:622a:15c3:b0:3e1:b06d:e9e1 with SMTP id d3-20020a05622a15c300b003e1b06de9e1mr3842264qty.57.1680972626213; Sat, 08 Apr 2023 09:50:26 -0700 (PDT) X-Google-Smtp-Source: AKy350a46s9y+/itqppzPjf57cV1ZevRRKIKzqVvsO1UIrG/xBtSg7j5IKxAIQvMkkT/GV64uTG74Q== X-Received: by 2002:a05:622a:15c3:b0:3e1:b06d:e9e1 with SMTP id d3-20020a05622a15c300b003e1b06de9e1mr3842236qty.57.1680972625999; Sat, 08 Apr 2023 09:50:25 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id s128-20020a372c86000000b0074688c36facsm2113865qkh.56.2023.04.08.09.50.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 09:50:25 -0700 (PDT) From: Tom Rix To: airlied@redhat.com, kraxel@redhat.com, airlied@gmail.com, daniel@ffwll.ch, nathan@kernel.org, ndesaulniers@google.com Subject: [PATCH] drm/qxl: remove variable count Date: Sat, 8 Apr 2023 12:50:23 -0400 Message-Id: <20230408165023.2706235-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Rix , llvm@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org, spice-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" clang with W=1 reports drivers/gpu/drm/qxl/qxl_cmd.c:424:6: error: variable 'count' set but not used [-Werror,-Wunused-but-set-variable] int count = 0; ^ This variable is not used so remove it. Signed-off-by: Tom Rix Reviewed-by: Nick Desaulniers --- drivers/gpu/drm/qxl/qxl_cmd.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/qxl/qxl_cmd.c b/drivers/gpu/drm/qxl/qxl_cmd.c index 281edab518cd..d6ea01f3797b 100644 --- a/drivers/gpu/drm/qxl/qxl_cmd.c +++ b/drivers/gpu/drm/qxl/qxl_cmd.c @@ -421,7 +421,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev, { uint32_t handle; int idr_ret; - int count = 0; again: idr_preload(GFP_ATOMIC); spin_lock(&qdev->surf_id_idr_lock); @@ -433,7 +432,6 @@ int qxl_surface_id_alloc(struct qxl_device *qdev, handle = idr_ret; if (handle >= qdev->rom->n_surfaces) { - count++; spin_lock(&qdev->surf_id_idr_lock); idr_remove(&qdev->surf_id_idr, handle); spin_unlock(&qdev->surf_id_idr_lock);