From patchwork Mon Apr 10 13:43:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yicong Yang X-Patchwork-Id: 13206381 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 570B3C77B73 for ; Mon, 10 Apr 2023 13:44:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ED373280021; Mon, 10 Apr 2023 09:44:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E846728001E; Mon, 10 Apr 2023 09:44:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D7249280021; Mon, 10 Apr 2023 09:44:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id C455728001E for ; Mon, 10 Apr 2023 09:44:50 -0400 (EDT) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 963DD4096A for ; Mon, 10 Apr 2023 13:44:50 +0000 (UTC) X-FDA: 80665601940.20.F0FF742 Received: from szxga08-in.huawei.com (szxga08-in.huawei.com [45.249.212.255]) by imf13.hostedemail.com (Postfix) with ESMTP id 65C6B20002 for ; Mon, 10 Apr 2023 13:44:46 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of yangyicong@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=yangyicong@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681134288; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BqwRMurKIGASGsYSlaF3zQFZVl0kqUg8iBL98CC2Co8=; b=wkCs1nN8eLoGDWVdXPb0xrNH0kfv5wtFXI/gDCPa5etERwF1JaKo3a02FT6tS1SSs4FZS+ pA6TE/t0GM3nIYZd3FgVoDcsCVpOhocgUuMM4A2mBAP/VspvEWWgaAM2pT3Uqga+2WoAlo vKixgR+LhrVBO7P+5wk4BoEHZuQ+A4s= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf13.hostedemail.com: domain of yangyicong@huawei.com designates 45.249.212.255 as permitted sender) smtp.mailfrom=yangyicong@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681134288; a=rsa-sha256; cv=none; b=WdPApPjQpyFu7S5rNDacp90t4sAEJNaT58t5b2XfCnTAamWnTok5e0Yb8RPcmhkZlm0UbH c5lRopi25V1RyHgoEKgjtVBCEllP0KB0TZlo0Zp/N8f+RNIBGIpq3aEniYf2CmyPB15n6H 72Se5WIG8Ep1PGwTkI1ky1J0TD4iAck= Received: from canpemm500009.china.huawei.com (unknown [172.30.72.56]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4Pw99M0wYdz17RLS; Mon, 10 Apr 2023 21:41:11 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 10 Apr 2023 21:44:42 +0800 From: Yicong Yang To: , , , , , , , CC: , , , , , , , , , , , , , , , , , Barry Song <21cnbao@gmail.com>, , , , , Anshuman Khandual , Barry Song Subject: [PATCH v9 1/2] mm/tlbbatch: Introduce arch_tlbbatch_should_defer() Date: Mon, 10 Apr 2023 21:43:51 +0800 Message-ID: <20230410134352.4519-2-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230410134352.4519-1-yangyicong@huawei.com> References: <20230410134352.4519-1-yangyicong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 65C6B20002 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: 6p9asjar57gstgsahxkzz4cqp7na5dab X-HE-Tag: 1681134286-410806 X-HE-Meta: U2FsdGVkX1+YKjzz6oxjUtqeXnbR4jknE76+qnVT6MIDJbifOLW0qa4Rc5ZPL6B/tH7vr8Lo4c2uLt7IJ6HZaxUN1zu7rxcZAT+gehrKc2BLS3CXmrGhPC0APYjh2PUMXwuW7IBCCEV+AUXjJBnY1HlEbXKiNLllKzCHh7op5d9cLr0/bPRx4nvRGeOd5k39XTdhxEhoF8YKU2gGFgtoHviUj+KvYVTpf/DEOHHBSU6oVTMdqPiXpQwn5uYn6WgUFbu/0kO/j6LxpBn6SYm1gVXxP0cyugDVqzFBU+8QK/DRFt7EDeCtCLsqfn+JxB+LzSmdZhF5X3eyl2qcwlEEnRw4RjyhI/4dpBUrVur7e8OhAGVgXKjWyHlhjFzwTQugXoEvc8NDsBY8hS/45luxXd2ukP9Omkj3OEEMiTXCYnHUzNgo7r0F4WnTHqQe0zw2KWctWDjjVHloGR7BI92ij15fOv1aZvfc38k0cNUMfVYbpq+7zqWASHFxHF287WJ4ohDUJKrtwCY9/DsVZp+sQLn/DSqah7ULrJTYnpGM7cELP0wdRCr8opXpjeqRX/Ks08dmW49wPyG1X/OrdFeNPForMrtFLqTLEerbPSAsR3MAFdPV3pAhuQ5CBslAb2qsOKAdnzI4eRuN65cE+MpsQHOy1MzccrbehMU4IQSm+/4sPFgiqH2PdVs9HAenHWUyzyGV1jC4nAXwT1QIU0qNJLBvj4VZuwAjQic4tiMHYBxPuX/+itqySrypc4xedqvdAQrFFRoOygJDj2+Vo8668oqFzpQxhuNm8botraEKNjocSpz1XKWxF04oZZDbWEkFSeILlDalrQ4gnXf0WGZ+tUiA65eXG05s4B+v7soMqlS5Rtb1/BxxnGbF+Zs49sjvfTn4+KNdWaGDVMOQlIS0/2Ka0o6Fkr5eiFF6v3UmijF98CRB79p9Ne033bMOx3VHE6aFKHs44YxqfRM395X Lq0lGqMC AB4sCTN1rvEcXFee/h+GfKUIqdT1MBfVqq7zKXamhwVeoiW1yVIIQAEnCcxHrvEuZ4vlDPeK4LffXfI1W58CFZshVEzkLyZsMfzvdkM0yMkBrv32lj9hVqRoPPnqG3RsThDFFPU6sm+d8LwI9poBhN9kH6XLHExDhrUGZiKyHA/YaZxxjSntph8BXQNRTN/r6ySh3TlO/LyepqKXt7Cz3YjGbU/QsM9BJXhLOpIHL2YwNC6WwI3vSwFsLQgfJrZT73jbgwRPnRbQo4EWqe0DFmgmesHthe1zF5h4vgl/jhy57vkikRHG8Dl7EHZTDTYGwuKo1fyeB3Wt4/UypaqAARV+y2vZAbHme8vVa6O52yaTMkjQ0796eVgg38rsgOiGVHkMqbVAc5xD48n2ojTOCaZlMg2PkYPo6D6jsjJaS6TqoRQd/J5Yrw48es+pvL5rSdlR9GFrieQQtOjWavQNFWyCwCrvdTjQVPZly/WnrPIVaND0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Anshuman Khandual The entire scheme of deferred TLB flush in reclaim path rests on the fact that the cost to refill TLB entries is less than flushing out individual entries by sending IPI to remote CPUs. But architecture can have different ways to evaluate that. Hence apart from checking TTU_BATCH_FLUSH in the TTU flags, rest of the decision should be architecture specific. Signed-off-by: Anshuman Khandual [https://lore.kernel.org/linuxppc-dev/20171101101735.2318-2-khandual@linux.vnet.ibm.com/] Signed-off-by: Yicong Yang [Rebase and fix incorrect return value type] Reviewed-by: Kefeng Wang Reviewed-by: Anshuman Khandual Reviewed-by: Barry Song Reviewed-by: Xin Hao Tested-by: Punit Agrawal --- arch/x86/include/asm/tlbflush.h | 12 ++++++++++++ mm/rmap.c | 9 +-------- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h index cda3118f3b27..8a497d902c16 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h @@ -240,6 +240,18 @@ static inline void flush_tlb_page(struct vm_area_struct *vma, unsigned long a) flush_tlb_mm_range(vma->vm_mm, a, a + PAGE_SIZE, PAGE_SHIFT, false); } +static inline bool arch_tlbbatch_should_defer(struct mm_struct *mm) +{ + bool should_defer = false; + + /* If remote CPUs need to be flushed then defer batch the flush */ + if (cpumask_any_but(mm_cpumask(mm), get_cpu()) < nr_cpu_ids) + should_defer = true; + put_cpu(); + + return should_defer; +} + static inline u64 inc_mm_tlb_gen(struct mm_struct *mm) { /* diff --git a/mm/rmap.c b/mm/rmap.c index 8632e02661ac..38ccb700748c 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -686,17 +686,10 @@ static void set_tlb_ubc_flush_pending(struct mm_struct *mm, bool writable) */ static bool should_defer_flush(struct mm_struct *mm, enum ttu_flags flags) { - bool should_defer = false; - if (!(flags & TTU_BATCH_FLUSH)) return false; - /* If remote CPUs need to be flushed then defer batch the flush */ - if (cpumask_any_but(mm_cpumask(mm), get_cpu()) < nr_cpu_ids) - should_defer = true; - put_cpu(); - - return should_defer; + return arch_tlbbatch_should_defer(mm); } /* From patchwork Mon Apr 10 13:43:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Yicong Yang X-Patchwork-Id: 13206382 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66CE7C77B70 for ; Mon, 10 Apr 2023 13:44:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 00675280022; Mon, 10 Apr 2023 09:44:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id EFA2028001E; Mon, 10 Apr 2023 09:44:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D9A11280022; Mon, 10 Apr 2023 09:44:52 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id C6D4B28001E for ; Mon, 10 Apr 2023 09:44:52 -0400 (EDT) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 7B85A160299 for ; Mon, 10 Apr 2023 13:44:52 +0000 (UTC) X-FDA: 80665602024.04.0FA0664 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf22.hostedemail.com (Postfix) with ESMTP id CC993C000E for ; Mon, 10 Apr 2023 13:44:49 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of yangyicong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yangyicong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1681134290; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=k2xesJD6d17M7ucAdZsUhVWjv60eskVq861P1d1JtEk=; b=Gdk7G48eQdGWInmsaN9xK9dORWXkE5yMMnroJXa/Dw2kIKKzE8tqJrBMyI8lEOFx0bHmVi sa1M9x3nOi/MiHKtGSknH1hEwl2VZEtVf2JkP/4q1uf0063CvLBUeZEdVdhUA7AiGtEiXa rsxtWbF6r1XQzILavLc4PI/X3u942P0= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; spf=pass (imf22.hostedemail.com: domain of yangyicong@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=yangyicong@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1681134290; a=rsa-sha256; cv=none; b=OZka0MDY/GRNJoGV8DVwYukoZ9sEutSoYGUuIFKFD/wmU1NK37GbuOSjAlGVoqEIqwRC0b A1LUHUAP723pdo2HI+aNYMS5puWTSJZsDgTw6+psBS+M8vyCaES03dlAr34qJrijHuVY2t AsjZimz/XrcqNHWjmaMG22EToaIfMqg= Received: from canpemm500009.china.huawei.com (unknown [172.30.72.55]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4Pw9BV17wjzKxPx; Mon, 10 Apr 2023 21:42:10 +0800 (CST) Received: from localhost.localdomain (10.50.163.32) by canpemm500009.china.huawei.com (7.192.105.203) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.23; Mon, 10 Apr 2023 21:44:43 +0800 From: Yicong Yang To: , , , , , , , CC: , , , , , , , , , , , , , , , , , Barry Song <21cnbao@gmail.com>, , , , , Barry Song , Nadav Amit , Mel Gorman Subject: [PATCH v9 2/2] arm64: support batched/deferred tlb shootdown during page reclamation/migration Date: Mon, 10 Apr 2023 21:43:52 +0800 Message-ID: <20230410134352.4519-3-yangyicong@huawei.com> X-Mailer: git-send-email 2.31.0 In-Reply-To: <20230410134352.4519-1-yangyicong@huawei.com> References: <20230410134352.4519-1-yangyicong@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.50.163.32] X-ClientProxiedBy: dggems706-chm.china.huawei.com (10.3.19.183) To canpemm500009.china.huawei.com (7.192.105.203) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: ujsiohribqt76tkfirbq4ribaq7hnp77 X-Rspamd-Queue-Id: CC993C000E X-HE-Tag: 1681134289-200533 X-HE-Meta: U2FsdGVkX19kB6TtEeJEc9wLSVI0CDcsPfO7tgfLq48dSSFHk7RzMj2BFd/ygyy4iXX53oWTiHEO+tp7O4NBTztEh5bPiZzimxAK6BYQUViT4FId7JhQUk7F2QdSFEDOdgszBKqIJKo5TEFi39yKe36PGPY9Gy2jI6SOR4tNlLL4CnWUetAxQqchlnYiP0Ei+blo8VV6+HdnloHuJXSNfYHNShCjRDdG7oqd0NODFrglZTYEBCHdkhduyOYUjeQ6amqMoOx9Z2C99vsu9+C7SWloNG+htbcHdb7E+Or7yNXTyxOUFGVoYpCsh8R5Jm5IMjKC3vNYl9jAoNnhI12RajYwLL2Yd0i4mB95cQgfmukURSyBtNXmGnpcOhxAJ/LXAGzQF5jfdAsmKxpMZXPR6w+4mR8CMUeccep3ne61CTykTTGH5j17hd28hvHy/WAcULkENCP+luRCa3+s8ZoEtGuVTy+3leMe56epWN+QApAl5h2tBJa7QFhYV1yBbGJ/lCuUAB1iNB45OYqMh6l0Brm9L/SVGCrGSaJZ/tRNYbVlF1lxlS3QVkZryXBLuUD84EBKzxWe8vjoCmUBhjMH6G1SD/2IX5gA9kVXNbFyn8DxU76JWdgktA8QnOJVzX3UbN+/CDY7kHanJhLRUpbcSDf9D38XyOceGuZQfAiCQOE90VpitTKhIN2KZS3QTxGVMTQSm0r9i7bvblTjmyZpsoOUP3W4vkN43oFoUuPelEyW8uSg+R8Nh+bl0naGWg5rTBjeMKoAKBXUsuT7tnnI3uqRAwWT3dwI3b/etarNuApD0zTj5Y5Wgt3lBUzTouM0si/jQJ1guy2vVxPqULVmVr2DVv+gwO+PUZbalBshiHpMiwvc77TGrKs2Drqp998fNXRJXjgk26rjMoBzmHBGVor1iVXjJ0QtLwzQ5gDi6qZxp6c5qkHH1I7EkLsxiq8MkTWajX+sarhhNDCD9Vv lmJ/LytY CFHXx9xXANuFNVx2EkIXU9B70RPBQur+nnS13gHMB8ACCIXwHKsI/p8dwat+Hhogpevg3YafyHda+d7MTTY9F2Oohi9NnUiTqPfy/iQcfdP/cD1XJ9teWc5q9cpwIad3hmXCQWHC9I7zOXJqPGRuN9536U4FUCZZ7TSuwoB7pLK50E6SfEfC3KCWZgNgzDfWsVHuFZumF02fvI76syFoQbReuHJpm4vWjoE12sZevTr+z2uVoNUN4kwwlhAwetzVSHeVtHJhv+C8Huw0zZOTaG37lmfwxoHG56ac/cu5RYhMoV61GECAYTp3QRnqQsNOKV9KAQ64a9qfCCC713hkaaxwbaWRmHpX4JofFxnHtgT2ulXyz0UGA/uyQno9kHfCbUTRrh8xN9leiXyN3grU8Pk3fqJeuVD/pa0Lt3clnnuBH05fukLPWqcvPfPAjMyA4LUE9VUQdjAa14vIoXADAu3ejK2uJoS+L1G60oZRcrj+POfzuSs3/HSEiRbPzeKA3odk8 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Barry Song on x86, batched and deferred tlb shootdown has lead to 90% performance increase on tlb shootdown. on arm64, HW can do tlb shootdown without software IPI. But sync tlbi is still quite expensive. Even running a simplest program which requires swapout can prove this is true, #include #include #include #include int main() { #define SIZE (1 * 1024 * 1024) volatile unsigned char *p = mmap(NULL, SIZE, PROT_READ | PROT_WRITE, MAP_SHARED | MAP_ANONYMOUS, -1, 0); memset(p, 0x88, SIZE); for (int k = 0; k < 10000; k++) { /* swap in */ for (int i = 0; i < SIZE; i += 4096) { (void)p[i]; } /* swap out */ madvise(p, SIZE, MADV_PAGEOUT); } } Perf result on snapdragon 888 with 8 cores by using zRAM as the swap block device. ~ # perf record taskset -c 4 ./a.out [ perf record: Woken up 10 times to write data ] [ perf record: Captured and wrote 2.297 MB perf.data (60084 samples) ] ~ # perf report # To display the perf.data header info, please use --header/--header-only options. # To display the perf.data header info, please use --header/--header-only options. # # # Total Lost Samples: 0 # # Samples: 60K of event 'cycles' # Event count (approx.): 35706225414 # # Overhead Command Shared Object Symbol # ........ ....... ................. ............................................................................. # 21.07% a.out [kernel.kallsyms] [k] _raw_spin_unlock_irq 8.23% a.out [kernel.kallsyms] [k] _raw_spin_unlock_irqrestore 6.67% a.out [kernel.kallsyms] [k] filemap_map_pages 6.16% a.out [kernel.kallsyms] [k] __zram_bvec_write 5.36% a.out [kernel.kallsyms] [k] ptep_clear_flush 3.71% a.out [kernel.kallsyms] [k] _raw_spin_lock 3.49% a.out [kernel.kallsyms] [k] memset64 1.63% a.out [kernel.kallsyms] [k] clear_page 1.42% a.out [kernel.kallsyms] [k] _raw_spin_unlock 1.26% a.out [kernel.kallsyms] [k] mod_zone_state.llvm.8525150236079521930 1.23% a.out [kernel.kallsyms] [k] xas_load 1.15% a.out [kernel.kallsyms] [k] zram_slot_lock ptep_clear_flush() takes 5.36% CPU in the micro-benchmark swapping in/out a page mapped by only one process. If the page is mapped by multiple processes, typically, like more than 100 on a phone, the overhead would be much higher as we have to run tlb flush 100 times for one single page. Plus, tlb flush overhead will increase with the number of CPU cores due to the bad scalability of tlb shootdown in HW, so those ARM64 servers should expect much higher overhead. Further perf annonate shows 95% cpu time of ptep_clear_flush is actually used by the final dsb() to wait for the completion of tlb flush. This provides us a very good chance to leverage the existing batched tlb in kernel. The minimum modification is that we only send async tlbi in the first stage and we send dsb while we have to sync in the second stage. With the above simplest micro benchmark, collapsed time to finish the program decreases around 5%. Typical collapsed time w/o patch: ~ # time taskset -c 4 ./a.out 0.21user 14.34system 0:14.69elapsed w/ patch: ~ # time taskset -c 4 ./a.out 0.22user 13.45system 0:13.80elapsed Also, Yicong Yang added the following observation. Tested with benchmark in the commit on Kunpeng920 arm64 server, observed an improvement around 12.5% with command `time ./swap_bench`. w/o w/ real 0m13.460s 0m11.771s user 0m0.248s 0m0.279s sys 0m12.039s 0m11.458s Originally it's noticed a 16.99% overhead of ptep_clear_flush() which has been eliminated by this patch: [root@localhost yang]# perf record -- ./swap_bench && perf report [...] 16.99% swap_bench [kernel.kallsyms] [k] ptep_clear_flush It is tested on 4,8,128 CPU platforms and shows to be beneficial on large systems but may not have improvement on small systems like on a 4 CPU platform. So make ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH depends on CONFIG_EXPERT for this stage and add a runtime tunable to allow to disable it according to the scenario. Also this patch improve the performance of page migration. Using pmbench and tries to migrate the pages of pmbench between node 0 and node 1 for 20 times, this patch decrease the time used more than 50% and saved the time used by ptep_clear_flush(). This patch extends arch_tlbbatch_add_mm() to take an address of the target page to support the feature on arm64. Also rename it to arch_tlbbatch_add_pending() to better match its function since we don't need to handle the mm on arm64 and add_mm is not proper. add_pending will make sense to both as on x86 we're pending the TLB flush operations while on arm64 we're pending the synchronize operations. Cc: Anshuman Khandual Cc: Jonathan Corbet Cc: Nadav Amit Cc: Mel Gorman Tested-by: Yicong Yang Tested-by: Xin Hao Tested-by: Punit Agrawal Signed-off-by: Barry Song Signed-off-by: Yicong Yang Reviewed-by: Kefeng Wang Reviewed-by: Xin Hao Reviewed-by: Anshuman Khandual --- .../features/vm/TLB/arch-support.txt | 2 +- arch/arm64/Kconfig | 1 + arch/arm64/include/asm/tlbbatch.h | 12 ++++ arch/arm64/include/asm/tlbflush.h | 33 ++++++++- arch/arm64/mm/flush.c | 69 +++++++++++++++++++ arch/x86/include/asm/tlbflush.h | 5 +- include/linux/mm_types_task.h | 4 +- mm/rmap.c | 12 ++-- 8 files changed, 126 insertions(+), 12 deletions(-) create mode 100644 arch/arm64/include/asm/tlbbatch.h diff --git a/Documentation/features/vm/TLB/arch-support.txt b/Documentation/features/vm/TLB/arch-support.txt index 7f049c251a79..76208db88f3b 100644 --- a/Documentation/features/vm/TLB/arch-support.txt +++ b/Documentation/features/vm/TLB/arch-support.txt @@ -9,7 +9,7 @@ | alpha: | TODO | | arc: | TODO | | arm: | TODO | - | arm64: | N/A | + | arm64: | ok | | csky: | TODO | | hexagon: | TODO | | ia64: | TODO | diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index 1023e896d46b..e6a6b34acb83 100644 --- a/arch/arm64/Kconfig +++ b/arch/arm64/Kconfig @@ -95,6 +95,7 @@ config ARM64 select ARCH_SUPPORTS_INT128 if CC_HAS_INT128 select ARCH_SUPPORTS_NUMA_BALANCING select ARCH_SUPPORTS_PAGE_TABLE_CHECK + select ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH if EXPERT select ARCH_WANT_COMPAT_IPC_PARSE_VERSION if COMPAT select ARCH_WANT_DEFAULT_BPF_JIT select ARCH_WANT_DEFAULT_TOPDOWN_MMAP_LAYOUT diff --git a/arch/arm64/include/asm/tlbbatch.h b/arch/arm64/include/asm/tlbbatch.h new file mode 100644 index 000000000000..fedb0b87b8db --- /dev/null +++ b/arch/arm64/include/asm/tlbbatch.h @@ -0,0 +1,12 @@ +/* SPDX-License-Identifier: GPL-2.0 */ +#ifndef _ARCH_ARM64_TLBBATCH_H +#define _ARCH_ARM64_TLBBATCH_H + +struct arch_tlbflush_unmap_batch { + /* + * For arm64, HW can do tlb shootdown, so we don't + * need to record cpumask for sending IPI + */ +}; + +#endif /* _ARCH_ARM64_TLBBATCH_H */ diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h index 412a3b9a3c25..8041905e26b9 100644 --- a/arch/arm64/include/asm/tlbflush.h +++ b/arch/arm64/include/asm/tlbflush.h @@ -254,17 +254,23 @@ static inline void flush_tlb_mm(struct mm_struct *mm) dsb(ish); } -static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, +static inline void __flush_tlb_page_nosync(struct mm_struct *mm, unsigned long uaddr) { unsigned long addr; dsb(ishst); - addr = __TLBI_VADDR(uaddr, ASID(vma->vm_mm)); + addr = __TLBI_VADDR(uaddr, ASID(mm)); __tlbi(vale1is, addr); __tlbi_user(vale1is, addr); } +static inline void flush_tlb_page_nosync(struct vm_area_struct *vma, + unsigned long uaddr) +{ + return __flush_tlb_page_nosync(vma->vm_mm, uaddr); +} + static inline void flush_tlb_page(struct vm_area_struct *vma, unsigned long uaddr) { @@ -272,6 +278,29 @@ static inline void flush_tlb_page(struct vm_area_struct *vma, dsb(ish); } +#ifdef CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH + +extern struct static_key_false batched_tlb_enabled; + +static inline bool arch_tlbbatch_should_defer(struct mm_struct *mm) +{ + return static_branch_likely(&batched_tlb_enabled); +} + +static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, + struct mm_struct *mm, + unsigned long uaddr) +{ + __flush_tlb_page_nosync(mm, uaddr); +} + +static inline void arch_tlbbatch_flush(struct arch_tlbflush_unmap_batch *batch) +{ + dsb(ish); +} + +#endif /* CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH */ + /* * This is meant to avoid soft lock-ups on large TLB flushing ranges and not * necessarily a performance improvement. diff --git a/arch/arm64/mm/flush.c b/arch/arm64/mm/flush.c index 5f9379b3c8c8..84a8e15cda96 100644 --- a/arch/arm64/mm/flush.c +++ b/arch/arm64/mm/flush.c @@ -7,8 +7,10 @@ */ #include +#include #include #include +#include #include #include @@ -107,3 +109,70 @@ void arch_invalidate_pmem(void *addr, size_t size) } EXPORT_SYMBOL_GPL(arch_invalidate_pmem); #endif + +#ifdef CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH + +DEFINE_STATIC_KEY_FALSE(batched_tlb_enabled); + +static bool batched_tlb_flush_supported(void) +{ +#ifdef CONFIG_ARM64_WORKAROUND_REPEAT_TLBI + /* + * TLB flush deferral is not required on systems, which are affected with + * ARM64_WORKAROUND_REPEAT_TLBI, as __tlbi()/__tlbi_user() implementation + * will have two consecutive TLBI instructions with a dsb(ish) in between + * defeating the purpose (i.e save overall 'dsb ish' cost). + */ + if (unlikely(cpus_have_const_cap(ARM64_WORKAROUND_REPEAT_TLBI))) + return false; +#endif + return true; +} + +int batched_tlb_enabled_handler(struct ctl_table *table, int write, + void *buffer, size_t *lenp, loff_t *ppos) +{ + unsigned int enabled = static_branch_unlikely(&batched_tlb_enabled); + struct ctl_table t; + int err; + + if (write && !capable(CAP_SYS_ADMIN)) + return -EPERM; + + t = *table; + t.data = &enabled; + err = proc_dointvec_minmax(&t, write, buffer, lenp, ppos); + if (!err && write) { + if (enabled && batched_tlb_flush_supported()) + static_branch_enable(&batched_tlb_enabled); + else + static_branch_disable(&batched_tlb_enabled); + } + + return err; +} + +static struct ctl_table batched_tlb_sysctls[] = { + { + .procname = "batched_tlb_enabled", + .data = NULL, + .maxlen = sizeof(unsigned int), + .mode = 0644, + .proc_handler = batched_tlb_enabled_handler, + .extra1 = SYSCTL_ZERO, + .extra2 = SYSCTL_ONE, + }, + {} +}; + +static int __init batched_tlb_sysctls_init(void) +{ + if (batched_tlb_flush_supported()) + static_branch_enable(&batched_tlb_enabled); + + register_sysctl_init("vm", batched_tlb_sysctls); + return 0; +} +late_initcall(batched_tlb_sysctls_init); + +#endif diff --git a/arch/x86/include/asm/tlbflush.h b/arch/x86/include/asm/tlbflush.h index 8a497d902c16..15cada9635c1 100644 --- a/arch/x86/include/asm/tlbflush.h +++ b/arch/x86/include/asm/tlbflush.h @@ -263,8 +263,9 @@ static inline u64 inc_mm_tlb_gen(struct mm_struct *mm) return atomic64_inc_return(&mm->context.tlb_gen); } -static inline void arch_tlbbatch_add_mm(struct arch_tlbflush_unmap_batch *batch, - struct mm_struct *mm) +static inline void arch_tlbbatch_add_pending(struct arch_tlbflush_unmap_batch *batch, + struct mm_struct *mm, + unsigned long uaddr) { inc_mm_tlb_gen(mm); cpumask_or(&batch->cpumask, &batch->cpumask, mm_cpumask(mm)); diff --git a/include/linux/mm_types_task.h b/include/linux/mm_types_task.h index 5414b5c6a103..aa44fff8bb9d 100644 --- a/include/linux/mm_types_task.h +++ b/include/linux/mm_types_task.h @@ -52,8 +52,8 @@ struct tlbflush_unmap_batch { #ifdef CONFIG_ARCH_WANT_BATCHED_UNMAP_TLB_FLUSH /* * The arch code makes the following promise: generic code can modify a - * PTE, then call arch_tlbbatch_add_mm() (which internally provides all - * needed barriers), then call arch_tlbbatch_flush(), and the entries + * PTE, then call arch_tlbbatch_add_pending() (which internally provides + * all needed barriers), then call arch_tlbbatch_flush(), and the entries * will be flushed on all CPUs by the time that arch_tlbbatch_flush() * returns. */ diff --git a/mm/rmap.c b/mm/rmap.c index 38ccb700748c..a4e2c16a1a72 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -641,12 +641,13 @@ void try_to_unmap_flush_dirty(void) #define TLB_FLUSH_BATCH_PENDING_LARGE \ (TLB_FLUSH_BATCH_PENDING_MASK / 2) -static void set_tlb_ubc_flush_pending(struct mm_struct *mm, bool writable) +static void set_tlb_ubc_flush_pending(struct mm_struct *mm, bool writable, + unsigned long uaddr) { struct tlbflush_unmap_batch *tlb_ubc = ¤t->tlb_ubc; int batch, nbatch; - arch_tlbbatch_add_mm(&tlb_ubc->arch, mm); + arch_tlbbatch_add_pending(&tlb_ubc->arch, mm, uaddr); tlb_ubc->flush_required = true; /* @@ -724,7 +725,8 @@ void flush_tlb_batched_pending(struct mm_struct *mm) } } #else -static void set_tlb_ubc_flush_pending(struct mm_struct *mm, bool writable) +static void set_tlb_ubc_flush_pending(struct mm_struct *mm, bool writable, + unsigned long uaddr) { } @@ -1575,7 +1577,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, */ pteval = ptep_get_and_clear(mm, address, pvmw.pte); - set_tlb_ubc_flush_pending(mm, pte_dirty(pteval)); + set_tlb_ubc_flush_pending(mm, pte_dirty(pteval), address); } else { pteval = ptep_clear_flush(vma, address, pvmw.pte); } @@ -1956,7 +1958,7 @@ static bool try_to_migrate_one(struct folio *folio, struct vm_area_struct *vma, */ pteval = ptep_get_and_clear(mm, address, pvmw.pte); - set_tlb_ubc_flush_pending(mm, pte_dirty(pteval)); + set_tlb_ubc_flush_pending(mm, pte_dirty(pteval), address); } else { pteval = ptep_clear_flush(vma, address, pvmw.pte); }