From patchwork Wed Apr 12 15:13:32 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fabrice Gasnier X-Patchwork-Id: 13209249 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6E453C77B6E for ; Wed, 12 Apr 2023 15:15:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=VVHRKNxFFQFzi/KdCqiJlcD2DFwst4Fy0lnD83DGd2U=; b=Zzk8uYzIUsU1mM mvFDPJa+dA6OF9q5AL2VNkMCikO+zflylivUk9ppvXoj5fejui7mNYbdQjdG95vHNpeu0HRiOj8C1 7MKeXUJiRBWeCg2L8fijPQEN8NFlxIVV68Z06tRwDgjgBoYCFS0meA+wZObYuMXZGgLbuKO2Y+Mlp 1Mq4QUD31jDszObcPuw9wj9tJU5TunTjYVC606ObRHi+JxFxMYW9kP3JoUwhei/nXbnxATk2vCJS1 U3gHju6RrIlIIDxn4ReBeOukWiRCN7PlZU/iYGgndfYJ4cfQnUcTRQFj00O96VIWv3aqS1gCwITBd 4dAbSFYAMz9/ot6ZBGYA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmcAw-003aoc-27; Wed, 12 Apr 2023 15:14:22 +0000 Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmcAt-003an6-1V for linux-arm-kernel@lists.infradead.org; Wed, 12 Apr 2023 15:14:21 +0000 Received: from pps.filterd (m0241204.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 33CCguLK012377; Wed, 12 Apr 2023 17:14:01 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=selector1; bh=P2PtWKI6YfEalebJHuMe+I95r6/HVvixKLwm20SX2QM=; b=Ty8jSxXpxURJf5TB5qiEpF9YuzCSBIvvBHAgfAxfzeopwa7CdDNypP3NaDtKSxddPCh8 BX8VBpbG+9/9CUEvRxBmBfwd2gcnmp9dSYv2kna8Bp7DFX3p7flUrq1I7wmp1Cg/dZet PkApiCqQ7yKnZfw9pcWfFV/Otli/lld9APhsAlBqe8bKx1QTDSiuGRnEsFcLJEKPw+uA ODdyt7Gz72rH2A4wEA4H0sPCYM8Aq4DylS/10GKm5rTil3ZgF/MXPgeC9gGilEDj50/B NxByH9Cx/vPAVaIqQhenIvRAi9YJfcSidUzOwwL9aCLvDxQ1vK5s+cBBBbKJ7JR6aQux 9Q== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com (PPS) with ESMTPS id 3pw7wp040x-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 12 Apr 2023 17:14:01 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DF22B100045; Wed, 12 Apr 2023 17:14:00 +0200 (CEST) Received: from Webmail-eu.st.com (shfdag1node2.st.com [10.75.129.70]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id 1217E218610; Wed, 12 Apr 2023 17:14:00 +0200 (CEST) Received: from localhost (10.48.1.102) by SHFDAG1NODE2.st.com (10.75.129.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Wed, 12 Apr 2023 17:13:59 +0200 From: Fabrice Gasnier To: , , CC: , , , , , Subject: [RFC PATCH] ARM: dts: stm32: remove typec port dtbs_check warning on stm32mp15xx-dkx Date: Wed, 12 Apr 2023 17:13:32 +0200 Message-ID: <20230412151332.3037845-1-fabrice.gasnier@foss.st.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Originating-IP: [10.48.1.102] X-ClientProxiedBy: SHFCAS1NODE1.st.com (10.75.129.72) To SHFDAG1NODE2.st.com (10.75.129.70) X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.942,Hydra:6.0.573,FMLib:17.11.170.22 definitions=2023-04-12_06,2023-04-12_01,2023-02-09_01 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_081420_104544_54D4B3E0 X-CRM114-Status: GOOD ( 17.63 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org According to usb-connector.yaml, typec connector should always use: - ports property - with port@0 (required). This is also true for a single HS port. This removes dtbs_check warning: stusb1600@28: connector: Unevaluated properties are not allowed ('port' was unexpected) Downside is it introduces another warning when building with W=1: Warning (graph_child_address): /soc/i2c@5c002000/stusb1600@28/connector/ ports: graph node has single child node 'port@0', #address-cells /#size-cells are not necessary By removing #address-cells/#size-cells as suggested, another couple of W=1 warning shows up: Warning (avoid_default_addr_size): /soc/i2c@5c002000/stusb1600@28/ connector/ports/port@0: Relying on default #address-cells value Warning (avoid_default_addr_size): /soc/i2c@5c002000/stusb1600@28/ connector/ports/port@0: Relying on default #size-cells value Is there a clean way or necessary change to reach a clean build and clean dtbs_check ? Maybe this kind of concern has already been addressed ? As far as I understand, the OF graph allows a single port {} node (e.g. code being reworked here). Could this be added in relevant dtschema, to address the single HS port use case (usb-connector.yaml) ? Signed-off-by: Fabrice Gasnier --- arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi index cefeeb00fc22..41e79c8cc752 100644 --- a/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi +++ b/arch/arm/boot/dts/stm32mp15xx-dkx.dtsi @@ -259,9 +259,14 @@ connector { power-role = "dual"; typec-power-opmode = "default"; - port { - con_usbotg_hs_ep: endpoint { - remote-endpoint = <&usbotg_hs_ep>; + ports { + #address-cells = <1>; + #size-cells = <0>; + port@0 { + reg = <0>; + con_usbotg_hs_ep: endpoint { + remote-endpoint = <&usbotg_hs_ep>; + }; }; }; };