From patchwork Thu Apr 13 19:40:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13210599 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A426C77B61 for ; Thu, 13 Apr 2023 19:41:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229733AbjDMTlR (ORCPT ); Thu, 13 Apr 2023 15:41:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38384 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229622AbjDMTlQ (ORCPT ); Thu, 13 Apr 2023 15:41:16 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 17E758A47 for ; Thu, 13 Apr 2023 12:40:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681414832; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DAws+N1whAZqdp2+FmcZLsXGffvhZMy054TUXCEFTxA=; b=c21UMAk5iscdghwkUGvCeUq/zkukLdfPXRkNdveNT28MbI4g3t/k18WJuZTveJMWscQcZM 5ph85kwSD2dwnzDqQ+o06XYbqYzv/69A0uxrfc3t0ckczQIvJnP32UuC+uIlT5WNkGWmMG 9AVNxC/mtSJQOF+e5t+7ZxS7Fzopy+8= Received: from mail-ot1-f72.google.com (mail-ot1-f72.google.com [209.85.210.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-96-WWAup0w0M4ao5ydGEms96Q-1; Thu, 13 Apr 2023 15:40:30 -0400 X-MC-Unique: WWAup0w0M4ao5ydGEms96Q-1 Received: by mail-ot1-f72.google.com with SMTP id s6-20020a056830124600b006a037b882d8so3950020otp.16 for ; Thu, 13 Apr 2023 12:40:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681414830; x=1684006830; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=DAws+N1whAZqdp2+FmcZLsXGffvhZMy054TUXCEFTxA=; b=fZwo68FTJDfsNnzgC24GlR15DHqvqi8/Iz4VNs8skCSlJyKlyCegxjNAFZYWL3vIyF FkKJ6qTTi0/lIANJWONmUWL4FkGVeYrwxdlGaoYCg8Jod4hIlWTbPbBZWaDgIca9OzgS RlqGz4ga6BzQAokvVL9+Eod2NJ0md8wNBkuMpE/xZoltvGJQ+Gcyylj8CeAPAdFnmbwD 4NWpnu1KhuIQcZYvzIKqjHNd8k+Yxb7KBESV+T/3XqRxNrZXfu7drnkBnWuMpcsXXb3q y/tiFA7rWqX9NehAyUWvjfjSWbjJ2Jk6wKlndkJKUQXSlQ8eEmfT+57UJyzF1AO+DTw2 dLBw== X-Gm-Message-State: AAQBX9e2gKMMhdNu85GOzXXHpVfbBCy2wXsx9QAEkRyIWT0kmiYZ/7m3 Ao3Weo64rxq5LyugGQlDLXUtygGN0ZgaiKFuFTKc5hh1knB0z87I2NnTrIn7NzBLE+Dkat6821v 760P0GnuafHEnpGSeYAZQgw0d/g== X-Received: by 2002:a05:6808:49:b0:387:3324:29c6 with SMTP id v9-20020a056808004900b00387332429c6mr1720496oic.30.1681414830168; Thu, 13 Apr 2023 12:40:30 -0700 (PDT) X-Google-Smtp-Source: AKy350bFJPcabd2xer93D43uqwTOnEY7fzuGU+iChbHVBOp+gryFxy/XPCdtzRuuHoUgy+wpwDOzRg== X-Received: by 2002:a05:6808:49:b0:387:3324:29c6 with SMTP id v9-20020a056808004900b00387332429c6mr1720483oic.30.1681414829849; Thu, 13 Apr 2023 12:40:29 -0700 (PDT) Received: from halaney-x13s.redhat.com (104-53-165-62.lightspeed.stlsmo.sbcglobal.net. [104.53.165.62]) by smtp.gmail.com with ESMTPSA id x19-20020a056808145300b003898bec0e01sm966140oiv.17.2023.04.13.12.40.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 12:40:29 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v2 1/3] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Date: Thu, 13 Apr 2023 14:40:18 -0500 Message-Id: <20230413194020.1077857-1-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As stated at the below link in another review, compatible is always the first property. Follow suit here to avoid copying incorrectly in the future. Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 Signed-off-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- Changes since v1: * None arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 339fea522509..029b23198b3a 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -352,19 +352,18 @@ ðernet { max-speed = <1000>; mdio { + compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; - compatible = "snps,dwmac-mdio"; - /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; interrupt-parent = <&tlmm>; interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ device_type = "ethernet-phy"; - compatible = "ethernet-phy-ieee802.3-c22"; }; }; }; From patchwork Thu Apr 13 19:40:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13210600 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C7E4C77B61 for ; Thu, 13 Apr 2023 19:41:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229744AbjDMTlY (ORCPT ); Thu, 13 Apr 2023 15:41:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38428 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229913AbjDMTlV (ORCPT ); Thu, 13 Apr 2023 15:41:21 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FCAA65BA for ; Thu, 13 Apr 2023 12:40:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681414840; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wHh16MFI12gMsfqbehl6umAoFEnRY63CfuAwT9OzHsk=; b=IWGX+pg2GPKQfjAyFZzPjyRCNWKNcHeKOsUNQltrc8ywUOHPEILpnQkuPODtrbkRr8uYh9 V1AT3s7PMmKJ1otdx06MQrfnPoG3vhQ8RNFXXSqypZlWSoJYJWF6XmDuSSMJAvzevT4Dss u4jXbVah7DXstWUmy9zHLazOHc/dY/Y= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-42-9IS-n_n2OXWn5UzCST1BYw-1; Thu, 13 Apr 2023 15:40:39 -0400 X-MC-Unique: 9IS-n_n2OXWn5UzCST1BYw-1 Received: by mail-oi1-f198.google.com with SMTP id fc10-20020a0568082a8a00b003894ce81c46so2370130oib.1 for ; Thu, 13 Apr 2023 12:40:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681414839; x=1684006839; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=wHh16MFI12gMsfqbehl6umAoFEnRY63CfuAwT9OzHsk=; b=MerpseIaNHCUQjd3BSPCppdXiUwGJ6satROkarJCGUavJn1jmq3q0pg40KLK42jJvj D/SR+/BabxjOwkOkT/4zwd43f7OiLGcmuRJce+Ip2zDJ53BzF5QsiTHMFztRKJuTSIyF dMl1bgzn1yWvHR7QebQA91qIjM89VXq5AIo5J4V4FYseuVgqRGc0z5KBGOrn4ol2yrB9 eJQRCWKtYhgbYmxvCfMOymUBgSchMbYtywovQ1+RzdK6AorNWw6tf8lUvBo60eLLnyYi fQoT2VkSlFQz2r4Zt3ehXMPc9yOYtzNiueJGXMSApEyDprErtuCg3BcpoyhBlih3qgYL +PTg== X-Gm-Message-State: AAQBX9eES4HL3JY2tFUVgQ5LLk2nVRtqe0pT8sDrGl2wuVQkHaFbshDH oXK4j0ywYgQfEe7WiACxUZmSmczfiYMjaQhfbj3eZwziAYeClLmL/tY7jsRQkZOVxs51fzOYcDj B1NuNF91jMwhzH+4Ixfkm3dsAXQ== X-Received: by 2002:a05:6808:4046:b0:389:4ea4:7a59 with SMTP id cz6-20020a056808404600b003894ea47a59mr1472112oib.33.1681414838917; Thu, 13 Apr 2023 12:40:38 -0700 (PDT) X-Google-Smtp-Source: AKy350bWufTE+ePpSscH/Va3pVkErpxbVW3rmbXpnUl6PIFkY+rrCsQ+ppVWMagLa8KFfSBI9GvSpA== X-Received: by 2002:a05:6808:4046:b0:389:4ea4:7a59 with SMTP id cz6-20020a056808404600b003894ea47a59mr1472106oib.33.1681414838685; Thu, 13 Apr 2023 12:40:38 -0700 (PDT) Received: from halaney-x13s.redhat.com (104-53-165-62.lightspeed.stlsmo.sbcglobal.net. [104.53.165.62]) by smtp.gmail.com with ESMTPSA id x19-20020a056808145300b003898bec0e01sm966140oiv.17.2023.04.13.12.40.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 12:40:38 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v2 2/3] arm64: dts: qcom: sa8155p-adp: Make -cells decimal Date: Thu, 13 Apr 2023 14:40:19 -0500 Message-Id: <20230413194020.1077857-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230413194020.1077857-1-ahalaney@redhat.com> References: <20230413194020.1077857-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The property logically makes sense in decimal, and is the standard used elsewhere. Suggested-by: Konrad Dybcio Signed-off-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 029b23198b3a..ac52a8dfeba1 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -353,8 +353,8 @@ ðernet { mdio { compatible = "snps,dwmac-mdio"; - #address-cells = <0x1>; - #size-cells = <0x0>; + #address-cells = <1>; + #size-cells = <0>; /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { From patchwork Thu Apr 13 19:40:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13210601 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A0114C77B6E for ; Thu, 13 Apr 2023 19:42:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229749AbjDMTmX (ORCPT ); Thu, 13 Apr 2023 15:42:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38822 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229530AbjDMTmW (ORCPT ); Thu, 13 Apr 2023 15:42:22 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0743C868D for ; Thu, 13 Apr 2023 12:41:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681414889; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pe0/oi4k+3plRUDjjra5Jf/XI2sf8St247Sf5O8j+8g=; b=K4a2WduOJ0U5HM/GwlKgiDV+pwL7xXdFRrO2kTpX2h/fDbfGIiQcXihfVFtO8nFyIyikw2 ZvDK8oeIQNsp7GUn+Xu/4eGdX7Gv1O7Td1BUW4N6zrpWRBZuy0BsWMkQoaCozAK9L+OV6c Ksq1c4VXOvnZpaHs7hj/pplJuA8+Etg= Received: from mail-ot1-f70.google.com (mail-ot1-f70.google.com [209.85.210.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-340-T5squllwMKGt_h2uTc7gxw-1; Thu, 13 Apr 2023 15:41:27 -0400 X-MC-Unique: T5squllwMKGt_h2uTc7gxw-1 Received: by mail-ot1-f70.google.com with SMTP id b17-20020a056830105100b006a42f47618fso764593otp.19 for ; Thu, 13 Apr 2023 12:41:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681414886; x=1684006886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pe0/oi4k+3plRUDjjra5Jf/XI2sf8St247Sf5O8j+8g=; b=iF4+QVgNwLyQsQpL7wGXcXEl8Zy1pSLTHXuAaHn5kDPXqmevWOmX9PCzcNWxXT0cw0 j9kxOI4SqUJixNrgvmVLmxQ7Dr6e7C8OaHOxlsSPo5+GQ3khexG03erQ69Bx4lRSlYMN TddG3QoL92iW2glrVpPYSAVkL6Zw1Kd4Ilbx4L8wxcip1IevqV55zGL1PmP3mmSR/3Th hrBuTQHroDklp4I8Kq9zMFwNKqnT/2atdnJZRLU+9psNG15mbT73UBS+3GFYtoiN22iA F1ZFnlan+T/BvM4DAJvBAYBqDb0ILrY5gw18H2MOu2EOxYzWGMcfgoLvEZ1PRelZtEal oP0Q== X-Gm-Message-State: AAQBX9cUrDHY0/eZSqbnmzrI0SPnEtgJBHhlbZ7n5BUn1uXJ++sBGM+R C/2VQ5BpwUhVi8CliClrNLzZh7noNMp75N6gs8D/ZAMtzl/VeKSAFu+uLTJKBDZ9PdGohQSuebd gejc0n19JsXIbN8DhNKaqnWWo3vMsaL5edA== X-Received: by 2002:a05:6808:9a2:b0:377:f784:3332 with SMTP id e2-20020a05680809a200b00377f7843332mr1567416oig.24.1681414886725; Thu, 13 Apr 2023 12:41:26 -0700 (PDT) X-Google-Smtp-Source: AKy350YlwdBnAy6xihkKJw9Nntu9FJ2LoTnC1J6rgKBnqrGWtgp/R0SrzSgYs1pLXe/uellQrAs7aw== X-Received: by 2002:a05:6808:9a2:b0:377:f784:3332 with SMTP id e2-20020a05680809a200b00377f7843332mr1567402oig.24.1681414886483; Thu, 13 Apr 2023 12:41:26 -0700 (PDT) Received: from halaney-x13s.redhat.com (104-53-165-62.lightspeed.stlsmo.sbcglobal.net. [104.53.165.62]) by smtp.gmail.com with ESMTPSA id x19-20020a056808145300b003898bec0e01sm966140oiv.17.2023.04.13.12.41.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 12:41:26 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v2 3/3] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Date: Thu, 13 Apr 2023 14:40:21 -0500 Message-Id: <20230413194020.1077857-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230413194020.1077857-1-ahalaney@redhat.com> References: <20230413194020.1077857-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Using interrupts-extended already indicates what the interrupt-parent is, so drop the explicit interrupt-parent. The comment about this being the phy-intr is not helpful either, since this is the only interrupt in the phy node. Suggested-by: Konrad Dybcio Signed-off-by: Andrew Halaney Reviewed-by: Konrad Dybcio --- Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index ac52a8dfeba1..b65e0203d783 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; - interrupt-parent = <&tlmm>; - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; device_type = "ethernet-phy"; }; };