From patchwork Sat Apr 15 09:55:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13212419 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ABCC0C77B76 for ; Sat, 15 Apr 2023 10:07:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=SVOiaOxJdgmDDzkebkUnusbYyYpIq39HCZ/zadBK8jU=; b=OthD1Kx5C4dMzx tlPyd6Up4Llwxha8qBofsoUePtgQoDqGmpI4+L3a12EPb+lqMuj/w+IpijIVx1dUr2J+pwS+3Rrc1 gKftGFnnMUiu9GqtSKo+2S30AOer7Sq4hrjCEVh+iIQqwTff3OQO8W/i66p+OP5O9tGbsFWmpK/dn IcIb82h+C2h7AgVCLULQK0/hUHkcgYMC+ZQDo4znQRF5xJVwDC3k7OITdKB8gvU+4eYPOm0bLlMl/ FG9H+zr+Iy4bMC7kZr6h9EAHMhQnKDKD/FygiGaWKecyZ0pi/4tFV+UrGFHaLGx2tdJPx6iukO7b7 5c3pZqRPHFcmhfIVGpYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pncnY-00BnVh-2Y; Sat, 15 Apr 2023 10:06:24 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pncnS-00BnTT-0K for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 10:06:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A8B9E61766; Sat, 15 Apr 2023 10:06:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BB405C4339B; Sat, 15 Apr 2023 10:06:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553176; bh=W7rOi6WjpD3uscFWmYE+SDo4q4MTdBEvs6oaRgrvjKM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bIJ8wwGlfYP1mRVObuTcpFYQWY8ID3xUbYwVRlP/D+LFiN9Mi89wZN+Lmf1Spa0cj tWZu3aJ1594zgqOyZiEvgF5KjVsmpyZL/9xIKPlTUH74Y/XHgfxLfuANNTBuFkJ3Cr EmxRcBNfnVFEuQPZgaM8oh3gFvQoaYeSZgRCcZji8c+zfKxYoeSAzugUDujNct+laP WH4PdqtdV8zLIZJUuNEglG39d1KKeWEXgQ2K49BI3lhmcRU8FYdF1WY4ELogzAeMoc WuqjPU4vHnAj/NDe3nLQmi0LL8yDSR3cLIlmXiwi4puaVBrAmtqcSqvp+VHjyDuS5Z 7tktgBBGEsatQ== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 1/5] dmaengine: dw-axi-dmac: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:13 +0800 Message-Id: <20230415095517.2763-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230415_030618_177575_692B204A X-CRM114-Status: GOOD ( 10.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 4169e1d7d5ca..7f3a60e28e38 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1445,7 +1445,6 @@ static int dw_probe(struct platform_device *pdev) dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask); /* DMA capabilities */ - dw->dma.chancnt = hdata->nr_channels; dw->dma.max_burst = hdata->axi_rw_burst_len; dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS; dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS; From patchwork Sat Apr 15 09:55:14 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13212418 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 824CAC7619A for ; Sat, 15 Apr 2023 10:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=uu8WKdzknh9G/KKnZ/y1QFXtUqJJzxiOc//7yGMNG1U=; b=AlZI8Y9hLIJDQx +UER4b+Hk2AwP1tqS/QH5UbklhAhW6ff+FK5FOGdr7Eq31oX3SStcyNZyL3NNQ0g23+dSvyJs7kQ3 PM58m18400KT4HmSU0K/9Jr0q7l7VQOu+HZSr6gtfUsuGyMAdd1OirLVPByYA4aIgkYYi0f+QyCOf sQ5iZwOWRRNhlGB2wPYZKboud/bRuEpnXvE+/xRy9i0UtLKlOMzO5Ep334w2/L50ELq9Nl4KTx02n pZS5BPOkE14ToLRjHC9c9zO3A53HNcx3QjoxAEhoPtqyNasxHeBEq+2lQolgdw6n4u4jTpVLsmqSb 7hLzmcNn66oOIFB6P2sA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pncnf-00BnYG-1L; Sat, 15 Apr 2023 10:06:31 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pncnW-00BnUb-0O for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 10:06:23 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B6C1A60B78; Sat, 15 Apr 2023 10:06:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 0649BC433D2; Sat, 15 Apr 2023 10:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553180; bh=tfDJeLEBi00e9/yxIl4hwmsmHEqD5UdGR6/fxpDa4NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=k2sRikwZx+XiHCdfh4R7Ouv5k2zlr3bwWx/XzF1tfUIkEE8KXZ6oMolLVyNsGKWPb 22UnC8x2NJzkmX+QyQeajrja4LbRqXi4ANbk/DOQxRxTACrHiKRuCaoWkWbzPaCRtM f3QPFkhdwajIuo32SA45G3EnhQ+Af5Ppy1178VSNAuhs43eLJ5oP27SP9Ms5CiTy4T 4A34nRroPNzztOipRbVVFnfTtiIc7Bpll2SpXRXwOV/EXYHx5tOU2voMaQ6zptNbz2 x57bYW6oDu2+LxYffEDa8gpMBaDFKVTBMuuDjql5Q6PZArQ79W2yfEjvWQyJy3QPqS mK9nY62W+KlRg== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 2/5] dmaengine: axi-dmac: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:14 +0800 Message-Id: <20230415095517.2763-3-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230415_030622_195487_F1C0B140 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Lars-Peter Clausen --- drivers/dma/dma-axi-dmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index a812b9b00e6b..fc7cdad37161 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev) dma_dev->device_terminate_all = axi_dmac_terminate_all; dma_dev->device_synchronize = axi_dmac_synchronize; dma_dev->dev = &pdev->dev; - dma_dev->chancnt = 1; dma_dev->src_addr_widths = BIT(dmac->chan.src_width); dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); dma_dev->directions = BIT(dmac->chan.direction); From patchwork Sat Apr 15 09:55:15 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13212420 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55A85C7619A for ; Sat, 15 Apr 2023 10:07:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aRwZcWeaEZ7phMPpBnSn8F9UWLfRppcNxfEfLxHZk4Q=; b=AOuA+zbuWyz5qq SRtl65nnfSnMl2ZriqlNsyP/mdZocnkM2HVEckbtKdXWSTF2ko1awbLRaHA/efF9d3C4TlKEHUl/I wvPex3q3v7X/G1v2Yho8XnBKmUT5uDU1fcgbcDSeaQsPgqyfFS7wdQC7gK3mhmWX8MNoWVsbJcUts XuEADvmqKtRZDvOe5FPKPDuYS6MeduyywmSYCWcpB3nOxlfdlCqT33tKypFfD0bpoOvh5IWl5vIgL nxjHaZLmY0V62XEVoh5CUJ805PnG3402mwkWF5o02EuQMeVUEX1xCXfNH+47p8ea/3e9UOHMXu803 dBScdJbbSFS8lFtMYvaw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pncng-00BnZI-1p; Sat, 15 Apr 2023 10:06:32 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pncnY-00BnVO-1f for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 10:06:25 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 20DE060BA1; Sat, 15 Apr 2023 10:06:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A277DC43444; Sat, 15 Apr 2023 10:06:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553183; bh=j0aBz66SH19AvtQqR7Wm6Ds/FEdfxHpyVN3OSq/97ic=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Wnb6lo7ozMMC+0h+H3aHtR73fgbRh+c1fxAOUu/duhI+c/RZPDt+thU1gS8iYN437 4xwKW5j54WgNmgpB46qD7PvQQ77aFl+X4XqFS5hBVXjfWB3hl8ElMn+2wWUVVA7bhW X2g6QLLhsl5w+8BRrkdt/0x7p7W3eVUUh6c06h3IE2Piuiy0xsVZ1+lTXvzIcns2q+ fel9D5AIU6F1SbXSnGMX3evpMmfZ2jWuiY4TTbKYd8MqqRMFIqLAQ63LhHEoLmdbKL RPbBsV0Rqu4+TndBK4FcxdwmrmNsAxdxim9AHje8usVbPN+f4VJ9nVo1Mzn1CG33K8 +8+BAvAGiaq1Q== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 3/5] dmaengine: plx_dma: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:15 +0800 Message-Id: <20230415095517.2763-4-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230415_030624_591126_AEB7682C X-CRM114-Status: GOOD ( 10.10 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Logan Gunthorpe --- drivers/dma/plx_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 12725fa1655f..34b6416c3287 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -517,7 +517,6 @@ static int plx_dma_create(struct pci_dev *pdev) plxdev->bar = pcim_iomap_table(pdev)[0]; dma = &plxdev->dma_dev; - dma->chancnt = 1; INIT_LIST_HEAD(&dma->channels); dma_cap_set(DMA_MEMCPY, dma->cap_mask); dma->copy_align = DMAENGINE_ALIGN_1_BYTE; From patchwork Sat Apr 15 09:55:16 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13212417 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4D542C77B71 for ; Sat, 15 Apr 2023 10:07:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=AAv4rblB/mL7VrV20S757ljmN72PhOTRct9686TeLmw=; b=wOqYHtiD4+ynRD U6kKcT+f5k9DgjGOM1EnON/g542aHw5vGCC4DLTMLg1n6/E6/HXJN2QWRexGyYS1o+Pj2iC5o3yyV X75vntYsrVpeCKp6AmPm4WOHgK5q+hYBH8tAUi17+ukFIOk2Q9J6HULSJtMDb967fzhbBprgy/fyL Iseoj29pbY61SYUOVBjE6sG/ESSwEHfyKJYDWVCfjHmUyPo9n+UBastNDwQJYiobmAbT+0mHC0H+I TOmhh9a/Y5RUaGh0xpKmRtRxn4ASEYOQtUQw5wLZlqwXVfnBXME0xDWra+xykrBCm0mZHo+3guXgv 2rgkmy0sPT0mpi1y8MEg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pncnh-00BnZr-2C; Sat, 15 Apr 2023 10:06:33 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pncnb-00BnX4-2i for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 10:06:28 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 69A65611F3; Sat, 15 Apr 2023 10:06:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB230C433A0; Sat, 15 Apr 2023 10:06:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553186; bh=VFo8FgxOsge+PUUwYU5GtQjYV19pyPbFfRwwhMQ8hcI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=mf7d8SGx7lp6TgaHpLQ0r7CcypJYZbtSBmAXTL3jgsRPSDHeVn5dk+nkqMOuvfX/D rpiwNkQ9as9hblItcJZWy6w9TRwxMaWShea8qiLPGvqPQ46PcOAA0pZ0yac892+Hp0 SJ/bTaxnjd3VOEb7m6Ou1KFuUOQrat5BUc7/tSJrw0L3boV1nzNUIyUfuWKXDYvtB4 o7qkPlQKkf/09FP/K5eCkKTqeuDXtAjGPOrSyZzAYItEcpWRGeKTZ+/VgF4mZVBKGc LqZ/NnT5JbVQBNCANjWbdDsHKRTXcPzsmJ1I2/gC943MXT3zK5sT7tmJ2jYY0RQf/Z 75cnKVSi5gKWw== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 4/5] dmaengine: hidma: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:16 +0800 Message-Id: <20230415095517.2763-5-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230415_030627_927687_199EE1F7 X-CRM114-Status: UNSURE ( 9.89 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/qcom/hidma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 04d1c33afc12..344525c3a32f 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -214,7 +214,6 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig) spin_lock_init(&mchan->lock); list_add_tail(&mchan->chan.device_node, &ddev->channels); - dmadev->ddev.chancnt++; return 0; } From patchwork Sat Apr 15 09:55:17 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13212421 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB8C0C77B71 for ; Sat, 15 Apr 2023 10:07:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=+TE+mWgRdHZMv0/sYc0K7c+qiK+4AZQkeVOOwRmjQi8=; b=TQbqVu6XL8EFL+ +mUFo7ic7EigCPZ+o2Pi6W0G/XemjcIJf/5DkYOkZXH0c5ZJoVUjtPNCiGcSsJbOCSHwnPOD136na TWVSg6IohiBmfSicqj6x7FSspBhufo5x1qaVtskrR+LRD4oDNtCJHVonuCLogT3csWi+PWbsmdvJO eSe10hoMI1eabNX984iC38DWbXj75EYwCbsdWoeI67Z3k1o8RSczQFlP2INa9ci0tQXmw2yV5oXeH lp0DLNJL87KbuqiMnUHA/rY/FwB9OojXu7sdYxLT+8DbYiCxl1NemE4MnsKqdI4DEmFRIWk+HaWpZ 3hjm0Whh12CrZh22FvQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pncns-00Bndu-1A; Sat, 15 Apr 2023 10:06:44 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pncnf-00BnY9-0y for linux-arm-kernel@lists.infradead.org; Sat, 15 Apr 2023 10:06:32 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id A9549616F7; Sat, 15 Apr 2023 10:06:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 444C0C433A1; Sat, 15 Apr 2023 10:06:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1681553190; bh=Z+1BObiXlJgUhyPJtWXSHre7idf+1fVLpCNeJRw84co=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FeGcLJBv75tSgIpzlNfzHv3/MLU4/OGHjPh8RTfAsdeo8+0+ZSKtOhSLGmHmg/VYf ppyz46KmgHsl0wpKO/yzSynsis1Vmh9ImTWOviJtUHyH5GeppSxdB48uaitTi6R5b8 LSwKISZeFt3mxodjCv+DKBsgWlHmXTch46IhAqfYOnGWkF8+kGPWlAtXI4UBv4ePS+ ryaikh9nl4FK/vf9A6QcjXhNDPzFAbuBssonZfOBE7Y6aUtyPy2f7jreSlxmnRPF8v h98Boa6DdQr2pFnzZe4yqrZTJpMyn9sKtFlzpzOwD5TLKKHmArtK3j6uEOEIwGDt4z pMI6fKNT8u1Gg== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v2 5/5] dmaengine: sprd: Don't set chancnt Date: Sat, 15 Apr 2023 17:55:17 +0800 Message-Id: <20230415095517.2763-6-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230415095517.2763-1-jszhang@kernel.org> References: <20230415095517.2763-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230415_030631_381985_3F5387F3 X-CRM114-Status: GOOD ( 10.46 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Reviewed-by: Baolin Wang --- drivers/dma/sprd-dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 474d3ba8ec9f..2b639adb48ba 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev) dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask); sdev->total_chns = chn_count; - sdev->dma_dev.chancnt = chn_count; INIT_LIST_HEAD(&sdev->dma_dev.channels); INIT_LIST_HEAD(&sdev->dma_dev.global_node); sdev->dma_dev.dev = &pdev->dev;