From patchwork Sat Apr 15 10:42:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212446 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B2F95C77B71 for ; Sat, 15 Apr 2023 10:43:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 8227EC4339B; Sat, 15 Apr 2023 10:43:19 +0000 (UTC) Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 633B6C433D2 for ; Sat, 15 Apr 2023 10:43:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 633B6C433D2 Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-94f0dd117dcso34977366b.3 for ; Sat, 15 Apr 2023 03:43:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555396; x=1684147396; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=6aFDy/SB7tnUF0+eQ7zFT5mQKFJQM8aVqeD2imV3VFQ=; b=YQEkWEK4VR8sC/8J0bTo0pPtA5ui12m+R4UvuHGj1HnX7Rq88fDAaf9QOhDXbO2yAl Y6icCppsb5LAK3+IWX2txT9xtOeV1PSM1x0ZjaEECRZGv7rhumJb1C0NS2R72MHLTkAR jPTKO7QHkfWTjn+Hn4iNlw0USmKQN6Hm1ppS5Frr3Th+IXX7yVfVF+GWUS2duwsg6Kff l8D54PAk2fKpq5bdHRy3Qb3qPcR2+/qzN+yNPOGqAPfIYen2Y6IwbRpwcuvMlgNQFaAI B/cc7Cu6MpxZELECRwgBqGcWbqXdBQ+lYVt2Jjqoo/NdkXCZbTgkzLK+YWQAjdY3NqAR W+9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555396; x=1684147396; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=6aFDy/SB7tnUF0+eQ7zFT5mQKFJQM8aVqeD2imV3VFQ=; b=UnJSH6RNLf/xFkCPLwKhNVioh6sJ6c7WPOEDacdXzCXOTm3hjQ5AOhYEglneX1rZAx 32PZKrfTcl+I9qkwiPOSzL3TAQDw4O+QyUtPvH4pdx1ai458WdHn4pGp02k+GYk7hWu4 q3quTS1YA0pg5IkTuHxg1jlrCty/vKeFU6cq9yknBKLSWhFIRyxWUQEkISNNvrMA5bcI ncr6PcXkhV4Cak5Twv06hCpU+HDF9WiMxgykOt9sn1sj+HwIU9oWPyusLgNwj5eE5C/H toDiCE294bNsnyTOj7u8bz6/6XnpJYnWG7lYEoV0qi3ZXXw65qd/KVCpG+uwlLB8AVO/ HK2w== X-Gm-Message-State: AAQBX9d387KakSKsJvpyiCYVEmEmnHo9JH1pu+6UHFi7NmcE5GFq0ylO yH75YFU0qGTv7DRWG9CddDZVLQ== X-Google-Smtp-Source: AKy350Z43wpLjbwwzoveofc5k6ZjhabN/INplT3i3zKAYsqb/f/i29jvpuHEVTH+7+a/rogzU+ed3Q== X-Received: by 2002:a05:6402:517b:b0:4c6:10a7:c422 with SMTP id d27-20020a056402517b00b004c610a7c422mr9151637ede.18.1681555396527; Sat, 15 Apr 2023 03:43:16 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.15 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:16 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 01/15] w1: ds2408: drop kerneldoc annotation Date: Sat, 15 Apr 2023 12:42:49 +0200 Message-Id: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Drop kerneldoc annotation from comment which is not a kerneldoc to fix: w1_ds2408.c:210: warning: This comment starts with '/**', but isn't a kernel-doc comment Signed-off-by: Krzysztof Kozlowski Reviewed-by: Randy Dunlap --- drivers/w1/slaves/w1_ds2408.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c index ad102c577122..7fa911989193 100644 --- a/drivers/w1/slaves/w1_ds2408.c +++ b/drivers/w1/slaves/w1_ds2408.c @@ -206,7 +206,7 @@ static ssize_t output_write(struct file *filp, struct kobject *kobj, } -/** +/* * Writing to the activity file resets the activity latches. */ static ssize_t activity_write(struct file *filp, struct kobject *kobj, From patchwork Sat Apr 15 10:42:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212447 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9367BC7619A for ; Sat, 15 Apr 2023 10:43:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 55B2CC4339B; Sat, 15 Apr 2023 10:43:20 +0000 (UTC) Received: from mail-ed1-f44.google.com (mail-ed1-f44.google.com [209.85.208.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 5F038C433EF for ; Sat, 15 Apr 2023 10:43:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 5F038C433EF Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f44.google.com with SMTP id 4fb4d7f45d1cf-504e232fe47so3565944a12.2 for ; Sat, 15 Apr 2023 03:43:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555397; x=1684147397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PW9iSx5IP2gUGmfeEvoHgXw1NIUTLCMqNNP3AylUxdA=; b=u97N5aYGxUM2vtu5i8b70KpwA6ql/hlHHL8q/LpGxBX0WpaGP45Xix9afoFsymFy+v BlY66ql6Bo+C8ojSi5FHvaZaZ+lF75hKh47W7UCAJvNWrPMrscOS1BJ0//qYJVqw2j4T NV6CNwfajlTeJddXW7RhRtSyLrtzXS8mkDDm+XsPiXnd4CeaQ9l4jFm3FzhI6kcPzpAw BFsRHR7BEXviQriGJs2ofbV5magubWSi7V5kxpjqI+MOhoTCPSof/XZXAj/CPw4lujfC iTa8dOnCQ1SBqjdOiLBjCQWGTIYy0oqSSMv1NKLtSQCVoBrh5E2LFGk+AWYCNYFhFbhx VqiQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555397; x=1684147397; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=PW9iSx5IP2gUGmfeEvoHgXw1NIUTLCMqNNP3AylUxdA=; b=an+6eog8L6lP3osmDZnyaH6OIlsMRcp31DFLmwjIykWIrkUJ1B6AAIUdDKz9duZEo5 cGP6z7eXgBdUUKnWd1ZpsAYGG0fgqNjFaD2fubey+NvW4mf/CIuad47jDaYVp4HscFGZ 6clRlT7pjDy3K9o1xbdrcgSqqD8s+NmI+tzBNL6dpTfNaf5oTbtfsx0/lZ0Ax47cUtb+ qDcUi3RfrR/iB5H4Bwj1ZNj84xP3SGNDfExNMEw2tTdjtT5Nu+knLvlCswK5m6ZDj0zp fM5fxeKhvys1CGIYxAwRSdXy//B08mAObdu8spAFlR9cboeqlxA2ER23gGz3FJkdCI9O kr9w== X-Gm-Message-State: AAQBX9fLWZ0tvQdcr5gmLM4+wq2QNW4MD6Gq2K1lJV483cCc5VW7Cyr0 7lsRMuxSxry6NOa6GGvM6x5fkw== X-Google-Smtp-Source: AKy350bjVhUQTb5JJQ7z/tqW66lylAGSuqRM4Coc7UVcca4c8McioxFauSi36KBt89MymEg2zw/R4w== X-Received: by 2002:aa7:c2d4:0:b0:506:bdc:49c6 with SMTP id m20-20020aa7c2d4000000b005060bdc49c6mr9123965edp.23.1681555397563; Sat, 15 Apr 2023 03:43:17 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:17 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 02/15] w1: ds2433: correct kerneldoc annotation Date: Sat, 15 Apr 2023 12:42:50 +0200 Message-Id: <20230415104304.104134-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Correct kerneldoc comments (or drop annotation) to fix: w1_ds2433.c:46: warning: This comment starts with '/**', but isn't a kernel-doc comment. w1_ds2433.c:141: warning: This comment starts with '/**', but isn't a kernel-doc comment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Randy Dunlap --- drivers/w1/slaves/w1_ds2433.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c index 0f72df15a024..6134ca2f37fe 100644 --- a/drivers/w1/slaves/w1_ds2433.c +++ b/drivers/w1/slaves/w1_ds2433.c @@ -42,7 +42,7 @@ struct w1_f23_data { u32 validcrc; }; -/** +/* * Check the file size bounds and adjusts count as needed. * This would not be needed if the file size didn't reset to 0 after a write. */ @@ -138,16 +138,17 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, } /** - * Writes to the scratchpad and reads it back for verification. + * w1_f23_write() - Writes to the scratchpad and reads it back for verification. + * @sl: The slave structure + * @addr: Address for the write + * @len: length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) + * @data: The data to write + * * Then copies the scratchpad to EEPROM. * The data must be on one page. * The master must be locked. * - * @param sl The slave structure - * @param addr Address for the write - * @param len length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) - * @param data The data to write - * @return 0=Success -1=failure + * Return: 0=Success, -1=failure */ static int w1_f23_write(struct w1_slave *sl, int addr, int len, const u8 *data) { From patchwork Sat Apr 15 10:42:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212448 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 59D99C77B76 for ; Sat, 15 Apr 2023 10:43:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 410D6C4339B; Sat, 15 Apr 2023 10:43:21 +0000 (UTC) Received: from mail-ej1-f45.google.com (mail-ej1-f45.google.com [209.85.218.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 5DA15C433EF for ; Sat, 15 Apr 2023 10:43:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 5DA15C433EF Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f45.google.com with SMTP id fy21so8887755ejb.9 for ; Sat, 15 Apr 2023 03:43:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555398; x=1684147398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oSLSErlIH/a5nW5Ta5oh6CbddfCcyu4mj1K7g4WIjAI=; b=HhTnbJQEImdGA4e+HXumaOJ6UMXiuni5QBZrUxtJ1Sug7SWnr1jkjOnSwg28LhxJU9 xl78Bea62KjaIvGHIT8yrbvsAH0mPjKzR+J0pZN4zVam2IVLIBnJk/6pYrWtjBgeBFo9 QiVdcQr7+X21OyvhCBa/G32aFyEvYF03A7oF+2hM42/k5bH3WBtb1TevhedL8muQSiHv WcdQNNLrMFUMq6L/AOUPsTi3fE3OKtkttB47mDIMXLn6iBpFh2mb2Jra1P/vhMOXdKwG 7EcJnbAAPquWrfqYVCL3Ehu/E48EvM8hiMFluOBLYAwrq/Rdo3GIP+RtLfZvpEakgNxk 3ebA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555398; x=1684147398; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oSLSErlIH/a5nW5Ta5oh6CbddfCcyu4mj1K7g4WIjAI=; b=cPSVDYaQ9eojAvgomJwFqKAd09h9Qu0FnKgtIzjzHa/M+FLRn4QPeFmQs7++K2mSa1 Geu+aDGwe+pZMbEdbpewsJsQOGabIeIeXh3L25Jwb1WXblBree1wfIni5U3An0zm0AcB BH5sTLOh6dG0vgzxEH5BHOmnEIrwx/4Ey6xB7Bq3M6ibxwG0pRWkTA2FHc8Du/PxhnEI SCas1XLb1YANEK8HhlCH17gr14VG54XJlJBTjTRkHjglAoCzH3Kc2lxsbANTNAQT4Tdh HbZYWcSuGxm/2SyEiUCVGKS+beYrg60/+1jSe0dTLSJdWOulEgx80sk4XclqelzcWW7U 6PkQ== X-Gm-Message-State: AAQBX9dc1ObYLonL7gLpgtVA4YuQNC9DXSfp7BHfj6BbygrkNekShRMB xNJDLT5ioihdNinC+e7I5uM6Hg== X-Google-Smtp-Source: AKy350bVdWLpfybIr/5BIXy/EYZJTe3HRjjltyZoeJ6ALCY3Bkd7hTW/mmp3WSLZhqFffOHW7eauoA== X-Received: by 2002:a17:906:b190:b0:94a:785e:6a46 with SMTP id w16-20020a170906b19000b0094a785e6a46mr1969337ejy.24.1681555398671; Sat, 15 Apr 2023 03:43:18 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:18 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 03/15] w1: ds28e04: correct kerneldoc annotation Date: Sat, 15 Apr 2023 12:42:51 +0200 Message-Id: <20230415104304.104134-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Correct kerneldoc comments (or drop annotation) to fix: w1_ds28e04.c:57: warning: This comment starts with '/**', but isn't a kernel-doc comment. w1_ds28e04.c:149: warning: This comment starts with '/**', but isn't a kernel-doc comment. Signed-off-by: Krzysztof Kozlowski Reviewed-by: Randy Dunlap --- drivers/w1/slaves/w1_ds28e04.c | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/w1/slaves/w1_ds28e04.c b/drivers/w1/slaves/w1_ds28e04.c index 6cef6e2edb89..f54d6afd79c3 100644 --- a/drivers/w1/slaves/w1_ds28e04.c +++ b/drivers/w1/slaves/w1_ds28e04.c @@ -53,7 +53,7 @@ struct w1_f1C_data { u32 validcrc; }; -/** +/* * Check the file size bounds and adjusts count as needed. * This would not be needed if the file size didn't reset to 0 after a write. */ @@ -146,16 +146,17 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, } /** - * Writes to the scratchpad and reads it back for verification. + * w1_f1C_write() - Writes to the scratchpad and reads it back for verification. + * @sl: The slave structure + * @addr: Address for the write + * @len: length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) + * @data: The data to write + * * Then copies the scratchpad to EEPROM. * The data must be on one page. * The master must be locked. * - * @param sl The slave structure - * @param addr Address for the write - * @param len length must be <= (W1_PAGE_SIZE - (addr & W1_PAGE_MASK)) - * @param data The data to write - * @return 0=Success -1=failure + * Return: 0=Success, -1=failure */ static int w1_f1C_write(struct w1_slave *sl, int addr, int len, const u8 *data) { From patchwork Sat Apr 15 10:42:53 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212449 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ED355C7619A for ; Sat, 15 Apr 2023 10:43:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id D0C07C433D2; Sat, 15 Apr 2023 10:43:23 +0000 (UTC) Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 0127BC433EF for ; Sat, 15 Apr 2023 10:43:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 0127BC433EF Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-50506111a6eso3091651a12.1 for ; Sat, 15 Apr 2023 03:43:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555401; x=1684147401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=TS0mVAwVSMB3TZMk93moob2qJ+9hbVdN2NNKYdROxrSv8Z2oA+4aGmxXKYDuzVcEm3 9WAO3TLgfk3G9ML7RIXjY0+uQuOmbaL6k8vqqwULuHlX4X2D/JxVN7h09cN4x7F2pn0t rpPYUBFDVlWZN7Caw5m+gaDUA9OmWj7wWdOGkRClJNU/AssvaD6n7MjIAQ8qkTQ5mZbU /SnSYhRWfTfkZGxD448UcXPUHEWCtgGCvKWl7FytOSgOWlkxLBnyhhZ4EzKf9SK/f1Ds eRUlsFjGuXFUyLEKgfNLUmosguoAt5m5GlPTyye+qpAhUv8pWtxlwd2Q4Arp7Rz6dAk4 dIXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555401; x=1684147401; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=OV2kxcAVLiBO3jAPb0hqO/OYTvQ06/VzqbrrHUBv1H04DAs9MTTyt2CShIc5SC6yCe mCBcva4+9O3rqDtLmoeiPzrsBmIkNOaPagb6AQ+6bzQZx1Wes1WXqrgtlPhe06imcn/e f88By7TybWtI4bMz6E6smxp/aIzEt8cA4h3MdhYlnScnxspgrwT14v2XRZDNs21S5+y1 suFhKLzEeaFZJNo8c9fPDk0YjyU1EQwOWBOb3RLLHj5rQjIwoSxJ5FQpEHuto3RlgViL Ad3VrZV72fkrdJrA/4aDW7L+mS00Ozmk53okOpwQ+G1A7Zy4yis5KUYSzW7WXEPmIxGX TFfg== X-Gm-Message-State: AAQBX9eJBptMtFv2koY0wWqYw0K2Bu0lnGvvIqkLoYQAK8jT0RwxsA32 dTExVINUapcvXSn7s2BphJ+R8w== X-Google-Smtp-Source: AKy350Y/jEVtp7V14c4ipCG9viPadpCpFPQ5g4EBv4b8edo0N6mm6U8UNf34WSAn2Z2nfW+5TbCmYg== X-Received: by 2002:a05:6402:1257:b0:506:8e91:3b35 with SMTP id l23-20020a056402125700b005068e913b35mr1944679edw.13.1681555401131; Sat, 15 Apr 2023 03:43:21 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:20 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 4/4] w1: omap-hdq: allow compile testing Date: Sat, 15 Apr 2023 12:42:53 +0200 Message-Id: <20230415104304.104134-5-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 omap-hdq does not depend on anything from ARCH_OMAP for building. Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/Kconfig b/drivers/w1/masters/Kconfig index 692cac3ff0ee..ad316573288a 100644 --- a/drivers/w1/masters/Kconfig +++ b/drivers/w1/masters/Kconfig @@ -53,7 +53,7 @@ config W1_MASTER_GPIO config HDQ_MASTER_OMAP tristate "OMAP HDQ driver" - depends on ARCH_OMAP + depends on ARCH_OMAP || COMPILE_TEST help Say Y here if you want support for the 1-wire or HDQ Interface on an OMAP processor. From patchwork Sat Apr 15 10:42:54 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212451 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3D805C77B76 for ; Sat, 15 Apr 2023 10:43:25 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 232D8C4339C; Sat, 15 Apr 2023 10:43:25 +0000 (UTC) Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 15AC6C4339B for ; Sat, 15 Apr 2023 10:43:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 15AC6C4339B Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f48.google.com with SMTP id 4fb4d7f45d1cf-5058181d58dso2757720a12.1 for ; Sat, 15 Apr 2023 03:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555402; x=1684147402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TOqB6Hh2cSpiNdbIkRosOrKqQ+RZFx7UN3jJlAfn/7k=; b=wOIFkjp98Oot9k1oi5lJxXgNJfK/wWjEj5CW+I6Suhrx9f7FAmmZ0U+gkd2j8pjya7 PTBfIYHP43DDauhySLvsvTyvTiE+kvoiIzO4t/wrIHW3JUVSj73EF2AKut5rUXYkkIKE SpLt2AQDIu7Jb4i8YvXFwYLl0G6KmevFbc3cvcQemaNDpYGIubgFUHiGnyWSEXXVjYCI BowNq1zRGpC8udrcx1nx31t1u0KaZcp1NQZWSU5A7kBpWec8Lv6scsczZQyH5R9ljTAv WhmSFQb0Z/WLwMRvj24+vJqSpYORz62lvvivOeoYgeM8iV8dfvA3fChXrrc5c7THpyCk A6NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555402; x=1684147402; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TOqB6Hh2cSpiNdbIkRosOrKqQ+RZFx7UN3jJlAfn/7k=; b=f2nEzgcFZdsm/t+VOtO+dlNId6ZM7+cztmxA7k5YYnWXcFtQmD/MNzgK4jalj7J+Oq xLRC9EBUSgYOTo786/jI2ONtFglYgtmNFekjD9jICUwk9mI/oCwb9mG9/zVJfKtsZPMM 99lRR3woFYv0R4JG09vjBAQnRv/lZE/TrQkddp26EJyGTjLwiBFJOftDJzD5HIW3NddI +1sTdVxVTQGblLFyMHlNxgJVwebbQhIfyxh3iDP0EspI1EV1ZoefJVEap1PFUmk8W68q Q/H05nOkYCr4tFSpCJ6qMrkzPHqlhYIea7guXxUswnjzF9zLFVmDupjJGxmbtm2mzp7j QMXA== X-Gm-Message-State: AAQBX9fYc1ZH9Snr7KChOEadq0zYInKxHy8S7NpTTlSjliD6pEVACT0J fJk0hqMBXx91EtDQzDobsn1z0g== X-Google-Smtp-Source: AKy350Ypa5Fu8Ca+HIsIdof7rvkA01OBiRVW51R7F246z8aRdNC9/gILiVEQwvADspd8tMNUIMBgfw== X-Received: by 2002:aa7:da0d:0:b0:506:8884:7f5 with SMTP id r13-20020aa7da0d000000b00506888407f5mr2820270eds.41.1681555402312; Sat, 15 Apr 2023 03:43:22 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:21 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 05/15] w1: use octal for file permissions Date: Sat, 15 Apr 2023 12:42:54 +0200 Message-Id: <20230415104304.104134-6-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Improve code readability and checkpatch warnings: WARNING: Symbolic permissions 'S_IRUGO' are not preferred. Consider using octal permissions '0444'. Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/ds2482.c | 2 +- drivers/w1/masters/omap_hdq.c | 2 +- drivers/w1/slaves/w1_ds2406.c | 4 ++-- drivers/w1/slaves/w1_ds2413.c | 2 +- drivers/w1/slaves/w1_ds2805.c | 2 +- drivers/w1/slaves/w1_ds28e17.c | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index 806e352c8292..90c0a33747db 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -36,7 +36,7 @@ MODULE_PARM_DESC(active_pullup, "Active pullup (apply to all buses): " \ /* extra configurations - e.g. 1WS */ static int extra_config; -module_param(extra_config, int, S_IRUGO | S_IWUSR); +module_param(extra_config, int, 0644); MODULE_PARM_DESC(extra_config, "Extra Configuration settings 1=APU,2=PPM,3=SPU,8=1WS"); /* diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index bf2ec59c1f9d..ae3e504cd543 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -48,7 +48,7 @@ static DECLARE_WAIT_QUEUE_HEAD(hdq_wait_queue); static int w1_id; -module_param(w1_id, int, S_IRUSR); +module_param(w1_id, int, 0400); MODULE_PARM_DESC(w1_id, "1-wire id for the slave detection in HDQ mode"); struct hdq_data { diff --git a/drivers/w1/slaves/w1_ds2406.c b/drivers/w1/slaves/w1_ds2406.c index 3bb88b51fe2b..2f5926859b8b 100644 --- a/drivers/w1/slaves/w1_ds2406.c +++ b/drivers/w1/slaves/w1_ds2406.c @@ -99,7 +99,7 @@ static struct bin_attribute w1_f12_sysfs_bin_files[NB_SYSFS_BIN_FILES] = { { .attr = { .name = "state", - .mode = S_IRUGO, + .mode = 0444, }, .size = 1, .read = w1_f12_read_state, @@ -107,7 +107,7 @@ static struct bin_attribute w1_f12_sysfs_bin_files[NB_SYSFS_BIN_FILES] = { { .attr = { .name = "output", - .mode = S_IRUGO | S_IWUSR | S_IWGRP, + .mode = 0664, }, .size = 1, .write = w1_f12_write_output, diff --git a/drivers/w1/slaves/w1_ds2413.c b/drivers/w1/slaves/w1_ds2413.c index bf4a72aae28a..739009806467 100644 --- a/drivers/w1/slaves/w1_ds2413.c +++ b/drivers/w1/slaves/w1_ds2413.c @@ -128,7 +128,7 @@ static ssize_t output_write(struct file *filp, struct kobject *kobj, return bytes_written; } -static BIN_ATTR(output, S_IRUGO | S_IWUSR | S_IWGRP, NULL, output_write, 1); +static BIN_ATTR(output, 0664, NULL, output_write, 1); static struct bin_attribute *w1_f3a_bin_attrs[] = { &bin_attr_state, diff --git a/drivers/w1/slaves/w1_ds2805.c b/drivers/w1/slaves/w1_ds2805.c index 6b5d12ba1b65..4c1a2c515317 100644 --- a/drivers/w1/slaves/w1_ds2805.c +++ b/drivers/w1/slaves/w1_ds2805.c @@ -264,7 +264,7 @@ static ssize_t w1_f0d_write_bin(struct file *filp, struct kobject *kobj, static struct bin_attribute w1_f0d_bin_attr = { .attr = { .name = "eeprom", - .mode = S_IRUGO | S_IWUSR, + .mode = 0644, }, .size = W1_F0D_EEPROM_SIZE, .read = w1_f0d_read_bin, diff --git a/drivers/w1/slaves/w1_ds28e17.c b/drivers/w1/slaves/w1_ds28e17.c index fdbaf77620ac..52261b54d842 100644 --- a/drivers/w1/slaves/w1_ds28e17.c +++ b/drivers/w1/slaves/w1_ds28e17.c @@ -31,12 +31,12 @@ MODULE_ALIAS("w1-family-" __stringify(W1_FAMILY_DS28E17)); /* Default I2C speed to be set when a DS28E17 is detected. */ static int i2c_speed = 100; -module_param_named(speed, i2c_speed, int, (S_IRUSR | S_IWUSR)); +module_param_named(speed, i2c_speed, int, 0600); MODULE_PARM_DESC(speed, "Default I2C speed to be set when a DS28E17 is detected"); /* Default I2C stretch value to be set when a DS28E17 is detected. */ static char i2c_stretch = 1; -module_param_named(stretch, i2c_stretch, byte, (S_IRUSR | S_IWUSR)); +module_param_named(stretch, i2c_stretch, byte, 0600); MODULE_PARM_DESC(stretch, "Default I2C stretch value to be set when a DS28E17 is detected"); /* DS28E17 device command codes. */ From patchwork Sat Apr 15 10:42:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212452 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C996C77B77 for ; Sat, 15 Apr 2023 10:43:26 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id E840CC433D2; Sat, 15 Apr 2023 10:43:25 +0000 (UTC) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 1DC21C433EF for ; Sat, 15 Apr 2023 10:43:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 1DC21C433EF Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-50670cc3abfso1882331a12.1 for ; Sat, 15 Apr 2023 03:43:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555403; x=1684147403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4MjSoC4TCDNhW7OuBd0aJYjoOlcx2Rf2xm/2TifHqkY=; b=r5n0teVtYfgLHJ9wzgJf36fggiHajrPhV/1oicQB5mindesT092j8KTlCn7LyH2mEs WgoDF6KkjqBEUHazPhB9mv4CS/ITzw4m/vUtQzaLxgJJERgkLDO5lXr5opoKYyg1w+yj amr5Gi2NoJ6mAY9/ImrkB1UNslGEwrdYoJrz5IYX46Gm0Wt3JklNeWrXg0ie8PU/i6ut o+VPu82oVbRRLiCAMkrqHexsp1wbFfL1KSuJdYYiq2taL8UAS8zZaFuBpY7DlPxh617l vZADQU4ytdiF4fpYPijHzxO2SCcsdJFgd4zLqJ9qk7DI206XS63S9hy/YMq5GNi3YJ+a j7MQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555403; x=1684147403; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4MjSoC4TCDNhW7OuBd0aJYjoOlcx2Rf2xm/2TifHqkY=; b=f3Lxcpdlkmh56MAbAFNR6wqsPgqet08KgFSxae+4g7d9+ffwN4yknv7v/fk3zlvd+t bdJ7Ew5wf/lKXeQLNuLNJv6iayu6cog8PuUNJsyONx7fMhF6A32/Ev7acfEo6uw4HGyK XdZrhP4uXHvTKOTa0huvovsJb8yquTR5PlO8CjTTBBCl8dlTLGNjOtOPg0Mz6KiItFZM CB4EHt02GxofT9SPSIhfvmQcM5faP0zYeOc+Cl1tLlRaLRcx5LNmVgdzk0lBlSeHjjX4 NjiLRSWsD/9ZY8mFJF8HTmHcX5Q1PJT6IyqE+WZrBZibTQnyqrqo5tKvtf8Qi5FSKAV2 pJVA== X-Gm-Message-State: AAQBX9f3lzi2igBSTSeFDY0dYR1mEv7EUEuvXdnd6po4IEveb1SdYlw7 5UjQGh0ntcmP810+BmVVbQq15A== X-Google-Smtp-Source: AKy350Yrv9okA+dGhbqDF/SEess+c9iNTOKwIXP3omv9uneJhrdzxrKiFw0whbsWdpmvHHdnSmQOQw== X-Received: by 2002:aa7:dcd4:0:b0:4fa:ee01:a0cb with SMTP id w20-20020aa7dcd4000000b004faee01a0cbmr9434833edu.32.1681555403256; Sat, 15 Apr 2023 03:43:23 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:22 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 06/15] w1: ds2433: do not use assignment in if condition Date: Sat, 15 Apr 2023 12:42:55 +0200 Message-Id: <20230415104304.104134-7-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Krzysztof Kozlowski --- drivers/w1/slaves/w1_ds2433.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c index 23cd099d032b..9f21fd98f799 100644 --- a/drivers/w1/slaves/w1_ds2433.c +++ b/drivers/w1/slaves/w1_ds2433.c @@ -98,7 +98,8 @@ static ssize_t eeprom_read(struct file *filp, struct kobject *kobj, u8 wrbuf[3]; #endif - if ((count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE)) == 0) + count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE); + if (!count) return 0; mutex_lock(&sl->master->bus_mutex); @@ -208,7 +209,8 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj, struct w1_slave *sl = kobj_to_w1_slave(kobj); int addr, len, idx; - if ((count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE)) == 0) + count = w1_f23_fix_count(off, count, W1_EEPROM_SIZE); + if (!count) return 0; #ifdef CONFIG_W1_SLAVE_DS2433_CRC From patchwork Sat Apr 15 10:42:56 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212453 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 23B04C7619A for ; Sat, 15 Apr 2023 10:43:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 0C19CC433EF; Sat, 15 Apr 2023 10:43:27 +0000 (UTC) Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 35A30C4339C for ; Sat, 15 Apr 2023 10:43:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 35A30C4339C Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-94f109b1808so39544266b.1 for ; Sat, 15 Apr 2023 03:43:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555404; x=1684147404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ItnFwDfcwsqeS2QehC4MzuWbNu7xUa/nTNiku0cT6q8=; b=zeV7LuBrZkIjBK7n40U3u33EVUV8ktgLJgumBB/CXtFsUTLE98GXhp9rXGaDxxWW43 2bNss8gDD2OxajnwJdmBav5Mu5b1XPqwgfZ5uWfKqjQitDidTummuAQkl6TXF8yJXraT HvWlNqhSfodkzfdRLg3dHpK8BRaBopDgLd5NqFCGfr51pA20dGUkWDzW0ON4wto5O1uR DVu/3yMRDhAheB6FUP546DdkOM5wG/Pv+zx8pt3s3UzPaHqLR79F4G1ChmT2tNw0ZLWL ke3sdlZBqJxrSu2VlZaaX1TBJOMqiuJ4jUxlE9pHJstvOpIcxy+1t2BAwxVZLW1qK2up 7pXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555404; x=1684147404; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ItnFwDfcwsqeS2QehC4MzuWbNu7xUa/nTNiku0cT6q8=; b=WNKallyaeRCcIGX8+WrDc+f3w+W0N0QImqfk3dNzUWYB+z+I2IOr/Vi+RGMjoAJd1v 6bNnde1zh79YXIbsEVqGHq/uOgZZJkw2Ce0xyjey7cVEnk/rKoh7P1Ibnu2R21tpIAjj cK4vI1d8ztjN3wfcGK4ZUY1wB7e1vObK9AhHuM94+L3f+AnSK78BkwR7dfPMeATiFg7c BLxA352Vdr+TxwnWoFj4CH6BOmxaa6d+3anUzvjWtAub2OWFYx+uMXkGkis96tv+jzkl Hws1nQdRudznADulM9i/YRiqOfPUjJmosf0jKnwoxApSYiwSPD1aKqXX9YqoBpkuzUUG 1Hxg== X-Gm-Message-State: AAQBX9cITz9gkYUs/Ai5337c5ayOR8evpqkL+8HPTumoxl1Y8D8hn89P vpL7m7jrhgoHn1nYZe/7rZTO+Q== X-Google-Smtp-Source: AKy350bPRbufNSuY7GUQjKnVdZFyy9yhi/blBYi5kJOs+vNjjp0jCuOVqYlC340a/TPCzmSIT5S1Yw== X-Received: by 2002:a05:6402:1156:b0:506:8838:45cc with SMTP id g22-20020a056402115600b00506883845ccmr2817127edw.6.1681555404418; Sat, 15 Apr 2023 03:43:24 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:23 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 07/15] w1: ds2482: drop unnecessary header Date: Sat, 15 Apr 2023 12:42:56 +0200 Message-Id: <20230415104304.104134-8-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 linux/delay.h is already included, so drop asm header to also fix checkpatch: WARNING: Use #include instead of Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/ds2482.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index 90c0a33747db..7e915b71045d 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -15,7 +15,6 @@ #include #include #include -#include #include From patchwork Sat Apr 15 10:42:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212454 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 33B2AC77B71 for ; Sat, 15 Apr 2023 10:43:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 1D57AC433EF; Sat, 15 Apr 2023 10:43:28 +0000 (UTC) Received: from mail-ed1-f46.google.com (mail-ed1-f46.google.com [209.85.208.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 41D60C4339C for ; Sat, 15 Apr 2023 10:43:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 41D60C4339C Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f46.google.com with SMTP id 4fb4d7f45d1cf-5069097bac7so345773a12.0 for ; Sat, 15 Apr 2023 03:43:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555405; x=1684147405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=eCXVhY21NYv8g0uVv2aMkrRaQ5OFE2M1RqCENUZEQwY=; b=MaeoAEhme5S3w6Vvm2hlX3H8xIfe4cKomyHpefHejjA5ljeacJhQM/kb4o7+eiw0Lb hoZ/DxNAqYGxd2DYpb355e27sMyk8XGTNuJPFDVlQqT6M/xYcY7JMUblwZxhTDMSs2Ff JVHN5V5XgZEUn/lfe4teNo+OHcpeLfrSZu9LbLtvlxexDFltXHvJk3oQ3XQ+6cOEC4WZ oaeSaThl1C8vFWrP6nXOOK2ESynnOFKsSaF6xikIMLFYpBlCatoEFokHwK9zRFUDZuMI yCBGNUIVfqqmBp0+QOXDsrQdTzy62ff2qusUwOjiOhRNoBq4lIsS9z49QuIaoPN5jRzT U7yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555405; x=1684147405; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eCXVhY21NYv8g0uVv2aMkrRaQ5OFE2M1RqCENUZEQwY=; b=it1FqDpRoz1+UD4PtIjnXg9VNDwNdCALmtRCQtGnCqr2s9yHehKhfTNcXCDTt0o03v 0Y20ixcOnBscmTBDgOnw1MBkM9+M0DMsKLBKeHaxlz39OV6hxYYMnJ1sAwcuIO/n3wFJ AA8pBb9IUFUiRps1zcjgdXTzdK+0Ii1xQ8cYLk/42gMhaS59XUG+oELlrSKlH/t7kjUD 47aYYZ9b45pZ01WTBdLk2JFZjnljc1kSLPAeig4TrB3DhmGEtgt0dVI2Nbmem84qpVuo zW9oIR+fRLbqnjEGBOWyPIE3vMMwMCA7zrZ6XKaU+3B2pr62fWSvnmzEV5TuZgLnqHva R8bA== X-Gm-Message-State: AAQBX9eEU+QPjnUZtByqUWZrHhoFW+QO5j9gtMBXJIijQcuReqYoOVJG feTRLyWu+fvgNpqfdLKx30NFkQ== X-Google-Smtp-Source: AKy350axUyld+HptWNFgmq7JEqEvSwSiRuyM/yYdGSOt3UHn5lx/H7ibPIBuKDzGrCTLDESGCPzlMQ== X-Received: by 2002:aa7:dd59:0:b0:506:77e6:c9e5 with SMTP id o25-20020aa7dd59000000b0050677e6c9e5mr6271718edw.8.1681555405433; Sat, 15 Apr 2023 03:43:25 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:24 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 08/15] w1: ds2482: do not use assignment in if condition Date: Sat, 15 Apr 2023 12:42:57 +0200 Message-Id: <20230415104304.104134-9-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Assignments in if condition are less readable and error-prone. Fixes also checkpatch warning: ERROR: do not use assignment in if condition Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/ds2482.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/w1/masters/ds2482.c b/drivers/w1/masters/ds2482.c index 7e915b71045d..f4ad644a7abf 100644 --- a/drivers/w1/masters/ds2482.c +++ b/drivers/w1/masters/ds2482.c @@ -451,7 +451,8 @@ static int ds2482_probe(struct i2c_client *client) I2C_FUNC_SMBUS_BYTE)) return -ENODEV; - if (!(data = kzalloc(sizeof(struct ds2482_data), GFP_KERNEL))) { + data = kzalloc(sizeof(struct ds2482_data), GFP_KERNEL); + if (!data) { err = -ENOMEM; goto exit; } From patchwork Sat Apr 15 10:42:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212455 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0B724C77B76 for ; Sat, 15 Apr 2023 10:43:29 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id E9028C433EF; Sat, 15 Apr 2023 10:43:28 +0000 (UTC) Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 2B0E6C4339C for ; Sat, 15 Apr 2023 10:43:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 2B0E6C4339C Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-504efe702d5so2720592a12.3 for ; Sat, 15 Apr 2023 03:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555406; x=1684147406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=JU+5r6JwnlkZV5udDpSU3TN1NmnqBEFaQ3l0VUaFTms=; b=u511iv3WysXlmqIRNEbk0a12CsPPRkaNq6plomGGvHIsvGFq/gHRz5u4Apv3X5I9s0 LnhTO02jB3h5e+5tG8C4HTPKnnbraGhyQGJnY3vx0dUIPGe8kjAN01ztD3P3rsle9bXd RJ+Us5PbPLRGW5x26AnX/lnCpPJFKFMGKp906BrPG5cUYil/21+5n1u1kJJX3/2u2USy wB9ouYXLn9DEbc1kgwSpzfE+LwUkVbRa/cwSbk3YXnoMvVljlaqH82dMgNv4MpJyfJuS 1wi7X36BOoqU3el55JPTw3aPFth82d3dDJS2TODyYhEViZqO500J3JhRFDbDCVr1HiLd WZsg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555406; x=1684147406; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JU+5r6JwnlkZV5udDpSU3TN1NmnqBEFaQ3l0VUaFTms=; b=fMkEXokWjxNjAQVIE5U6D+52b+DGCecuJYDtwXhC83kZE0LipPBF7QlN2eqvVX2a86 oDQYyBizDUbnj/btCRrNCDIOhn2NqaEHKbJW4VMC/Vg+j8Wf+n34Bvv1UmoKlOt3kmQ3 VgpWhlHiuUssDp2B0jYT/AcdjkxoiKwfyT+0m3y4zMGPYmc0ikDfeft2tZCvKzZKvJHX SdH/eev24C44zwBgjtyWw984SLt27MKOhOm2KLIq6wVn1OQb4oeTmj8noh29pXje2WJt U1OsvMEPU8fXJIhxefmH4ABl5o0QX7eLwSaWgpPtgjJL81fAqJCga5ZcD/GRg5Xk4MAQ Y4HQ== X-Gm-Message-State: AAQBX9fSMoMSUX74XHUJVYb3/LP4SIJp4hKFXirymBGVZUK5m7TgRRpI 2j1wDE39ar5auAb6Q8qz8T4F4A== X-Google-Smtp-Source: AKy350YyOTMpW+nN80cP1bbacqd+TASdoxSP7lVeVgOVVD1mXbr+acvFjhul8bei+0eLKe9bJgdTLA== X-Received: by 2002:a05:6402:5168:b0:506:75e6:6321 with SMTP id d8-20020a056402516800b0050675e66321mr7198815ede.30.1681555406465; Sat, 15 Apr 2023 03:43:26 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:26 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 09/15] w1: matrox: switch from asm to linux header Date: Sat, 15 Apr 2023 12:42:58 +0200 Message-Id: <20230415104304.104134-10-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 linux/io.h is preferred over asm/io.h: WARNING: Use #include instead of Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/matrox_w1.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index 94a1f3fa2dc3..662108b1d806 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c @@ -7,7 +7,7 @@ #include #include -#include +#include #include #include From patchwork Sat Apr 15 10:42:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212456 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 45C26C7619A for ; Sat, 15 Apr 2023 10:43:30 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 26527C4339C; Sat, 15 Apr 2023 10:43:30 +0000 (UTC) Received: from mail-ej1-f43.google.com (mail-ej1-f43.google.com [209.85.218.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 4E056C4339B for ; Sat, 15 Apr 2023 10:43:29 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 4E056C4339B Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f43.google.com with SMTP id gc14so6743086ejc.5 for ; Sat, 15 Apr 2023 03:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555407; x=1684147407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=a2p4W5eau8bFWAzOfsvO6/XIL8xZyE8Y7G5G/91OHq0=; b=XSqvT0MjSDdLTrS54l9ymoLk0dcAi+uusPHgm963TQ8wCFPSVMSeE1ZFT5wOxDlg5T KzeQ3q30t3Y9XN6PVBlq9WJICKGIDYBdlFruiisSKJP5PfpUx68xKyBj8yWyIZnpId8P gVNolNHrl0D0nNByF1+1+TT+E/LJ+yhV7hmJf+m5LdtBKshrsr5IMPcz2i2QSFDTNJ2/ SlUJsGf/MUsg2LWtRPWfnc9rKY5b4QszIT14GBCrS45t+uljNM3nU1G27X/cZ3X7qeKl criRn8R2npvBXWn34nDI+taICL7B4ZQl8pJiHEI5G2ZlHcbojOBnvhHSbXcGdKO7M95J WNtw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555407; x=1684147407; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=a2p4W5eau8bFWAzOfsvO6/XIL8xZyE8Y7G5G/91OHq0=; b=IfOD7yxji+sH4FceCcAdZqKSAPba7oY+mGZhilqzJLkaaggRZEdVDVfol0jIQ+US14 Ludp1l19/TrMdD7BCdXEMmH8vP9W3tH8KAo1fkmQnosDCQ9Jx6hgnkoekanAyvF2eUcL Sm80hXqa9jupqGDKe8dtye5QKBSWEllS9HF4sZFpSBU/9tPE7yJZbyfbmgKp4nPOnTjs a1CgtGAxrM++nI0tc1apvn35hQTKPYxpDA2C5mp4E466IVcYJbIt/5PAor4J2zGdBm5y 9h2F4jaFqHAmLcIt1PESxP0F3/DU2k3eIQZFlGzx71tGOn70Hd0ZI+UfHb1v1qNRg+EB hr4w== X-Gm-Message-State: AAQBX9cd/6v2kxt//fPaAXZuaHG8lyyDDLgQJo9R4UI6ofuUWD2+wW6l 76ZS+quo3ARxYZLjWZ+w3T/nJQ== X-Google-Smtp-Source: AKy350YHGBB50ymOjH++0GwAiv3zGH2q9RmNoc2RqYpIg9DKEFNk7nmLsO7o3uBbLq3E/8fWE0lc8w== X-Received: by 2002:a17:906:fc2:b0:94a:6874:713d with SMTP id c2-20020a1709060fc200b0094a6874713dmr1476846ejk.56.1681555407506; Sat, 15 Apr 2023 03:43:27 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:27 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 10/15] w1: matrox: use inline over __inline__ Date: Sat, 15 Apr 2023 12:42:59 +0200 Message-Id: <20230415104304.104134-11-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Switch to inline as preferred by coding style: WARNING: plain inline is preferred over __inline__ Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/matrox_w1.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index 662108b1d806..fb38d92b2f43 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c @@ -63,7 +63,7 @@ struct matrox_device { * * Port mapping. */ -static __inline__ u8 matrox_w1_read_reg(struct matrox_device *dev, u8 reg) +static inline u8 matrox_w1_read_reg(struct matrox_device *dev, u8 reg) { u8 ret; @@ -74,7 +74,7 @@ static __inline__ u8 matrox_w1_read_reg(struct matrox_device *dev, u8 reg) return ret; } -static __inline__ void matrox_w1_write_reg(struct matrox_device *dev, u8 reg, u8 val) +static inline void matrox_w1_write_reg(struct matrox_device *dev, u8 reg, u8 val) { writeb(reg, dev->port_index); writeb(val, dev->port_data); From patchwork Sat Apr 15 10:43:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212457 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 268F3C77B77 for ; Sat, 15 Apr 2023 10:43:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 0F7CBC433D2; Sat, 15 Apr 2023 10:43:31 +0000 (UTC) Received: from mail-ed1-f42.google.com (mail-ed1-f42.google.com [209.85.208.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 32CCDC433EF for ; Sat, 15 Apr 2023 10:43:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 32CCDC433EF Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f42.google.com with SMTP id 4fb4d7f45d1cf-504eac2f0b2so3434812a12.3 for ; Sat, 15 Apr 2023 03:43:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555408; x=1684147408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dNpxORV+uoxzQyQgTWsAR7xLsJXttT16I2OZ/0Honq0=; b=aW07LZTdTwP7o5RXmg8t7d4WFICyTSv+PXdRSa8Msr4wzY/LXIrZsQbLG5nhA6tdfj f0Zo3G6XhksREG0cy9X5oV3y4DDqNOD5bZJY1DNCoWthLRVzJQTfSg3UrKmxxoDzbAs1 80ADIsMge9hQ47Sktug56lB6XdBnUq1b8X17AUF/zhKHwh5mLKmCglcqZeZdc3y030za ZF4PYygVggajmzOA//IRZzzuIfSPDlPft5mwgXSIWQGQ/gzovNNNPVDuXe9rlfSlRa0+ /AIAQtUAQvjitNZNKCH/ZcjksU1xNZLqocrjcD8OJpHQ8l7s0zyRVvxTv0bQx2mOECKw psQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555408; x=1684147408; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=dNpxORV+uoxzQyQgTWsAR7xLsJXttT16I2OZ/0Honq0=; b=b6AAMWC2V0gd2WIoxWLWkD6xR/xF9DmbOEQ2whuIAHg9Z4tkhqhQPzq+bEJdIBetKS 9C2E8IptucuD8fHibRzvAB4N2BEucLhKl1m5+bKKfLm8HslCRuLYAkc4vyRNPeW1TlUp UCXdEHpu+j5NUkcV6hn+wIY5qveXB2GYpY6FmyTMtLXPpkvnlv0aXwRahRP3J0W3p0fi R6vlOlP0T+PxQ2op7X0gekF8Wov0L6rmX5UNLHGPjtoq84LVjJar87sAG+OMn7Oddz80 Za8wcskoFPIw2OC19nrG414bayB4+/92YY4UudKK7DwzzhSlEeqkrkFgyTaEQafiiUZK cTag== X-Gm-Message-State: AAQBX9dtCtdV4Tp1AxDGard5w+SvI0cH8ccWgEpxHWX5cm/5QsvZmoZP ccwWXH9cpo4F33XvFHFMIgJD4g== X-Google-Smtp-Source: AKy350Y3GOYqbNMSnzkQCc0JrsAFfLFROPGeR3lT8jjPs5mFkIueWpDuN5QsJOgO7YKSusVnYhKh6Q== X-Received: by 2002:a50:fe94:0:b0:504:9393:18b1 with SMTP id d20-20020a50fe94000000b00504939318b1mr9209691edt.9.1681555408494; Sat, 15 Apr 2023 03:43:28 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:28 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 11/15] w1: matrox: remove unnecessary ENOMEM messages Date: Sat, 15 Apr 2023 12:43:00 +0200 Message-Id: <20230415104304.104134-12-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Core already prints detailed reports on out of memory: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/matrox_w1.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/w1/masters/matrox_w1.c b/drivers/w1/masters/matrox_w1.c index fb38d92b2f43..2852cd2dc67c 100644 --- a/drivers/w1/masters/matrox_w1.c +++ b/drivers/w1/masters/matrox_w1.c @@ -122,13 +122,8 @@ static int matrox_w1_probe(struct pci_dev *pdev, const struct pci_device_id *ent dev = kzalloc(sizeof(struct matrox_device) + sizeof(struct w1_bus_master), GFP_KERNEL); - if (!dev) { - dev_err(&pdev->dev, - "%s: Failed to create new matrox_device object.\n", - __func__); + if (!dev) return -ENOMEM; - } - dev->bus_master = (struct w1_bus_master *)(dev + 1); From patchwork Sat Apr 15 10:43:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212458 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5CDA8C7619A for ; Sat, 15 Apr 2023 10:43:32 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 4458EC433EF; Sat, 15 Apr 2023 10:43:32 +0000 (UTC) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 60272C4339E for ; Sat, 15 Apr 2023 10:43:31 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 60272C4339E Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5066ce4f725so2021915a12.1 for ; Sat, 15 Apr 2023 03:43:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555409; x=1684147409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=YXcbgRwsSgr/cZJsxc8wHJKyT2TNmzYL0AS/8ZRCR5I23P+xV4iRCgOJJ/b+doiGoP 1PMy18o+UMdWKonNljUZNVQ6z2oyM1sNBaWRa/bmOS3qGWngxZZ8QsD+SEh1LcjxOdPl goRDvRwsJ8qKJEA+smv6WiMmABWP43MzDflZ/29iv24fcUwlrhR1U++ZdwDJPlfQyQ0n v5taaDS/yUDTaNe56P+LON+qY7Q32ruraDVQniSE97D/mU9IaHmcwWmpCjObjjV8yE2Q y5Ooz5D0Rv6GXP0BDgj0s5uh3Fa9RLcj2JmUowCBxWc6qx3A4+26bonHxm1DbgQ61qvG LfMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555409; x=1684147409; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q/p4NRTjs3BLjzJ+cn6r3EmwmpCVSEOW5kd0Ht7+9co=; b=dx7RZwuEGa7o8m+pXEI/7xUiGYClsj4haUnV4O5IdICeb+T1RVaYw+CIPbsJZ0IZcQ nok9LVx+QDlpxfZ0g7sBt1U99+fxkz5fZXN0nc1fF5lD5cfIepIQNDvzAEmV7OlJ5hTH INdPfOjVUDnzoZ9NKxbtKRMeKXoO91d4H7UV7EL4nGJMXv8uT8kourON6Ndkd+37F0Uw h7RWjRYE7ACUOjz5jAg6PwxgH6TnCIuZKF49KcBekJZ+AVnG7+mpTUKd6RP5qHH19XsE +V1J7SwRVKliypZEZ+a8965120s51jS7iJlz/Xu1kczKs+Ht3kV0TeQOpcD/6VlvKBx+ ZQSg== X-Gm-Message-State: AAQBX9f2A9G1KrH0APLkM25HDe0gHb4605agBBBpDdeQhLt+EclOPB12 wnnVMO69+ZedkBCDPpdZSIzXKQ== X-Google-Smtp-Source: AKy350b8nFIjeKtfcK+zDkqqPw0+7OElRQc6Y3ogylMJD+VwGYTUHrhFdnCujozs0PidPBblAjvWmA== X-Received: by 2002:aa7:d509:0:b0:506:7d34:51d1 with SMTP id y9-20020aa7d509000000b005067d3451d1mr5623056edq.29.1681555409487; Sat, 15 Apr 2023 03:43:29 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:29 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 12/15] w1: omap-hdq: allow compile testing Date: Sat, 15 Apr 2023 12:43:01 +0200 Message-Id: <20230415104304.104134-13-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 omap-hdq does not depend on anything from ARCH_OMAP for building. Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/w1/masters/Kconfig b/drivers/w1/masters/Kconfig index 692cac3ff0ee..ad316573288a 100644 --- a/drivers/w1/masters/Kconfig +++ b/drivers/w1/masters/Kconfig @@ -53,7 +53,7 @@ config W1_MASTER_GPIO config HDQ_MASTER_OMAP tristate "OMAP HDQ driver" - depends on ARCH_OMAP + depends on ARCH_OMAP || COMPILE_TEST help Say Y here if you want support for the 1-wire or HDQ Interface on an OMAP processor. From patchwork Sat Apr 15 10:43:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 27294C77B71 for ; Sat, 15 Apr 2023 10:43:33 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 11FEAC433EF; Sat, 15 Apr 2023 10:43:33 +0000 (UTC) Received: from mail-ed1-f45.google.com (mail-ed1-f45.google.com [209.85.208.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 38FE6C433D2 for ; Sat, 15 Apr 2023 10:43:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 38FE6C433D2 Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f45.google.com with SMTP id 4fb4d7f45d1cf-50489d1af35so5682748a12.3 for ; Sat, 15 Apr 2023 03:43:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555410; x=1684147410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1JY3jsR/xgkB17cBH5xBif+/bYELKytDPMGjtCShK30=; b=rrCnD2MJDWFKfYhL7x6nQnOh+YMKDuJI9rtquhzI+vLy8lcLiIW6BnVDdMIgT9ZGdS 4br3TNxPAMwdnqae60DiBJkB/ehAtzVa/IsiKJFRzupmu6LA+mApQJg7YnfZCLzmECiL dyRl0mQXmPat6dmp2WMr5QIkCWnH7SrLfvBiKn/bknOM/O8OazYf3stnK5C/gx71gkx2 YcWAf75XPGDbC5b0WI1ZVfypjCzs1ZgAI1eJgTYXzZduZYaS8QuZQv5Zj46D1VawW4fr UeqjJDXn6AUzXXnXZ3U+2c6biextlhNru2xr2kTrDmwPXEer8lYNF/Br7j7Y2l0IiSu4 +2bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555410; x=1684147410; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1JY3jsR/xgkB17cBH5xBif+/bYELKytDPMGjtCShK30=; b=WAwezN+NSMbddaPZI5hgFzCf6FGpr6hBSZTTRiJr8MagaO+BYyCDYq6zl07FLjyU3+ 167atDf2pWndsxF3WJl7nYUkJ6G+rLX/RmDu3pRzRTBnMWPFsGqMFGF8tejBGEiRtFRN OWSzcFZvknuT01GODMXo61lC8blbPLKrCQCxKsADXNhwnELhBjClAnU+PzYK0buD7vXZ VCTT6Z126Aj2oRVUXvajNKERumqCl29hJQ0v7AEa6Q/9oRLHj1ATNXqpW507QyhAK5mN OozdvfIGLVCkPkjzmNp1RDolmO8xBENG5MHy6xtsvwpj81w5W/cB4J1C/u5COqUHo+Ku F31g== X-Gm-Message-State: AAQBX9cLXnMuIj5g1jVH2Rzow5kC6SinQZp2XBJowq9BCr43c9sqoosC cqbnYoqFvU6JwzRQJb0xacLOLg== X-Google-Smtp-Source: AKy350ZATVXui9h9cXaUtzFUPITgQBvaiO//1uAf1DShc4vcU9QHEaLogN577tZwy6t7lyOCjeea1Q== X-Received: by 2002:a05:6402:1486:b0:4fd:29a1:6a58 with SMTP id e6-20020a056402148600b004fd29a16a58mr9791328edv.19.1681555410463; Sat, 15 Apr 2023 03:43:30 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:30 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 13/15] w1: omap-hdq: add SPDX tag Date: Sat, 15 Apr 2023 12:43:02 +0200 Message-Id: <20230415104304.104134-14-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Replace GPLv2 license text with SPDX and drop unnecessary file name in comment to fix checkpatch warnings: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1 WARNING: It's generally not useful to have the filename in the file Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/omap_hdq.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index ae3e504cd543..826207c24bd0 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -1,12 +1,6 @@ +// SPDX-License-Identifier: GPL-2.0-only /* - * drivers/w1/masters/omap_hdq.c - * * Copyright (C) 2007,2012 Texas Instruments, Inc. - * - * This file is licensed under the terms of the GNU General Public License - * version 2. This program is licensed "as is" without any warranty of any - * kind, whether express or implied. - * */ #include #include From patchwork Sat Apr 15 10:43:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212461 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13AFAC77B77 for ; Sat, 15 Apr 2023 10:43:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id F110EC4339B; Sat, 15 Apr 2023 10:43:33 +0000 (UTC) Received: from mail-ed1-f50.google.com (mail-ed1-f50.google.com [209.85.208.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 2DF56C4339C for ; Sat, 15 Apr 2023 10:43:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 2DF56C4339C Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ed1-f50.google.com with SMTP id 4fb4d7f45d1cf-506767f97f8so1932545a12.1 for ; Sat, 15 Apr 2023 03:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555411; x=1684147411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5buqkue5965jfQy5B2BdRMuK1Vit+T6gg2ptTUMAnCo=; b=JbNLf4kZtv5Gjgl0zLLoKT4pJSwleFT3ifkJekiFLaat6x5g4dVnqrHkkCEn1H0rNL bec3i9Nj5vmMLznJbar3okJAxZCj1hJ15TixBGdrHRt485nQYXyvih6vXLh1DBx95aWh yy7/G1ZTNTCCTJbyDiI44ip363NsgriVktYooVC8R5FxrBWkNqeHC1Z2o7GIgRPeik7H 2bJ5sZgeW/yAFkbO+XqkmDOOOr+QHnj/rsMFGrwWBpvayPfpQbijX70hTRCh3P/bkvug ez3SGh67/kYA3QZ8aPzVWL863MoNKbW1NYFYw2Zh/qSAgQ/Dec47sL1schb0hTXirCmj ydWQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555411; x=1684147411; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5buqkue5965jfQy5B2BdRMuK1Vit+T6gg2ptTUMAnCo=; b=X9TsG1bxeecwYfPQIP0sHfUK2AzwoeBdb2EHiv8prVniKLDVaoRZnvsUvxi5R8O6jG AUqWeKVDqDdjJyInomn+GNhz5odpSWPr0rvKvL3kre94Ya89dRsAlUQXn54Efg9MAXWz bL6ntprX5O177+y8ypZYMf+Q6dpGTkBz1mkOZ4qEdV0TVR9G22Wb/ZJO5T4HbfapA0Ll /wFiIbk0+jsJriFGEM/1Wv4vBMLN3uv1mGyHT8rEMHmonaN7Rwqt+3m5GHzd2LbaQKs4 FUYCpyS40NLnV20eiJX13RiIzJO0RxDAT6SIZxcF8/egK/YbJax089sC/WbfwXlu92F8 LtBA== X-Gm-Message-State: AAQBX9dc/54rL4zhT+5GrdzQWrtdL/WB/73wUUnEUCzQXE4+A9xlkyQg lDJyzD7I1Mi2cXmsI/GFeUcQIw== X-Google-Smtp-Source: AKy350ZKvLWv7f/2M2Sgzqt65cxEHQTSAG6DpgZTuH7ADx+YAHDCfjCjqt3IgUqQLWy0Lug5eSJBOg== X-Received: by 2002:aa7:d48a:0:b0:504:b313:5898 with SMTP id b10-20020aa7d48a000000b00504b3135898mr8886150edr.27.1681555411461; Sat, 15 Apr 2023 03:43:31 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:31 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 14/15] w1: omap-hdq: remove unnecessary ENOMEM messages Date: Sat, 15 Apr 2023 12:43:03 +0200 Message-Id: <20230415104304.104134-15-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Core already prints detailed reports on out of memory: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/omap_hdq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c index 826207c24bd0..6a39b71eb718 100644 --- a/drivers/w1/masters/omap_hdq.c +++ b/drivers/w1/masters/omap_hdq.c @@ -573,10 +573,8 @@ static int omap_hdq_probe(struct platform_device *pdev) const char *mode; hdq_data = devm_kzalloc(dev, sizeof(*hdq_data), GFP_KERNEL); - if (!hdq_data) { - dev_dbg(&pdev->dev, "unable to allocate memory\n"); + if (!hdq_data) return -ENOMEM; - } hdq_data->dev = dev; platform_set_drvdata(pdev, hdq_data); From patchwork Sat Apr 15 10:43:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13212460 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22871C77B79 for ; Sat, 15 Apr 2023 10:43:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 0C256C433EF; Sat, 15 Apr 2023 10:43:34 +0000 (UTC) Received: from mail-ej1-f46.google.com (mail-ej1-f46.google.com [209.85.218.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.kernel.org (Postfix) with ESMTPS id 372E1C433D2 for ; Sat, 15 Apr 2023 10:43:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.kernel.org 372E1C433D2 Authentication-Results: smtp.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-ej1-f46.google.com with SMTP id a640c23a62f3a-94f1d0d2e03so16391766b.0 for ; Sat, 15 Apr 2023 03:43:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681555412; x=1684147412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/GpG6BrvNSByzEWolZqrrfdu9R1OUjer6DD5hZw47Yw=; b=SR8ucM9B6N4/Wvn8RZz18nK/iv9LqIsfQMhAigP33Ivuy1+kbRYO27mZnKqAw9y32Q AtP7SHwTbB1Ta86j0WTR90Vr5Sv4sRTCESymR2jgG6C0T68joTKZMiC6q5TmJOYPhei+ 9RN7yF2WD6pzC4WY+6xBu7fetubohElOypwB8YtBL5mSoNSHZTJGg3P88X89GyGSsmF9 o5I1QUHoJPRXy9MT2CQO0/15Bs4YSxLucV2pTlosuR444CvBnflp89KFthAvBD0t9ebD 0X5W4zvgfcyREyr2E8jXdWxHCcJTVZfI5WvBMTEQNupFKwwkUInT1jOV7ZJt71X5S/Ah bpdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681555412; x=1684147412; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/GpG6BrvNSByzEWolZqrrfdu9R1OUjer6DD5hZw47Yw=; b=Uojabmu8hepIVU4Ko6sWj7TvEmlDbVUJs0p07VHNhXE39laOFWfRcbjzaxtNc/HCed ksnJWtQQ21rvBthAGyMQu3xy3vjoJbxfxSUu6n8N7YJbg17aIpEds3WooyCZDTckcTxy ncvC6wT1Ho21VzifhRPD+OEqghPTxuRLzVnPZEJUJbvnc69Iwi+p5X+7UqQvXtS6Fmfs bKDrAQPf57Vht3O06h6YE1IcZ313EgbvPds9AU/Crpvbg65MUT0vqJRy0D0bDmfIEF6H T85RRm8Hi19EtoMnNEG6WGTfz9b8oevvI5j1skzTgeKKI/K9EiQ3Aes8SGZpSOGwKc/M Q0gA== X-Gm-Message-State: AAQBX9cZ+q7QFduzBkmhgbUtcoK/Km2/FLu6oSrlScqEK8wb1F0Mgje5 Qwn4V7mVUo7iTptYhxOVgCo5Ng== X-Google-Smtp-Source: AKy350bNSPXliC1HMcFk7yScGBMVjoz+38R0GHGZie0X0VdcqMt5F+DiXUR3dOCZbJKlmXnJFmQmCw== X-Received: by 2002:aa7:dd59:0:b0:4fc:9c79:86bc with SMTP id o25-20020aa7dd59000000b004fc9c7986bcmr9142694edw.42.1681555412732; Sat, 15 Apr 2023 03:43:32 -0700 (PDT) Received: from krzk-bin.. ([2a02:810d:15c0:828:a3bf:4ed:6c53:2a36]) by smtp.gmail.com with ESMTPSA id b10-20020aa7d48a000000b004fd1ee3f723sm3157481edr.67.2023.04.15.03.43.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 15 Apr 2023 03:43:32 -0700 (PDT) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , linux-kernel@vger.kernel.org List-Id: Cc: Evgeniy Polyakov , Greg Kroah-Hartman , Arnd Bergmann , Olof Johansson , soc@kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 15/15] w1: gpio: remove unnecessary ENOMEM messages Date: Sat, 15 Apr 2023 12:43:04 +0200 Message-Id: <20230415104304.104134-16-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> References: <20230415104304.104134-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Core already prints detailed reports on out of memory: WARNING: Possible unnecessary 'out of memory' message Signed-off-by: Krzysztof Kozlowski --- drivers/w1/masters/w1-gpio.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/w1/masters/w1-gpio.c b/drivers/w1/masters/w1-gpio.c index d4632aace402..ac7ad63f8f8d 100644 --- a/drivers/w1/masters/w1-gpio.c +++ b/drivers/w1/masters/w1-gpio.c @@ -101,10 +101,8 @@ static int w1_gpio_probe(struct platform_device *pdev) master = devm_kzalloc(dev, sizeof(struct w1_bus_master), GFP_KERNEL); - if (!master) { - dev_err(dev, "Out of memory\n"); + if (!master) return -ENOMEM; - } pdata->gpiod = devm_gpiod_get_index(dev, NULL, 0, gflags); if (IS_ERR(pdata->gpiod)) {