From patchwork Tue Apr 18 19:20:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13216124 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A49D0C6FD18 for ; Tue, 18 Apr 2023 19:20:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E79310E85F; Tue, 18 Apr 2023 19:20:58 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id A363810E85F for ; Tue, 18 Apr 2023 19:20:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1681845655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=aai1WHo4fg1sxKcLX3kD4BGAw1PP+pR+m3nWfdfcZTU=; b=SEJPcsAflSfXP88Lt9fb57YukdDbEswjw1lGuKpACS5WyAxg0NBNTljoFiGj/vv/dAGvG9 bC4WzVzxisL3tnNpi4w99QF8zVWcU3cXmA8L4JJOdkuZfZS5BExFrt+ii52s2XcBnfGW5O xTgRB9uwuE+7NeVoeakDW11IHC3YHAI= Received: from mail-qt1-f198.google.com (mail-qt1-f198.google.com [209.85.160.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-659-7lqq48ClNzG9PSdpF4edDQ-1; Tue, 18 Apr 2023 15:20:54 -0400 X-MC-Unique: 7lqq48ClNzG9PSdpF4edDQ-1 Received: by mail-qt1-f198.google.com with SMTP id l20-20020a05622a051400b003e6d92a606bso16315224qtx.14 for ; Tue, 18 Apr 2023 12:20:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681845654; x=1684437654; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=aai1WHo4fg1sxKcLX3kD4BGAw1PP+pR+m3nWfdfcZTU=; b=fx/GZBbJRIAyVamfSss8JkrMHALk9GBnCepG5ceUcI5eRkpIBtxCWw0JMFrjFFUS2u 7tmDXyDL3P9QxdEgWr67YWqFAdxcZ9X9o81uJvxvvwdWPqiHjbZnJH8UnlpAIQdyH7o6 YU4IPOs6dqz+YhZzMWuMRwHcxKrODMKu7VTvAKZz64s/cBg1M91rIB74YVYX0F+ORG1G R7lRkQdZN2/Swr5Ti7RF0D/87rgpSYXPVqL8QlMOizS5FZF84MfQEEJYtZM617nck7Sn CgoNBDMU0LIrwhhAOq3H7rFojDu/tjVHDVTF8NaLuwToz6caSM9OFbITopX8IUrsyNBT tYgQ== X-Gm-Message-State: AAQBX9fWDzWlYaLIvSm11aPZpHR5JtLwEdoDtBfIoIc995mjtGtI80yP nyNRGuIjibNJ/B+/IyVqo1oHzX3gr2lnplJMhHMVh9z+fEDy1CJaW2Himt9OuowV+8lw/7iz8rN u3aayx0wPS+QUXcROyuXh7jGT2WZ+ X-Received: by 2002:a05:6214:410:b0:56c:13cc:d21f with SMTP id z16-20020a056214041000b0056c13ccd21fmr25855300qvx.50.1681845654141; Tue, 18 Apr 2023 12:20:54 -0700 (PDT) X-Google-Smtp-Source: AKy350ZFUZ7JQR9xbohdXv2IbnkoRfbUviweblbnyFfC0N6wmvnsGUN3xBE3c2IZkXBZ0ZSdmAywfQ== X-Received: by 2002:a05:6214:410:b0:56c:13cc:d21f with SMTP id z16-20020a056214041000b0056c13ccd21fmr25855272qvx.50.1681845653894; Tue, 18 Apr 2023 12:20:53 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id 7-20020a370c07000000b0074df3f7e14esm1709609qkm.67.2023.04.18.12.20.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Apr 2023 12:20:53 -0700 (PDT) From: Tom Rix To: quic_jhugo@quicinc.com, ogabbay@kernel.org, nathan@kernel.org, ndesaulniers@google.com, jacek.lawrynowicz@linux.intel.com, quic_carlv@quicinc.com, stanislaw.gruszka@linux.intel.com, quic_pkanojiy@quicinc.com Subject: [PATCH] accel/qaic: initialize ret variable to 0 Date: Tue, 18 Apr 2023 15:20:46 -0400 Message-Id: <20230418192046.3235870-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-msm@vger.kernel.org, llvm@lists.linux.dev, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Tom Rix Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" clang static analysis reports drivers/accel/qaic/qaic_data.c:610:2: warning: Undefined or garbage value returned to caller [core.uninitialized.UndefReturn] return ret; ^~~~~~~~~~ The ret variable is only set some of the time but is always returned. So initialize ret to 0. Fixes: ff13be830333 ("accel/qaic: Add datapath") Signed-off-by: Tom Rix --- drivers/accel/qaic/qaic_data.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/accel/qaic/qaic_data.c b/drivers/accel/qaic/qaic_data.c index c0a574cd1b35..b46a16fb3080 100644 --- a/drivers/accel/qaic/qaic_data.c +++ b/drivers/accel/qaic/qaic_data.c @@ -591,7 +591,7 @@ static int qaic_gem_object_mmap(struct drm_gem_object *obj, struct vm_area_struc struct qaic_bo *bo = to_qaic_bo(obj); unsigned long offset = 0; struct scatterlist *sg; - int ret; + int ret = 0; if (obj->import_attach) return -EINVAL;