From patchwork Wed Apr 19 11:14:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghu Halharvi X-Patchwork-Id: 13216668 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7152CC77B73 for ; Wed, 19 Apr 2023 11:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232102AbjDSLRI (ORCPT ); Wed, 19 Apr 2023 07:17:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45994 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231580AbjDSLRH (ORCPT ); Wed, 19 Apr 2023 07:17:07 -0400 Received: from mail-pf1-x42c.google.com (mail-pf1-x42c.google.com [IPv6:2607:f8b0:4864:20::42c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 57B3214478; Wed, 19 Apr 2023 04:16:33 -0700 (PDT) Received: by mail-pf1-x42c.google.com with SMTP id d2e1a72fcca58-63b78b344d5so2210180b3a.1; Wed, 19 Apr 2023 04:16:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681902933; x=1684494933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4qJ0quS8PSmcOSKHlL8+ZsUIniTqrOGEBBq6bjBNxf0=; b=Z5Q5tE1GLgm4wm3YWrNt4E+8IlHzviPDJAEPbQU/+E8/RAaqgG+gqOBlL9ZGwGHb5G ME5NefLIzmK408Lre3SEK75QOOaPcvunXL3eq/b/+kJ252xTopqnqfmbmR01H1bDD3M1 wRmcFJqIEG/2sIkVL6j5E3G0AzGkxSjAMt1UXw5ZW4knVTMugvgDppz+7vItmdWPCheh HMN6mhK2UNk1OjVFul+nf5MxMJjghQsj8nY8/vrKYUGVKKCR63pTvz5jc0sgkQyGYRbC 2EeR9ajKXTxZK8bInDFHXgDJJQ7Y1KDbDiAeTMz1U2BvXBAA0OqwvbivdTlvtgZfd4/D NMtQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681902933; x=1684494933; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4qJ0quS8PSmcOSKHlL8+ZsUIniTqrOGEBBq6bjBNxf0=; b=g8Y+BfYmrF7JCTx3XSD8EtluG5ggfZZjZl9pq4bdSaXZELIza5Ffla/Ig/fgL1ahBT ASUA7qpaTcVweRjusXwY/3V59l6EUX9dpZoVpdFNsI5yEvQl2YnPsaetMTwL8ldWJr5G ugQsC4WTbUsb25N+V0gPPlwK8gJQsqAVMVHfhww73nva1HAinY5RCiSXhcdu71d1nCE5 D3Thf9TvogL7qIVSnjwOVhztyHGZ5c9tQFS4BElBRtzPe++1pLaJzUHgr/VG6FCYOYYi Z9Rp/xpm6AvCWBriox32aK36OnFh+hPGHtosxdz7/aVCaQO6gTcJudbTxRImYfJSSJhF gP+w== X-Gm-Message-State: AAQBX9ehD36t2MLEugzuDs6PZTeepAzYdh+qD3gwpKLpOyt/HT3V6NDM iAmlyAL7yyu8N4PCs02ETiho3gzAh64= X-Google-Smtp-Source: AKy350bG4AYtxLuwGUlX5AcJqEu6yQpwW6OC2sqIZKSpq8IDRXsVeQIJI5UtSm7kkibPb0jck5rJHw== X-Received: by 2002:a17:902:e84e:b0:1a2:296:9355 with SMTP id t14-20020a170902e84e00b001a202969355mr5518861plg.16.1681902932888; Wed, 19 Apr 2023 04:15:32 -0700 (PDT) Received: from cxl-test.. ([103.181.222.211]) by smtp.gmail.com with ESMTPSA id o4-20020a170902bcc400b001a6566045ccsm11194914pls.192.2023.04.19.04.15.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 04:15:32 -0700 (PDT) From: Raghu H To: linux-cxl@vger.kernel.org, Alison Schofield , raghuhack78@gmail.com, Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams Cc: linux-kernel@vger.kernel.org Subject: [STYLE v1 1/3] cxl/mbox: remove redundant debug msg Date: Wed, 19 Apr 2023 11:14:41 +0000 Message-Id: <20230419111443.231151-2-raghuhack78@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230419111443.231151-1-raghuhack78@gmail.com> References: <20230419111443.231151-1-raghuhack78@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org A return of errno should be good enough if the memory allocation fails, the debug message here is redundatant as per the coding style, removing it. Signed-off-by: Raghu H Reviewed-by: Ira Weiny --- drivers/cxl/core/mbox.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/cxl/core/mbox.c b/drivers/cxl/core/mbox.c index f2addb457172..11ea145b4b1f 100644 --- a/drivers/cxl/core/mbox.c +++ b/drivers/cxl/core/mbox.c @@ -1112,10 +1112,8 @@ struct cxl_dev_state *cxl_dev_state_create(struct device *dev) struct cxl_dev_state *cxlds; cxlds = devm_kzalloc(dev, sizeof(*cxlds), GFP_KERNEL); - if (!cxlds) { - dev_err(dev, "No memory available\n"); + if (!cxlds) return ERR_PTR(-ENOMEM); - } mutex_init(&cxlds->mbox_mutex); mutex_init(&cxlds->event.log_lock); From patchwork Wed Apr 19 11:14:42 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghu Halharvi X-Patchwork-Id: 13216670 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 571BCC77B73 for ; Wed, 19 Apr 2023 11:17:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232812AbjDSLRQ (ORCPT ); Wed, 19 Apr 2023 07:17:16 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46144 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231391AbjDSLRM (ORCPT ); Wed, 19 Apr 2023 07:17:12 -0400 Received: from mail-pf1-x431.google.com (mail-pf1-x431.google.com [IPv6:2607:f8b0:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96132146E5; Wed, 19 Apr 2023 04:16:39 -0700 (PDT) Received: by mail-pf1-x431.google.com with SMTP id d2e1a72fcca58-63d4595d60fso6135296b3a.0; Wed, 19 Apr 2023 04:16:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681902939; x=1684494939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=F7+u9xQhLDQrqjy4o4RJRJ8DCzaXxJZlsawnZVjNt3s=; b=g9tElXFhLI2LM3U0SMnA9tTDN79NflMAFeMM9JwZPuAOPASC90wunJ5LWNPooTMYiS vF8A7X2qZOHB20OaZ/1ijX+qPlMQ6IT2p1hywRhTTfbAlxDPuEnv00wTz/egUeIlhBjG xNhRby8s6DEaPxyd8Gr8tbAf86GO6e4CASaVDK22oSY2LYWtpczKVLqFYYkQ7N+63xWw TJO6BMTg2ToYvs8a5YCrzcXKGVZ/bTr2QXjx6L0yHXkCWo3d5grS7KCHBrfmu3hSevM6 NDf53OeVEnZyKw0plNIl/u9jk4gMZL/YFQXxE+Aja7Kh4+PeeyW6DoiSGeUt/kRHRg6S mifw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681902939; x=1684494939; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=F7+u9xQhLDQrqjy4o4RJRJ8DCzaXxJZlsawnZVjNt3s=; b=NFd0v6UPfbZUdgOvioEFSyR/hTE3z9j4Pjr6zyvmqBCixqLRvNShAYoQWdrdHi8Toh p25BtXZQiz6XyIeg7QxjejVG6tvl4MJU/zRhxuL3RmK63iz0FsS8i5MF3PbQ57V/H2KG 4IDgMm430DZhi5DrHlnn+qNq1TR0L89Yd1V8n9eTtzTFs1REQ7mVnlsFlg4BNH/AvTNg d0psIWLSmI1HJxjhh+wyxZC0kUt9rz3MhquFbfluLfXUQ5yEBooz0NjlWssx7j0tSa+W LsIBrAinJvJM4CCH2B2NvGt+oiQctkKQGn/p+iJWke87sjWEJUmygIcGbXwDpmXsBamF 8IIA== X-Gm-Message-State: AAQBX9d9oi4t5dPO7PmFPRG3/uC3RWFFZgua01FD5tjjQQoFnrzr64DB eTH8Rm3uodSladcRn+EO65NSBgJjTFs= X-Google-Smtp-Source: AKy350a21cL08vpppTtL6kpNrYMoThyva9XUw3uT0DzkomW6MhBVlSDcxusUPZevt8anqS9NlY5sww== X-Received: by 2002:a17:902:c40f:b0:1a6:6edc:c884 with SMTP id k15-20020a170902c40f00b001a66edcc884mr2856114plk.16.1681902938762; Wed, 19 Apr 2023 04:15:38 -0700 (PDT) Received: from cxl-test.. ([103.181.222.211]) by smtp.gmail.com with ESMTPSA id o4-20020a170902bcc400b001a6566045ccsm11194914pls.192.2023.04.19.04.15.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 04:15:38 -0700 (PDT) From: Raghu H To: linux-cxl@vger.kernel.org, Alison Schofield , raghuhack78@gmail.com, Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams Cc: linux-kernel@vger.kernel.org Subject: [STYLE v1 2/3] cxl/core/port: Use tabs to fix styling errors Date: Wed, 19 Apr 2023 11:14:42 +0000 Message-Id: <20230419111443.231151-3-raghuhack78@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230419111443.231151-1-raghuhack78@gmail.com> References: <20230419111443.231151-1-raghuhack78@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org Styling errors due to linux of unwanted spaces in the definition, modified the definition to use tab to fix the styling issue. Signed-off-by: Raghu H --- drivers/cxl/core/port.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c index 8ee6b6e2e2a4..7c3aaed180ca 100644 --- a/drivers/cxl/core/port.c +++ b/drivers/cxl/core/port.c @@ -95,15 +95,15 @@ static ssize_t size_show(struct device *dev, struct device_attribute *attr, } static DEVICE_ATTR_RO(size); -#define CXL_DECODER_FLAG_ATTR(name, flag) \ -static ssize_t name##_show(struct device *dev, \ - struct device_attribute *attr, char *buf) \ -{ \ - struct cxl_decoder *cxld = to_cxl_decoder(dev); \ - \ - return sysfs_emit(buf, "%s\n", \ - (cxld->flags & (flag)) ? "1" : "0"); \ -} \ +#define CXL_DECODER_FLAG_ATTR(name, flag) \ +static ssize_t name##_show(struct device *dev, \ + struct device_attribute *attr, char *buf) \ +{ \ + struct cxl_decoder *cxld = to_cxl_decoder(dev); \ + \ + return sysfs_emit(buf, "%s\n", \ + (cxld->flags & (flag)) ? "1" : "0"); \ +} \ static DEVICE_ATTR_RO(name) CXL_DECODER_FLAG_ATTR(cap_pmem, CXL_DECODER_F_PMEM); From patchwork Wed Apr 19 11:14:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Raghu Halharvi X-Patchwork-Id: 13216671 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2713EC6FD18 for ; Wed, 19 Apr 2023 11:17:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232779AbjDSLRT (ORCPT ); Wed, 19 Apr 2023 07:17:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46348 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbjDSLRO (ORCPT ); Wed, 19 Apr 2023 07:17:14 -0400 Received: from mail-pf1-x42b.google.com (mail-pf1-x42b.google.com [IPv6:2607:f8b0:4864:20::42b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9FA149EDD; Wed, 19 Apr 2023 04:16:42 -0700 (PDT) Received: by mail-pf1-x42b.google.com with SMTP id d2e1a72fcca58-63b4960b015so2634433b3a.3; Wed, 19 Apr 2023 04:16:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681902942; x=1684494942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ct0EwfRf0voCrFEqbmxJCbJeLzfDoba7OgIp+FO1WjY=; b=XCsKKkyEYFFRkMk6HScjJojoSQQEp5iESfLRH2ZjobzOGjvG/Dmf55Eyqyr3JVrgRM rrP15EnxnJZgXFvdlGkrhI9G2DztJJc8z70z9S295rqktadJfhphtbC3Nvhcssnn4qDG rcWVCswFtLWH6IO27BA2SUXRboa1Zg2z+D3PS/3lmxHdn6UK6q8+fmNeYI3TAo9JnDWg 8JpVzrlsFNrfMgbiOvHXEpKGWYBqEsQV0ykxjFuLoIfz2VIQr6kr3aUTkcJAfH1txX5S Km9NvX0ZNSHphN2AFJ7M9Bg2cV5RwJ9K1fPExougi/oikeO6CAR+zACnSJYZndiVRENA hASg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681902942; x=1684494942; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ct0EwfRf0voCrFEqbmxJCbJeLzfDoba7OgIp+FO1WjY=; b=d1jmJAl0X2EkbiiwrMfR385BkK7yrysGe10e4vCvqX+ba1FoEvyRI7RDjEyX2+kcfV awBk/hMaLLjMorNUoTHq/hxoo6Nd3GrU04NS/RuZkIaUMpn0XQf/N4wgTKjIcSJC/kvL HezfW23JNxnriGhvy3SBe3X+RVLUNkklysY/YZgofHmAUVVpv6ihFpO7ooBLzS8rDNPp tDVSR9b2Ikwb25028WA1m8qLP05gdy+tjqw0fy6Vx/VqlXAS2axy7cNb0aogMKaRL++3 FOGOcOuy3ZQz2tb9Oa2C5uB5mwiyCSom9ZRmjJOwUr16M0Co0uoTG18LSGxhtPM27JFT /mGA== X-Gm-Message-State: AAQBX9ckpT0eLrKrb+5l/Y+RGtmiKwVsb4GlHfBqlnBUvkC+n+p/+I6/ JDG679LEC5OXFEpP2Bsirr00rM7LzLU= X-Google-Smtp-Source: AKy350bVvj2NnO8cX9NptQ/pkC8mSvzPt8syY4FJbeCsWaTMb7WNJ3VI5MkkLFqG8iX8zN/aLw4jow== X-Received: by 2002:a17:902:f945:b0:1a2:9dd8:d646 with SMTP id kx5-20020a170902f94500b001a29dd8d646mr4866313plb.54.1681902942569; Wed, 19 Apr 2023 04:15:42 -0700 (PDT) Received: from cxl-test.. ([103.181.222.211]) by smtp.gmail.com with ESMTPSA id o4-20020a170902bcc400b001a6566045ccsm11194914pls.192.2023.04.19.04.15.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 19 Apr 2023 04:15:42 -0700 (PDT) From: Raghu H To: linux-cxl@vger.kernel.org, Alison Schofield , raghuhack78@gmail.com, Vishal Verma , Ira Weiny , Ben Widawsky , Dan Williams Cc: linux-kernel@vger.kernel.org Subject: [STYLE v1 3/3] cxl/core/region:Remove else after return statement Date: Wed, 19 Apr 2023 11:14:43 +0000 Message-Id: <20230419111443.231151-4-raghuhack78@gmail.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230419111443.231151-1-raghuhack78@gmail.com> References: <20230419111443.231151-1-raghuhack78@gmail.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-cxl@vger.kernel.org The else section here is redundant after return statement, removing it. Sanity and correctness is not affected due to this fix. Signed-off-by: Raghu H Reviewed-by: Ira Weiny --- drivers/cxl/core/region.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index f29028148806..1d695107b4a7 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -2666,11 +2666,10 @@ static int cxl_region_invalidate_memregion(struct cxl_region *cxlr) "Bypassing cpu_cache_invalidate_memregion() for testing!\n"); clear_bit(CXL_REGION_F_INCOHERENT, &cxlr->flags); return 0; - } else { - dev_err(&cxlr->dev, - "Failed to synchronize CPU cache state\n"); - return -ENXIO; } + dev_err(&cxlr->dev, + "Failed to synchronize CPU cache state\n"); + return -ENXIO; } cpu_cache_invalidate_memregion(IORES_DESC_CXL);