From patchwork Mon Apr 24 07:30:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 13221811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4E734C77B7C for ; Mon, 24 Apr 2023 07:31:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231131AbjDXHbE (ORCPT ); Mon, 24 Apr 2023 03:31:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52458 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbjDXHbD (ORCPT ); Mon, 24 Apr 2023 03:31:03 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10hn2208.outbound.protection.outlook.com [52.100.155.208]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6A176E53; Mon, 24 Apr 2023 00:31:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TlAkyWzdgCcuQygYz9xAfl/IS00PzhiJu4BDUeuCkqvrpBU4Bv4I3ZE45riQY1hNX9fr9W6soV4DLgOWSALP3BwQHbfsw9uixuGm4hfwAObSDlQ/B+5dvBxNuBkIJ92ljDLgJ/Ly4rxMDLysJb/aYyjs/pMRxgGFJDtrgvDPnUZkAQA7CZn3QVdbpIT17rFLWekhUNMFHqmeNEJ1a0VPvOSlOVG2oGmT09+ViaYe6AG+QcsmNM+LmZh68Ug77SKz29mLpXwXIm25hUDuk9PPGEncs0g28x/XH6ANOi+1NZygKdmDMG9jNhQQHyy2sroFJsWUlq0VxuQLcKqEyYj7qA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Cypey35BJytHe/i8AM3tgY/ZiUzrnRv5NbcvJrFImCc=; b=bUVFQGOCzSaJiG3eFemtjLYfyPgUzkWbATj1vjc4DEMYGqkgDkqsXkD+EZfpZ14U0JsYXnEmKxYUbFd70i611xfTbggaYOZyY817S2gUellGgGu+HTq9eW89mZ1HWHucSLQuddfW/A+PPpeSRRlGsjipXA6eB7d2ham5y+ecg14O7MEm6PO7CuoOLfT+NFRzQbCd2MKAMh7IdyZ62H8URVSvcJZS3fNrogTS9mznvF7T/P7y3noSvzNDe9FPB+cGLoZ7lkFyEF+nIW+oPKRjBc6aX1GL7TIkhWh84+jFTkzAhdpNY447HpiawlvHNr7dv7cq+Dg8Ur4LE41742DIkw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Cypey35BJytHe/i8AM3tgY/ZiUzrnRv5NbcvJrFImCc=; b=e7zTAUyFGGsmwK8VLtArkh+MXtaPCI19H8rE4wS3gAsa3IQSwW+ESptKtVpx7ptkwvsEJmXXDnqN8sF9WSER6ijRqfmHEeEfPQv053MGQNwxtkwHc8H92IrRhRKkyn9SYESTIn78h3tyr7ZzmHsKdyJECJo/0P9caW2TlwWBSC5GS1jEGfKFgRLtdqUHtJZz8AL1UmHoMWMOEorjsbb8hfEpmgdQgKwkl0R0S08KklG6W8MsjFC+aDUxWEKx/Uci1QQCL6gnW6UpA0ghfURd+6OJyyCRudjQh429zC06/MbgDRrrxm4C1ythvPZ2fXHjBIgWae7R+qIxBVqc2c6aAQ== Received: from MW4PR04CA0059.namprd04.prod.outlook.com (2603:10b6:303:6a::34) by SN7PR12MB7980.namprd12.prod.outlook.com (2603:10b6:806:341::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 07:31:00 +0000 Received: from CO1NAM11FT094.eop-nam11.prod.protection.outlook.com (2603:10b6:303:6a:cafe::dc) by MW4PR04CA0059.outlook.office365.com (2603:10b6:303:6a::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Mon, 24 Apr 2023 07:31:00 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT094.mail.protection.outlook.com (10.13.174.161) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.19 via Frontend Transport; Mon, 24 Apr 2023 07:31:00 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 24 Apr 2023 00:30:43 -0700 Received: from dev.nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 24 Apr 2023 00:30:42 -0700 From: Chaitanya Kulkarni To: , CC: , , , , , , , , , , , , , Subject: [PATCH 1/5] null_blk: don't clear the flag that is not set Date: Mon, 24 Apr 2023 00:30:19 -0700 Message-ID: <20230424073023.38935-2-kch@nvidia.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230424073023.38935-1-kch@nvidia.com> References: <20230424073023.38935-1-kch@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT094:EE_|SN7PR12MB7980:EE_ X-MS-Office365-Filtering-Correlation-Id: 99d38731-7311-4107-4bff-08db4495da03 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qCEyDvcIl41c26qLJx1TlBwBbXdQyQo+13Erf4au+yMIHbIQ8fmbW0V/FpyB6JjMJD1oaj/AxuhU9iK1HG8MIAneLC6hY/WuMvLytqTNF1tACeY29f4vgI2zxa5b/zy2mJ5TnE3QBY/NyqH3Y7e/473j1YlBEe2z3vrMzhNKwypTuwxLkjdbIacEmACIfqYttnuQgclWF5lB+hpVnuamjgSz8QGWosbNlWflyn6XVy62oVHaJVb6BWe7vUUwvoluZpvlg6FhgW23X0/T+MINm5WoWZRvGQt/GB6lmqwxYKFg2eza16cR452Lr3Smxe4/9NcCxMQESZSykX8n9zxLvHZpZq8L9b1AEJRUD8bafRBO6Ulepvr1Vanavl6+o5BZgZt5ajZtQQ+l4OM5B+RTXPLWpnNr5DB27fEYjJK+fxVqQ0ocofOo2N7qD/o8pTFxY/VsXAYtfN0FIwh39eipgJmIXrIuhQsQUXTqxOrlRn5gz5y6bnMrY+jhlJxRVyxBQWmdI3nxi+RAsdMn2mk+TgI7yIECyUtFblXjzx0fA83CIVwAdBToUQdNBqRjVv/NusOmQ81lO+9pksp964rgkDslgTAFUS5N6BXAQr3ZNjTMxmTZogzd/99ZeyutQ/Dhj9XZnScbVdGHrJPPas/eQ9U/TrrDhyXZwcWcZGTBh1RsUJwZbKCIks+5x9OGLKUYstRIRzgs0f3D8Xo6N3diw4Y7K7aTrVjPJEb4Q9R5DrKeUmTKi07VlxRysExrjBhUSvS7Bmhdx04R8pjG6aDYZg== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(396003)(136003)(39860400002)(376002)(346002)(5400799015)(451199021)(46966006)(36840700001)(40470700004)(1076003)(26005)(40480700001)(336012)(426003)(2616005)(34020700004)(36756003)(83380400001)(36860700001)(47076005)(186003)(16526019)(40460700003)(7636003)(356005)(82740400003)(70206006)(70586007)(478600001)(8936002)(8676002)(54906003)(7416002)(110136005)(5660300002)(7696005)(41300700001)(4744005)(2906002)(82310400005)(4326008)(6666004)(316002)(12100799030);DIR:OUT;SFP:1501; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 07:31:00.0584 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 99d38731-7311-4107-4bff-08db4495da03 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT094.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB7980 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org QUEUE_FLAG_ADD_RANDOM is not set in null_add_dev() before we clear it. There is no point in clearing the flag that is not set. Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM. Signed-off-by: Chaitanya Kulkarni --- drivers/block/null_blk/main.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/null_blk/main.c b/drivers/block/null_blk/main.c index b195b8b9fe32..b3fedafe301e 100644 --- a/drivers/block/null_blk/main.c +++ b/drivers/block/null_blk/main.c @@ -2144,7 +2144,6 @@ static int null_add_dev(struct nullb_device *dev) nullb->q->queuedata = nullb; blk_queue_flag_set(QUEUE_FLAG_NONROT, nullb->q); - blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, nullb->q); mutex_lock(&lock); rv = ida_simple_get(&nullb_indexes, 0, 0, GFP_KERNEL); From patchwork Mon Apr 24 07:30:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 13221812 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75054C7618E for ; Mon, 24 Apr 2023 07:31:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231195AbjDXHbM (ORCPT ); Mon, 24 Apr 2023 03:31:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52496 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230476AbjDXHbL (ORCPT ); Mon, 24 Apr 2023 03:31:11 -0400 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10hn2223.outbound.protection.outlook.com [52.100.155.223]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 22031E7F; Mon, 24 Apr 2023 00:31:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=GwZwVcQvenKQT8J+iyTrgX0wFoX0UMpqDoPl2onOtolmYu00pAEDnHmTqu9x15QvhOF0vSmxO1aFbEVkh+3UvBLfn33CZeH9+742Ka+fPJlL+lT33cWaB5EveCg3qHHPwmCvakdiB/7d/1XBHVnvHN8QPPUQvpFdC++ktin+fhoSZeRwJ7mAgdv4C/uWx4WroeZyZ2bBqyC1YXMP2wqNM3GPb7xKzon59hovC+QkpyLv1I9JwEbyhds2QULuhY6NKx4lIcvuBrWQ2GQx4cvGwHmRhsV2ifr7AGhaPXz4Fx0w+Td1yexdLtAsOEGRPKoZNfhiOFc/CketsYubHeZz1g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=AV4fsN2/gyKEGzHc8V0wf1SYvMoUEZfiB3frDpCdd28=; b=AMT0nne0HVjavlNh+i9YwURYDHW5TX3PqLp78/ql8PJj7wWgNhuIIoCkc74wXynNOtWkQYTRbRe3lp3nflpgHmNmBi0i8D/k0JupA4LSDNdaywVh03J2PwqL7W0jBk/Axip70apvl1nGPmcYea15t5040mBy0KSx4yHxiUO3Y+HGC6/HUlNAObqUXj4xJPSv+AlNTSjOQI8eo+YMZpdXhy+j1r662ZuXNOkO4N4k+RRoH7cE4ycmM44PM7Rzo4//LAC1BAE6g3SyTouCIQYFWazziREW+N5rBWXXPUhsy/Bg+8fNd7uv/LJIwAoCCIUwTLoV/kVVSX9MGrqYdfFT0g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=AV4fsN2/gyKEGzHc8V0wf1SYvMoUEZfiB3frDpCdd28=; b=hcQAiUXYD6NqHNgu5i1BzDmeswEDC7xpq8sdgtKPHuswPC0LvHc52YgNjrXWrAjMlHYkEwaArdtMcfNtE2LRLifhI81T5Rc884Zeo+lBqueLvPqVs2LuKcutY/36vcD9yM7N05NDSYxthxOJA+F4FAdD/kZP+05flhBfoeiARCsEpaQkqZSBSFn1Rn533xOZhsuqj9DMhK7/kzS+oMSH7riBQpqKvTnlHHWz103izzPTT3Mo6hEI1C/dJySvWAL+uqlMfCIHi9de3accuF+Fw4lv+W4zKGznAl5YkmRHE/IX7pUkiEjkArEFhM54xtxVuy8S6+HDgz6KNSppuuKntQ== Received: from DM6PR02CA0058.namprd02.prod.outlook.com (2603:10b6:5:177::35) by PH8PR12MB7111.namprd12.prod.outlook.com (2603:10b6:510:22d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 07:31:07 +0000 Received: from DM6NAM11FT109.eop-nam11.prod.protection.outlook.com (2603:10b6:5:177:cafe::f7) by DM6PR02CA0058.outlook.office365.com (2603:10b6:5:177::35) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Mon, 24 Apr 2023 07:31:06 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT109.mail.protection.outlook.com (10.13.173.178) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.19 via Frontend Transport; Mon, 24 Apr 2023 07:31:06 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 24 Apr 2023 00:30:54 -0700 Received: from dev.nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 24 Apr 2023 00:30:53 -0700 From: Chaitanya Kulkarni To: , CC: , , , , , , , , , , , , , Subject: [PATCH 2/5] brd: don't clear the flag that is not set Date: Mon, 24 Apr 2023 00:30:20 -0700 Message-ID: <20230424073023.38935-3-kch@nvidia.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230424073023.38935-1-kch@nvidia.com> References: <20230424073023.38935-1-kch@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT109:EE_|PH8PR12MB7111:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b676bca-0e25-4339-33b4-08db4495dde2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: s/jAKn7lRuv2IxC4xA81zf7h5CpmjCFSuUAucHps9S30ShFiYZQIwB5TZt4dNVoCCzbNyt9O8asPVcNR3ea2/eDgaq+k/rCajwIGx3WBgQxrefQwNDosZasUJe+OUOGBh3j1GuggC9BrXHn0EqGqIsleOPShb8QFwhYNGSA6y8nXEPOD8HuGD4s3iPGztNDjXW3rPRvh9mus5yIDp1LPj4V4PZiVDID8WM4v2J8AIf5es08ubMRgZwSkl3VVR67OyiwknlM+YN2Br7TVkKesA8MekyLFQ6/nas03Gq9vf7gSwsl/htn/IIEqvJ2zb5GJHp5MtRVDwKgtZ8W0YWibvuW4jsvFU0EfxsxXc2WIo/bQnxquyyXIlgoSzSa6n5odt1WLvsGlWUbgXfjDr0hJw4f+ydszhmCRUaJ3WBayjp+f9Fbxl6xgujvbzRJUi5aKht4VlDX7yHcGFq1ZDCi6SMBqmbDBLYWr4dGEy01wTfZfwxn3afuo0iuc6mRU2rHEToUNXuGOdwYc2F3BEpMIl9XDRW+uyEEpCymKOIOcl25b+/4QbXYqxSWB5TO53Irj1hdb7oeS5DrVBq89OkmVgXBSWtaV/vETLRovQecIdZGRzOn7/T4gjvZhkOjQ0Iix5qE2wTqExtt8L6DAi5Jay53AYNWbGA4jU1kpbX/X872P+POTXp5CHu23z5wdC1XHoy4U8xJiHXE/7QqEaQ0wBCA7N6s1LuC+CK74ye7Q9M+7I4RBJ0g4MUpkdhUw23bHR4SY5T15ZD/JgeRTT6fZFg== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(136003)(39860400002)(396003)(346002)(376002)(5400799015)(451199021)(36840700001)(46966006)(40470700004)(2906002)(4744005)(7696005)(2616005)(6666004)(16526019)(1076003)(26005)(186003)(40480700001)(70586007)(70206006)(8676002)(8936002)(316002)(41300700001)(4326008)(478600001)(5660300002)(7416002)(54906003)(110136005)(82740400003)(356005)(7636003)(82310400005)(36756003)(40460700003)(36860700001)(47076005)(426003)(336012)(83380400001)(34020700004)(12100799030);DIR:OUT;SFP:1501; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 07:31:06.5055 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b676bca-0e25-4339-33b4-08db4495dde2 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT109.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7111 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org QUEUE_FLAG_ADD_RANDOM is not set in brd_alloc() before we clear it. There is no point in clearing the flag that is not set. Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM. Signed-off-by: Chaitanya Kulkarni --- drivers/block/brd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/brd.c b/drivers/block/brd.c index 34177f1bd97d..bcad9b926b0c 100644 --- a/drivers/block/brd.c +++ b/drivers/block/brd.c @@ -404,7 +404,6 @@ static int brd_alloc(int i) /* Tell the block layer that this is not a rotational device */ blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue); blk_queue_flag_set(QUEUE_FLAG_SYNCHRONOUS, disk->queue); - blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue); blk_queue_flag_set(QUEUE_FLAG_NOWAIT, disk->queue); err = add_disk(disk); if (err) From patchwork Mon Apr 24 07:30:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 13221813 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88B2EC77B76 for ; Mon, 24 Apr 2023 07:31:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231224AbjDXHbX (ORCPT ); Mon, 24 Apr 2023 03:31:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52650 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230499AbjDXHbV (ORCPT ); Mon, 24 Apr 2023 03:31:21 -0400 Received: from NAM02-BN1-obe.outbound.protection.outlook.com (mail-bn1nam02hn2237.outbound.protection.outlook.com [52.100.160.237]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1F0CFE71; Mon, 24 Apr 2023 00:31:19 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WIGZXww5k0obNOgUknjlggLRg2OgvX6yI+p9sDU2m9b89XOaA9ek9kmYN+B4vQBgwWuHBXh3YRQszAUbC6xNv0Bv7nvM+KL/51kTn87wgfHzFx9KCtVfjVVpJIXkYOqoWbYRezFziVsem9kLq4syROx2Iv+rG2vBMHM2oX8iqyX/Enrd5CS0t6Qr9gJk+Ek+90MxLipbPuE8+5DQeBs8pai0zfJk4VYNOhnus8N2OU1IuOKnrozSGBzf+T+YRjytSCLcABE3tmF159f9p7mRU9PSuvk/34jutNS8yvWfprxgDDzAJo7xgQb4nhq13rOJOiwuQWe2hCGYyx6QI/kCIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=q0JE5sPj1JBSNn0kA/6fe94CuFYT7geDSqyMLk20AkI=; b=isvPztAtB9i+zVvFZ9pEckp3rvWRRXuMxji0Iy3FtXvMBXTpvn3G4BeGbkAAOvTTrwGGdsJwLMxEmkU5mci/sZZeSr4lP2WHjOQDH6ECX7d9/KPM4rNMJxCvLQO4sG0H0qLd01xAg3NritLWKzB6BYNGpsC1pu/9oSOhjzeYokRLwZbwfNk4nfBHahsQm+QfWlyGKXDfkSGDdYaA/Wv1GF3zyiehZGaupJz8OpmUKd4ck+Wf3eNL3byFgx3gpalbk7J20GLHJ5rPzC0o1t0gcFYTqNO7x60kTzE8Lm7oeDpRo8Oj+lFeCwyrrT6ybGrBwlOWcazMoP5RevW460vZWA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=q0JE5sPj1JBSNn0kA/6fe94CuFYT7geDSqyMLk20AkI=; b=ENX0t1Aqqyjz0UrBHq8M2+7mSYYbxCXOxIGxtC9pTtbO22a9foQ4X/8x0ZVdMtQsf8TlK2QQfaDkjAqFZFPMr2a203jmSENo9uvp5xZceRFFpUfIGdgKHvnqg8XkQVnmVBmEOvbKfT4M4cE6Hr3SFxYb9Z5/UrOroyXWOZ9zvL65hcMKGpQaCrGKAI5Wt00FIkcK81WVUAy8UtrHZD4zzojI8o88zdmdmH7prSBEQCi1pJyhj1OKfaNMILwWEg4Kzf5MjETdg2ChvD7TvZfZUNjUBS28s/youhi5L7yK87EML6oa4Ig3BkddRTt1lhSRJr6ovfvxQ0DOURlAINP3jg== Received: from DS7PR03CA0151.namprd03.prod.outlook.com (2603:10b6:5:3b2::6) by PH8PR12MB6915.namprd12.prod.outlook.com (2603:10b6:510:1bc::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 07:31:17 +0000 Received: from DM6NAM11FT025.eop-nam11.prod.protection.outlook.com (2603:10b6:5:3b2:cafe::a4) by DS7PR03CA0151.outlook.office365.com (2603:10b6:5:3b2::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Mon, 24 Apr 2023 07:31:17 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by DM6NAM11FT025.mail.protection.outlook.com (10.13.172.197) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.19 via Frontend Transport; Mon, 24 Apr 2023 07:31:16 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 24 Apr 2023 00:31:06 -0700 Received: from dev.nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 24 Apr 2023 00:31:05 -0700 From: Chaitanya Kulkarni To: , CC: , , , , , , , , , , , , , Subject: [PATCH 3/5] nbd: don't clear the flag that is not set Date: Mon, 24 Apr 2023 00:30:21 -0700 Message-ID: <20230424073023.38935-4-kch@nvidia.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230424073023.38935-1-kch@nvidia.com> References: <20230424073023.38935-1-kch@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT025:EE_|PH8PR12MB6915:EE_ X-MS-Office365-Filtering-Correlation-Id: a2fbcbe7-0254-4a49-5794-08db4495e410 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 1c1AuiDGdoghnLOr7+x+pONbhrs0uRmKCBYeNuPHcKQDsDD5oMDqJDT63ibcYhnjvM7RD/qSy2u0YVbnqFyaczJBTn4WcQKNre6HmQ3yXx4ofvippghNThYTiGednxGac3Tr9NJgow6PlRptTVXQYL0e3aU4OhcK6x7WMhu4Cgpyd7xlXgI3bg9S22J9fzkZOOHTs2YRlIQHGprgX23BNhyXXWOVaDGfFuBnjWa6k54dz48KxlgiohgWEnl1betoa64b34yNJa0BgD59K7Wbr5yHdZmbllfaweW4yjiiwFp3XHU5wWgWvZ2ljMJ8pv0CPppWwjkQAdNQmigcSyQ4kdvgD2bLPL7TKHuAlS7GBr15+7NwgSK6x/Ym+aWyzDj4Zsti2M6i8+mdtZdJYlAWaoRANEFnsGKEVr/7bXAF+nJLFycOYQ+wbTtrrnsGJwRKaP3A/Q49jNbNyMlMcySk1ZdgWXkQS+xg3+CFA1rcQEhUMAiynkGRzlIoSgHgGcIOhyF0m8wdqcC42NquG0A7exCpMFvg2I0x7FJvaThntKZJxBhoX/ztgR6R66xz9bjRcX3XGM3PSZF7yQcG1QyeZjfrGwHet6Vz2/d29NKe9o168Fr5N/uhWYaCiwEUwC4IiVhhaTOwlM8SOVvT3tlODcmduEG7dITpHfmgLetfLXKZuTwk58xetqixucEml3mij/iZV5wprJBRxP6ofkqA/wKeH+88Z2g5rsfsRoEhNJlAW5tLvGj0h2X/FXSj/V/idNrbkpcEItJeBM623SvkMg== X-Forefront-Antispam-Report: CIP:216.228.117.161;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge2.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(136003)(396003)(39860400002)(451199021)(5400799015)(46966006)(40470700004)(36840700001)(54906003)(36756003)(110136005)(40460700003)(34020700004)(478600001)(82740400003)(316002)(4326008)(40480700001)(70206006)(70586007)(7416002)(356005)(7636003)(41300700001)(4744005)(2906002)(8936002)(8676002)(5660300002)(2616005)(426003)(336012)(1076003)(26005)(186003)(16526019)(6666004)(83380400001)(47076005)(7696005)(82310400005)(36860700001)(12100799030);DIR:OUT;SFP:1501; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 07:31:16.8743 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: a2fbcbe7-0254-4a49-5794-08db4495e410 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.161];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT025.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB6915 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org QUEUE_FLAG_ADD_RANDOM is not set in nbd_dev_add() before we clear it. There is no point in clearing the flag that is not set. Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM. Signed-off-by: Chaitanya Kulkarni --- drivers/block/nbd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c index d445fd0934bd..7c96ec4e99df 100644 --- a/drivers/block/nbd.c +++ b/drivers/block/nbd.c @@ -1805,7 +1805,6 @@ static struct nbd_device *nbd_dev_add(int index, unsigned int refs) * Tell the block layer that we are not a rotational device */ blk_queue_flag_set(QUEUE_FLAG_NONROT, disk->queue); - blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, disk->queue); disk->queue->limits.discard_granularity = 0; blk_queue_max_discard_sectors(disk->queue, 0); blk_queue_max_segment_size(disk->queue, UINT_MAX); From patchwork Mon Apr 24 07:30:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 13221814 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A71BC77B76 for ; Mon, 24 Apr 2023 07:31:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230499AbjDXHbc (ORCPT ); Mon, 24 Apr 2023 03:31:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52746 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230319AbjDXHbb (ORCPT ); Mon, 24 Apr 2023 03:31:31 -0400 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12hn2237.outbound.protection.outlook.com [52.100.165.237]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 32082E7B; Mon, 24 Apr 2023 00:31:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kBuYqWmcLnT1PQkSftBw7J/ByxxAYhIOjBkSEj1YiAObagKmqC4XjB7wndhYSqb+r/1/G3Yas96zCS/HxrumXGJ5YgflN0+GZBoeZBOe/sIGZqpszyFsx6lpXtyAjuf4cibNRH6lmAFF8H02xjvFpL+MvGLUXheVVDRUuBFABRBdma94aCHpw4i91ZZJPU5KXWM+LBclP/+kFSwvsEuqlm5GPT/8SelMqUcuo04oOcaLp2iM0sBRvU2QMkqXz3oYV1nS+v7Y4Te4ZoAYIS+fCsBjtXxVig+IkVN3sOg/NfSyI/MfQYmCJg15/JWxxnDK4I22dyuygpQESreIF2+iig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2y5B4LJkWB1SZ6Dsmj69gjrzaWaAMKpviVi0SmwTtX8=; b=m7KyDHWxn9YLCm2OOM5rFxBOJYZ4ZqVQ8xTOIPfg1KNxt+D1O9CmUeXPhUaFmg55KL0pbECE4Swzq5JmL1NI/BLVGTtxGKuphg2bOoPg7Fvw+AxEa0ULFeYrfpbCU8cgRbJgERSnMnW28FGRlkqZrwqOXAxre73hn+uqu5F2sXz+rESXYMIvYnTCz/sdXBnCtRENZeGxp9d4Q04d/lQCdp0N5YpghFimrQZiiGEAVplSsG6JW4ECBPen63psWrIrafpyR9mda+FMBPGzAAfGiqMcuZSDJm7pEk3yD8wvszDIOehva2+o34qkqj1lcl3EC5BeIWvzck3wgJ+F8Bbsvg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2y5B4LJkWB1SZ6Dsmj69gjrzaWaAMKpviVi0SmwTtX8=; b=onnPLDSnRZKuZI0oLMu9FvqhMP5qeTMIy0CuwEYeJEQiK2CESCNzQIevvJJuBjrg+2J2AeqO41t/o5AUMt8slG8ubc5GoWdFEZy+AEaGtrDpbltMGC7xG+m1QLY4jsM/Sap9frhFfV50AtoHglKn7Ee2tvxL29rHyo7Jq0JoPV4pyphpX3ngEczYF6h6cUqZwL1y+1D65K+NlOcW4lLFLxO2gdPKG2zLXw4bXGVS3a7noUw00t45jGfcxN7o/zvZk1JSXmiqlMmBRdc+R9kDKw4SnY57NxoEIKRBpy0sKFGxPa5yGkfgsoakwkZGLRUh+QoYZyYwq9mYRe3qy0nJmQ== Received: from MW4PR04CA0257.namprd04.prod.outlook.com (2603:10b6:303:88::22) by DM4PR12MB6134.namprd12.prod.outlook.com (2603:10b6:8:ad::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6298.45; Mon, 24 Apr 2023 07:31:28 +0000 Received: from CO1NAM11FT090.eop-nam11.prod.protection.outlook.com (2603:10b6:303:88:cafe::8f) by MW4PR04CA0257.outlook.office365.com (2603:10b6:303:88::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Mon, 24 Apr 2023 07:31:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT090.mail.protection.outlook.com (10.13.175.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.19 via Frontend Transport; Mon, 24 Apr 2023 07:31:27 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 24 Apr 2023 00:31:18 -0700 Received: from dev.nvidia.com (10.126.231.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 24 Apr 2023 00:31:17 -0700 From: Chaitanya Kulkarni To: , CC: , , , , , , , , , , , , , Subject: [PATCH 4/5] zram: don't clear the flag that is not set Date: Mon, 24 Apr 2023 00:30:22 -0700 Message-ID: <20230424073023.38935-5-kch@nvidia.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230424073023.38935-1-kch@nvidia.com> References: <20230424073023.38935-1-kch@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT090:EE_|DM4PR12MB6134:EE_ X-MS-Office365-Filtering-Correlation-Id: 70b7afd1-0dec-4e4c-b33f-08db4495eaa6 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: FUTrN3NL9jTniIDY2nTeNKxqQ5P5sJzNv1cM/DieY5r3MqcWkqeXUAQ7Zq+GlNUjQRSDYSeFVnUA00eDyIWLX+/H1sh51cNi0AUheSIkNJa4WXPyrzIFoBZJph+zhhr4HxN9a2U9bHwpGZCjjiOtxzAHhCIsyD+xlS4BMJhTkf7TNgIx9e4bSJG8y6qPBQOooPHYslVetaVStYhchhD0SRVSQbworBnEAAxgLyTtJZ83m9wm6bGoDMwpd/4NyRtvg/DbjeLPL2xY50xBhaIj8mkb6pxb/06TK1WO1kFXcpun4STpaKXgbU6Qr9Sayd8zCiDfAoWL5R0hl3tBJ44BX7JsY9/nIuJsmd3vxWZDMLXJObV/NzVNwcCYQqeWPeVFuPn8DFUiye85Gce1Pek0XMKoB1mV8Y04Rp0LmMkvt/Trom4h696Mggffi3agwwCd1suFYaZcrlCNWvWzjanf8Xn6uL8wnaj7Gu34xNaXIaSuR/S2y2ZRYGCeFxvrRiYleiMcHJcJnYq38A1GVTkDp0rTXD5Xwq3GBWriJYOkZR72QIo0lKgEcBv6LWm6vYCokLUD5DOmyleai8uYR2A/crazfYyvZiLOSksxNARhS+aqYFtVCdUTUiWwCfrZsNzC8T3J+dQggriRxHehqYxD/750goAFP87ljSTvbVjyvaEWV3uG4lbGxTmmUPfff4bPEDzFEQeBH2wSry6/DefTPFgvWpqfGjmvXmAy7NDlW8UMmwF6l3VApss4juCqU2dLF8tZbPNMRaQUNUnFub0R+Q== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(39860400002)(396003)(136003)(346002)(451199021)(5400799015)(46966006)(40470700004)(36840700001)(34020700004)(478600001)(6666004)(8936002)(8676002)(316002)(82740400003)(4326008)(70206006)(70586007)(40480700001)(41300700001)(54906003)(110136005)(7636003)(356005)(4744005)(40460700003)(186003)(83380400001)(2906002)(16526019)(1076003)(26005)(426003)(47076005)(336012)(82310400005)(36756003)(36860700001)(5660300002)(2616005)(7696005)(7416002)(12100799030);DIR:OUT;SFP:1501; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 07:31:27.9572 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 70b7afd1-0dec-4e4c-b33f-08db4495eaa6 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT090.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6134 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org QUEUE_FLAG_ADD_RANDOM is not set in zram_add() before we clear it. There is no point in clearing the flag that is not set. Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM. Signed-off-by: Chaitanya Kulkarni --- drivers/block/zram/zram_drv.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c index aa490da3cef2..f7d4c0d5ad0d 100644 --- a/drivers/block/zram/zram_drv.c +++ b/drivers/block/zram/zram_drv.c @@ -2323,7 +2323,6 @@ static int zram_add(void) /* zram devices sort of resembles non-rotational disks */ blk_queue_flag_set(QUEUE_FLAG_NONROT, zram->disk->queue); blk_queue_flag_set(QUEUE_FLAG_SYNCHRONOUS, zram->disk->queue); - blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, zram->disk->queue); /* * To ensure that we always get PAGE_SIZE aligned From patchwork Mon Apr 24 07:30:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaitanya Kulkarni X-Patchwork-Id: 13221815 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29C8FC77B76 for ; Mon, 24 Apr 2023 07:31:51 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231256AbjDXHbt (ORCPT ); Mon, 24 Apr 2023 03:31:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52870 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231338AbjDXHbr (ORCPT ); Mon, 24 Apr 2023 03:31:47 -0400 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12hn2235.outbound.protection.outlook.com [52.100.167.235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B1808210A; Mon, 24 Apr 2023 00:31:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=hKMq67jbXhMxzKBshzSzIc3S4SVj8we24/SrDX/zyXJxaVAU8gfm+gC2GzlSFHDQyopmqSNtgstexxDxN83KUbSV/HUbqtdaOAKKvHHKwtFivgxeH0Lf+q+LKvVaeTPA+rtAQg+HsCWQ4KRZI5dsKkFxoK82Vf/cogFpVkDW4a61cDuvOL0iNwdSFM25b7048tCxeLbSiouEv6VoGD7uegtg6JHYcpls74/0PRdhxGpaZ7HuN5fER7o60WP2OCLY7+tP2WTmlx5w+YSm5z6B6IA5S6sdLwQEwCeCwQhVXK2OVomk8TcPtRKPfBEY8UKEM3+C+Ibdfve6QtS8ICLL9Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=J4oeCNFOCeDAhqIMeUlEQeofszzQD0ppHGlt7WyUhz0=; b=X5rM8QpisMzpJO840L9xs056F0xHFQ//HW0rjQ9iw51LXTuVb0t6guSgZcDtxc9n7NEuFT/jEF7aUuluKVWt7uEDI8d4m82Dp5BpZGnsXhF0FpoIUbW5E6ZA5o5KYCmawOyUjUR+9wSbbaVbP9P9iGbZMuaqiUHPgxDkJiNwQ+3gs9+YnpVM5RlBFQFg2IZtbheKIiLVdx1o0op3Mytv+TBL8+Zemvn4eE+ZNOJbXrPE4vr9J6D/dV8ICrX0q1AhA/eouS1sYWysjRog8dIkMOq5DWCkrys+G3k6R+kLCyrdIHOtkKeLm/3nrGedP28eriW282q9QVziI3hg614Faw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=vger.kernel.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=J4oeCNFOCeDAhqIMeUlEQeofszzQD0ppHGlt7WyUhz0=; b=fU8DauFr95WiypPlqwUY4UmZs6RCuv3MINFd+vNImq3QfxyvQ1FyL4NsFsUpnOEOHxMQzhvwygUYIVNV2n7igPwplLWIab5IXFQvlTkUFj/sDYSOI1FjKvNtc+KHXQh0XKF5HurNfKQMuzy6Cuei08WRH24ztkebAh0FXX4X+OMYmkaVmS60TjGDvxOYO+BDZnBX1qbAX+3kU5x3EDHTTZ4oCcPF3Xdu/kIRpjylGi430EFFPxpKbu7kIFMeENBoKl2fMxOAP3AnGhFxdcJe0qZjIJLjXagu66yP2GWUiJpKfLzBO3d8WgSslvbz+t50nCeuj4pJOZTN0V8SZn68EQ== Received: from MW4PR04CA0251.namprd04.prod.outlook.com (2603:10b6:303:88::16) by CH2PR12MB4149.namprd12.prod.outlook.com (2603:10b6:610:7c::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33; Mon, 24 Apr 2023 07:31:42 +0000 Received: from CO1NAM11FT071.eop-nam11.prod.protection.outlook.com (2603:10b6:303:88:cafe::49) by MW4PR04CA0251.outlook.office365.com (2603:10b6:303:88::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6319.33 via Frontend Transport; Mon, 24 Apr 2023 07:31:42 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CO1NAM11FT071.mail.protection.outlook.com (10.13.175.56) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6340.19 via Frontend Transport; Mon, 24 Apr 2023 07:31:41 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.5; Mon, 24 Apr 2023 00:31:29 -0700 Received: from dev.nvidia.com (10.126.230.37) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.37; Mon, 24 Apr 2023 00:31:28 -0700 From: Chaitanya Kulkarni To: , CC: , , , , , , , , , , , , , Subject: [PATCH 5/5] bcache: don't clear the flag that is not set Date: Mon, 24 Apr 2023 00:30:23 -0700 Message-ID: <20230424073023.38935-6-kch@nvidia.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230424073023.38935-1-kch@nvidia.com> References: <20230424073023.38935-1-kch@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.37] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CO1NAM11FT071:EE_|CH2PR12MB4149:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fea8fe1-d5cd-4bf8-784e-08db4495f301 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: BCgZXxoPGI4nejtzseAwx5A34WCiNoeq0nFVagcDGLo1Y9NRcYJvarAJtmg1XBH+s8RlRIHjL9njDX5mrkg87nz8N/BR0Am0cpJB0mtWFgyKla6sHY7xqZiG8zt712xJFGE/cSNhqCKVQBR+MmuddGTk7fFAZ9xltOo6TdBA+3iSLeDe7mKBBrh03PJuSkhqcMxdC0jF+lxz3QeKWJu79zOOw7DuZEBMyJjnbZPoTbemf2LaL4FqXnsBcmrPUfmUpxCQdP/TLsbkhFVjX2I8z8rVPJy6P5reqg7GHIOe8iblM9TCR4Hryh5G8NRhmSXXjJDOcV5MA1sqZ0SlV1I1+714gh97fHxW25mmstljeMfkxFlb0AM6Aigq4GgMNAQI0SEqCu25DshdjquS/i0qiAFLterCKt7Epvu8fKCiDSlsWacDXPGNyNzWSoxbzICb4pZ7lC/c+yE2uGCg/yf4+EScacCCafVwOnX0TEKfWCy1SBCrX+ab7fnS7Xh7S5BFAkSl/0s5d+UjmRndXc3r8tQUQit0bqtCiWzZRjA2VJ/sM+MwhPCZby58FhRaS+zgVEdvhYYOKFOnOGExg7dVyU6G9LNCvsSg1ALBQLjcG8Nh26tR+yNc3ugsV0Sh8AFsUGOkcFQrBsgTaJSBZXBLLbs6R1/aE+CX9eO8DMZe97It6cFiQGBzfzvyLZUiaDP9pY8i5Ca4JCHHiKJScM+JfdYXMwxuRN8kQwslK+fls04NVNcBZvXNHtYqW2yqaIm+98a5jP0CBX2zUBPPpjHTyw== X-Forefront-Antispam-Report: CIP:216.228.117.160;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:mail.nvidia.com;PTR:dc6edge1.nvidia.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(346002)(39860400002)(136003)(396003)(5400799015)(451199021)(36840700001)(46966006)(40470700004)(478600001)(40460700003)(16526019)(110136005)(54906003)(36756003)(34020700004)(186003)(7696005)(26005)(82310400005)(1076003)(40480700001)(6666004)(4326008)(316002)(82740400003)(83380400001)(70206006)(70586007)(36860700001)(2906002)(4744005)(7636003)(336012)(356005)(426003)(41300700001)(8676002)(8936002)(5660300002)(47076005)(7416002)(2616005)(12100799030);DIR:OUT;SFP:1501; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2023 07:31:41.9895 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 1fea8fe1-d5cd-4bf8-784e-08db4495f301 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a;Ip=[216.228.117.160];Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CO1NAM11FT071.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4149 Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org QUEUE_FLAG_ADD_RANDOM is not set in bcache_device_init() before we clear it. There is no point in clearing the flag that is not set. Remove blk_queue_flag_clear() for QUEUE_FLAG_ADD_RANDOM. Signed-off-by: Chaitanya Kulkarni Acked-by: Coly Li --- drivers/md/bcache/super.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/md/bcache/super.c b/drivers/md/bcache/super.c index ba3909bb6bea..7e9d19fd21dd 100644 --- a/drivers/md/bcache/super.c +++ b/drivers/md/bcache/super.c @@ -971,7 +971,6 @@ static int bcache_device_init(struct bcache_device *d, unsigned int block_size, } blk_queue_flag_set(QUEUE_FLAG_NONROT, d->disk->queue); - blk_queue_flag_clear(QUEUE_FLAG_ADD_RANDOM, d->disk->queue); blk_queue_write_cache(q, true, true);