From patchwork Fri Apr 28 17:35:33 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 13226648 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8962C77B61 for ; Fri, 28 Apr 2023 17:35:40 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 507766B0075; Fri, 28 Apr 2023 13:35:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4B7B46B007B; Fri, 28 Apr 2023 13:35:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 37F996B007D; Fri, 28 Apr 2023 13:35:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 264C26B0075 for ; Fri, 28 Apr 2023 13:35:40 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E3938140286 for ; Fri, 28 Apr 2023 17:35:39 +0000 (UTC) X-FDA: 80731501998.08.F09CC3C Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) by imf12.hostedemail.com (Postfix) with ESMTP id 2702A4001F for ; Fri, 28 Apr 2023 17:35:37 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nQwQyaHp; spf=pass (imf12.hostedemail.com: domain of 36QNMZAYKCEo463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=36QNMZAYKCEo463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1682703338; a=rsa-sha256; cv=none; b=PubRCQPcBz14twOwyvi2+MH7yk/mxXBsvi8WqA7kDBeKdVrqzVBVCO7y9tJIfWwhmyKjxD x77EHsolcaFY2qcignjuZd6H5dpyjr3wXSQBhJJrU56+6N0ARPCOc0Wv9lUcANyZqJivVS ZcsBgwsuFUEwGvEsPIISh/VV0zTamag= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=nQwQyaHp; spf=pass (imf12.hostedemail.com: domain of 36QNMZAYKCEo463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com designates 209.85.219.201 as permitted sender) smtp.mailfrom=36QNMZAYKCEo463qzns00sxq.o0yxuz69-yyw7mow.03s@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1682703338; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=yyTrtR3S5gMM0KVdMQoSGiM4SzOrc6DI1bOXsYT1q/A=; b=x49FnmnMxIJIN3XSy5Xlanq9FSDect+6vRpqRmKjWr2xwbnEfhWlrVgq9I5HjlZGikeaKi N5SSxVErEI6D5Q10DuFk5FzKNAeVltyAeEUN+UxMEEo4nvCby9UeBwNuQIwQno+fOikoDG KaFHtVPGFZc9cwBxoUghoKWba5yubb0= Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-b9a805e82a9so4649239276.3 for ; Fri, 28 Apr 2023 10:35:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1682703337; x=1685295337; h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject :date:message-id:reply-to; bh=yyTrtR3S5gMM0KVdMQoSGiM4SzOrc6DI1bOXsYT1q/A=; b=nQwQyaHpYfL58xtHqqBDwedop7h9GVNhO8im6D5ItL5TT3/jAi7ai9In0/BO8VnFDa qkTXUAXDHJ6IqJgFYeuedFEi0Br7UDyk/XAYEoeA3NmhdtOFFHeYWt4LIgKw611NLFHv nD98nj14+oDPx/kUoLmUd8k3EcA5cVJjpf/fvjcHBpwbDNHK+hf7n9qTzAhHQ8N4liEL ytXu9oXNn1PVAz2Uhqm6BmBU9eZOwscjpuw4sWFTElsrGxlI1w18+V1XmPGPDF86TXbX 4ZtOJ7muAxfe37u+4e4pa7vBNb6Mplg2RQR1FUWuydhoM5Dxzyw3mnNVGTyRhien6tMA gwzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682703337; x=1685295337; h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=yyTrtR3S5gMM0KVdMQoSGiM4SzOrc6DI1bOXsYT1q/A=; b=AQclaGmWP/iYXt6VT/w1gLC1e9oJCk03nxDsZDTN8yHKe2b57hDKbTRfICpjytoVYE lYD2ro5ZDQr/WFFYT7JjmjzM5RPilKU4ukNashqefMMuVn+mrV3xLURUoTGL/nlClr1e 5PvLbAD3cWV+r5jfze500xSLVDdRwsJDzzkTPDdZ0ie2AFIxWiGv9igOTOxfo9ZTLQwV 9jub81tHWd613KceFgausu+mW6mFaVccYJkopOUlMRPn2tsZNu+TNW31r5dKVz90i+nW ZX93lpHQEayBgAZyoj9stQoh+tQr7ne27TuAWT7mCRuSLY0Bd6CwO9evadFE0XrG0gbC Bzjw== X-Gm-Message-State: AC+VfDxzTJYhFwBL8WI5A/cFWY60oWssLVZjj5a1z7mULM3DNZt1UWhL s/KFA2cZTEEcX4CeVXu265ZNC70eaLk= X-Google-Smtp-Source: ACHHUZ6a47311Z3E3ThyzHPQ9KyYllAPKcWDtQk5Fh1wPStyP+ENdM1WFpxyywRRQqPl48Pb/lCint/KSic= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:201:51d6:764:dc11:ffbd]) (user=surenb job=sendgmr) by 2002:a25:84d1:0:b0:b9a:76e4:ccd2 with SMTP id x17-20020a2584d1000000b00b9a76e4ccd2mr2343098ybm.10.1682703337303; Fri, 28 Apr 2023 10:35:37 -0700 (PDT) Date: Fri, 28 Apr 2023 10:35:33 -0700 Mime-Version: 1.0 X-Mailer: git-send-email 2.40.1.495.gc816e09b53d-goog Message-ID: <20230428173533.18158-1-surenb@google.com> Subject: [PATCH 1/1] mm: change per-VMA lock statistics to be disabled by default From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: torvalds@linux-foundation.org, lstoakes@gmail.com, vbabka@suse.cz, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@android.com, surenb@google.com X-Rspam-User: X-Rspamd-Queue-Id: 2702A4001F X-Rspamd-Server: rspam01 X-Stat-Signature: 9w4qc8gkn9admxqiatrhsfqtb65mme97 X-HE-Tag: 1682703337-534575 X-HE-Meta: U2FsdGVkX1+kyddEUN/EASymN0/dBc99KGkwc7bLJ/q+Jg/U40uqXxxSV1pwmDbyE9eAIoztWahJeZG4dePaht2HCuD+L8bDB9kohwHgr98e9Wmf9JPMiYN3t+3lNtsxb6moQo87k7oGGhcVTdp81GUPuXYZOszaUlAfCRtsU5xsOyaC+sbuA6XZWzlYPhjbs/cDSc8z6KBLs5J0VL//fPxTt04YfCUPW84KPPCw1bZSKXMa0JV9/l8A+limrpFWDOA9cKYd7tuJFx1gLybW9uBAmrCVIi/Vk3lk60xboe7qpbPmVXJex9U59clMoh2pxt52YHAuhGQjGkZCqkRq/y2tZXtyBywjPgiYZe9xpnmZr+aF+X6aymPzQ1cqgXHwGhak9o7RrJy+7L/RSihbgDB+q3D/pVzi5GLZFjGF+81d0hUJRYkXvLkSbS9dIFTig9S0HEnPJIXBdNr9vbLYfAoX1OUBRUIT+q2i9S0oG3fb7he0jF84LmLc5RscUbxRXta1vRsX6iBNQOlc3Q6fdcPfoYImgWaZBGTOfZkQOU0ttlvycxmoZW5ob2MZDMG5fsa/wJwuaMc3avZ35cmf0EbJxD30VFuRA6WNmut1AZz6JseDFsj8gvz8BbNQJWvxhPyOkbowtFQJLzX/tqN5c8serjB21SvX2lCriea27mcVVSRCWGuMjOB5Qe6pOC5s4+U9zqlGfXQDXApFZHqtgjcBZH2eHmKyZseOiKsNQLEJgBi76RsNzcIB+U5WkGqRK8+qHroaNnzg9FIKNcy5WodkemY5NO+gP9L0AutG7yYEVQJG42yjN7xTTC34n/LR3gATm9LdVsIqP4MmJxP+3/tMEo01+YO2mTjbdgRTNIEywncHRQe1JxIQGL5px1cwrTXM6fZ7/TPdlIJ3ZqoKqtpiUujUu6Y/wERm9uXsBzeFLLNpTSok3VFFBHONXdbJVIw0SJznGzmAfwQXygL vZpLbh+2 zi2fP2TDJQM35uZ8eWpLR6DwGn11Cj4g0XGUVmbSO7NcAEn6iXUvBOcQMAtYANRTrUk6lKp5lnSa2JyW8O1p5M9N1lAnWa7xsv17bilsOw065h/0XRGQQ+cFXeduVe/qA2BBFAFuuUQl9PtqrqEngCApoGA4hOA4uyWhXKbDsYujLoZd2//EYPUo2Hub+drcCY8CwXYg1QKOjaEaMwkilLwjb6i9JNqFpzKSt5/N+vgFSgNRsa0lufI0MIntmbQiHchMX6E2KNYKTJw1orTHQHk1V3ghTd2inyr2eA0Uzc/ZiVz6tK/IThGhioV0oa0Ucbxz1eIU/C8QQBlsVqUHJS8fQUrqtNtmd/Mc6pZATrMn97mqRprkh0p+01E7nslI9q/qf6dzUW6exvI+Z1+ZzdMuUDumZXzyfvJdHrCbxxhWlQUx5Qve9ieqOBSadPi4X/eTkbMaeRCURJQj8JROGYDObgh5R6/wmeVK7jHaSunJkwi0sD4l5L+0RLSPeshINuqH+nbJFP9smOBO83ObTjf/WOqdU3hC6VxBSd0QyQp9oE7OdG/CWPoebVRQ5ed2r5zQTxCzbuN7/NB4e8A8vSZwMQJkCTqzK5Gk5KO67TCZMvbi0Kk8WNKYc0JLr5IoOOJnsSCzWBwYrl58eM4TURL6YsDihssYXeAeV X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Change CONFIG_PER_VMA_LOCK_STATS to be disabled by default, as most users don't need it. Add configuration help to clarify its usage. Fixes: 52f238653e45 ("mm: introduce per-VMA lock statistics") Suggested-by: Linus Torvalds Signed-off-by: Suren Baghdasaryan Reviewed-by: Lorenzo Stoakes Acked-by: Vlastimil Babka Reviewed-by: David Hildenbrand --- mm/Kconfig.debug | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug index 6dae63b46368..a925415b4d10 100644 --- a/mm/Kconfig.debug +++ b/mm/Kconfig.debug @@ -274,6 +274,12 @@ config DEBUG_KMEMLEAK_AUTO_SCAN config PER_VMA_LOCK_STATS bool "Statistics for per-vma locks" depends on PER_VMA_LOCK - default y help - Statistics for per-vma locks. + Say Y here to enable success, retry and failure counters of page + faults handled under protection of per-vma locks. When enabled, the + counters are exposed in /proc/vmstat. This information is useful for + kernel developers to evaluate effectiveness of per-vma locks and to + identify pathological cases. Counting these events introduces a small + overhead in the page fault path. + + If in doubt, say N.