From patchwork Mon May 1 21:24:43 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13228348 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 802B7C83003 for ; Mon, 1 May 2023 21:26:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232754AbjEAV0D (ORCPT ); Mon, 1 May 2023 17:26:03 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45262 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229627AbjEAV0C (ORCPT ); Mon, 1 May 2023 17:26:02 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DC8752706 for ; Mon, 1 May 2023 14:25:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682976310; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TuHaeHAXI9GPugBSTpdzSqqdOtmVVSm+cOC6UAbi8I0=; b=YXxCXEt5yt8A5EL1D04ZkvlO8JrjbsagcN5FvUak40BCLDtefrpfeImtnSA8TJVxAsKwkf BCJueL/xh0RGpdSft4eVZApe59azeIW1mLpA+qC+f/M6sfdLSMdsKscU2nbLuJWenuaaeL 3TezQrBLGfIbl6NJ44xx7DHWVMwYt6w= Received: from mail-oo1-f72.google.com (mail-oo1-f72.google.com [209.85.161.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-363-qUXGtGP0Oi-FobA3co9BSQ-1; Mon, 01 May 2023 17:25:08 -0400 X-MC-Unique: qUXGtGP0Oi-FobA3co9BSQ-1 Received: by mail-oo1-f72.google.com with SMTP id 006d021491bc7-549dbb14e1eso1739853eaf.3 for ; Mon, 01 May 2023 14:25:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976308; x=1685568308; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TuHaeHAXI9GPugBSTpdzSqqdOtmVVSm+cOC6UAbi8I0=; b=PsAZDF3s195WyjCNgobBJuK6QvzxzJs3TpaT1nSAHXFxi5nJlU//ttDJX62njtXbpB yPOGyHwmC7wtER2ViXeS+3Wn+NEtqRfG6kJRPPyHIxiZEi04jasQGuIaukM+h6xCe6IU MZGY9RHjhC/NtM1fjj0hWEfpvUQELvOx7UkPvMMZv0Yk/PAd9F8avmFxKaxC6YndArcp hskB/fBQLh+rHUee8KhU1IXC8vnQT0egqhysn2CVUtMuc4f3gNeujRL/zLXgBkWFFACY A05nYd/ZjMOx3qMV9C4a02OA857JQJzwZ7K0uf2t09FVPuS/SkWUixNh9pE75lTtajAW kTnw== X-Gm-Message-State: AC+VfDxDNKM8vFDanJ+qYJcaE+56FmgNZ0uwc3u0/yz+AN3pZeKn6i5z WRRjz3YRi73OVFScquN+qcKTT1wzJ4YKbH/kd846a0+Ad/kw4C5HapDjkbq+cuEXefklGV7HAsO K1QP9A4ZwxBk8Oo6j69B1D8EcqQ== X-Received: by 2002:a05:6808:5a:b0:38d:f298:6cfc with SMTP id v26-20020a056808005a00b0038df2986cfcmr7224352oic.0.1682976308098; Mon, 01 May 2023 14:25:08 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4SbvWwmykUItBzmqFI5W2I8HfTV/ULJhJO3zEWw6FZxUduhjFzNK4MGF6+18C35B4vrbEWQA== X-Received: by 2002:a05:6808:5a:b0:38d:f298:6cfc with SMTP id v26-20020a056808005a00b0038df2986cfcmr7224342oic.0.1682976307919; Mon, 01 May 2023 14:25:07 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id q5-20020acac005000000b0038756901d1esm11911385oif.35.2023.05.01.14.25.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:25:07 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v4 1/4] arm64: dts: qcom: sa8155p-adp: Make compatible the first property Date: Mon, 1 May 2023 16:24:43 -0500 Message-Id: <20230501212446.2570364-2-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501212446.2570364-1-ahalaney@redhat.com> References: <20230501212446.2570364-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org As stated at the below link in another review, compatible is always the first property. Follow suit here to avoid copying incorrectly in the future. Link: https://lore.kernel.org/netdev/20230331215804.783439-1-ahalaney@redhat.com/T/#ma76b4116bbb9e49ee4bcf699e40935d80965b3f3 Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v3: * None Changes since v2: * Collect tags Changes since v1: * None arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 339fea522509..029b23198b3a 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -352,19 +352,18 @@ ðernet { max-speed = <1000>; mdio { + compatible = "snps,dwmac-mdio"; #address-cells = <0x1>; #size-cells = <0x0>; - compatible = "snps,dwmac-mdio"; - /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { + compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; interrupt-parent = <&tlmm>; interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ device_type = "ethernet-phy"; - compatible = "ethernet-phy-ieee802.3-c22"; }; }; }; From patchwork Mon May 1 21:24:44 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13228349 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BD8DC87FDD for ; Mon, 1 May 2023 21:26:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232975AbjEAV0T (ORCPT ); Mon, 1 May 2023 17:26:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232827AbjEAV0O (ORCPT ); Mon, 1 May 2023 17:26:14 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B90BC2693 for ; Mon, 1 May 2023 14:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682976322; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8c5WPJF11ihr/oNejbMdPXQbVSmYhsjYnYYtzg1kHm0=; b=B4RvMkzIpMWzPmuG7Cgu74VucR4t2a+ZuT4md5eoc+ZXhPMxrgTdqyCnjzot4J5HEbYQFL 2zjt+wJL254gYJSf2imCC0rR87ypW8hYq2sHPdmSxvgqmXptWPt/ECaox9vpdlIR1yoAq5 vsfEf10fc1WEp9mHFF1ayU+bXYWl8qc= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-316-pFGlBR5MPse9CQvr66MRJg-1; Mon, 01 May 2023 17:25:21 -0400 X-MC-Unique: pFGlBR5MPse9CQvr66MRJg-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-38eef8f6aa7so1976263b6e.3 for ; Mon, 01 May 2023 14:25:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976321; x=1685568321; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8c5WPJF11ihr/oNejbMdPXQbVSmYhsjYnYYtzg1kHm0=; b=l+T/8cDb8X47yTtDmKbqk7akgMFdwQtmNF2s20JeNrqZwhDqgSA837dGi629WrUxX6 IhViHEkCIZDsXi5VJDgTSn4IaOwtPH5ugE5xxfOZHlY05SP3zqcW+4oaqu/RE5+dzvp8 9hqA2aPFdutqGd4lkPnAzPrN/iPHyu3LuGJqkmcWwA9gV8XdzOkuD5uka8aQNPASZHFn 1j9A3Yrfjfi1u+DoIan30zu0cJhEjnewtyM1m157viRB6HF2FoYlyOEquwD/4qQ9Ols3 kkaaQ5IOpQhoD7v19b4ZkmCWbMQqBgAhWh1RFfaly1/AAQg04C0Ilm4ni0n30VCgXb4D VChA== X-Gm-Message-State: AC+VfDzA0wBsOf8rSSGUKqrI8PZn8/4IUtNIWzKZwFDdnI/zwWOXnpUA OBvqWllHYgsqrL/D5wlQeT44CtiQIxsAw28ZWpVI4JM9Ta5lMcXqiDCKM6Vu6X39og1Uc8QaLVb Q+skndD2Mpludw8SLrbCszKy3/g== X-Received: by 2002:a05:6808:295:b0:390:43a9:98fa with SMTP id z21-20020a056808029500b0039043a998famr7242307oic.33.1682976320989; Mon, 01 May 2023 14:25:20 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4b9UrOY8vDozWqJ1pwOCcrPApFWuY2pxYYR2O1g9/yIm7n4imMdiM8vyfRLUPjNSUHVcVOpg== X-Received: by 2002:a05:6808:295:b0:390:43a9:98fa with SMTP id z21-20020a056808029500b0039043a998famr7242301oic.33.1682976320779; Mon, 01 May 2023 14:25:20 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id q5-20020acac005000000b0038756901d1esm11911385oif.35.2023.05.01.14.25.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:25:20 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v4 2/4] arm64: dts: qcom: Make -cells decimal Date: Mon, 1 May 2023 16:24:44 -0500 Message-Id: <20230501212446.2570364-3-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501212446.2570364-1-ahalaney@redhat.com> References: <20230501212446.2570364-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The property logically makes sense in decimal, and is the standard used elsewhere. Suggested-by: Konrad Dybcio Signed-off-by: Andrew Halaney Reviewed-by: Krzysztof Kozlowski --- Changes since v3: * Treat all of arm64/qcom at once (Krzysztof) * Dropped Konrad's RB tag since the scope expanded Changes since v2: * Collect tags Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/ipq6018.dtsi | 2 +- arch/arm64/boot/dts/qcom/ipq8074.dtsi | 14 +++++++------- arch/arm64/boot/dts/qcom/msm8953.dtsi | 4 ++-- arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts | 4 ++-- arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 4 ++-- 5 files changed, 14 insertions(+), 14 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/ipq6018.dtsi b/arch/arm64/boot/dts/qcom/ipq6018.dtsi index 9ff4e9d45065..ccaf8e57668a 100644 --- a/arch/arm64/boot/dts/qcom/ipq6018.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq6018.dtsi @@ -571,7 +571,7 @@ intc: interrupt-controller@b000000 { #address-cells = <2>; #size-cells = <2>; interrupt-controller; - #interrupt-cells = <0x3>; + #interrupt-cells = <3>; reg = <0x0 0x0b000000 0x0 0x1000>, /*GICD*/ <0x0 0x0b002000 0x0 0x1000>, /*GICC*/ <0x0 0x0b001000 0x0 0x1000>, /*GICH*/ diff --git a/arch/arm64/boot/dts/qcom/ipq8074.dtsi b/arch/arm64/boot/dts/qcom/ipq8074.dtsi index 84e715aa4310..0bde1303bb9d 100644 --- a/arch/arm64/boot/dts/qcom/ipq8074.dtsi +++ b/arch/arm64/boot/dts/qcom/ipq8074.dtsi @@ -29,8 +29,8 @@ xo: xo { }; cpus { - #address-cells = <0x1>; - #size-cells = <0x0>; + #address-cells = <1>; + #size-cells = <0>; CPU0: cpu@0 { device_type = "cpu"; @@ -106,8 +106,8 @@ scm { }; soc: soc { - #address-cells = <0x1>; - #size-cells = <0x1>; + #address-cells = <1>; + #size-cells = <1>; ranges = <0 0 0 0xffffffff>; compatible = "simple-bus"; @@ -321,9 +321,9 @@ tlmm: pinctrl@1000000 { interrupts = ; gpio-controller; gpio-ranges = <&tlmm 0 0 70>; - #gpio-cells = <0x2>; + #gpio-cells = <2>; interrupt-controller; - #interrupt-cells = <0x2>; + #interrupt-cells = <2>; serial_4_pins: serial4-state { pins = "gpio23", "gpio24"; @@ -666,7 +666,7 @@ intc: interrupt-controller@b000000 { #address-cells = <1>; #size-cells = <1>; interrupt-controller; - #interrupt-cells = <0x3>; + #interrupt-cells = <3>; reg = <0x0b000000 0x1000>, <0x0b002000 0x1000>; ranges = <0 0xb00a000 0xffd>; diff --git a/arch/arm64/boot/dts/qcom/msm8953.dtsi b/arch/arm64/boot/dts/qcom/msm8953.dtsi index 602cb188a635..eeebdab58c04 100644 --- a/arch/arm64/boot/dts/qcom/msm8953.dtsi +++ b/arch/arm64/boot/dts/qcom/msm8953.dtsi @@ -1505,8 +1505,8 @@ apcs: mailbox@b011000 { timer@b120000 { compatible = "arm,armv7-timer-mem"; reg = <0x0b120000 0x1000>; - #address-cells = <0x01>; - #size-cells = <0x01>; + #address-cells = <1>; + #size-cells = <1>; ranges; frame@b121000 { diff --git a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts index 59702ba24f35..358827c2fbd3 100644 --- a/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts +++ b/arch/arm64/boot/dts/qcom/qcs404-evb-4000.dts @@ -27,8 +27,8 @@ ðernet { phy-handle = <&phy1>; phy-mode = "rgmii"; mdio { - #address-cells = <0x1>; - #size-cells = <0x0>; + #address-cells = <1>; + #size-cells = <0>; compatible = "snps,dwmac-mdio"; phy1: phy@4 { compatible = "ethernet-phy-ieee802.3-c22"; diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index 029b23198b3a..ac52a8dfeba1 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -353,8 +353,8 @@ ðernet { mdio { compatible = "snps,dwmac-mdio"; - #address-cells = <0x1>; - #size-cells = <0x0>; + #address-cells = <1>; + #size-cells = <0>; /* Micrel KSZ9031RNZ PHY */ rgmii_phy: phy@7 { From patchwork Mon May 1 21:24:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13228350 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DED61C7EE21 for ; Mon, 1 May 2023 21:26:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232172AbjEAV0U (ORCPT ); Mon, 1 May 2023 17:26:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45516 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232957AbjEAV0P (ORCPT ); Mon, 1 May 2023 17:26:15 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 910962102 for ; Mon, 1 May 2023 14:25:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682976329; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8n1iKzbSEbcRTyERJXwfTcGMwG21ns2eb1EhMK8ImtQ=; b=MIB9iG+6v10nKouwDSEkgA/O92cwtkCkVR7ZIakdl1gsxr6mFvSyF0Qsan7Dkjp8cVAz8H 2/i0UtIHAsL7CS8OxAuTPG0S5FrEGtS3MbWSOuGma/Jdh5vXmu0V+IhfO0DKY5BGXUC75B yIWDjnvSEk3EyXlO5K0GCij6r3Nl6n0= Received: from mail-oi1-f200.google.com (mail-oi1-f200.google.com [209.85.167.200]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-345-We0zLAeqOkS9WvI-MmGP9w-1; Mon, 01 May 2023 17:25:28 -0400 X-MC-Unique: We0zLAeqOkS9WvI-MmGP9w-1 Received: by mail-oi1-f200.google.com with SMTP id 5614622812f47-38eab7030c2so506480b6e.0 for ; Mon, 01 May 2023 14:25:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976327; x=1685568327; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8n1iKzbSEbcRTyERJXwfTcGMwG21ns2eb1EhMK8ImtQ=; b=A6fCJDK+GGL/OADaV+N65ox1hQul5YtUM+06PNGMd9ZarmDOXLxXW+qip3QshNto/F VM8EM9CIhKjqILAqraeok/xv9Lz4tcll4K537Imucf2I6IA0XyBnJpBgPzGDlJHrYmd0 wNz4MagnnwyExTEhCm5MBA6dqy6x9Xw0Xa8ln0/+c9kWW94o9R41Mz++mDuV/ojeYUG+ 4pdslDAr/eXqmTEeGpMpr0Bd2yvL3VdyrqYxDHEBbdRPjTcnxWQWpdwyGwi3JPRBsGao A7h10xGGEn4gH7N8XsP2mH71y2XRTA4x3dqohjmd/Km7n6OwxCV1KT/30dbTQe83j1yN vyVA== X-Gm-Message-State: AC+VfDzpNAihsmVVh31xRukPVviTqUCRHxKNv1qy2GFb1qL42jkqk6/9 nTpmsvahCiIF343R7XUoAHgOFo4FPg7DY/G+UxeEFd3FH/FuT8aIn4F2++lk7J6Mde3TT0Bj0wD XTmr3cRkp4lUgpLjLw28skIPu1w== X-Received: by 2002:a05:6808:3096:b0:390:983c:4ab1 with SMTP id bl22-20020a056808309600b00390983c4ab1mr6117845oib.42.1682976327754; Mon, 01 May 2023 14:25:27 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4xKd0hSXYgwrrx7dYRkQ/OFyeE0kBY0kJvUuw2acvC3o4uOA025xxiX27bG2NBLyZMIKhc7g== X-Received: by 2002:a05:6808:3096:b0:390:983c:4ab1 with SMTP id bl22-20020a056808309600b00390983c4ab1mr6117841oib.42.1682976327429; Mon, 01 May 2023 14:25:27 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id q5-20020acac005000000b0038756901d1esm11911385oif.35.2023.05.01.14.25.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:25:27 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v4 3/4] arm64: dts: qcom: sa8155p-adp: Remove unneeded rgmii_phy information Date: Mon, 1 May 2023 16:24:45 -0500 Message-Id: <20230501212446.2570364-4-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501212446.2570364-1-ahalaney@redhat.com> References: <20230501212446.2570364-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Using interrupts-extended already indicates what the interrupt-parent is, so drop the explicit interrupt-parent. The comment about this being the phy-intr is not helpful either, since this is the only interrupt in the phy node. Suggested-by: Konrad Dybcio Reviewed-by: Konrad Dybcio Signed-off-by: Andrew Halaney --- Changes since v3: * None Changes since v2: * Collect tags Changes since v1: * New patch (Konrad) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index ac52a8dfeba1..b65e0203d783 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -361,8 +361,7 @@ rgmii_phy: phy@7 { compatible = "ethernet-phy-ieee802.3-c22"; reg = <0x7>; - interrupt-parent = <&tlmm>; - interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; /* phy intr */ + interrupts-extended = <&tlmm 124 IRQ_TYPE_EDGE_FALLING>; device_type = "ethernet-phy"; }; }; From patchwork Mon May 1 21:24:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Halaney X-Patchwork-Id: 13228351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9BFC6C7EE29 for ; Mon, 1 May 2023 21:26:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232966AbjEAV0a (ORCPT ); Mon, 1 May 2023 17:26:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232813AbjEAV00 (ORCPT ); Mon, 1 May 2023 17:26:26 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E242726AA for ; Mon, 1 May 2023 14:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1682976336; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mDamfEXI3whq2cw/x9Hd2+R2GXvUBBZU4UUvZz4CPZQ=; b=KmK34DoZgicG6LK/GFd3p8VyUSo328aINdi6FCD1RvtQF8lcnUNKe5KXKiAEUSLZRTSWLr XOuQPAvpl5UvyKa9erEV9wKVj9ocwPKr0I4wXINCLYnNN++1gwQ8Ald2WZX4I4SMehTWtY rDOfBGqZv8GGp53TZLXFO9Ex75fblbU= Received: from mail-oi1-f198.google.com (mail-oi1-f198.google.com [209.85.167.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-10-bvI8iZR8M2anKYJBDjSwNg-1; Mon, 01 May 2023 17:25:35 -0400 X-MC-Unique: bvI8iZR8M2anKYJBDjSwNg-1 Received: by mail-oi1-f198.google.com with SMTP id 5614622812f47-38e0523ba37so1983597b6e.1 for ; Mon, 01 May 2023 14:25:34 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1682976334; x=1685568334; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mDamfEXI3whq2cw/x9Hd2+R2GXvUBBZU4UUvZz4CPZQ=; b=eJOK9cF2AnPqAUDRE07d+Nn3rpk5Qpj+dbfqX0+e7tb19EcmqkZX6CoBWs4Vgod/Pi nYezCGC4+areWlU6tys2rLzMo5SP56C5gxJ3Zk0pBRQqOUAiiqd2sb1k9Pavm0anDHpF otX/JJLgc+PCntTrrENsHqLAZweP3WJgXBlhqwIzqzA+O6ut6E7iG7WxR9H9dE/4VM1e skN/42ByJmh7nT1VNxn3JuAfdWhFrEWw8enx1nBZS3mCuKe3cJFjC6atrmnFPrqBglvT eDsrG7sNRU5qRu7zIpjPLf8sd7+QR4vnCDJVlcFcv+77RSTQHF12ojBUUEb15OjhfLKb EYLQ== X-Gm-Message-State: AC+VfDzWnOBOXe1rORrH1PPn8Ujvj83azfvGoNOFdPAj9AyZUMTlNw/U AvbTjSl0NnwrAo5AXEH1PzIcLk/W4Rr51GemR2GzkKgFEg6BmzAzMA2zxF06JJahqLgnu24CH0y ruILOD10TXkOc6QM8b4yOJPdagg== X-Received: by 2002:a05:6808:4345:b0:38e:50:415 with SMTP id dx5-20020a056808434500b0038e00500415mr7011946oib.44.1682976334398; Mon, 01 May 2023 14:25:34 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4BYwS+ULQ3y0vZhVcaPo7KzPmc9j3hnqCUWlnnvYXv9iYD7qYyCrXV++03Po9pEsgckmWoVA== X-Received: by 2002:a05:6808:4345:b0:38e:50:415 with SMTP id dx5-20020a056808434500b0038e00500415mr7011943oib.44.1682976334174; Mon, 01 May 2023 14:25:34 -0700 (PDT) Received: from halaney-x13s.attlocal.net ([2600:1700:1ff0:d0e0::22]) by smtp.gmail.com with ESMTPSA id q5-20020acac005000000b0038756901d1esm11911385oif.35.2023.05.01.14.25.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 01 May 2023 14:25:33 -0700 (PDT) From: Andrew Halaney To: linux-kernel@vger.kernel.org Cc: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Andrew Halaney Subject: [PATCH v4 4/4] arm64: dts: qcom: sa8155p-adp: Move mtl nodes into ethernet node Date: Mon, 1 May 2023 16:24:46 -0500 Message-Id: <20230501212446.2570364-5-ahalaney@redhat.com> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230501212446.2570364-1-ahalaney@redhat.com> References: <20230501212446.2570364-1-ahalaney@redhat.com> MIME-Version: 1.0 Content-type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The mtl nodes aren't evaluated unless they're under the node with the compatible. Move them so they're now evaluated in case future patchsets modify them incorrectly. An example of this can be seen in the link. Link: https://lore.kernel.org/linux-arm-msm/20230414145844.wyg6pt623pzqwh5l@halaney-x13s/ Signed-off-by: Andrew Halaney --- Changes since v3: * None Changes since v2: * New patch (me, after realizing this on another platform) arch/arm64/boot/dts/qcom/sa8155p-adp.dts | 46 ++++++++++++------------ 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts index b65e0203d783..02d04ce877c9 100644 --- a/arch/arm64/boot/dts/qcom/sa8155p-adp.dts +++ b/arch/arm64/boot/dts/qcom/sa8155p-adp.dts @@ -47,29 +47,6 @@ vreg_s4a_1p8: smps4 { vin-supply = <&vreg_3p3>; }; - - mtl_rx_setup: rx-queues-config { - snps,rx-queues-to-use = <1>; - snps,rx-sched-sp; - - queue0 { - snps,dcb-algorithm; - snps,map-to-dma-channel = <0x0>; - snps,route-up; - snps,priority = <0x1>; - }; - }; - - mtl_tx_setup: tx-queues-config { - snps,tx-queues-to-use = <1>; - snps,tx-sched-wrr; - - queue0 { - snps,weight = <0x10>; - snps,dcb-algorithm; - snps,priority = <0x0>; - }; - }; }; &apps_rsc { @@ -365,6 +342,29 @@ rgmii_phy: phy@7 { device_type = "ethernet-phy"; }; }; + + mtl_rx_setup: rx-queues-config { + snps,rx-queues-to-use = <1>; + snps,rx-sched-sp; + + queue0 { + snps,dcb-algorithm; + snps,map-to-dma-channel = <0x0>; + snps,route-up; + snps,priority = <0x1>; + }; + }; + + mtl_tx_setup: tx-queues-config { + snps,tx-queues-to-use = <1>; + snps,tx-sched-wrr; + + queue0 { + snps,weight = <0x10>; + snps,dcb-algorithm; + snps,priority = <0x0>; + }; + }; }; &qupv3_id_1 {