From patchwork Tue May 16 15:30:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243277 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 484D6C77B7A for ; Tue, 16 May 2023 15:31:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 13921C433EF; Tue, 16 May 2023 15:31:34 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CF0DEC433A4; Tue, 16 May 2023 15:31:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251094; bh=jSt93p6QqRHSfhQI7J2hfgJYmouz2AQLVyfURXXqX8s=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=AwomvbT8Pm+fhyGJwGnUOYhunar1+rxNklkbAupsLWDpLmLjStG8P95r0LW0TZ7Sn rUt0ea8SiWMVTZAiu4cMYZbbqvqcv2e5DTPOk7p1oIHvJ+Ao0RHe6GVdZ5zJRnAPVd qy/Nqrez73CiiRfbe0msHl+n84nCTm1LvattabEfx9Ed1CbYinH+MqmnQ4vCIsy8bD HpHPXOv+AbSGsNFushKq1hOP4kIPFJLROWGA9jOdBsyH0QKtmHcFeRb2CsRWAEBNXZ gM8iD9hn1D5PUXY3XhTLS9pkXmC1Abn+RFpluaep373/1+vT3WOghrCF2mY9s3EJiv NZdHPN/tuvyTQ== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 01/13] ARM: davinci: fix davinci_cpufreq_init() declaration Date: Tue, 16 May 2023 17:30:57 +0200 Message-Id: <20230516153109.514251-2-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann The davinci_cpufreq_init() declaration is only seen by its caller but not the definition: drivers/cpufreq/davinci-cpufreq.c:153:12: error: no previous prototype for 'davinci_cpufreq_init' Move it into the platform_data header that is already used an interface between the two places. Signed-off-by: Arnd Bergmann Acked-by: Bartosz Golaszewski --- arch/arm/mach-davinci/common.c | 1 + arch/arm/mach-davinci/common.h | 6 ------ include/linux/platform_data/davinci-cpufreq.h | 6 ++++++ 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/arch/arm/mach-davinci/common.c b/arch/arm/mach-davinci/common.c index c1ce6b2a8d48..7bc7018688de 100644 --- a/arch/arm/mach-davinci/common.c +++ b/arch/arm/mach-davinci/common.c @@ -11,6 +11,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-davinci/common.h b/arch/arm/mach-davinci/common.h index b2a96cdf88da..010ba1df27b3 100644 --- a/arch/arm/mach-davinci/common.h +++ b/arch/arm/mach-davinci/common.h @@ -55,12 +55,6 @@ extern void davinci_common_init(const struct davinci_soc_info *soc_info); extern void davinci_init_ide(void); void davinci_init_late(void); -#ifdef CONFIG_CPU_FREQ -int davinci_cpufreq_init(void); -#else -static inline int davinci_cpufreq_init(void) { return 0; } -#endif - #ifdef CONFIG_SUSPEND int davinci_pm_init(void); #else diff --git a/include/linux/platform_data/davinci-cpufreq.h b/include/linux/platform_data/davinci-cpufreq.h index bc208c64e3d7..1ef91c36f609 100644 --- a/include/linux/platform_data/davinci-cpufreq.h +++ b/include/linux/platform_data/davinci-cpufreq.h @@ -16,4 +16,10 @@ struct davinci_cpufreq_config { int (*init)(void); }; +#ifdef CONFIG_CPU_FREQ +int davinci_cpufreq_init(void); +#else +static inline int davinci_cpufreq_init(void) { return 0; } +#endif + #endif /* _MACH_DAVINCI_CPUFREQ_H */ From patchwork Tue May 16 15:30:58 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243278 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD2E2C77B7F for ; Tue, 16 May 2023 15:31:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id B031BC4339E; Tue, 16 May 2023 15:31:41 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B0F7C433A1; Tue, 16 May 2023 15:31:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251101; bh=5Ob/x9sOKHvBpaTIVr8ONLXcGD9gziQ+4a3wROsf1bo=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=IHuGfAQPh5Mp3dhNT5Mx+S1PqR+LqyyBSG/XwwaAU1dg7uPcXFP4wrgEgfb7+3tRD Al1R8pbUX8n0AIA49EifWICbGjD4TVnacdED78FsO21z07NX7lplDIex3HpB7DoEIG nzs5RpgzCNbDrY8qXkqgExO47LYddcAEG4uMK7z4yeiPvpjU7bnm/VidZMuDjb8tR4 GE/AwNA6Yg/k8Qhx9L+/904Q7sbtnmXCYiJ3UVtetXOiStDf9fwVsBgKP3Z4lW5UOI VEsps2PwUSvko3ALHGI5qUe/VZ8TuR1rtWWwwGzFg+fOBYsdZK6cyIpeHhRTuHJ4tp R2E6+v/AzUnHw== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 02/13] ARM: ep93xx: fix missing-prototype warnings Date: Tue, 16 May 2023 17:30:58 +0200 Message-Id: <20230516153109.514251-3-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann ep93xx_clocksource_read() is only called from the file it is declared in, while ep93xx_timer_init() is declared in a header that is not included here. arch/arm/mach-ep93xx/timer-ep93xx.c:120:13: error: no previous prototype for 'ep93xx_timer_init' arch/arm/mach-ep93xx/timer-ep93xx.c:63:5: error: no previous prototype for 'ep93xx_clocksource_read' Fixes: 000bc17817bf ("ARM: ep93xx: switch to GENERIC_CLOCKEVENTS") Signed-off-by: Arnd Bergmann Acked-by: Alexander Sverdlin --- arch/arm/mach-ep93xx/timer-ep93xx.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/arm/mach-ep93xx/timer-ep93xx.c b/arch/arm/mach-ep93xx/timer-ep93xx.c index dd4b164d1831..a9efa7bc2fa1 100644 --- a/arch/arm/mach-ep93xx/timer-ep93xx.c +++ b/arch/arm/mach-ep93xx/timer-ep93xx.c @@ -9,6 +9,7 @@ #include #include #include "soc.h" +#include "platform.h" /************************************************************************* * Timer handling for EP93xx @@ -60,7 +61,7 @@ static u64 notrace ep93xx_read_sched_clock(void) return ret; } -u64 ep93xx_clocksource_read(struct clocksource *c) +static u64 ep93xx_clocksource_read(struct clocksource *c) { u64 ret; From patchwork Tue May 16 15:30:59 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243279 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 83E82C77B7F for ; Tue, 16 May 2023 15:31:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 6A480C433EF; Tue, 16 May 2023 15:31:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 224C9C433D2; Tue, 16 May 2023 15:31:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251109; bh=BIagkEY4mLvGqj4tPqjkB1cb/gqev1UThavPZEGdG5M=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=hGyYeFqlE/uEmWvEwVxHREbGHmJvhAvqdVTAkN1iXDNQRc5fpQRVIFrMHuNw+27Dp vmTVi3Ldc35LGpEStLxFP/6zP8YV+sQdd3NOgRs6j3Mm45+rLnBGdE2CIGpoJoOjRb TuxluRCdiplaJCG1GaKE27GXjJxP+l5nROu+qXP0xFBXP2USW89qRMbk19lJFm24yh BAhAQ/3d2DxsxTtUya+ndT98c62mUeJP5AugjbAWfLoVdMc8sHgmxDnUzF52b855BU qpYgomV0TLXapsX2O9OM4VL6lYzqnw/+3NSb71xu3zhdFtNsLCngDN5FAZT4RuZwAK E+PoHTJXfLsxg== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 03/13] ARM: highbank: add missing include Date: Tue, 16 May 2023 17:30:59 +0200 Message-Id: <20230516153109.514251-4-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann highbank_pm_init() is declared in core.h this is not included in the file that defines it. arch/arm/mach-highbank/pm.c:43:13: error: no previous prototype for 'highbank_pm_init' Signed-off-by: Arnd Bergmann Acked-by: Andre Przywara --- arch/arm/mach-highbank/pm.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/mach-highbank/pm.c b/arch/arm/mach-highbank/pm.c index 561941baeda9..3fdbdb83113b 100644 --- a/arch/arm/mach-highbank/pm.c +++ b/arch/arm/mach-highbank/pm.c @@ -12,6 +12,8 @@ #include +#include "core.h" + #define HIGHBANK_SUSPEND_PARAM \ ((0 << PSCI_0_2_POWER_STATE_ID_SHIFT) | \ (1 << PSCI_0_2_POWER_STATE_AFFL_SHIFT) | \ From patchwork Tue May 16 15:31:00 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243280 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4CEC8C77B7F for ; Tue, 16 May 2023 15:31:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 0E511C433D2; Tue, 16 May 2023 15:31:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CAB97C4339B; Tue, 16 May 2023 15:31:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251117; bh=w4lHecQFJ3ZINP3Hc7+YhHQezZE2AOKlOI1bwVTKIBg=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=RQDSyMJnvfCmcikGVq/JcSp3iv74yOgo5tXTfilU+bVA8a2P+ZY9hu6ZzoD6eHEbn ONnZK6g+LjqmQVemTraCdw+lXaaQHL1YcDe8Vm9IVr4ALIXXMdK7y1KYcR68lSsRtx vCZ3emzEsNpJvz6y2V/Vo7j3lq37rOlbqRSuS0sirTuBtycZaO7ssZixsCQqe9MOc3 g1cxzYhfbd84IrhpJIYucYcWAzT++8R2Snq/KU6vDUNpkbket/PCkfVhIM7FkAntqd L9yt/v8nAVk8exjrfYckjxLnnNj7e9+uWs7DEHpeoTGSjRvpN3pD+dGmQUf4OMFw6e DZFR9KRdd5PKA== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 04/13] ARM: imx: add missing include Date: Tue, 16 May 2023 17:31:00 +0200 Message-Id: <20230516153109.514251-5-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann imx25_pm_init() is declared in common.h but this is not included before its definition: arch/arm/mach-imx/pm-imx25.c:31:13: error: no previous prototype for 'imx25_pm_init' Signed-off-by: Arnd Bergmann --- arch/arm/mach-imx/pm-imx25.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-imx/pm-imx25.c b/arch/arm/mach-imx/pm-imx25.c index f253e5019465..0c574e8607fd 100644 --- a/arch/arm/mach-imx/pm-imx25.c +++ b/arch/arm/mach-imx/pm-imx25.c @@ -6,6 +6,7 @@ #include #include #include +#include "common.h" static int imx25_suspend_enter(suspend_state_t state) { From patchwork Tue May 16 15:31:01 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243281 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BEA3BC77B7A for ; Tue, 16 May 2023 15:32:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id A55D4C433D2; Tue, 16 May 2023 15:32:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4E1C433EF; Tue, 16 May 2023 15:31:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251124; bh=dGtx50T5is7qnVEdQTiLOc5141/dVGpeqDfz3k59KAw=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=TQuu3nUvQAba0rT7rxE8hy/wOhHfYyKB27Jn2i6pr7EzDud+kwVMFWXuJrnXLbVgC bdGeo/3tyLHKBqpYuZUwAFXvnKHBI0QiRpJglxXDMZCVrScgnLt5YTQewDQK12dddt dVyDI5+U+30YS/0p9GE40rOFX6WLE5H4K7tzdKycVou7KVmvNn3nC2cz2N+yJbwAig m4IhSVGuMDqkU8Mwee18/7qij03qT2CEljXKwSjrtvSCqrOz/sB3rZeNxJbYYVhW2B Iu0zG9Qcu7r6bk3bTPGUjuVIpGQthfIfO50PISjc6/bK8aF5N5ffX7ijhJnFAEWIfJ 0DcsBjRXNhKCQ== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 05/13] ARM: imx: remove unused mx25_revision() Date: Tue, 16 May 2023 17:31:01 +0200 Message-Id: <20230516153109.514251-6-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann This function has no prototype and no callers: arm/mach-imx/cpu-imx25.c:43:5: error: no previous prototype for 'mx25_revision' [-Werror=missing-prototypes] Signed-off-by: Arnd Bergmann --- arch/arm/mach-imx/Makefile | 2 +- arch/arm/mach-imx/cpu-imx25.c | 50 ----------------------------------- 2 files changed, 1 insertion(+), 51 deletions(-) delete mode 100644 arch/arm/mach-imx/cpu-imx25.c diff --git a/arch/arm/mach-imx/Makefile b/arch/arm/mach-imx/Makefile index 5c650bf40e02..35a99888f54a 100644 --- a/arch/arm/mach-imx/Makefile +++ b/arch/arm/mach-imx/Makefile @@ -1,7 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 obj-y := cpu.o system.o irq-common.o -obj-$(CONFIG_SOC_IMX25) += cpu-imx25.o mach-imx25.o pm-imx25.o +obj-$(CONFIG_SOC_IMX25) += mach-imx25.o pm-imx25.o obj-$(CONFIG_SOC_IMX27) += cpu-imx27.o pm-imx27.o mach-imx27.o diff --git a/arch/arm/mach-imx/cpu-imx25.c b/arch/arm/mach-imx/cpu-imx25.c deleted file mode 100644 index cc86977d0a34..000000000000 --- a/arch/arm/mach-imx/cpu-imx25.c +++ /dev/null @@ -1,50 +0,0 @@ -// SPDX-License-Identifier: GPL-2.0-or-later -/* - * MX25 CPU type detection - * - * Copyright (c) 2009 Daniel Mack - * Copyright (C) 2011 Freescale Semiconductor, Inc. All Rights Reserved - */ -#include -#include -#include -#include - -#include "iim.h" -#include "hardware.h" - -static int mx25_cpu_rev = -1; - -static int mx25_read_cpu_rev(void) -{ - u32 rev; - void __iomem *iim_base; - struct device_node *np; - - np = of_find_compatible_node(NULL, NULL, "fsl,imx25-iim"); - iim_base = of_iomap(np, 0); - of_node_put(np); - BUG_ON(!iim_base); - rev = readl(iim_base + MXC_IIMSREV); - iounmap(iim_base); - - switch (rev) { - case 0x00: - return IMX_CHIP_REVISION_1_0; - case 0x01: - return IMX_CHIP_REVISION_1_1; - case 0x02: - return IMX_CHIP_REVISION_1_2; - default: - return IMX_CHIP_REVISION_UNKNOWN; - } -} - -int mx25_revision(void) -{ - if (mx25_cpu_rev == -1) - mx25_cpu_rev = mx25_read_cpu_rev(); - - return mx25_cpu_rev; -} -EXPORT_SYMBOL(mx25_revision); From patchwork Tue May 16 15:31:02 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243282 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 69716C77B7A for ; Tue, 16 May 2023 15:32:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 4BBC1C433D2; Tue, 16 May 2023 15:32:12 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 136AAC4339B; Tue, 16 May 2023 15:32:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251132; bh=Lif0fPFnMA+RVd7k+dq/VZD68IuDTY92OD9g1tXQ54A=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=ASVc7pRCEvgwvGP60q+d+Xrx1QFUzr9N2Pm9i7uUwMw7hudmAR8i+hVaZF3Jzw1nU rJOg+dT5ocHqbf4B4khzmAlpOEyIMB7EIk63umwG8/A27VTgLvNN0HEocz6MKqvSY6 oE300R8yaflSxMPW/1GiTnEve0Y8tKXbsx6GbY3eoeSnv2GUq0YQ+q4D1rcoXr9YhM HDZPAOgWmnRZ1ktr2Bxx3wK5F8Md3HJAFt1MN/ZmVOphPVsHWeIQ77eP/3gSh9ZD/M jcU4v5S45zBUkKu7CkBG0FMOo7zxSes0BcOX6UCEG/WrdoE/VSDKwZjozIVjp8YgKE lghSKYQVriOxw== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 06/13] ARM: lpc32xx: add missing include Date: Tue, 16 May 2023 17:31:02 +0200 Message-Id: <20230516153109.514251-7-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann lpc32xx_loopback_set() is defined in linux/soc/nxp/lpc32xx-misc.h but this is not included before the function definition. arch/arm/mach-lpc32xx/serial.c:63:6: error: no previous prototype for 'lpc32xx_loopback_set' Signed-off-by: Arnd Bergmann Acked-by: Vladimir Zapolskiy --- arch/arm/mach-lpc32xx/serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-lpc32xx/serial.c b/arch/arm/mach-lpc32xx/serial.c index 3e765c4bf986..3b1203db81b2 100644 --- a/arch/arm/mach-lpc32xx/serial.c +++ b/arch/arm/mach-lpc32xx/serial.c @@ -15,6 +15,7 @@ #include #include #include +#include #include "lpc32xx.h" #include "common.h" From patchwork Tue May 16 15:31:03 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243283 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F2011C77B7A for ; Tue, 16 May 2023 15:32:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id D7D18C4339C; Tue, 16 May 2023 15:32:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8001C433EF; Tue, 16 May 2023 15:32:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251139; bh=dDRQbj/KbMQidLzt89wdLCnqDQHFvR8G70nf6jL+1Jo=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=q9aWL79Ak+LPTHCFymDaK/bTJEoBzpQ0TDN2miU15QI6phT666vjvqi8ICCUY3oS/ NMl7bOlEwi7SJIX8/rOgfjl8cZE/X4pbqIqqsaWNgWT7yMU4MO5rlHIwCKIg7qjLgY 5SBUGfW/4uAScd7GyBlrwutWporaGKZsnYZkwuWXU9hrUF3B7sHW0HfMxMKCx/pSTa QlJpi91NxL0Ifip2A0KnQXDLBAlzJyRJQK4+MTfaRPm3mnB0yalBAQ08R6Lj7BenQG vLrGvTlVtznA5Tdi3Rbaw/I8Xk8McclPS3975cBayCcQ6gbjECgH3NwbuydwMtXynP dfoheysl/A6kQ== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 07/13] ARM: omap1: add missing include Date: Tue, 16 May 2023 17:31:03 +0200 Message-Id: <20230516153109.514251-8-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann The omap_serial_wakeup_init() declaration is not visible where it is defined, so make sure "common.h" is included here, avoiding: arch/arm/mach-omap1/serial.c:221:12: error: no previous prototype for 'omap_serial_wakeup_init' [-Werror=missing-prototypes] Signed-off-by: Arnd Bergmann Acked-by: Aaro Koskinen Acked-by: Tony Lindgren Acked-by: Tony Lindgren --- arch/arm/mach-omap1/serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap1/serial.c b/arch/arm/mach-omap1/serial.c index 96f59110d649..f25b94c86aec 100644 --- a/arch/arm/mach-omap1/serial.c +++ b/arch/arm/mach-omap1/serial.c @@ -19,6 +19,7 @@ #include +#include "common.h" #include "serial.h" #include "mux.h" #include "pm.h" From patchwork Tue May 16 15:31:04 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243284 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92F5AC77B7A for ; Tue, 16 May 2023 15:32:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 7F014C4339C; Tue, 16 May 2023 15:32:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E920C4339B; Tue, 16 May 2023 15:32:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251147; bh=dvQdqL3zWm7vO4AUHY3E39PwDsm+dTszcVCJpk1xl0g=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=LLy1+d+/ZCw6Wb4qr5DYAXio7HcbcAKuFJxjrWjq7tmqqOy9SdHdHp0evNa02cqjd WGOgkub2eKH9G8sWfcYvsLCLqejYnItvRYzgP0jpk+D1QijzHW1X7cJHNJF43tRq0V QZ1MdGAE4ryPpIKvCe57NOmzILA9xzp6R5NA8ROPOfASOKgmZRBHBXHbYnngDmV6MZ ub/526cr9ReXuNlkxkjh8EUaV/zL60LKlbQjiN30juWlUtlO65+PII73MHoC8c1SbK XykoHq4KxQdKkw1bENapWueD8wdcB+oNVBX8Hv/EN0vOLG9ceY3BH5ZCefmu5J/Ryn i3xnd7ykEn6kA== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 08/13] ARM: omap2: fix missing tick_broadcast() prototype Date: Tue, 16 May 2023 17:31:04 +0200 Message-Id: <20230516153109.514251-9-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann omap2 contains a hack to define tick_broadcast() on non-SMP configurations in place of the normal SMP definition. This one causes a warning because of a missing prototype: arch/arm/mach-omap2/board-generic.c:44:6: error: no previous prototype for 'tick_broadcast' Make sure to always include the header with the declaration. Fixes: d86ad463d670 ("ARM: OMAP2+: Fix regression for using local timer on non-SMP SoCs") Signed-off-by: Arnd Bergmann Acked-by: Aaro Koskinen --- arch/arm/mach-omap2/board-generic.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c index 853409b341a3..7aa41841edd4 100644 --- a/arch/arm/mach-omap2/board-generic.c +++ b/arch/arm/mach-omap2/board-generic.c @@ -13,6 +13,7 @@ #include #include #include +#include #include #include From patchwork Tue May 16 15:31:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243285 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 77A22C77B7F for ; Tue, 16 May 2023 15:32:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 5FBA8C433D2; Tue, 16 May 2023 15:32:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E1A2BC433EF; Tue, 16 May 2023 15:32:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251155; bh=DrqAX+1UhPNTYpc/1d0D3nvDlt1nvYJqyMlOg0NqDNY=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=tn4bT2n56+ohbh8dxl7/RdZwx7SCsqHB2ZcSWJQXTBOVcKLmRxc9SrHDhHSq/drKi kglo46WZ2JIwmfJZ+JDYZUAcqYYGUU0M8ANaekCIepNN2vwjHPtNu+gPLEJMYriEDR kcJOwZrxUedGV3ZTczsqETUqFu1bTlnXsJfqxlRyonKUJKpWdYKCZmioM81KkZ/9g5 esLrBbkZzPkF6KpMFtGdkcup2dvd7XiwGpuQo1YvBBwaxKFzW+E+HxR08wyfmH1Gj9 qk3VkeUmHTpr9/isE/FwAePtr2YOI/ghZuGBjJDt9K79f+RWKiZdmWH5lwssqF/jQO r9Uz3T7rDMN4A== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH 09/13] ARM: orion5x: fix d2net gpio initialization Date: Tue, 16 May 2023 17:31:05 +0200 Message-Id: <20230516153109.514251-10-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann The DT version of this board has a custom file with the gpio device. However, it does nothing because the d2net_init() has no caller or prototype: arch/arm/mach-orion5x/board-d2net.c:101:13: error: no previous prototype for 'd2net_init' Call it from the board-dt file as intended. Fixes: 94b0bd366e36 ("ARM: orion5x: convert d2net to Device Tree") Cc: stable@vger.kernel.org Signed-off-by: Arnd Bergmann Reviewed-by: Andrew Lunn --- arch/arm/mach-orion5x/board-dt.c | 3 +++ arch/arm/mach-orion5x/common.h | 6 ++++++ 2 files changed, 9 insertions(+) diff --git a/arch/arm/mach-orion5x/board-dt.c b/arch/arm/mach-orion5x/board-dt.c index e3736ffc8347..be47492c6640 100644 --- a/arch/arm/mach-orion5x/board-dt.c +++ b/arch/arm/mach-orion5x/board-dt.c @@ -60,6 +60,9 @@ static void __init orion5x_dt_init(void) if (of_machine_is_compatible("maxtor,shared-storage-2")) mss2_init(); + if (of_machine_is_compatible("lacie,d2-network")) + d2net_init(); + of_platform_default_populate(NULL, orion5x_auxdata_lookup, NULL); } diff --git a/arch/arm/mach-orion5x/common.h b/arch/arm/mach-orion5x/common.h index f2e0577bf50f..8df70e23aa82 100644 --- a/arch/arm/mach-orion5x/common.h +++ b/arch/arm/mach-orion5x/common.h @@ -73,6 +73,12 @@ extern void mss2_init(void); static inline void mss2_init(void) {} #endif +#ifdef CONFIG_MACH_D2NET_DT +void d2net_init(void); +#else +static inline void d2net_init(void) {} +#endif + /***************************************************************************** * Helpers to access Orion registers ****************************************************************************/ From patchwork Tue May 16 15:31:06 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243286 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1A9D3C7EE25 for ; Tue, 16 May 2023 15:32:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 0318DC433D2; Tue, 16 May 2023 15:32:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BEC04C433A7; Tue, 16 May 2023 15:32:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251162; bh=poBedNYca11WcbITBXBuz+ooZ6HYTQ+UBh0gmv7VB8A=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=RaMLjoUme5tPm65FUZABY/287OPkHR/67/TSDDl0Gx1GddULP1jQohF/9X62GeEAi qVtirzrbkFsnn8ckUoTSX9H91191iRF1CeRVmQXvb8wv2dpn2Sow0ngktUGH8FmhHR xwlcNGtJUqHm2iclK1qhONDrE3qjvyM1g7X13LxuJUaun+LaH04V0JkY4l3OmZDrlw X4JovRCBOqM263l8R3YYDg8sAdQUeSjyOyC6oAcu2VKedtyc1TO+TLa61WZCqlMW3v OzMrPPcrvgkYafXz7UiCqPeBj6uRW9u5WsdFSNEibj/AoYXLP8EmvosOP7gxaqpVcO 9lFz+qhMYn9CA== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 10/13] ARM: pxa: fix missing-prototypes warnings Date: Tue, 16 May 2023 17:31:06 +0200 Message-Id: <20230516153109.514251-11-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann The PXA platform has a number of configurations that end up with a warning like these when building with W=1: drivers/hwmon/max1111.c:83:5: error: no previous prototype for 'max1111_read_channel' [-Werror=missing-prototypes] arch/arm/mach-pxa/reset.c:86:6: error: no previous prototype for 'pxa_restart' [-Werror=missing-prototypes] arch/arm/mach-pxa/mfp-pxa2xx.c:254:5: error: no previous prototype for 'keypad_set_wake' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa25x.c:70:14: error: no previous prototype for 'pxa25x_get_clk_frequency_khz' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa25x.c:325:12: error: no previous prototype for 'pxa25x_clocks_init' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa27x.c:74:14: error: no previous prototype for 'pxa27x_get_clk_frequency_khz' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa27x.c:102:6: error: no previous prototype for 'pxa27x_is_ppll_disabled' [-Werror=missing-prototypes] drivers/clk/pxa/clk-pxa27x.c:470:12: error: no previous prototype for 'pxa27x_clocks_init' [-Werror=missing-prototypes] arch/arm/mach-pxa/pxa27x.c:44:6: error: no previous prototype for 'pxa27x_clear_otgph' [-Werror=missing-prototypes] arch/arm/mach-pxa/pxa27x.c:58:6: error: no previous prototype for 'pxa27x_configure_ac97reset' [-Werror=missing-prototypes] arch/arm/mach-pxa/spitz_pm.c:170:15: error: no previous prototype for 'spitzpm_read_devdata' [-Werror=missing-prototypes] The problem is that there is a declaration for each of these, but it's only seen by the caller and not the callee. Moving these into appropriate header files ensures that both use the same calling conventions and it avoids the warnings. Signed-off-by: Arnd Bergmann Acked-by: Stephen Boyd Acked-by: Greg Kroah-Hartman --- arch/arm/mach-pxa/generic.h | 15 --------------- arch/arm/mach-pxa/mfp-pxa2xx.c | 1 + arch/arm/mach-pxa/pxa25x.c | 1 + arch/arm/mach-pxa/pxa27x.c | 3 +++ arch/arm/mach-pxa/reset.c | 1 + arch/arm/mach-pxa/spitz_pm.c | 2 +- drivers/clk/pxa/clk-pxa25x.c | 2 ++ drivers/clk/pxa/clk-pxa27x.c | 3 ++- drivers/hwmon/max1111.c | 1 + drivers/usb/gadget/udc/pxa27x_udc.c | 6 ------ drivers/usb/host/ohci-pxa27x.c | 7 +------ include/linux/platform_data/asoc-pxa.h | 1 + include/linux/platform_data/pxa2xx_udc.h | 6 ++++++ include/linux/soc/pxa/smemc.h | 16 ++++++++++++++++ sound/arm/pxa2xx-ac97-lib.c | 2 -- 15 files changed, 36 insertions(+), 31 deletions(-) diff --git a/arch/arm/mach-pxa/generic.h b/arch/arm/mach-pxa/generic.h index 7bb1499de4c5..c9c2c46ecead 100644 --- a/arch/arm/mach-pxa/generic.h +++ b/arch/arm/mach-pxa/generic.h @@ -27,7 +27,6 @@ extern void __init pxa25x_map_io(void); extern void __init pxa26x_init_irq(void); #define pxa27x_handle_irq ichp_handle_irq -extern unsigned pxa27x_get_clk_frequency_khz(int); extern void __init pxa27x_init_irq(void); extern void __init pxa27x_map_io(void); @@ -52,18 +51,4 @@ extern void pxa2xx_clear_reset_status(unsigned int); static inline void pxa2xx_clear_reset_status(unsigned int mask) {} #endif -/* - * Once fully converted to the clock framework, all these functions should be - * removed, and replaced with a clk_get(NULL, "core"). - */ -#ifdef CONFIG_PXA25x -extern unsigned pxa25x_get_clk_frequency_khz(int); -#else -#define pxa25x_get_clk_frequency_khz(x) (0) -#endif - -#ifdef CONFIG_PXA27x -#else -#define pxa27x_get_clk_frequency_khz(x) (0) -#endif diff --git a/arch/arm/mach-pxa/mfp-pxa2xx.c b/arch/arm/mach-pxa/mfp-pxa2xx.c index b556452dfcf9..f5a3d890f682 100644 --- a/arch/arm/mach-pxa/mfp-pxa2xx.c +++ b/arch/arm/mach-pxa/mfp-pxa2xx.c @@ -20,6 +20,7 @@ #include "pxa2xx-regs.h" #include "mfp-pxa2xx.h" +#include "mfp-pxa27x.h" #include "generic.h" diff --git a/arch/arm/mach-pxa/pxa25x.c b/arch/arm/mach-pxa/pxa25x.c index 802babff6c91..d6c6aaeb02ad 100644 --- a/arch/arm/mach-pxa/pxa25x.c +++ b/arch/arm/mach-pxa/pxa25x.c @@ -27,6 +27,7 @@ #include #include #include +#include #include #include diff --git a/arch/arm/mach-pxa/pxa27x.c b/arch/arm/mach-pxa/pxa27x.c index bc47552b763c..7e7aaeff95b2 100644 --- a/arch/arm/mach-pxa/pxa27x.c +++ b/arch/arm/mach-pxa/pxa27x.c @@ -24,6 +24,7 @@ #include #include #include +#include #include #include @@ -31,7 +32,9 @@ #include "irqs.h" #include "pxa27x.h" #include "reset.h" +#include #include +#include #include "pm.h" #include "addr-map.h" #include "smemc.h" diff --git a/arch/arm/mach-pxa/reset.c b/arch/arm/mach-pxa/reset.c index f0be90573ad3..27293549f8ad 100644 --- a/arch/arm/mach-pxa/reset.c +++ b/arch/arm/mach-pxa/reset.c @@ -10,6 +10,7 @@ #include "regs-ost.h" #include "reset.h" #include "smemc.h" +#include "generic.h" static void do_hw_reset(void); diff --git a/arch/arm/mach-pxa/spitz_pm.c b/arch/arm/mach-pxa/spitz_pm.c index 4001fa589a2b..9571f2b5b118 100644 --- a/arch/arm/mach-pxa/spitz_pm.c +++ b/arch/arm/mach-pxa/spitz_pm.c @@ -167,7 +167,7 @@ static bool spitz_charger_wakeup(void) gpio_get_value(SPITZ_GPIO_SYNC); } -unsigned long spitzpm_read_devdata(int type) +static unsigned long spitzpm_read_devdata(int type) { switch (type) { case SHARPSL_STATUS_ACIN: diff --git a/drivers/clk/pxa/clk-pxa25x.c b/drivers/clk/pxa/clk-pxa25x.c index 93d5907b8530..0a4da519d704 100644 --- a/drivers/clk/pxa/clk-pxa25x.c +++ b/drivers/clk/pxa/clk-pxa25x.c @@ -11,10 +11,12 @@ */ #include #include +#include #include #include #include #include +#include #include #include "clk-pxa.h" diff --git a/drivers/clk/pxa/clk-pxa27x.c b/drivers/clk/pxa/clk-pxa27x.c index 116c6ac666e3..2bea89874ec1 100644 --- a/drivers/clk/pxa/clk-pxa27x.c +++ b/drivers/clk/pxa/clk-pxa27x.c @@ -12,6 +12,7 @@ #include #include #include +#include #include #include "clk-pxa.h" @@ -99,7 +100,7 @@ unsigned int pxa27x_get_clk_frequency_khz(int info) return (unsigned int)clks[0] / KHz; } -bool pxa27x_is_ppll_disabled(void) +static bool pxa27x_is_ppll_disabled(void) { unsigned long ccsr = readl(clk_regs + CCSR); diff --git a/drivers/hwmon/max1111.c b/drivers/hwmon/max1111.c index 4c5487aeb3cf..5cc08c720b52 100644 --- a/drivers/hwmon/max1111.c +++ b/drivers/hwmon/max1111.c @@ -80,6 +80,7 @@ static int max1111_read(struct device *dev, int channel) #ifdef CONFIG_SHARPSL_PM static struct max1111_data *the_max1111; +int max1111_read_channel(int channel); int max1111_read_channel(int channel) { if (!the_max1111 || !the_max1111->spi) diff --git a/drivers/usb/gadget/udc/pxa27x_udc.c b/drivers/usb/gadget/udc/pxa27x_udc.c index 160c7bd1024e..af1707a8829b 100644 --- a/drivers/usb/gadget/udc/pxa27x_udc.c +++ b/drivers/usb/gadget/udc/pxa27x_udc.c @@ -2472,12 +2472,6 @@ static void pxa_udc_shutdown(struct platform_device *_dev) udc_disable(udc); } -#ifdef CONFIG_PXA27x -extern void pxa27x_clear_otgph(void); -#else -#define pxa27x_clear_otgph() do {} while (0) -#endif - #ifdef CONFIG_PM /** * pxa_udc_suspend - Suspend udc device diff --git a/drivers/usb/host/ohci-pxa27x.c b/drivers/usb/host/ohci-pxa27x.c index 0bc7e96bcc93..dcac2938789a 100644 --- a/drivers/usb/host/ohci-pxa27x.c +++ b/drivers/usb/host/ohci-pxa27x.c @@ -29,6 +29,7 @@ #include #include #include +#include #include #include #include @@ -263,12 +264,6 @@ static inline void pxa27x_reset_hc(struct pxa27x_ohci *pxa_ohci) __raw_writel(uhchr & ~UHCHR_FHR, pxa_ohci->mmio_base + UHCHR); } -#ifdef CONFIG_PXA27x -extern void pxa27x_clear_otgph(void); -#else -#define pxa27x_clear_otgph() do {} while (0) -#endif - static int pxa27x_start_hc(struct pxa27x_ohci *pxa_ohci, struct device *dev) { int retval; diff --git a/include/linux/platform_data/asoc-pxa.h b/include/linux/platform_data/asoc-pxa.h index 327454cd8246..7b5b9e20fbf5 100644 --- a/include/linux/platform_data/asoc-pxa.h +++ b/include/linux/platform_data/asoc-pxa.h @@ -27,5 +27,6 @@ typedef struct { } pxa2xx_audio_ops_t; extern void pxa_set_ac97_info(pxa2xx_audio_ops_t *ops); +extern void pxa27x_configure_ac97reset(int reset_gpio, bool to_gpio); #endif diff --git a/include/linux/platform_data/pxa2xx_udc.h b/include/linux/platform_data/pxa2xx_udc.h index 102d47c53d6d..996a73e8fb80 100644 --- a/include/linux/platform_data/pxa2xx_udc.h +++ b/include/linux/platform_data/pxa2xx_udc.h @@ -25,4 +25,10 @@ struct pxa2xx_udc_platform_data { int gpio_pullup; /* high == pullup activated */ }; +#ifdef CONFIG_PXA27x +extern void pxa27x_clear_otgph(void); +#else +#define pxa27x_clear_otgph() do {} while (0) +#endif + #endif diff --git a/include/linux/soc/pxa/smemc.h b/include/linux/soc/pxa/smemc.h index f1ffea236c15..4feb1dded3ec 100644 --- a/include/linux/soc/pxa/smemc.h +++ b/include/linux/soc/pxa/smemc.h @@ -10,4 +10,20 @@ int pxa2xx_smemc_get_sdram_rows(void); unsigned int pxa3xx_smemc_get_memclkdiv(void); void __iomem *pxa_smemc_get_mdrefr(void); +/* + * Once fully converted to the clock framework, all these functions should be + * removed, and replaced with a clk_get(NULL, "core"). + */ +#ifdef CONFIG_PXA25x +extern unsigned pxa25x_get_clk_frequency_khz(int); +#else +#define pxa25x_get_clk_frequency_khz(x) (0) +#endif + +#ifdef CONFIG_PXA27x +extern unsigned pxa27x_get_clk_frequency_khz(int); +#else +#define pxa27x_get_clk_frequency_khz(x) (0) +#endif + #endif diff --git a/sound/arm/pxa2xx-ac97-lib.c b/sound/arm/pxa2xx-ac97-lib.c index 2ca33fd5a575..a03a3291de84 100644 --- a/sound/arm/pxa2xx-ac97-lib.c +++ b/sound/arm/pxa2xx-ac97-lib.c @@ -33,8 +33,6 @@ static struct clk *ac97conf_clk; static int reset_gpio; static void __iomem *ac97_reg_base; -extern void pxa27x_configure_ac97reset(int reset_gpio, bool to_gpio); - /* * Beware PXA27x bugs: * From patchwork Tue May 16 15:31:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243287 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C7C33C77B7A for ; Tue, 16 May 2023 15:32:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id ADFB5C433A0; Tue, 16 May 2023 15:32:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 67ED9C433B0; Tue, 16 May 2023 15:32:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251170; bh=Emte/YhcCmT4/MTbj5KVs4cf0HcNeSK1g1qaffydyrs=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=L9DWu9l1CL+gxEuelOq1x/f8fBM+wQtWWB3qw0yxYDl0cYXk8PgVXTDxZssKBzZHF PDtTgXiWHOlxBkFESe8dxWBGRfUyi0cVitH5F98nUU0r26Zry+AVTKl7vLxEisx5wn jbi6UrOwnVKkkA7S7LmvJukD8+6qJ2tiZr+KQTTgdeSHpTF5wKdAJ1K5JsBzpdNUeb 5epYgwtNA4PO4TrqJ7coDAhYCOr/uhNKWoUMmFvocsJfPNiqAB1zIexM3GcYHbynUP WgDjwe7I8Eno1YCGUli9kI3+JNMAYydTc3XlddgK6gTg8XmFtn6ILf9lBZ2pEH20Ln WR4i4CAk+l0rg== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 11/13] ARM: sa1100: address missing prototype warnings Date: Tue, 16 May 2023 17:31:07 +0200 Message-Id: <20230516153109.514251-12-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann There are three warnings for mach-sa1100 when building with W=1: arch/arm/common/sa1111.c:699:1: error: no previous prototype for 'sa1111_configure_smc' [-Werror=missing-prototypes] 699 | sa1111_configure_smc(struct sa1111 *sachip, int sdram, unsigned int drac, | ^~~~~~~~~~~~~~~~~~~~ arch/arm/mach-sa1100/assabet.c:718:13: error: no previous prototype for 'assabet_init_irq' [-Werror=missing-prototypes] 718 | void __init assabet_init_irq(void) | ^~~~~~~~~~~~~~~~ arch/arm/mach-sa1100/pm.c:126:12: error: no previous prototype for 'sa11x0_pm_init' [-Werror=missing-prototypes] 126 | int __init sa11x0_pm_init(void) | ^~~~~~~~~~~~~~ The first two are only used locally and can be 'static', while the last one needs to include the right header. Signed-off-by: Arnd Bergmann --- arch/arm/common/sa1111.c | 2 +- arch/arm/mach-sa1100/assabet.c | 2 +- arch/arm/mach-sa1100/pm.c | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c index aad6ba236f0f..77c83ba81715 100644 --- a/arch/arm/common/sa1111.c +++ b/arch/arm/common/sa1111.c @@ -695,7 +695,7 @@ static u32 sa1111_dma_mask[] = { /* * Configure the SA1111 shared memory controller. */ -void +static void sa1111_configure_smc(struct sa1111 *sachip, int sdram, unsigned int drac, unsigned int cas_latency) { diff --git a/arch/arm/mach-sa1100/assabet.c b/arch/arm/mach-sa1100/assabet.c index 0c32b08a3a9c..08dcdd8ceb6d 100644 --- a/arch/arm/mach-sa1100/assabet.c +++ b/arch/arm/mach-sa1100/assabet.c @@ -715,7 +715,7 @@ static void __init assabet_map_io(void) sa1100_register_uart(2, 3); } -void __init assabet_init_irq(void) +static void __init assabet_init_irq(void) { u32 def_val; diff --git a/arch/arm/mach-sa1100/pm.c b/arch/arm/mach-sa1100/pm.c index cd900a7b5248..c94ebe1c9091 100644 --- a/arch/arm/mach-sa1100/pm.c +++ b/arch/arm/mach-sa1100/pm.c @@ -37,6 +37,8 @@ #include #include +#include "generic.h" + extern int sa1100_finish_suspend(unsigned long); #define SAVE(x) sleep_save[SLEEP_SAVE_##x] = x From patchwork Tue May 16 15:31:08 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243288 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AC375C7EE25 for ; Tue, 16 May 2023 15:32:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id 5D4DFC4339B; Tue, 16 May 2023 15:32:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 195B7C433EF; Tue, 16 May 2023 15:32:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251178; bh=MGpebGFHpc0L0zdL2phujQLcz6KDg8DvNfOSVA71ez0=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=kzTKyvbDHAlfcLnPPaRMDeJ1hnPyGJz8z1y3Gpyjl65t0vC1nlvdBnhxOXYF6fYDU PjuJMTzXldiYVj/uRaBM9Y0DUCTZYqnFQsVOPvMlHKTmncVBpCHyCJNspeS9L7jliO bF6kEpzE3EpNr0Qs6XPI4CeAFlRn7ccL84622jT4SgrRkDfJvhE3cuyd1j/y8EPSuZ jfJ62SJK4gWwCtg/RGzS4GsVBBybpK+F0r3PwnHhumCDqzuy0Lpi9umqPcaNZIwAp/ rXk2HpVteoZePx2HWX3hNEtHwBhR3K/2jAIYze7Mi6D/lRW4swaCprb+DoU5D4284p paJw0hRnIBfLw== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 12/13] ARM: spear: include "pl080.h" for pl080_get_signal() prototype Date: Tue, 16 May 2023 17:31:08 +0200 Message-Id: <20230516153109.514251-13-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann pl080_get_signal() and pl080_put_signal() are declared in pl080.h and defined in pl080.c, but this file is missing an include of the header: arch/arm/mach-spear/pl080.c:27:5: error: no previous prototype for 'pl080_get_signal' arch/arm/mach-spear/pl080.c:62:6: error: no previous prototype for 'pl080_put_signal' Signed-off-by: Arnd Bergmann Acked-by: Viresh Kumar --- arch/arm/mach-spear/pl080.c | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/mach-spear/pl080.c b/arch/arm/mach-spear/pl080.c index d6b8627d2544..47243a8153d0 100644 --- a/arch/arm/mach-spear/pl080.c +++ b/arch/arm/mach-spear/pl080.c @@ -16,6 +16,7 @@ #include #include "spear.h" #include "misc_regs.h" +#include "pl080.h" static spinlock_t lock = __SPIN_LOCK_UNLOCKED(x); From patchwork Tue May 16 15:31:09 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arnd Bergmann X-Patchwork-Id: 13243289 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0F1F7C77B7A for ; Tue, 16 May 2023 15:33:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) id E75BDC433D2; Tue, 16 May 2023 15:33:05 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B3BC3C433A7; Tue, 16 May 2023 15:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684251185; bh=C4SQH88o4X8B0aZDjwE/ytf02UfVOzvqYZUgEam+Yak=; h=From:List-Id:To:Cc:Subject:Date:In-Reply-To:References:From; b=Q/8wxST6e4Z+JZ+RhzY/zoHGngrClR10FXgLYUTQhzQPnn6BqbNnHSWPBclX/ijHr MPlKyvyjHyavoBTrerlvk7AhR1ZSyLUVOeV8I5JzsggGk4lk6aj4AgzHZGLTkB0uAU Igz8wNgGKfKTwxXOt5FYTmPd4IW/ilWnVFQXk8sw1EoFI6b0VdZTiOjdLUzvmLCANw hbrml1KqP8PM1Lvpzxe5JzNmgrEuMaixcAUAe+upaDoq1++2N21SbAmoDO961KedR7 uLaQsXgNa/8BZOgdLjOG95NljNNx3DrW7m2f/N8MvvzWEhaPbGq8OUP16LiA/H4SMq vHc1T58kI5phw== From: Arnd Bergmann List-Id: To: soc@kernel.org Cc: Arnd Bergmann , Russell King , Bartosz Golaszewski , Hartley Sweeten , Alexander Sverdlin , Andre Przywara , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Aaro Koskinen , Janusz Krzysztofik , Tony Lindgren , Andrew Lunn , Sebastian Hesselbarth , Gregory Clement , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Viresh Kumar , Shiraz Hashim , Sudeep Holla , Lorenzo Pieralisi , Linus Walleij , Michael Turquette , Stephen Boyd , Greg Kroah-Hartman , Alan Stern , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-omap@vger.kernel.org, linux-clk@vger.kernel.org, linux-usb@vger.kernel.org Subject: [PATCH 13/13] ARM: versatile: mark mmc_status() static Date: Tue, 16 May 2023 17:31:09 +0200 Message-Id: <20230516153109.514251-14-arnd@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20230516153109.514251-1-arnd@kernel.org> References: <20230516153109.514251-1-arnd@kernel.org> MIME-Version: 1.0 From: Arnd Bergmann mmc_status() is only used in the file it is defined in, and no longer has an 'extern' declaration: arch/arm/mach-versatile/versatile.c:56:14: error: no previous prototype for 'mmc_status' Fixes: 16956fed35fe ("ARM: versatile: switch to DT only booting and remove legacy code") Signed-off-by: Arnd Bergmann --- arch/arm/mach-versatile/versatile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/mach-versatile/versatile.c b/arch/arm/mach-versatile/versatile.c index 02ba68abe533..7ef03d0c224d 100644 --- a/arch/arm/mach-versatile/versatile.c +++ b/arch/arm/mach-versatile/versatile.c @@ -53,7 +53,7 @@ static void __iomem *versatile_sys_base; -unsigned int mmc_status(struct device *dev) +static unsigned int mmc_status(struct device *dev) { struct amba_device *adev = container_of(dev, struct amba_device, dev); u32 mask;