From patchwork Wed May 17 18:33:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hamza Mahfooz X-Patchwork-Id: 13245522 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 75085C77B75 for ; Wed, 17 May 2023 18:34:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1A6CC10E2FB; Wed, 17 May 2023 18:34:37 +0000 (UTC) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2069.outbound.protection.outlook.com [40.107.92.69]) by gabe.freedesktop.org (Postfix) with ESMTPS id 60FF410E22E; Wed, 17 May 2023 18:34:35 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JYPbCejWiP/4rDAhzW6qmDSb3X+z50LITwusbPfDe2GVemNq76oU/respW4ykkPatAvUJlSQ/7ZHAV6SpugztGRYKHBVUjK8FtIQSGVrMYgLja+yJ6r0J91t8EyreY6ZdrKdfz1W9aIRnD1bdHbO9QPs8bYkw7cjkIe5awi18ySZDs2TkPjydmD/S0dcQsOWxr58Bln+eqSBydlaSuFDyI58GOS8dmpaSc56hygh13RN3zi93j7eeD6xkpaOgjkIBiOd67Ag9vb5EtElOWndpAr0tpVhdihiQ4/xrbrnBDXKr/tCz6YTK47mSIYCwfkFYoPoMpwb705tXw/TXLRYew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Jhbo/StYlLnJNWpVlS+CXRHr66jym3+B2/ZPhrPK+0o=; b=eyiyfci0DD7hpGhXDG4QmUrFsmdP9QQV4H2l79dKpC3+/8EjXOxHoQDiQnUvH0PXvzTG6AvjsZICeX2ydJPANx9V0Dy2nrj8hvioP71f01UDK1J+X2c8qGOtw8hYA1KHpGJn6WqHeoSiwyzSA5nTmlZGcmDBQkQZOX2STfrXavvT7F8YYzGmlluvbCw0UYRTxFr5Gv6/XwcYz/JnIRfRrPejX+G2vXdhJR7ZvZZ0vBR7bel2apDxdq5TYnIxhR1N3lkBSR/1sDLdkmLL2DH0aazCDopWxQzdxfAkdUW2vmh6sF50PoGTm45VeqK6PZSPij0stgQT9aTLqihUfD9BGQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Jhbo/StYlLnJNWpVlS+CXRHr66jym3+B2/ZPhrPK+0o=; b=Qugm8fAmGdKlQW00rU/XDSnmep9weyLSUKk+lxQtP0cFxbyRf6A5SwevZXYwuz0ACuHMDqZYik8Zm5bk/Umss2A2Ofn6my2E+xQhmR+8xvkSy6RMAWZs5VAVHRPx0sIhZcyT/7+q2QohrM5rq1t22kcxeyUlM3mbhmQ1gmaN1zA= Received: from DM6PR02CA0063.namprd02.prod.outlook.com (2603:10b6:5:177::40) by BN9PR12MB5164.namprd12.prod.outlook.com (2603:10b6:408:11d::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33; Wed, 17 May 2023 18:34:31 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:5:177:cafe::fc) by DM6PR02CA0063.outlook.office365.com (2603:10b6:5:177::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33 via Frontend Transport; Wed, 17 May 2023 18:34:31 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.18 via Frontend Transport; Wed, 17 May 2023 18:34:30 +0000 Received: from hamza-pc.localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 17 May 2023 13:34:28 -0500 From: Hamza Mahfooz To: Subject: [PATCH 1/3] drm/amd/display: drop redundant memset() in get_available_dsc_slices() Date: Wed, 17 May 2023 14:33:45 -0400 Message-ID: <20230517183350.314082-1-hamza.mahfooz@amd.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT032:EE_|BN9PR12MB5164:EE_ X-MS-Office365-Filtering-Correlation-Id: 7834d83d-9ac2-4fca-9dcb-08db57055aa8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: esHtKSzpycsP+oYRNdKv4qphocZsEzn5lMwSJi0mTyxQNNqEuG4UUll/WgqN0cgx5IROjSxbDFUQMbP1xqZgynfzo6st7YfsoVMo+DNinfL6oeFA7vOMo+U2eGc7qReRY8Co0/ANXI2tSD52hR/fthGIz5aaftnfGNUKgk0p3ZZysrHIw0DwNf5f24HgdUGJEjYeuFXWcUEL1AHqwJ1/r1xPxpcrZjIHipidXINrGqF3ymVcLF3AiWZm609vMsDRIEVyuWIZWcL9xeo+v31ah+LnTfhx7PiER7O5xznf+E/z7iDNIIV8fx9684YRgQJ8HfzTDQYncgSuXIdt/jjWu9hlE+uaWaIqnMuTBuvn9pG6wROlkrnpTdwJqmt4NF18+9/GVv9Q2Qz2lElkWHEUMSewacziJin954YINZaxA9ZM4ua/n+xhkyON/D7ihjN75FoGpmfyaHx+zAT0d+cYSeU1NmQMeoR5yYuwDjK69eDYMHNLs5zJdp9GYuzG61J45vAjaEVq42kUKUmg+fg4T/gqVEEp3w1GipLhtqfnSFe66ZEKVyjP7+iS+VKNhYKJON3VLSnbIE737lRPUUBOJyjPs9puSDH4xPG7z57XzMnuNXIZ1CMdHFnNwEVIay0TwFIrTg1U72Vm24osgSHjOPFrjHURUOs6eoc9xb77Xh2rAkJxEslu4uo2XnPld5frKp93EXAQlPSgmJ9lqEddHWjv/QCYxolwk+2tCtf4ZYNgZf8Cr9GvEgpJyC1gPLJ6OB6UA3R69VW9b/Kg58o1VBqBumEjJk1coJru3FpLgOtmJW35hRo+LZe+a9nsKMH6 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(136003)(396003)(346002)(376002)(39860400002)(451199021)(46966006)(40470700004)(36840700001)(40460700003)(70586007)(70206006)(4326008)(6916009)(478600001)(316002)(54906003)(36756003)(86362001)(83380400001)(47076005)(2616005)(16526019)(186003)(1076003)(26005)(40480700001)(36860700001)(426003)(336012)(44832011)(5660300002)(8936002)(8676002)(2906002)(6666004)(82310400005)(82740400003)(81166007)(356005)(41300700001)(16060500005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 18:34:30.9885 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7834d83d-9ac2-4fca-9dcb-08db57055aa8 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5164 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wenjing Liu , dri-devel@lists.freedesktop.org, Hamza Mahfooz , Jun Lei , Nasir Osman , Rodrigo Siqueira , Aurabindo Pillai , Stylon Wang , Leo Li , pengfuyuan , Christophe JAILLET , Cruise Hung , Mike Hsieh , Hans de Goede , Qingqing Zhuo , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Leon Huang , Alex Deucher , Hersen Wu , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" get_available_dsc_slices() returns the number of indices set, and all of the users of get_available_dsc_slices() don't cross the returned bound when iterating over available_slices[]. So, the memset() in get_available_dsc_slices() is redundant and can be dropped. Fixes: 97bda0322b8a ("drm/amd/display: Add DSC support for Navi (v2)") Reported-by: Christophe JAILLET Signed-off-by: Hamza Mahfooz Reviewed-by: Rodrigo Siqueira Reviewed-by: Christophe JAILLET --- drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c index b9a05bb025db..58dd62cce4bb 100644 --- a/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c +++ b/drivers/gpu/drm/amd/display/dc/dsc/dc_dsc.c @@ -645,8 +645,6 @@ static int get_available_dsc_slices(union dsc_enc_slice_caps slice_caps, int *av { int idx = 0; - memset(available_slices, -1, MIN_AVAILABLE_SLICES_SIZE); - if (slice_caps.bits.NUM_SLICES_1) available_slices[idx++] = 1; From patchwork Wed May 17 18:33:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hamza Mahfooz X-Patchwork-Id: 13245523 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 53DA2C77B7A for ; Wed, 17 May 2023 18:34:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A27FE10E222; Wed, 17 May 2023 18:34:43 +0000 (UTC) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on20614.outbound.protection.outlook.com [IPv6:2a01:111:f400:7eaa::614]) by gabe.freedesktop.org (Postfix) with ESMTPS id 87A5510E222; Wed, 17 May 2023 18:34:42 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QZJbEAfW7UP/jdO/1IHjZWIYJKasiBcCgAU33ItkD9GS8/p+mE6UbR5Z5UINtaWxhfzAbs/Ksj4TAJbBL40vxd3YQbmcJ6GfdJ8Y8SiNo+Os71CDkdAafyIGh/ykUlDtVxznypKiSR8q3CWxfLQp4jEXovKkd2zmatOARKnFyCQ0CAOQzTK2g2o+fkGQDSytYomx5/Wx00ES9SBsjEI4fwWGczQJ8im/yD0ytnoy8v8Ayqy7B7worFKC27P2fZuXAXy0T6a4rXcIExryzHvsdAmPaxE7bJmkL6JgzIdAJnJ/YOCh2dqTOZqPiXzjQwDKwzL0W8U7NOClbwbs+cPzjw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=93aK1EtrxgRooQgtd6a2U+5yaty7/ZAr+872R7LmBKk=; b=aZ1+ZO7Kg4ma1MfT9ud8Xpe1nay6kzvJnRGYtumHpV4mL1VV91WikzadwS/MkeJWm7DSK2LBtZgbBdMf+rmq81GVrHo7ZzINmLY9Y8LXP4S0rWli+IjR5cDMJltEb3JFg7mkRXsjq3LV4eYlV1I1I1lmXdIacIKYSCUzREtOsT11e6rFXInoW3vbbjSw3LbkhgvlheMPC+hta1l1Utd3ObqW8/edHmt1U3jOxRYfNg6iK/Z4l3q2lKnKOMPBKMdAWifsF4GHXUX8RTflpJK861KIdx75r9vGSUvOdfVCb/NpFygvyeH/chee47LEpy890craRqVfEGDNRKy2W7T4Nw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=93aK1EtrxgRooQgtd6a2U+5yaty7/ZAr+872R7LmBKk=; b=ZalQOTkiU9iCq0UIfq28hnmQt9o9lyH6V33efML/sm/7wSaUG1XzpMQpp6kTGaaHb8ulbJTq8+k5/zF74KR5K7crHQmC0px4LRfgDOqAhUXLo00BatgD2r78eBEiB4oZjpNgWBszQmd2xL40Wr8mqrLRGUwFO3HDq13/0CwriSs= Received: from DM6PR02CA0063.namprd02.prod.outlook.com (2603:10b6:5:177::40) by PH7PR12MB7843.namprd12.prod.outlook.com (2603:10b6:510:27e::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 18:34:39 +0000 Received: from DM6NAM11FT032.eop-nam11.prod.protection.outlook.com (2603:10b6:5:177:cafe::fc) by DM6PR02CA0063.outlook.office365.com (2603:10b6:5:177::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6387.33 via Frontend Transport; Wed, 17 May 2023 18:34:39 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT032.mail.protection.outlook.com (10.13.173.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.18 via Frontend Transport; Wed, 17 May 2023 18:34:39 +0000 Received: from hamza-pc.localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 17 May 2023 13:34:35 -0500 From: Hamza Mahfooz To: Subject: [PATCH 2/3] drm/amd/display: drop unused function set_abm_event() Date: Wed, 17 May 2023 14:33:46 -0400 Message-ID: <20230517183350.314082-2-hamza.mahfooz@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230517183350.314082-1-hamza.mahfooz@amd.com> References: <20230517183350.314082-1-hamza.mahfooz@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT032:EE_|PH7PR12MB7843:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b8c87cf-fc6a-44f8-aea5-08db57055f82 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: pP+TadWuvPixNfZ83s7z8uHTC/goFrxVn6wgGCEgw9cazOHw3DT9IykOL2N2EEaY/z6cobtlWrdqM+da+r0idZHL6XGwFge4pKEoTAU+0ddeHyYd+MP1jCmzWsI9HyGagq6sMVJ5MkZlZ23O9Lk6rE3uscGjr+7977A5Ef7d1JZkEfShb4q0mksy5D7uv4FTFqPdiumldhYOFDQW/JdCzweLVA1Hpv2dNDhs5p1jH31frDWn3CEE5HUhxjyDkYomfWozKfu+wceLoAISVZS0T1Jzw8/+iQJTLYANDCq/MPijTFHFCIX3ysJkMMQrKrtvZrb+rYu0PWiPBZ4dGNeVDFQCanQe3c4LWPiXddWHMJ+xrfDAH3mpOT2jJst7xyz7eeqchcxuQ+kAwNhMnhUeilin6q3kNavMynCSLPwaDBTcekgGCq7Z29FL7lErqsICpip0vk8AUxQSCymKfEHOEg3w2/FdwqWo3UMe+w2JtIvRX748KnrgRi1XsEjFkevetz0qrrRJxsORLkitfLW6LcEePPIcgnOgR5XCvfZDlVDFSil0XtV3Df+G79rbhCT/Dz/xeUBLxxoU59QRY+fTNZp0fE5DvPO4jIRe40Zjg5hoyLms0Z1/vBbDsVcXDXRPdl6pqor4DxUcOCdA1xT2jsPLGeQAE2npzXw6QzY1wpcefTBenDLFvjP97l3/FO80rtr/BTeM8T0iJ3hu6MyDH4Q2fcL+QxaYRzCmjLQaivnmx/Y5SB7MthXjhoRiCs16DO22EIkgJvhWcf7JNWOPEz2VsXwIswNcKvDBOD283TnPUJeTuEPwXOyjpQqzyznj X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(396003)(136003)(376002)(39860400002)(346002)(451199021)(36840700001)(40470700004)(46966006)(54906003)(41300700001)(6666004)(82740400003)(316002)(70206006)(70586007)(6916009)(4326008)(44832011)(8676002)(8936002)(5660300002)(478600001)(86362001)(26005)(1076003)(82310400005)(40460700003)(16526019)(186003)(2906002)(81166007)(47076005)(356005)(83380400001)(40480700001)(36756003)(36860700001)(426003)(2616005)(336012)(36900700001)(16060500005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 18:34:39.1285 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9b8c87cf-fc6a-44f8-aea5-08db57055f82 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT032.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR12MB7843 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Rix , dri-devel@lists.freedesktop.org, Hamza Mahfooz , Nasir Osman , kernel test robot , Rodrigo Siqueira , Aurabindo Pillai , Stylon Wang , Leo Li , Wenjing Liu , pengfuyuan , Hersen Wu , Cruise Hung , Mike Hsieh , Hans de Goede , Qingqing Zhuo , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Leon Huang , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" set_abm_event() is never actually used. So, drop it. Fixes: b46c01aa0329 ("drm/amd/display: Refactor ABM feature") Reported-by: kernel test robot Reported-by: Tom Rix Signed-off-by: Hamza Mahfooz Reviewed-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c | 12 ------------ drivers/gpu/drm/amd/display/dc/inc/hw/abm.h | 2 -- 2 files changed, 14 deletions(-) diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c index a66f83a61402..2fb9572ce25d 100644 --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm.c @@ -131,17 +131,6 @@ static bool dmub_abm_set_pipe_ex(struct abm *abm, uint32_t otg_inst, uint32_t op return ret; } -static bool dmub_abm_set_event_ex(struct abm *abm, unsigned int full_screen, unsigned int video_mode, - unsigned int hdr_mode, unsigned int panel_inst) -{ - bool ret = false; - unsigned int feature_support; - - feature_support = abm_feature_support(abm, panel_inst); - - return ret; -} - static bool dmub_abm_set_backlight_level_pwm_ex(struct abm *abm, unsigned int backlight_pwm_u16_16, unsigned int frame_ramp, @@ -167,7 +156,6 @@ static const struct abm_funcs abm_funcs = { .init_abm_config = dmub_abm_init_config_ex, .set_abm_pause = dmub_abm_set_pause_ex, .set_pipe_ex = dmub_abm_set_pipe_ex, - .set_abm_event = dmub_abm_set_event_ex, .set_backlight_level_pwm = dmub_abm_set_backlight_level_pwm_ex, }; diff --git a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h index db5cf9acafe6..d2190a3320f6 100644 --- a/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h +++ b/drivers/gpu/drm/amd/display/dc/inc/hw/abm.h @@ -59,8 +59,6 @@ struct abm_funcs { unsigned int otg_inst, unsigned int option, unsigned int panel_inst); - bool (*set_abm_event)(struct abm *abm, unsigned int full_screen, unsigned int video_mode, - unsigned int hdr_mode, unsigned int panel_inst); }; #endif From patchwork Wed May 17 18:33:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hamza Mahfooz X-Patchwork-Id: 13245524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3DCAC77B75 for ; Wed, 17 May 2023 18:34:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B41A210E24E; Wed, 17 May 2023 18:34:54 +0000 (UTC) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2041.outbound.protection.outlook.com [40.107.236.41]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3F4FC10E23B; Wed, 17 May 2023 18:34:52 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aNGfdtzt0MFhxpoNnoBn1t2N2OKzzx6kZZ7ujswsUGpCgeYiP1kQ7l8KxkCtfKXY3Km3ISQ6AMkHyE8GB1dV6vFgEBS2xiQQNZUuaM+/drUtoI5vwpg66rmlxLu85nB7kTKycwjEx0+SSMVLCifgS+t+iSu7B3hqw993xAfwTNZ3SHBY+549trEYchcYlGibexnspP8ONxSuUTJnVpU64JKUITN6fSmSlqnfe9SngAiv1DjrTJ8SbzjO0hinz/isSeZj9Dh82mt90TNHjP8tkSXKF+PGj76IODc4U39KgQggSqjYvn/v7NDVzH/vTVDjY9VrZ8z10SlVyra0R8rU4Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BRYH/uzNiOwE1sDt/LCmolvLy4Oaj0Zbqy2+rO2nD70=; b=H3gCkG/9lhQX6cBqFvCmgobiGjYZ7RFeaDruVAjDWdQ0vEcTd42qhxelgLbV+Mp5PWF6fuKK/CCwAkU+ZrOqJTNSYiAe0fxWVT08utJPx8IyV9GdP5TKnOh55ulFkUJlHBc6fiqVTym8WakPQ6BCTHZQe9jg4CJA0j+asiM40A1Ya5cXxQQtQJ5PKa0oCnWMWCqSkhwLpfs1m0vpjCi7xUNs4gJniEjVTAFiXexuqGNnH4gzl0Xu/Xxy+y4Dqu0rzZidASGzlel/d+PkK+5ob6pkUWTJK9iEUM9pGQBlLivSIyyzkpErTL4Mq9VScQzzOSg2gp1aSb6aTaRkcvsTOw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=lists.freedesktop.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BRYH/uzNiOwE1sDt/LCmolvLy4Oaj0Zbqy2+rO2nD70=; b=qD1ZhFuj5fQOmta/OKqIPS3yRPWBglAaajtRp3sqcuKj7z4PRRuUuUa2gUSuYWBIBeg/JUBZlVAkC9xx3G01IVF6eRogj4IV7VvzNMhp71PXGPLRq3b1TSmiSoPoXxHPX/JjxiXjNAj/oejkvvdv//3ggYMfrihs6OwfHVcoXjY= Received: from DM6PR07CA0038.namprd07.prod.outlook.com (2603:10b6:5:74::15) by MN2PR12MB4287.namprd12.prod.outlook.com (2603:10b6:208:1dd::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.17; Wed, 17 May 2023 18:34:49 +0000 Received: from DM6NAM11FT085.eop-nam11.prod.protection.outlook.com (2603:10b6:5:74:cafe::96) by DM6PR07CA0038.outlook.office365.com (2603:10b6:5:74::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6411.18 via Frontend Transport; Wed, 17 May 2023 18:34:49 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DM6NAM11FT085.mail.protection.outlook.com (10.13.172.236) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.6411.18 via Frontend Transport; Wed, 17 May 2023 18:34:49 +0000 Received: from hamza-pc.localhost (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.34; Wed, 17 May 2023 13:34:47 -0500 From: Hamza Mahfooz To: Subject: [PATCH 3/3] drm/amd/display: drop unused count variable in create_eml_sink() Date: Wed, 17 May 2023 14:33:47 -0400 Message-ID: <20230517183350.314082-3-hamza.mahfooz@amd.com> X-Mailer: git-send-email 2.40.1 In-Reply-To: <20230517183350.314082-1-hamza.mahfooz@amd.com> References: <20230517183350.314082-1-hamza.mahfooz@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6NAM11FT085:EE_|MN2PR12MB4287:EE_ X-MS-Office365-Filtering-Correlation-Id: 55980f43-ac8a-4b7e-3169-08db570565b5 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WWKwejt24dkvk3jTOoYMU7TJh/hem0RNqx5naTLwlBv/iUF6N6SLgN96qQzn7UnICzLQMt8wV2ZTUtBrlE5+ExzbZ2HNQT5j7jFkJWxiXUMXjxZeRxQonpaQMjKksA2pxNBNqc8T8Mo8b0YF4QMcZKJhBynt73YnGSQ/Y/4GuQZ9LSLG+TaAFXg5FErT5j0YVFLbUc/a5ebhi4jlecpBy+EA6QYg07N5KaG5Tt7DOBXAqmg+KSpcQSqjisXvpXRpmd179p1tvpaFovA4EhfbJBiI/fteMj3hDWf+Y6IFixcrmrdbJMCROi+Y3a5ssTiaub3lyRa/anMSecBWXOVGSqy9tXwzm2sjCn7N+MC2c8c/5aSfyR/d86GWkA3vKIaAo18VMgb7ZDAOAckaXVtKzT0EV10y5JwbXev9HnzQEc/Yh8QzAPh95dvdNnYc8pPX4geVi3f0Ke0Oiw7tUNMHXbE7sbRJ0O8hKGyPksSF9C6gDbO+1IJsBlTrYIEsQY/BcuwDkUTSFJpc8g2VkF3ZTNCpfGfNHZDfP0J6Yq/YXU11JInAOpInlNYLDOzWZoMO8MsG3po9SS5lOJCMJJDGMK1u/OMa0GDHg8Y3D/5mTUN2caLnzRL/BVS+LNlDhWZNbvm83LuIcDUNSpyvzFu7JZKd4vMd6EHk3dIySH/cVjvFmRmTldaoPH/Hd/uuH4NhfA+IavhJQKTGrbXt2nn0k/14kl+tWNlzQ+3lybHdBWg/TZcXcBR01ukTlOYYWir4pJFhbwH/etOdzzAzJK+LknG/qsUaTwVIQKfnvpb5PPMkX+SaK2NY9WV0JK9Eymdr X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230028)(4636009)(346002)(39860400002)(376002)(396003)(136003)(451199021)(46966006)(36840700001)(40470700004)(70586007)(70206006)(5660300002)(8936002)(8676002)(54906003)(478600001)(6916009)(4326008)(316002)(41300700001)(40460700003)(36860700001)(81166007)(40480700001)(47076005)(426003)(336012)(83380400001)(2616005)(86362001)(82740400003)(82310400005)(356005)(44832011)(16526019)(36756003)(186003)(1076003)(26005)(2906002)(16060500005)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 May 2023 18:34:49.5102 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 55980f43-ac8a-4b7e-3169-08db570565b5 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DM6NAM11FT085.eop-nam11.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4287 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Wenjing Liu , dri-devel@lists.freedesktop.org, Hamza Mahfooz , Jun Lei , Nasir Osman , kernel test robot , Rodrigo Siqueira , Aurabindo Pillai , Stylon Wang , Leo Li , pengfuyuan , Hersen Wu , Mike Hsieh , Hans de Goede , Qingqing Zhuo , "Pan, Xinhui" , linux-kernel@vger.kernel.org, Leon Huang , Alex Deucher , =?utf-8?q?Christian_K=C3=B6nig?= Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Since, we are only interested in having drm_edid_override_connector_update(), update the value of connector->edid_blob_ptr. We don't care about the return value of drm_edid_override_connector_update() here. So, drop count. Fixes: 068553e14f86 ("drm/amd/display: assign edid_blob_ptr with edid from debugfs") Reported-by: kernel test robot Signed-off-by: Hamza Mahfooz Reviewed-by: Rodrigo Siqueira --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c index 14b296e1d0f6..5a2d04f47276 100644 --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c @@ -6396,9 +6396,8 @@ static void create_eml_sink(struct amdgpu_dm_connector *aconnector) /* if connector->edid_override valid, pass * it to edid_override to edid_blob_ptr */ - int count; - count = drm_edid_override_connector_update(&aconnector->base); + drm_edid_override_connector_update(&aconnector->base); if (!aconnector->base.edid_blob_ptr) { DRM_ERROR("No EDID firmware found on connector: %s ,forcing to OFF!\n",