From patchwork Thu May 18 14:11:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tom Rix X-Patchwork-Id: 13246885 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE41EC77B7A for ; Thu, 18 May 2023 14:12:12 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 17520900004; Thu, 18 May 2023 10:12:12 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 0FDC5900003; Thu, 18 May 2023 10:12:12 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EDF73900004; Thu, 18 May 2023 10:12:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D9033900003 for ; Thu, 18 May 2023 10:12:11 -0400 (EDT) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id AB6FC1407C1 for ; Thu, 18 May 2023 14:12:11 +0000 (UTC) X-FDA: 80803565262.15.CB020A7 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf26.hostedemail.com (Postfix) with ESMTP id CF43B14012E for ; Thu, 18 May 2023 14:11:26 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AsplUBRZ; spf=pass (imf26.hostedemail.com: domain of trix@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=trix@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684419087; a=rsa-sha256; cv=none; b=2f5PT90T2eDN4KcKQgnB26UldTFMyUC7BiNB66wliLS5cm/DhE2fyY6Flbm0d2D/2ZYYQb fVxbvZbMEODap8HAucTTk+Ad/1O2Vi9OyF+Q9gXZWPpbrJH5bPsIcGWk4Do6C+dbHXCzsc 2KvqXsCSH4g+JSsXLx3eGqiemRoc0xE= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=AsplUBRZ; spf=pass (imf26.hostedemail.com: domain of trix@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=trix@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684419087; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=iQwVdHv6Lw8dEb3HJ22Fi/mr3hZkypY/pgo/f+VOrUI=; b=CD84namgoaMv/xqp4IbX+XtXC7zEA6YMGWxe+RQ5aKd1s0uYUvaLPClWwl5lRR7iDLGlEF xsPqCuaYEgB7nbEYXvu3r/5JVLmoAlgCu40Kxl6NwwSfFSb+rcxg4pMyWHgkxa7abik7gj smoaD5MB+um4c4ZPtyhWsDEhATIjpgk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684419086; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=iQwVdHv6Lw8dEb3HJ22Fi/mr3hZkypY/pgo/f+VOrUI=; b=AsplUBRZw7tgzHrkvezZeYbSbfo/16dS5XHfbVnffhrC5AFNG7uZR1CvV8aS9bBr5U2lnb rkMaU9w3EbIPosWUhzYq4JGOw9n4EUz6Ts/BwO3A53FyL1z7kRTvNkPJ/dL45V0JLvosdH Rzqecbjk+1rYfsP5Qs7mY8m+RVk3xqM= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-319-td8VMdjnM2OcIgD4Aj2ocQ-1; Thu, 18 May 2023 10:11:24 -0400 X-MC-Unique: td8VMdjnM2OcIgD4Aj2ocQ-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-6237e3d5983so29975206d6.3 for ; Thu, 18 May 2023 07:11:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684419084; x=1687011084; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=iQwVdHv6Lw8dEb3HJ22Fi/mr3hZkypY/pgo/f+VOrUI=; b=ccbF0KB1hmU20w/snW20RDw34pAQzbadA3yxbW7ouSyykM1Kaw6mtk1m5aOBEksIfy 44Gro1+mQY/83cAt4wt9P2DKVR4CRgxm8/7BIogbC/gAQfYoQssezkygpkj4OzCIhmqU VkTOR/9fETimnY59UhnT6FJatMCPBmwDsvz+TNpYzPuDHFDHxZZN4azftrMnM2juVE+6 PoQ8irxXwKcZHB4wmMBEbObY+uA1LFymzLcALEZ9hPxmzlpysbs8DEyK1JZZw/a137b8 IibdVzBBGk7GoI78S+8IDNVk9qwi6BBA3JMBaZLAigod/wnn2E28B8Pe5wN8Tul7+meT zHSg== X-Gm-Message-State: AC+VfDzhtaXloOaVU1WgYXDviGMS3ZrDgtaODTsn3dA1lGkqNOE1aNrZ j3xpro7jOOpSPm70An6XY54M28kxpAHGnyQ+CFOWP+fRAGegv9eM1B3ocbAtX5QVo3wqh4JirLs KMDGbAt/erVY= X-Received: by 2002:a05:6214:2aa1:b0:607:e40:c7c3 with SMTP id js1-20020a0562142aa100b006070e40c7c3mr5780676qvb.6.1684419084104; Thu, 18 May 2023 07:11:24 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4sS63L/DaE4MyDckM9sjRqG00t/bCBaKB4ljyhbTxnxCkkUDcnixiQgVZxf3I21eHBiXouFw== X-Received: by 2002:a05:6214:2aa1:b0:607:e40:c7c3 with SMTP id js1-20020a0562142aa100b006070e40c7c3mr5780650qvb.6.1684419083864; Thu, 18 May 2023 07:11:23 -0700 (PDT) Received: from dell-per740-01.7a2m.lab.eng.bos.redhat.com (nat-pool-bos-t.redhat.com. [66.187.233.206]) by smtp.gmail.com with ESMTPSA id dc9-20020a056214174900b0061b7c0ff41dsm549620qvb.34.2023.05.18.07.11.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 May 2023 07:11:23 -0700 (PDT) From: Tom Rix To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Tom Rix Subject: [PATCH] mm: page_alloc: set sysctl_lowmem_reserve_ratio storage-class-specifier to static Date: Thu, 18 May 2023 10:11:19 -0400 Message-Id: <20230518141119.927074-1-trix@redhat.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CF43B14012E X-Stat-Signature: grnru73rc84ze6a9fp1d6ncb6r1413ax X-HE-Tag: 1684419086-204246 X-HE-Meta: U2FsdGVkX18RrgtIzyYwk8RVMpD/Zubwkn/IVutosmwUhAdm0e/4RKoR3IHVi5I2d8GYSD3fN3XRbYyE4k94vIku3OLoGVAhzpEoqPhFnxBYQX635Cys/cYYQtmL6XToppcgeG3L6YoVikHBz9zhQPCPtGs7oBihWzIOf7v6razclWwDX1FZPoN6lxy0Lko+wV4AOM6ytUygYG7FSoZAF9odgO/5GSutaDM9SaxeBFK10i147mj1juPq4aJbFFR1lkY8rN9bB9pJy0davPsSdT31XAHkMuLzSHCXUijOUrYbpniaKv+hn6E9IMMkiCqyzdwOFSWDbpITOwoOrn7FotmguE8thFiu4oKlRwYMJDg7hOlYwneSHZTTv+NxM9P39xzBhcbsG10JI01TfX4wB/ryjC060qXe0I/H4qthsYh0VnTLUkXiVV8rqVbulYafq5OLOAZjIjFlyeXa8RbW4tX9QLMU4f1fZ9O/PT1HtpR6QGyu33j0l5IVm2YR6loUv7pCrxSfm08GcTtBh+Ung4J6dsTqR7sFuaWoeslSrFbzmeHDEhFRgn2jJyKvILB+kLOyLYw+qaIQIJyw8ePi9sWb0NDvBAUtVKxQ1EHP3qNnQFi5MluQFAFy1h5VbVv2Dg6Up/sNj/LgaFmHDLEk15Kp0+F6HHBh/sBsI7oU9yOejZgr1OqdHdtrRlxMyIPcun5MB7FDbcyGfv5bwPA+tLcHOFsJZFUCiNiyGU6UFQUH/BV87JoEFZ8D1gRpNcxXpmWDI+lOxr7iiU6LTrKWTelGBPy0imxi8Q3WBT4yPwcd1bQe7Sjv1EPb78aylyhQMEai/X4zhe/3a8KUST+X93nm4OPO1NRY/bGXMgl6ch1j1ykOHM2pkMqULf+WOC+tZ/sT7jytNLhPIoQrV2LROxutmLGOkBcnsR9xEyavpaFO4I91Zb66icF8d/NRPBrcJj98jsEtAYzAbjijSDG 067lLkgR AGO2SSQQ0j+soXxzSipiyNTIQoBhSUyxASaJn7OLqa9O32aF0jutJvdDyLz2Q9VZdBRc98BuCR6WpK0SAXGoUeAeyNYF+UrDEg+Pt9YwNtzL9GvgwyM0mtWLqeW7O8Gz5INJnhYgofgxw1pfS+NY+DXUoiQDi5GiEJD3Ao8HKRdzwZoIz/ZZI6lxvYynPJL6P2IFsNfyU6rhqZFfEWpmv5QPDeAcH5l/ER4+jiYW1c+4kByGDC7WGwbAqR4wfQh92sjdUu1+VMANagbRZupo6rwheZ9T7LBHUFRI7yl9cnvoUw8TaFJQPhpc32O3Y2McpHJiAogR9kfYTR0s3+qqO5O3xynI/hgzNmRmzp6jsteAA2x52r+oZQHC8J53WiYxCflFBthJ2jiASnYY+abdhgBesQvKX8w9TFpzDY1bW1uXtRkKq0tF3af6huQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: smatch reports mm/page_alloc.c:247:5: warning: symbol 'sysctl_lowmem_reserve_ratio' was not declared. Should it be static? This variable is only used in its defining file, so it should be static Signed-off-by: Tom Rix --- mm/page_alloc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1023f41de2fb..8032fffa425a 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -244,7 +244,7 @@ static void __free_pages_ok(struct page *page, unsigned int order, * TBD: should special case ZONE_DMA32 machines here - in those we normally * don't need any ZONE_NORMAL reservation */ -int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = { +static int sysctl_lowmem_reserve_ratio[MAX_NR_ZONES] = { #ifdef CONFIG_ZONE_DMA [ZONE_DMA] = 256, #endif