From patchwork Sun May 21 10:02:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249352 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82147C7EE29 for ; Sun, 21 May 2023 10:14:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=m6eQ9i0SC1NzU6kPW0QMyULBUuEIJrm8domJ8wJVJmM=; b=RqoHXRd/OAWAIH RRGD0ECl109o5n7lPHx2motVr+a655BM2GJ/CuNAFrSo7nBpyuFlwxcJAXC6XOQQWjitK1nJUjgpH HNPJSb1VvNfptCKnaeg9LD5QEFbGoCIVX16ywB/+lVdFP+Foe4z5qn1qOsIm0wRfvVWAWQqwkMZKh mzaUEriiKnXkui7zP8XhITWU9WbGvcyLe7WD+qHe5mpHxph8pZqWXeww672Wsjjf2wJeqPCSplHVB 3++LrPcVx9OwdlVJMx7b3FNhP5Se0dlnYX8Zo5ZNuAYn3LE9/5I0hGSoUz9FAoW2kYXgIJhMwCB0j 0CbqKuDP/hi+j439/ekQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q0g4t-003Z2d-13; Sun, 21 May 2023 10:14:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q0g4m-003Z0q-1H for linux-arm-kernel@lists.infradead.org; Sun, 21 May 2023 10:14:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BA3F161532; Sun, 21 May 2023 10:14:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 465CAC433A0; Sun, 21 May 2023 10:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664047; bh=705IbEQR9rBrNaTOK0WaKUUekkPcDSW7kXi/cfnV5VA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MUVndTHcpPU908yiU65cmte9E0nyV3gRWK9GLfARUXuD0H7FKZn12VR11W/FwfLCC SDxcuqtYH403Imj8zdQVqJI6Kp4DSqG87zDbE4k3euSrIp0z1GBqPXmW8B746uSEhu Pfje810jmbEiYAOcypN3Nt0WbHxmR7qr0BfLGVDGlZzEy//ACd5IKw5rilFobMxJ6V I27lH8Gc5Q8QLGn10R7+OqyR5jK5KZ7Q1GDk6smvWW/Obhr8WyAuG88GobdRVQHRlU tuc2xGCW0+no1IGxSCDnha0LARVY4RNXU3tjrSE2qL7c5dlRPUJFbR33p1giAI5IEx w0ucU+KcMY+pg== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 1/5] dmaengine: dw-axi-dmac: Don't set chancnt Date: Sun, 21 May 2023 18:02:48 +0800 Message-Id: <20230521100252.3197-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230521_031408_477757_E0AE28C7 X-CRM114-Status: GOOD ( 10.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 6937cc0c0b65..796b6caf0bab 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1466,7 +1466,6 @@ static int dw_probe(struct platform_device *pdev) dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask); /* DMA capabilities */ - dw->dma.chancnt = hdata->nr_channels; dw->dma.max_burst = hdata->axi_rw_burst_len; dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS; dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS; From patchwork Sun May 21 10:02:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249351 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 30DB3C77B73 for ; Sun, 21 May 2023 10:14:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=CEw75gRY6lhhEuAMjNxmMXmnDZJGnqKWibLr+QCoOGU=; b=0GLOP+kojfJJSY KwpFkdbXYNSpjYFwjzp3RxYYlUktE5B8IEXa2+QGTIXN7nNoZ3TSONHGJuM5Ttixlk7gqgHMnQ05d wKNkaJiX+nylH7w6CLKxciDhssG2dhXg2klFplWQkVm9kfWjA0xM1JCcjKOnQ4MFHS7JUFp7AIAHk qffy0ONDA8feCm2Ihm8KPLSK10eFxl7Z1uU5aJ1FwQA1DlqaCUb4ykvEJQVH4h6XxWfU21BzwxVJW dJ9HkzhXb02NBF5kcNCza4xkO8J0JrMvwgo73hZHQcpqF3QTaFWNQRsAuD/FatTC3Dew5VuKvuuQJ CGe00njpk6f/QHgMZnJQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q0g4t-003Z2z-2l; Sun, 21 May 2023 10:14:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q0g4p-003Z1M-1c for linux-arm-kernel@lists.infradead.org; Sun, 21 May 2023 10:14:12 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 178A56154E; Sun, 21 May 2023 10:14:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 978D8C433A1; Sun, 21 May 2023 10:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664050; bh=iKBSLxOITCXkuIZreLUcOGXCAwPyJ2AdsBgElqBT+P8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jalWQArAy9uK0OcA78NzbJf6BcDyjcl8QCFrKtS5uzQErfVDibIxJWp9+YjqwKE8G fczdosw3VjLQ32PcSSoRQ3xkDwdVNj8kYrMA60jQVVjZnjYWlRFbpWQbMi/tHEAQlO Q77wjRHo7sHMWk5H+zdlSqyOn7FVM8mY+4npxP6SlciOM997/MPKUHNfnx/81eil1P mGea0V77U8ZRFXgTDXW0+39hfIGHJPxwBZ/tObb0eOZDc5s0HQrGpXqeDvS2yDarcF E8mRyccMsmLFzy/2+ZTRE2ei4DLbBQyEYGhwVEU65M1H+kxdGnlp8dKTXydESO8pSs mGt26HR+FF3rQ== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 2/5] dmaengine: axi-dmac: Don't set chancnt Date: Sun, 21 May 2023 18:02:49 +0800 Message-Id: <20230521100252.3197-3-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230521_031411_605283_7BF3C405 X-CRM114-Status: GOOD ( 10.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Lars-Peter Clausen --- drivers/dma/dma-axi-dmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index a812b9b00e6b..fc7cdad37161 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev) dma_dev->device_terminate_all = axi_dmac_terminate_all; dma_dev->device_synchronize = axi_dmac_synchronize; dma_dev->dev = &pdev->dev; - dma_dev->chancnt = 1; dma_dev->src_addr_widths = BIT(dmac->chan.src_width); dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); dma_dev->directions = BIT(dmac->chan.direction); From patchwork Sun May 21 10:02:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249355 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id ECC3AC77B73 for ; Sun, 21 May 2023 10:14:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2gQjjDCTZhIyL0mZPhc3mjsdPXt8p7bZ2dYNqKPWxF8=; b=M3coPLIMp04Ntm 3XxUkE93SFOGRSwl95sLn0TJUcoc/CJFo3vNjQ083/0B1u6KRMUX+54460cNJrF4CDrEeUwEcKHkD eFZMqtWvTROhi+n0Ql1TYajhxTM2RCuYp2vRAELSOx0DzrRSta+CLClOkzjmj9edbojU2u5YmUzDz WAoJSvmCoLkj1kG2azOxgshDrW1Viu2pSPnRFPgtzhuXFq1pwWfXwShVjyXukCqtwGIhUbSxoJ6Uw 73NYhBA9mh9SJbQ1wUv3SiHxnrs8DWe4DNPzvmbNhUu87arN/YCznSLgIlB/mChoKG375QZhOLjn6 ae14/lntISUrLhjqFspw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q0g54-003Z5v-2U; Sun, 21 May 2023 10:14:26 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q0g4s-003Z23-2k for linux-arm-kernel@lists.infradead.org; Sun, 21 May 2023 10:14:16 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6579A6153D; Sun, 21 May 2023 10:14:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7FBBC433EF; Sun, 21 May 2023 10:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664053; bh=SgpWj/R+8haw9UTysuAqZBmQnttr3cu4CFi/nHEGkNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Src54wdI36aeOynbc3nFprzf1ixqJOCjyA6KIfieOBDUuIl669VLVg0iwTwdfMjsU 6+mi4eyBQsT8j5VAK68AbOYGn1J+hKNVDz+5nrfStN3Fv8SqeAbg3IA33zdrXm3I6o s/flsp9Vt/c3vEEshAQwbinbWjAfrR80eFC16KB4lOQFHOM1KeOl4E5rRU4ZHIyB07 WyfCOT3PIZzxD/9KyTeSSAy2ma3qkdgdQfZh0EDgW4w0zCA4OOQsQ7loW4l6FYB4qE NfIiR52lT3eS9GAiW3KON4SDq0eHAXtmLCq7hmf6XZMniBR1sXjWouaFDK1OMuHlvM ut8UgulwKj9/w== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 3/5] dmaengine: plx_dma: Don't set chancnt Date: Sun, 21 May 2023 18:02:50 +0800 Message-Id: <20230521100252.3197-4-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230521_031414_935057_45434A81 X-CRM114-Status: GOOD ( 10.45 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Logan Gunthorpe --- drivers/dma/plx_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 12725fa1655f..34b6416c3287 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -517,7 +517,6 @@ static int plx_dma_create(struct pci_dev *pdev) plxdev->bar = pcim_iomap_table(pdev)[0]; dma = &plxdev->dma_dev; - dma->chancnt = 1; INIT_LIST_HEAD(&dma->channels); dma_cap_set(DMA_MEMCPY, dma->cap_mask); dma->copy_align = DMAENGINE_ALIGN_1_BYTE; From patchwork Sun May 21 10:02:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249353 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4632DC77B73 for ; Sun, 21 May 2023 10:14:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DTpGJ4AM8lyejxAyXQAvNuGKU0WtWs1CTNTQAVwSwWU=; b=JYisAvcTuq1EeR v66oBw0sgFvN8amvwOxjaYIBOoeZK/oPjFYM7MZNszJ61aM79IhlumMvChS9jR4vdvfZ0xujhk+GJ +P/+qgzeOfYlaNI45vCQU5W+cRWNMMXMRp4JYH+svkfZdykP1M4nRxyPsoCnGoB3px886ENte6JCk XS/q7/VP0SmqoMlTwxCuKWw+UJNuFYm1Lxm8vj+KGavAfBmt26lEZT9TJYHEtE90Iru428vYYfQA6 p214lREwvrtv82sYbidS3Vo5TPN8U39/y5mfXaFz37M8JGsbmR9EnhHiYKJtyfxOX1t7XBH6N+TWY cww8eILkPlS96yMtjEfQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q0g55-003Z6G-12; Sun, 21 May 2023 10:14:27 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q0g4w-003Z3p-0Y for linux-arm-kernel@lists.infradead.org; Sun, 21 May 2023 10:14:19 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BD18261541; Sun, 21 May 2023 10:14:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44CA9C4339E; Sun, 21 May 2023 10:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664057; bh=VWHHZGOph30FRSEIQKdN3FOhxU5GdBKx6unG4ho62NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gwdzc8fcRcHU/eCL7hnccXdMDGUCH9rcOxlu+ymGWE7sMpzJF4GydPHgDhWlbKL+P kbx8r3vRZ6OyCzcsSmdoYbz0dl81U4JWUuu8KskJarknuBBLNACXgEybq234srfs+q uJ5yGpMK73hqWEzE81SnNQlEph0bM/a5OF+xXY2XI77RQCXYQt1m6nzi1dkfy8GvJ7 p9JDeOYb+DzeNaRVzWkuczeniwn5iDGXDgf5CdIoC7sqHPk3Sl/fRx1g1+Idymlpf/ Bfzs/3OH1rSUzRF2c7bsO/oHbMjX3gQ87JlfEv9dioAFnbYdCOx0LdEwm0ZWm6WT/i 5wyvEliqBS+og== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 4/5] dmaengine: hidma: Don't set chancnt Date: Sun, 21 May 2023 18:02:51 +0800 Message-Id: <20230521100252.3197-5-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230521_031418_252090_16E4DD45 X-CRM114-Status: GOOD ( 10.24 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/qcom/hidma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 04d1c33afc12..344525c3a32f 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -214,7 +214,6 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig) spin_lock_init(&mchan->lock); list_add_tail(&mchan->chan.device_node, &ddev->channels); - dmadev->ddev.chancnt++; return 0; } From patchwork Sun May 21 10:02:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249354 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2692C7EE23 for ; Sun, 21 May 2023 10:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5Xin3J7N4pftS7F6JQccEIHf/D7DYLHFT34A4iSz9nk=; b=eiWDRy/8N+39vH iEkrEp9Colz/5zGibFQqLchDGNlmyt4i2M3vc0rmjhuWchgJJwZzdgqkRzB8YbvwNq7rgMKPRXaPm hrmr965RMTIi1ORwrdON81YsajroxRyNR675jH0frpJx1IQjRqbKqB5YlgoibNiQRBf1UhbKMMF/A u1h9CfrFrnsOkTS9hYdLXFXJWNPEpCMMq4XzdHyp9XWDnYuZEY6iPPPP6kBpiPLOxwmOyjHzV8oxS jym4wA6KFW8tLD/4vTAeRWJZAuh/6r5SkPgd4SaLYPjpACU3u2thFiGBTIutHyBKESxoQuqdr/d7G FpOknzycSkm5Y3G66Dxw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q0g55-003Z6l-2r; Sun, 21 May 2023 10:14:27 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q0g4z-003Z4e-1k for linux-arm-kernel@lists.infradead.org; Sun, 21 May 2023 10:14:22 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 17FF86154E; Sun, 21 May 2023 10:14:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ACFDC433A4; Sun, 21 May 2023 10:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664060; bh=6pmh1p/2P56PknsAf9XgnrAcTCEe0jke0QzLpJtlW2A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uofbQcNglIZ9SCjmGN+WPWumHtt/je6y8z/YzzUos9PthN9lQldIWEzLGiL6qhyLs zKpcmIWqjnBTatvWM58sQ48WBPDzYdChRwONNQYeDmKPnJFU39vvPPeX6w4BYDPXFD F2/AutCikIJdzYM2Cbm6RX5ZLnnDVGswhSpCK36slWRJUCiuhcwrIhcIkcNeLeWFOa 53jIlqITQiEkHsQx7z+F3gnQ2BYHCp3CNtUBBjkbETRf/uslkwFCP3mUr+zRB/Wj1q lBnvVuJEPBlSfOqE5LFmEv641lmVLX9HTKLDhywlJKtZuJrw1PMaM2B3gCmG3F1vbM gZs8mNOQ5Pj5g== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 5/5] dmaengine: sprd: Don't set chancnt Date: Sun, 21 May 2023 18:02:52 +0800 Message-Id: <20230521100252.3197-6-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230521_031421_618656_AD29FE21 X-CRM114-Status: GOOD ( 10.81 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Reviewed-by: Baolin Wang --- drivers/dma/sprd-dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 474d3ba8ec9f..2b639adb48ba 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev) dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask); sdev->total_chns = chn_count; - sdev->dma_dev.chancnt = chn_count; INIT_LIST_HEAD(&sdev->dma_dev.channels); INIT_LIST_HEAD(&sdev->dma_dev.global_node); sdev->dma_dev.dev = &pdev->dev;