From patchwork Sun May 21 10:02:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249391 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82D7EC7EE31 for ; Sun, 21 May 2023 11:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230217AbjEULsS (ORCPT ); Sun, 21 May 2023 07:48:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35634 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231166AbjEUKZE (ORCPT ); Sun, 21 May 2023 06:25:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3568D10C4; Sun, 21 May 2023 03:14:08 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE68861541; Sun, 21 May 2023 10:14:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 465CAC433A0; Sun, 21 May 2023 10:14:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664047; bh=705IbEQR9rBrNaTOK0WaKUUekkPcDSW7kXi/cfnV5VA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MUVndTHcpPU908yiU65cmte9E0nyV3gRWK9GLfARUXuD0H7FKZn12VR11W/FwfLCC SDxcuqtYH403Imj8zdQVqJI6Kp4DSqG87zDbE4k3euSrIp0z1GBqPXmW8B746uSEhu Pfje810jmbEiYAOcypN3Nt0WbHxmR7qr0BfLGVDGlZzEy//ACd5IKw5rilFobMxJ6V I27lH8Gc5Q8QLGn10R7+OqyR5jK5KZ7Q1GDk6smvWW/Obhr8WyAuG88GobdRVQHRlU tuc2xGCW0+no1IGxSCDnha0LARVY4RNXU3tjrSE2qL7c5dlRPUJFbR33p1giAI5IEx w0ucU+KcMY+pg== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 1/5] dmaengine: dw-axi-dmac: Don't set chancnt Date: Sun, 21 May 2023 18:02:48 +0800 Message-Id: <20230521100252.3197-2-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c index 6937cc0c0b65..796b6caf0bab 100644 --- a/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c +++ b/drivers/dma/dw-axi-dmac/dw-axi-dmac-platform.c @@ -1466,7 +1466,6 @@ static int dw_probe(struct platform_device *pdev) dma_cap_set(DMA_CYCLIC, dw->dma.cap_mask); /* DMA capabilities */ - dw->dma.chancnt = hdata->nr_channels; dw->dma.max_burst = hdata->axi_rw_burst_len; dw->dma.src_addr_widths = AXI_DMA_BUSWIDTHS; dw->dma.dst_addr_widths = AXI_DMA_BUSWIDTHS; From patchwork Sun May 21 10:02:49 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249394 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08089C7EE45 for ; Sun, 21 May 2023 11:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230341AbjEULsU (ORCPT ); Sun, 21 May 2023 07:48:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35636 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231173AbjEUKZE (ORCPT ); Sun, 21 May 2023 06:25:04 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 85FB710C6; Sun, 21 May 2023 03:14:11 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1AC8761528; Sun, 21 May 2023 10:14:11 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 978D8C433A1; Sun, 21 May 2023 10:14:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664050; bh=iKBSLxOITCXkuIZreLUcOGXCAwPyJ2AdsBgElqBT+P8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jalWQArAy9uK0OcA78NzbJf6BcDyjcl8QCFrKtS5uzQErfVDibIxJWp9+YjqwKE8G fczdosw3VjLQ32PcSSoRQ3xkDwdVNj8kYrMA60jQVVjZnjYWlRFbpWQbMi/tHEAQlO Q77wjRHo7sHMWk5H+zdlSqyOn7FVM8mY+4npxP6SlciOM997/MPKUHNfnx/81eil1P mGea0V77U8ZRFXgTDXW0+39hfIGHJPxwBZ/tObb0eOZDc5s0HQrGpXqeDvS2yDarcF E8mRyccMsmLFzy/2+ZTRE2ei4DLbBQyEYGhwVEU65M1H+kxdGnlp8dKTXydESO8pSs mGt26HR+FF3rQ== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 2/5] dmaengine: axi-dmac: Don't set chancnt Date: Sun, 21 May 2023 18:02:49 +0800 Message-Id: <20230521100252.3197-3-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Lars-Peter Clausen --- drivers/dma/dma-axi-dmac.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dma-axi-dmac.c b/drivers/dma/dma-axi-dmac.c index a812b9b00e6b..fc7cdad37161 100644 --- a/drivers/dma/dma-axi-dmac.c +++ b/drivers/dma/dma-axi-dmac.c @@ -963,7 +963,6 @@ static int axi_dmac_probe(struct platform_device *pdev) dma_dev->device_terminate_all = axi_dmac_terminate_all; dma_dev->device_synchronize = axi_dmac_synchronize; dma_dev->dev = &pdev->dev; - dma_dev->chancnt = 1; dma_dev->src_addr_widths = BIT(dmac->chan.src_width); dma_dev->dst_addr_widths = BIT(dmac->chan.dest_width); dma_dev->directions = BIT(dmac->chan.direction); From patchwork Sun May 21 10:02:50 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249392 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DD841C7EE39 for ; Sun, 21 May 2023 11:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230352AbjEULsV (ORCPT ); Sun, 21 May 2023 07:48:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35572 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231179AbjEUKZZ (ORCPT ); Sun, 21 May 2023 06:25:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D05AB10C9; Sun, 21 May 2023 03:14:14 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 6520361528; Sun, 21 May 2023 10:14:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id E7FBBC433EF; Sun, 21 May 2023 10:14:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664053; bh=SgpWj/R+8haw9UTysuAqZBmQnttr3cu4CFi/nHEGkNA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Src54wdI36aeOynbc3nFprzf1ixqJOCjyA6KIfieOBDUuIl669VLVg0iwTwdfMjsU 6+mi4eyBQsT8j5VAK68AbOYGn1J+hKNVDz+5nrfStN3Fv8SqeAbg3IA33zdrXm3I6o s/flsp9Vt/c3vEEshAQwbinbWjAfrR80eFC16KB4lOQFHOM1KeOl4E5rRU4ZHIyB07 WyfCOT3PIZzxD/9KyTeSSAy2ma3qkdgdQfZh0EDgW4w0zCA4OOQsQ7loW4l6FYB4qE NfIiR52lT3eS9GAiW3KON4SDq0eHAXtmLCq7hmf6XZMniBR1sXjWouaFDK1OMuHlvM ut8UgulwKj9/w== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 3/5] dmaengine: plx_dma: Don't set chancnt Date: Sun, 21 May 2023 18:02:50 +0800 Message-Id: <20230521100252.3197-4-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Acked-by: Logan Gunthorpe --- drivers/dma/plx_dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/plx_dma.c b/drivers/dma/plx_dma.c index 12725fa1655f..34b6416c3287 100644 --- a/drivers/dma/plx_dma.c +++ b/drivers/dma/plx_dma.c @@ -517,7 +517,6 @@ static int plx_dma_create(struct pci_dev *pdev) plxdev->bar = pcim_iomap_table(pdev)[0]; dma = &plxdev->dma_dev; - dma->chancnt = 1; INIT_LIST_HEAD(&dma->channels); dma_cap_set(DMA_MEMCPY, dma->cap_mask); dma->copy_align = DMAENGINE_ALIGN_1_BYTE; From patchwork Sun May 21 10:02:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249390 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 431C2C7EE30 for ; Sun, 21 May 2023 11:49:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230233AbjEULsT (ORCPT ); Sun, 21 May 2023 07:48:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35666 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbjEUKZZ (ORCPT ); Sun, 21 May 2023 06:25:25 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3A64810CB; Sun, 21 May 2023 03:14:18 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id C104861551; Sun, 21 May 2023 10:14:17 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 44CA9C4339E; Sun, 21 May 2023 10:14:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664057; bh=VWHHZGOph30FRSEIQKdN3FOhxU5GdBKx6unG4ho62NU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Gwdzc8fcRcHU/eCL7hnccXdMDGUCH9rcOxlu+ymGWE7sMpzJF4GydPHgDhWlbKL+P kbx8r3vRZ6OyCzcsSmdoYbz0dl81U4JWUuu8KskJarknuBBLNACXgEybq234srfs+q uJ5yGpMK73hqWEzE81SnNQlEph0bM/a5OF+xXY2XI77RQCXYQt1m6nzi1dkfy8GvJ7 p9JDeOYb+DzeNaRVzWkuczeniwn5iDGXDgf5CdIoC7sqHPk3Sl/fRx1g1+Idymlpf/ Bfzs/3OH1rSUzRF2c7bsO/oHbMjX3gQ87JlfEv9dioAFnbYdCOx0LdEwm0ZWm6WT/i 5wyvEliqBS+og== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 4/5] dmaengine: hidma: Don't set chancnt Date: Sun, 21 May 2023 18:02:51 +0800 Message-Id: <20230521100252.3197-5-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang --- drivers/dma/qcom/hidma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/qcom/hidma.c b/drivers/dma/qcom/hidma.c index 04d1c33afc12..344525c3a32f 100644 --- a/drivers/dma/qcom/hidma.c +++ b/drivers/dma/qcom/hidma.c @@ -214,7 +214,6 @@ static int hidma_chan_init(struct hidma_dev *dmadev, u32 dma_sig) spin_lock_init(&mchan->lock); list_add_tail(&mchan->chan.device_node, &ddev->channels); - dmadev->ddev.chancnt++; return 0; } From patchwork Sun May 21 10:02:52 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jisheng Zhang X-Patchwork-Id: 13249393 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BAB2C7EE43 for ; Sun, 21 May 2023 11:49:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230365AbjEULsW (ORCPT ); Sun, 21 May 2023 07:48:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35586 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231190AbjEUKZc (ORCPT ); Sun, 21 May 2023 06:25:32 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7EE5810CC; Sun, 21 May 2023 03:14:21 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 14AAD60F0E; Sun, 21 May 2023 10:14:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 9ACFDC433A4; Sun, 21 May 2023 10:14:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684664060; bh=6pmh1p/2P56PknsAf9XgnrAcTCEe0jke0QzLpJtlW2A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=uofbQcNglIZ9SCjmGN+WPWumHtt/je6y8z/YzzUos9PthN9lQldIWEzLGiL6qhyLs zKpcmIWqjnBTatvWM58sQ48WBPDzYdChRwONNQYeDmKPnJFU39vvPPeX6w4BYDPXFD F2/AutCikIJdzYM2Cbm6RX5ZLnnDVGswhSpCK36slWRJUCiuhcwrIhcIkcNeLeWFOa 53jIlqITQiEkHsQx7z+F3gnQ2BYHCp3CNtUBBjkbETRf/uslkwFCP3mUr+zRB/Wj1q lBnvVuJEPBlSfOqE5LFmEv641lmVLX9HTKLDhywlJKtZuJrw1PMaM2B3gCmG3F1vbM gZs8mNOQ5Pj5g== From: Jisheng Zhang To: Lars-Peter Clausen , Vinod Koul , Eugeniy Paltsev , Logan Gunthorpe , Sinan Kaya , Andy Gross , Bjorn Andersson , Konrad Dybcio , Orson Zhai , Baolin Wang , Chunyan Zhang Cc: dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org Subject: [PATCH v3 5/5] dmaengine: sprd: Don't set chancnt Date: Sun, 21 May 2023 18:02:52 +0800 Message-Id: <20230521100252.3197-6-jszhang@kernel.org> X-Mailer: git-send-email 2.40.0 In-Reply-To: <20230521100252.3197-1-jszhang@kernel.org> References: <20230521100252.3197-1-jszhang@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org The dma framework will calculate the dma channels chancnt, setting it ourself is wrong. Signed-off-by: Jisheng Zhang Reviewed-by: Baolin Wang --- drivers/dma/sprd-dma.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/sprd-dma.c b/drivers/dma/sprd-dma.c index 474d3ba8ec9f..2b639adb48ba 100644 --- a/drivers/dma/sprd-dma.c +++ b/drivers/dma/sprd-dma.c @@ -1169,7 +1169,6 @@ static int sprd_dma_probe(struct platform_device *pdev) dma_cap_set(DMA_MEMCPY, sdev->dma_dev.cap_mask); sdev->total_chns = chn_count; - sdev->dma_dev.chancnt = chn_count; INIT_LIST_HEAD(&sdev->dma_dev.channels); INIT_LIST_HEAD(&sdev->dma_dev.global_node); sdev->dma_dev.dev = &pdev->dev;