From patchwork Mon Feb 4 12:48:32 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 10795573 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 684D213BF for ; Mon, 4 Feb 2019 12:48:41 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 55EAC27816 for ; Mon, 4 Feb 2019 12:48:41 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 476012B3E4; Mon, 4 Feb 2019 12:48:41 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1B7BE27816 for ; Mon, 4 Feb 2019 12:48:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730988AbfBDMsj (ORCPT ); Mon, 4 Feb 2019 07:48:39 -0500 Received: from mail-lj1-f195.google.com ([209.85.208.195]:42106 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbfBDMsj (ORCPT ); Mon, 4 Feb 2019 07:48:39 -0500 Received: by mail-lj1-f195.google.com with SMTP id l15-v6so11397293lja.9; Mon, 04 Feb 2019 04:48:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=+fOArrM0Jv02/PFRcwb2W1MidL7ddqkP1Jf7AuR+n70=; b=bpxpVkfzs0DCazW37Q37RbHlbT6BiuQMiNds85Q3kSN8/bKQD8XJs4SPrCoVefxASH YAvbqdzAhIRUO1YxkZoj3cbiyafG4pGPn0rTEFapFPSTbkcmn5B+U1xsBaARtmp5pxx8 lESVtJmntN7NeDyp4j+BmgFZnFenmMNymcf6ShAZ09aMQY4vlJv8F2c7kC21/P9FkZTW 9Ym6HgIS1DK6nVl0MLIQHUXoXw03xsmn0uheWqDMYnRirvrFYV+87ksC0WspUgfbRUnF +zzKo/poZRd84BSTAC+oFO7W6BJCg6QIiSsLXKcNyQzcbeOhBXRdENnubwyLiXMo/JUP w65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :mime-version:content-transfer-encoding; bh=+fOArrM0Jv02/PFRcwb2W1MidL7ddqkP1Jf7AuR+n70=; b=tRSyHEdYoQRX6QVspNY8I2rd3n1ReWcDIS21Bg7Y6622djWnWkJC3cw2qBz/oh3ZaE 41LvL7g71naRKfkGXJk99NrdBGXJhxByg4I6RUYSdqOUlrIBTX+6m0FNXFiyGCMDVWju JVEb+0EISo/Tj9eNxocZFpDvf/9SlLYXoqO0DpQEM7Q8Oqa0z0OuE/xVSwFQc/UWFoC5 9jNhpQ5kZwraMJug4ei0kOs2a5qjdh3RBBGvlmBtcK/MtsvA3B4v80gorvTb+gGJMCjo Vo68Dc58RB8A/o3s+qUEuNQ5dssR6nw22C0surksMnbwa7iR49aU8uKOjm5jbioucFmc /rXg== X-Gm-Message-State: AHQUAubZ/cLDQWk/w34J3IpLetQEXeTRsY68qDSZVCnFPX4c5sIZX6nf fOcSVMhh23Do6phKRZnGEhA= X-Google-Smtp-Source: AHgI3IZliv9FSHU4QeHdIQdqlLhzJSXGKZzBeYL09FzK7hsiLWuPZXg7Gs3uSBJhekU2rgCnQdEJPg== X-Received: by 2002:a2e:b04f:: with SMTP id d15-v6mr10855509ljl.3.1549284515557; Mon, 04 Feb 2019 04:48:35 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id d23sm3056791lfc.11.2019.02.04.04.48.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 04:48:34 -0800 (PST) From: Ricardo Ribalda Delgado To: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado Subject: [PATCH v4 1/2] iio:dac:ti-dac7612: Add driver for Texas Instruments DAC7612 Date: Mon, 4 Feb 2019 13:48:32 +0100 Message-Id: <20190204124833.18779-1-ricardo@ribalda.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP It is a driver for Texas Instruments Dual, 12-Bit Serial Input Digital-to-Analog Converter. Datasheet of this chip: http://www.ti.com/lit/ds/sbas106/sbas106.pdf Signed-off-by: Ricardo Ribalda Delgado --- Changelog v4 by: Jonathan Cameron , dt related: -Fix pin name -Fix part name -improve comments MAINTAINERS | 6 ++ drivers/iio/dac/Kconfig | 10 ++ drivers/iio/dac/Makefile | 1 + drivers/iio/dac/ti-dac7612.c | 184 +++++++++++++++++++++++++++++++++++ 4 files changed, 201 insertions(+) create mode 100644 drivers/iio/dac/ti-dac7612.c diff --git a/MAINTAINERS b/MAINTAINERS index d039f66a5cef..30ba5435906b 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14877,6 +14877,12 @@ F: Documentation/devicetree/bindings/clock/ti,sci-clk.txt F: drivers/clk/keystone/sci-clk.c F: drivers/reset/reset-ti-sci.c +Texas Instruments' DAC7612 DAC Driver +M: Ricardo Ribalda +L: linux-iio@vger.kernel.org +S: Supported +F: drivers/iio/dac/ti-dac7612.c + THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER M: Hans Verkuil L: linux-media@vger.kernel.org diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index f28daf67db6a..fbef9107acad 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -375,6 +375,16 @@ config TI_DAC7311 If compiled as a module, it will be called ti-dac7311. +config TI_DAC7612 + tristate "Texas Instruments 12-bit 2-channel DAC driver" + depends on SPI_MASTER && GPIOLIB + help + Driver for the Texas Instruments DAC7612, DAC7612U, DAC7612UB + The driver hand drive the load pin automatically, otherwise + it needs to be toggled manually. + + If compiled as a module, it will be called ti-dac7612. + config VF610_DAC tristate "Vybrid vf610 DAC driver" depends on OF diff --git a/drivers/iio/dac/Makefile b/drivers/iio/dac/Makefile index f0a37c93de8e..1369fa1d2f0e 100644 --- a/drivers/iio/dac/Makefile +++ b/drivers/iio/dac/Makefile @@ -41,4 +41,5 @@ obj-$(CONFIG_STM32_DAC) += stm32-dac.o obj-$(CONFIG_TI_DAC082S085) += ti-dac082s085.o obj-$(CONFIG_TI_DAC5571) += ti-dac5571.o obj-$(CONFIG_TI_DAC7311) += ti-dac7311.o +obj-$(CONFIG_TI_DAC7612) += ti-dac7612.o obj-$(CONFIG_VF610_DAC) += vf610_dac.o diff --git a/drivers/iio/dac/ti-dac7612.c b/drivers/iio/dac/ti-dac7612.c new file mode 100644 index 000000000000..c46805144dd4 --- /dev/null +++ b/drivers/iio/dac/ti-dac7612.c @@ -0,0 +1,184 @@ +// SPDX-License-Identifier: GPL-2.0 +/* + * DAC7612 Dual, 12-Bit Serial input Digital-to-Analog Converter + * + * Copyright 2019 Qtechnology A/S + * 2019 Ricardo Ribalda + * + * Licensed under the GPL-2. + */ +#include +#include +#include +#include +#include + +#define DAC7612_RESOLUTION 12 +#define DAC7612_ADDRESS 4 +#define DAC7612_START 5 + +struct dac7612 { + struct spi_device *spi; + struct gpio_desc *loaddacs; + uint16_t cache[2]; + + /* + * DMA (thus cache coherency maintenance) requires the + * transfer buffers to live in their own cache lines. + */ + uint8_t data[2] ____cacheline_aligned; +}; + +static int dac7612_cmd_single(struct dac7612 *priv, int channel, u16 val) +{ + int ret; + + priv->data[0] = BIT(DAC7612_START) | (channel << DAC7612_ADDRESS); + priv->data[0] |= val >> 8; + priv->data[1] = val & 0xff; + + priv->cache[channel] = val; + + ret = spi_write(priv->spi, priv->data, sizeof(priv->data)); + if (ret) + return ret; + + gpiod_set_value(priv->loaddacs, 1); + gpiod_set_value(priv->loaddacs, 0); + + return 0; +} + +#define dac7612_CHANNEL(chan, name) { \ + .type = IIO_VOLTAGE, \ + .channel = (chan), \ + .indexed = 1, \ + .output = 1, \ + .datasheet_name = name, \ + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW), \ + .info_mask_shared_by_type = BIT(IIO_CHAN_INFO_SCALE), \ +} + +static const struct iio_chan_spec dac7612_channels[] = { + dac7612_CHANNEL(0, "OUTA"), + dac7612_CHANNEL(1, "OUTB"), +}; + +static int dac7612_read_raw(struct iio_dev *iio_dev, + const struct iio_chan_spec *chan, + int *val, int *val2, long mask) +{ + struct dac7612 *priv; + + switch (mask) { + case IIO_CHAN_INFO_RAW: + priv = iio_priv(iio_dev); + *val = priv->cache[chan->channel]; + return IIO_VAL_INT; + + case IIO_CHAN_INFO_SCALE: + *val = 1; + return IIO_VAL_INT; + + default: + return -EINVAL; + } +} + +static int dac7612_write_raw(struct iio_dev *iio_dev, + const struct iio_chan_spec *chan, + int val, int val2, long mask) +{ + struct dac7612 *priv = iio_priv(iio_dev); + int ret; + + if (mask != IIO_CHAN_INFO_RAW) + return -EINVAL; + + if ((val >= BIT(DAC7612_RESOLUTION)) || val < 0 || val2) + return -EINVAL; + + if (val == priv->cache[chan->channel]) + return 0; + + mutex_lock(&iio_dev->mlock); + ret = dac7612_cmd_single(priv, chan->channel, val); + mutex_unlock(&iio_dev->mlock); + + return ret; +} + +static const struct iio_info dac7612_info = { + .read_raw = dac7612_read_raw, + .write_raw = dac7612_write_raw, +}; + +static int dac7612_probe(struct spi_device *spi) +{ + struct iio_dev *iio_dev; + struct dac7612 *priv; + int i; + int ret; + + iio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*priv)); + if (!iio_dev) + return -ENOMEM; + + priv = iio_priv(iio_dev); + /* + * LOADDACS pin can be controlled by the driver or externally. + * When controlled by the driver, the DAC value is updated after + * every write. + * When the driver does not control the PIN, the user or an external + * event can change the value of all DACs by pulsing down the LOADDACs + * pin. + */ + priv->loaddacs = devm_gpiod_get_optional(&spi->dev, "ti,loaddacs", + GPIOD_OUT_LOW); + if (IS_ERR(priv->loaddacs)) + return PTR_ERR(priv->loaddacs); + priv->spi = spi; + spi_set_drvdata(spi, iio_dev); + iio_dev->dev.parent = &spi->dev; + iio_dev->info = &dac7612_info; + iio_dev->modes = INDIO_DIRECT_MODE; + iio_dev->channels = dac7612_channels; + iio_dev->num_channels = ARRAY_SIZE(priv->cache); + iio_dev->name = spi_get_device_id(spi)->name; + + for (i = 0; i < ARRAY_SIZE(priv->cache); i++) { + ret = dac7612_cmd_single(priv, i, 0); + if (ret) + return ret; + } + + return devm_iio_device_register(&spi->dev, iio_dev); +} + +static const struct spi_device_id dac7612_id[] = { + {"ti-dac7612"}, + {} +}; +MODULE_DEVICE_TABLE(spi, dac7612_id); + +static const struct of_device_id dac7612_of_match[] = { + { .compatible = "ti,dac7612" }, + { .compatible = "ti,dac7612u" }, + { .compatible = "ti,dac7612ub" }, + { }, +}; +MODULE_DEVICE_TABLE(of, dac7612_of_match); + +static struct spi_driver dac7612_driver = { + .driver = { + .name = "ti-dac7612", + .of_match_table = dac7612_of_match, + }, + .probe = dac7612_probe, + .id_table = dac7612_id, +}; +module_spi_driver(dac7612_driver); + +MODULE_AUTHOR("Ricardo Ribalda "); +MODULE_DESCRIPTION("Texas Instruments DAC7612 DAC driver"); +MODULE_LICENSE("GPL v2"); From patchwork Mon Feb 4 12:48:33 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ricardo Ribalda Delgado X-Patchwork-Id: 10795579 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B013A1823 for ; Mon, 4 Feb 2019 12:48:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 96DF42A25E for ; Mon, 4 Feb 2019 12:48:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 84EF82A9A2; Mon, 4 Feb 2019 12:48:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F8582A7D5 for ; Mon, 4 Feb 2019 12:48:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725992AbfBDMsk (ORCPT ); Mon, 4 Feb 2019 07:48:40 -0500 Received: from mail-lj1-f194.google.com ([209.85.208.194]:45147 "EHLO mail-lj1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729423AbfBDMsj (ORCPT ); Mon, 4 Feb 2019 07:48:39 -0500 Received: by mail-lj1-f194.google.com with SMTP id s5-v6so11363824ljd.12; Mon, 04 Feb 2019 04:48:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=odKZR5LuUPQq6nEynHHZu620HK8qG1oypfpwL9UmJOI=; b=B8sSN6QKIcxS+IglLxosSA0jjlNsykMSeA+VA9IbL7jEUqfcec5cdNaQeKryMcFejV rYcZCOW//fzE28Ue5xpeOWKDAejLv7NMlA9OAc4bQEZtN2WD5+hYrRLFG0rcrwks0Qbb UZeOOS2V3/LkRRJqT2oBgSt3pcAJZfk5gJusWCLqzBzFzuQJ747zFwAyw0vwhLRldL1s yBk0yneSkFUefz+CYW9I+HaS4i97UKrCilZ0K6IUcz03NICRyWL5crhCXcW8mg7Uis2x b77+P4QUrbKZbM4cqRvkNI02eJwGvYtirMKJq3DQSYn01IqDmmwJQ1aANcL6ZhJ+TkAC CS+g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references:mime-version:content-transfer-encoding; bh=odKZR5LuUPQq6nEynHHZu620HK8qG1oypfpwL9UmJOI=; b=UJaKLwf0/bBzPZRMebJwRthF4TnyiAFzyM9gQPds1UAkKAjHT09E9QIX14zbQThbzI dot8dftn/J5SAfqyIMgk6rFvyZ/haVf+4TQJZ+ZET0OY2zVhokaKJt447O7j8wDeuFj4 0nFTWjl9kPgu9GGZqb9Nlt6iTuBy8dJ0pxae3UevHf4Nc+mCf5O9yDEX19M/UcSSXMul IoWw2OgmjUuOYMFijuZgKEOVn8l3nZWGQCjxgUfRxP1OaqkNSfR4o+4fZ2dD6B5t1Tin FEy2pwQ/CZa+NR1Xvw5HtMcdUsza0E0gOod4ur/DBA+b+rpStqn5l2l1h2y8MqPKRIcs N/tQ== X-Gm-Message-State: AHQUAuZeg1Anp0GHD0Lpbv+tPIOxBVi5LWBQWwXrYfsuXxQj5o0z2RH1 s3a2paNDW0EGMXJKVvAvPM4= X-Google-Smtp-Source: AHgI3IaXISGFwkthbAWLEA6y/aCqzB4L/6VddmrRjpSiN1ooITIEitVOGQNOS/OYDOhRrq0ILJ0cZA== X-Received: by 2002:a2e:8e8e:: with SMTP id z14-v6mr4755141ljk.84.1549284517300; Mon, 04 Feb 2019 04:48:37 -0800 (PST) Received: from neopili.qtec.com (cpe.xe-3-0-1-778.vbrnqe10.dk.customer.tdc.net. [80.197.57.18]) by smtp.gmail.com with ESMTPSA id d23sm3056791lfc.11.2019.02.04.04.48.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Feb 2019 04:48:35 -0800 (PST) From: Ricardo Ribalda Delgado To: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda Delgado , devicetree@vger.kernel.org Subject: [PATCH v4 2/2] iio:dac:dac7612: device tree bindings Date: Mon, 4 Feb 2019 13:48:33 +0100 Message-Id: <20190204124833.18779-2-ricardo@ribalda.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190204124833.18779-1-ricardo@ribalda.com> References: <20190204124833.18779-1-ricardo@ribalda.com> MIME-Version: 1.0 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Bindings for dac7612. Cc: devicetree@vger.kernel.org Signed-off-by: Ricardo Ribalda Delgado --- v4 Changelog by Rob Herring -Add ti, prefix to gpio -Fix example da@1 -Fix partname .../bindings/iio/dac/ti,dac7612.txt | 29 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt diff --git a/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt new file mode 100644 index 000000000000..14a66c0dcdaa --- /dev/null +++ b/Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt @@ -0,0 +1,29 @@ +* Texas Instruments Dual, 12-Bit Serial Input Digital-to-Analog Converter + +The DAC7612 is a dual, 12-bit digital-to-analog converter (DAC) with guaranteed +12-bit monotonicity performance over the industrial temperature range. +Is is programmable through an SPI interface. + +The internal DACs are loaded when the LOADDACS pin is pulled down. + +http://www.ti.com/lit/ds/sbas106/sbas106.pdf + +Required Properties: +- compatible: Should be one of: + "ti,dac7612" + "ti,dac7612u" + "ti,dac7612ub" +- reg: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt + +Optional Properties: +- ti,loaddacs-gpios: GPIO descriptor for the LOADDACS pin. +- spi-*: Definition as per Documentation/devicetree/bindings/spi/spi-bus.txt + +Example: + + dac@1 { + compatible = "ti,dac7612"; + reg = <0x1>; + ti,loaddacs-gpios = <&msmgpio 25 GPIO_ACTIVE_LOW>; + }; + diff --git a/MAINTAINERS b/MAINTAINERS index 30ba5435906b..e28e5afaae16 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14882,6 +14882,7 @@ M: Ricardo Ribalda L: linux-iio@vger.kernel.org S: Supported F: drivers/iio/dac/ti-dac7612.c +F: Documentation/devicetree/bindings/iio/dac/ti,dac7612.txt THANKO'S RAREMONO AM/FM/SW RADIO RECEIVER USB DRIVER M: Hans Verkuil