From patchwork Wed Jun 7 17:24:37 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ziyang Huang X-Patchwork-Id: 13271036 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8C092C7EE25 for ; Wed, 7 Jun 2023 17:25:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230045AbjFGRZS (ORCPT ); Wed, 7 Jun 2023 13:25:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229563AbjFGRZR (ORCPT ); Wed, 7 Jun 2023 13:25:17 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01olkn2109.outbound.protection.outlook.com [40.92.53.109]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 68EE11FE9; Wed, 7 Jun 2023 10:25:04 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OIMQUlGY8ix9icudO8ibb91fnMbnFH0LsxJbQKW/zhqiOmsuwlWGqzQxWv4KYjKWuAmzbvgnN98SGKepndLV8WbvAhs1/uuCKiaJy7lYdvnyDm3l/0Vexc+W2Ag1BJkAoJ6BqVzT55gqVWiYbMkAO/sUxHGxlAsgMRLkkiIh43547b9Q8p9K/ULJSLCONitmQNvBC5DHP5Oll/CeGnO8uriTV2TT4u7TvcaVqw9jei7XfFtDc9aOdny0lyY/4mnjyns8avlOANVirtFqaCvnJYroOtmlMKDXZXhNYFd38zbrSrDHCvPbrC6DA/Dvy219R/dYpiE3q3gVGsSgdA6Ohg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xaF1w8VO8XGhwWF/rwXqBwwfIRSACmUXPpupGkJsg4w=; b=UrCTfJiFRCRlGXQ/evDyTtPMqaGoctf1mT9vCKHtN8AFAaUyG9WEuqzggFXoq+1/Fi3RpM8UY1F0DKRai6p3UqwG0AMiXEVtPEzIS77b6kF7llznLoX574zAbndxj2B3oLcjvTxiQGqRvC3MLP6m7W/pMwuH5xltpd6P6i82PBx+1tBqToRnZ7IY5U+scNviTuprkvfvqf8deGQzXDbUbIX1XNfbrmpLq/8JeCm6CTqpmVLrI1UeUrnyVQh9urUXun2NjhsDqpP7BseSyAQ968QbS6Ry/oj6eCQW2WTbXzPg/LKgKHOLnjuh81f5Fqj6OA593ksLTkWljdYPP65bTA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xaF1w8VO8XGhwWF/rwXqBwwfIRSACmUXPpupGkJsg4w=; b=mmb8uDEMOOroi4qPHNIlsweSitULAKSodtaCMT22XlYr+d0AX0i7EX84Bk1F45Skwr0+RvdSOxBNoWTAQBT/+4SEUbtW7zzqLkX7N6WSJFDtiC8ormzzHzfgSOggcAhgWNcZ8oJyBKO73iMA1myMQs+O6U0jU4FLsV/B89jowXurgCyqUY+Xque4oO0tYq5ZiXdf0GGTGmpBJg4ScbMPdSPEmJi0ST6Qq4QmVj7+BelnMYQsFK1hpRVPW6SRYkZ2amzJIvO9LgDsDWadFWVOBzkUUSjuZ5SxiHYPjTuymmxS3zZIXezeaXh19meUZmA5/tmvE26zTry4+SbSIvY5Fg== Received: from TYZPR01MB5556.apcprd01.prod.exchangelabs.com (2603:1096:400:363::9) by SI2PR01MB4396.apcprd01.prod.exchangelabs.com (2603:1096:4:1b3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 17:25:00 +0000 Received: from TYZPR01MB5556.apcprd01.prod.exchangelabs.com ([fe80::5b31:f8db:585d:f204]) by TYZPR01MB5556.apcprd01.prod.exchangelabs.com ([fe80::5b31:f8db:585d:f204%7]) with mapi id 15.20.6411.021; Wed, 7 Jun 2023 17:25:00 +0000 From: Ziyang Huang To: kvalo@kernel.org Cc: quic_srirrama@quicinc.com, quic_kathirve@quicinc.com, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyang Huang Subject: [PATCH 1/3] wifi: ath11k: Add missing ops config for IPQ5018 in ath11k_ahb_probe() Date: Wed, 7 Jun 2023 17:24:37 +0000 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: References: X-TMN: [FpcJ3u87YcuYIGVpuOHeodVHoyG3T5CiLiZxi8nKzY0=] X-ClientProxiedBy: PH7PR13CA0024.namprd13.prod.outlook.com (2603:10b6:510:174::10) To TYZPR01MB5556.apcprd01.prod.exchangelabs.com (2603:1096:400:363::9) X-Microsoft-Original-Message-ID: <20230607172439.2258343-1-hzyitc@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR01MB5556:EE_|SI2PR01MB4396:EE_ X-MS-Office365-Filtering-Correlation-Id: 63519b4f-7301-4026-0dec-08db677c1eef X-MS-Exchange-SLBlob-MailProps: znQPCv1HvwXpdfrfzfVGwTZpgc3WKBgZZ1x/hoAx3TQvdZC6sFjWhcwX0ir1I2cIEhkvHSWBESfoG09YSU24NzA9ot1wvFy6BLe5lj+BX4Dkr19NxMrueaRzCFuFwpIPCcsuYQ1swXUabgn49B8/1p6IsyeiUUhBjYI9vrIda8Ui5cTWQj9+5tvLWIRTDMHBBqva98TIYZz/0dKhpPe8fvv1aCoNCCv9vbfagmS9b/mgsFlOcUt0ZGntSWsyYsNrOsBIgrVNtMi6/Xe1ctiNBGit3606KK/8ZzCJFrvNBN8+XwZGzVOMb3nFfFohv0oY77B/O6IZ9h3EgRsSmcjMAbq3HPo0QaPnhFMCKPqea3tgR00DuR3IXzITjxOSH2bGjsSrQcySOdfWI9R137v8ap6lyAN54rUFfxZOvGo7JsvtYPiQaXH1P3KZzKybw3uI0DhMjOg8a6elmV3aaVyQcSgOwHGeX0huj0GtT5otOcte45eHg5HGZvM3PMP/Yh5yhWCxJlGtimpsNrRkQnjHmT5mKY4393MmDh6rVV4F12G/GH+f41+1BuVvOZ4BFo+7Oi7MQZzpDG2FEjpjF/zVvjccZa4TgJusXd2s1tkMRBEhybVbh/pTrjTQZGsh+RyTiRKUGgXBkYb/2ejR3LVWWyQQe4VQRymZnqGW7K39eObeb33xyYlh6witzPQia2qCCYAtWZBpykxGJTqZ0NPMau0AWxJSeU8+6YUKeZABTVHfxcINN0rMZ+Vx0HxbXaLBfot4J6XoSn4= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cwxCwGq1uKCwIuX63DcBHzr/QYFlYrjF6mSTraBFf2XybHnlNAQANTiUvB1LgjG4TMhiBvlb0EpPspu4XI85O24aXUoUmwjQrTxDFsgtdatbv8YkCfRHiDH57XAfeLCCFB14j0k/u+vo0n3o6tec04/XScHxUcC0QyQ7B9DwvIrI8KeQnrLsk1BJ+HcDt466FYulh2sJEN8AR7iKVLgxQrp6ZQr+Kmyevq0U3vKhPHxpoR0zcAhvq+VCJjz7uFjqqHhC4AuS8jjPy6h2kBVk+CbaEXQ3wykcsMWguChVpui7MhZ3cU6OvR2Pk/pRXWHZydnrQijgROXXuqS/s/lyYaoxbA1v5YdfJOjwwOM4bQyvzjjAB+X790q6qAx51fcdp6GhWpTjVvMjFAr9J3LCzituZqIqfWKgzCTEol5nIPr2tlvUK7fhsF5hs3kFkWS6GnhhFc1f89CMKRLfVYuRF8hkdq89TnEn0Dqb0DO2H6x0RAaEeV4zEZEXFOc4Ynr4Uf94KRnev1wG1dDXE6OY89VgkskjJgu75wFVWjS/s221zL3xXoWqOyJOcsFp4+Id+HqIquYxlV8C9oOFXgLpkH5LevF+iLVoKs30t9s+xcWAqDwlJwP3yWSWa0n1COCH X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: QwyavinE5Vjncv5fbmSTgo9m7qtC4xdCDTKhZgjMfE7LRNduYhYMKBy3298k+eMoNN3n+66oF97P4O5dw4DBcrmvYnL/quX59nhatmfsE5sWp5X5G+rR2okYe/Bgm2cW6wIm5IjLw7tnVByKF2rnqjTgiF0e/M20NSfBMoCyQeZ4QpRm0F+qyXScGr0wtJIlVdg/AwUEP9QZPa5JDaIsteaiwRJbZKqB7mrCW9QkZvtEMKEB79WaTx2Z9DHWIWjYVd2a3tc+3SQynYZLyknJf9oCJOxGvKPE3rGzcNWq2dDKIgkLgYUezGBiCRw6PjAKQUcmPm410BiiL+1RnEM8K9NxSwKOXQv7iUKrUGyxODCB/8RhxEgLHZZkjRcXoZC1wx7kFZEWJwhrmxS0Ba/u+OnJZ+DlIoDpl1Rekgwh27IZzsJtVCMeN+dVjwEQMMJzalEAN54SYvWPd3qHLN4JsIRffMfMfYo+HdB2C5nsihDWipBmObbUDIJPbkSJ/0ixeWgoDk7c4aH4P/LoU6YbhYQD7wg8JD4Q2Y6EdyMfjrQTA/CbjYAQAsDM5h5jFAtdukajwyu6DUAjsGdUJe9hvAkVd092RbNyo87Mfdu68QRroXHh+1bsnD2JE0DQJl8vRGMwOXdJGH2Gcm5Wb3rNBTuDJ6rhadwte14oPOM6tihQ4+qRv+fhLLvCwKvO1j3PElIo8wcKF5OTeHmAUsBN+Gc1sIFMsClNVKtpgAJWwcseUN0acb/cBlTSlhAluWwjJklvFbhmUZ7F8+94R5d5XiOMqPj/L60ceNDBd7iotKz+crJujJjflff/fRpp9s1ZsEStllY5jlPej2yIYaD8M+WRvPMyVEeHKmXNkbpGqiJbuXdcKNrZ4pMyWUTlnyqNNNSWleAlVk2eHoWAu6FzNUw5oDtpHctv8WYs/O1pt3Vl7SGOdad0Fm1OZSZApCfW9rINHkvCnOiQRhEBvLotniHyzwFLpgBvmgzRfBDTZnP+tRhHakHa0t4dynO1xOkDmokPiThWXEOj4/XEO5l4wtYUosaLUd05ODJOqEZ3RofFT1Nqtjf5EQ6IagwlYvB3DCv2BG/3A68PILiuYhxj7dEOzW63UIRgixe+0//DOM4PoOpdsXcJh/zbxJ+IvOV4TE3Zd0tkWU2gyKQgUCZtrthi5p9UoyTX+pdxaXymSijUkts2MgjH4EvnNMPvkqA/gfLZwGojPKqdU965rvb352y1a/BGWl5uGP8228/mwRw= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 63519b4f-7301-4026-0dec-08db677c1eef X-MS-Exchange-CrossTenant-AuthSource: TYZPR01MB5556.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 17:25:00.0523 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR01MB4396 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Without this patch, the IPQ5018 WiFi will fail and print the following logs: [ 11.033179] ath11k c000000.wifi: unsupported device type 7 [ 11.033223] ath11k: probe of c000000.wifi failed with error -95 Fixes: 25edca7bb18a ("wifi: ath11k: add ipq5018 device support") Signed-off-by: Ziyang Huang --- drivers/net/wireless/ath/ath11k/ahb.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/ahb.c b/drivers/net/wireless/ath/ath11k/ahb.c index 5cbba9a8b6ba..396548e57022 100644 --- a/drivers/net/wireless/ath/ath11k/ahb.c +++ b/drivers/net/wireless/ath/ath11k/ahb.c @@ -1127,6 +1127,7 @@ static int ath11k_ahb_probe(struct platform_device *pdev) switch (hw_rev) { case ATH11K_HW_IPQ8074: case ATH11K_HW_IPQ6018_HW10: + case ATH11K_HW_IPQ5018_HW10: hif_ops = &ath11k_ahb_hif_ops_ipq8074; pci_ops = NULL; break; From patchwork Wed Jun 7 17:24:38 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ziyang Huang X-Patchwork-Id: 13271037 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3D4FC7EE25 for ; Wed, 7 Jun 2023 17:25:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230148AbjFGRZb (ORCPT ); Wed, 7 Jun 2023 13:25:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230516AbjFGRZ3 (ORCPT ); Wed, 7 Jun 2023 13:25:29 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01olkn2109.outbound.protection.outlook.com [40.92.53.109]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 320E51FC2; Wed, 7 Jun 2023 10:25:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WDUvLMgBaIcbe6GyY6XhEp+YzpaPP9wTG5rsCb2RGfutvyiy8amrMV4gYQp+hUpD/aDGoaDsLOj0gJdHeFppDGriij6fw4wDGTEcPSaO3y8dxq2Y32pJDIHjae0U3/pPKYxdAHrn8ung2Ys0CZ4IaRvUpQP2yFYr9HkWq4ATkKhVKY/8nzRocS1kXlEr+BrMIdvmoSj7aqb2CS1/MiMQBAhVBTqW4LKOvZW/ZIbo384Z9wCYeMCSdVQ8ZzdCPC4i8+sj2FyqO2jg7+l2YJi/SQ8C71lo69r5YAxOTcwqwqiUCLOU1tm1aY9J2WW9KrxuuPSfwnDd3d8VM31eiuJ8Rw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=l2VKcwdIzZLSBE9XVzaQAJrkXkRY0virbAMOibGoB+4=; b=cQzIoGGPiWV9izkYk5NhaXtO9AbzMk3Io1sTj3rZshlkEy3OT8qpeHXq40kE+Y03VXMLbBm/fUmsw6cfP3Wh+5pZybSqO0Wqk8rmr77wuakv+lZGoHFow+WnLqmEF8Kjn/T+IjFoiu6VXvS1PFMrsEJth+u2pVfOybtFJOHqfUH9sLt7qDGqVoMpRsXt0sQPQP7HkcHV6eZwNCu6VTJrKunUMMXYxxbOfV38sDvfgSkgs+kzoab0Y8vgruw4zW80/5tXjZ7fGt4vmx7ar9xheNKrFV6Ni8GuP1tfMh4TTebmFKtkA8/xlLFqqRaHJONal7KiGEyI5w46/nRMeOVkWw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=l2VKcwdIzZLSBE9XVzaQAJrkXkRY0virbAMOibGoB+4=; b=bdsY1kap8R8QAvf/sM0G7TyIul+lDKeIWJ7scdr8kesmDGPlc1z9ZkoLb42p03aIjZC9ZNtKKcgblWaCd2jLR9OIdRR6VMOj+9Sb+PhHebsWyiK/LLmwfaw7HOkq1itT1n5JvkuaY/SRVtDMTdySNpd3P/ORFk22svhnrUjnFyxh1zO6UW8fiVwnF3GpzgI1qoZEV2xTXJCa/EXd9jxdCUgQC1XKbpY+/nekXkfftjqyON1XH/Pii8ekPUzDiDBwVZmVmEDcmMXfdHLViGXpd6ZQiknGW0AqaOvNSDJTSLy8whHFWS8VVNNUKXZ60FkzlobaYfxJYP2SXq+yCA+hKQ== Received: from TYZPR01MB5556.apcprd01.prod.exchangelabs.com (2603:1096:400:363::9) by SI2PR01MB4396.apcprd01.prod.exchangelabs.com (2603:1096:4:1b3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 17:25:06 +0000 Received: from TYZPR01MB5556.apcprd01.prod.exchangelabs.com ([fe80::5b31:f8db:585d:f204]) by TYZPR01MB5556.apcprd01.prod.exchangelabs.com ([fe80::5b31:f8db:585d:f204%7]) with mapi id 15.20.6411.021; Wed, 7 Jun 2023 17:25:06 +0000 From: Ziyang Huang To: kvalo@kernel.org Cc: quic_srirrama@quicinc.com, quic_kathirve@quicinc.com, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyang Huang Subject: [PATCH 2/3] wifi: ath11k: Restart firmware after cold boot calibration for IPQ5018 Date: Wed, 7 Jun 2023 17:24:38 +0000 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230607172439.2258343-1-hzyitc@outlook.com> References: <20230607172439.2258343-1-hzyitc@outlook.com> X-TMN: [oTcwOAdqUETCwEmNZh5EpQkLpFB1DQkj3T5Dh3kx8vQ=] X-ClientProxiedBy: PH7PR13CA0024.namprd13.prod.outlook.com (2603:10b6:510:174::10) To TYZPR01MB5556.apcprd01.prod.exchangelabs.com (2603:1096:400:363::9) X-Microsoft-Original-Message-ID: <20230607172439.2258343-2-hzyitc@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR01MB5556:EE_|SI2PR01MB4396:EE_ X-MS-Office365-Filtering-Correlation-Id: 2b2b2941-f850-44c3-ef49-08db677c228b X-MS-Exchange-SLBlob-MailProps: EgT5Wr3QDKyrQfZcuz+zjlXZpgEjMWpep3TL2SFAz/CHNQ/wPfd+vbpOHMLPXfBmY59JVgkabY2C40ThEeanFPatU7qJ6E3NV7AWOeGENtWp/k3pjG16M48UuK+1nWcouXcb0dVJcv1i4d4Zyj2FolNeabs79eS714nVKqa6EuerAl+5U6ZBM0uyQy0nwpffBDFC04HjYC4oqDByUH0owxG+55bAmbqdClKB7wGWLN2J6WXjfg62rzsR5KJt3pZpp5W5qBpAOS1VuHl7WuEEd38CEGUGKI3AaOOR3XDW/RyEcOlWHg7W6itB509i9az1pPkS/pmnREDHE9UyWuEfptCLtofLgSpCyao+tmPim/wmGC6zmrA3NW3sLwEOISZ7nocT20HiFG29+TbcF4KkR/+qs3RFzIdPw8EsBAhv036MOv9IF1Omtt54nOCdsvpYsybLtCahuqZV8lM5o6JNc2AoXKBEwOTWdBoaSbpH6kuce2r2qaTNZvn0wPQYxK8jYkcfMeRGudFNL/bhi/Qaq2PgTkhj9T/w+QLsU8hIbbF6176ICIh9jE9hiRjZdfJ9XernY5CGM1YGLjj0qN89isS1KGt7ow3GeTyRPZ+VRSIdwzzdZxTpjapjJCtuhGP1ef4f5bwCNJy1wmgOd8PhUMgXI1FscTY7YHfI2PCtKWogfnATr1bA0Vav5V0d9/TdU2EFL9jpLxxFYMZiRgBZANpvCLmlCzPbOIOBPvW2FQ0= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: cjMswBtLjtoUBwrsfsEuVGw9vaO9beiW1xzk8iWvNccWMf43JpLZ8qEJECq7sr6OJvWZwpkfLfy2MlmlUaTPkTVEr0wjVbuxwZ5m/aBzgDjb5vX63S+yGX7/YkqZGcd4GUS/HkEwKeDY6dqdBletzSkZhE3p6VcBLQn4byvr6eSbW56qrBT5neBaMluiDQs7jSYIUjE9J+Jeh+UUfbyGyNaFxIrremq39Xt9gOigAwV/7C5iVUdvMw9TdMRmPsieXREK+hRNtAex71J3WGFDSXl4C0qLgCu9OEeZMrmmmnR5Bfkh98UhMBZHXWzfEgwQZJjsvLMqkj+lRwjvqoQWQoPFa7/hbe82/UDVX1iwcG+turCMcebZYiLhFZyaCztfvXvFqsdVqzhqp58hBOetq/pp1WKRq2U98c71EHZMPGnvReCu6X+877HLcrrb02VE4+wOw1yk/HFs/i3vZAWrBFHOzGpKM2TWTtkRt6MQMtpew76aoioD3lAvRbtKjoAsR7Rg3Do3sESjKx6hChNQplulwXrISP916dkOQlMSt0CgGPC6oTa8TQEUr06CP/fBttVb5prOZN+syVNe+MSDXsCY5Og6ngKFAv+2LLVEomocC4oWmDSijrypUZ9bnWgv X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: 5Wwv5T+VR/Ozj2zn+s3QjZQ9MNxY1/cfQ4HhapCtCclXiU+tdPIQGI/7/MtYs8W3xpbNtODgF3IRXt/v9diLJkGUgF4Vd2rJcTeYtbQpih45C+w4u1c5CxfXXWBpbNE69wT1C5s6kzhvMA7Lz7xH3EPjPRimkk2SSI/IAH87I3TCbkPGLOo9G/ahsurrVp6pUUTgaAhhFjujg9g4SQWBR0s31lIANvroYs5P7p+17n5y0piRUUHgFj7NZqwFdUugGDhQhoQKM5dFP9Uv/WyGkhD7RmwNDlNi6omFHBlJDYV4BQmavivxHgYYz7r92U4KNdW9HeTE3eO5JHvEs7aC+vShfgVMuZq+JqfFMv9gOj7lc06HI+jfhjl/zV0QMapZX4JgIDGDjBEkXpIeYJofoIDh/fzNCBxJjFfCJQUI2XDuVvvq7BxA4ObScap7TmvG6y95Kb04VixE8hHUFESYzPhqVMP2OryC5pMat1MU5410dbNnvGbn8rl0yHp2GE6pgO7Ej7ZZCXq77u4xVGR/wEkoW9JilIum6j2tbyFEfZarfOuhAUzequHrgnn0t/0qvkuqGOttHLLaNnQw5NYf0OzXyUO+YsZ1MsO0dUNj3EvLcSOEuslDQjQ9cyIyHcbzfrVY4Fg9RW/aJAiu3xTzqbD8IQtuBEjlCUGiQl4hD1d4G78NlWMgXUtUrN/UlVTpzrV0P99Gw6prn9b/BUq2TeK5Du3PY8mqk859ABYl6avYW7Eo3Lr6fQ92vducFQYaDudtaPPzQ1RoNtsy7zfmu8pdMpE/k+7ostjo3Lz1Y0S5rsT7Pg9BdVqAN3YTRINnO6q+fAxKTEZNiYVFld+5QK06jV6X82VFv01vcthu/++qX8dvdjxJXNG63huJ9ZoBXAxCP+v/6xNoYedjAVFKQ3XKr/HfyIZueC5+0Vub98cClOTPr0bzyivIuGOUiXMsPdsyxDhtFburCEnaAdV0xsuTfgoF1UJUfU7HfOTvl0T1rd5fJ0W6L6zH4C674lSTw78EwlTW77PfJY9bHr8d/xzFh6p0mt1QO8WCGUiIaeMoAjr6g1KIWzz+QcY4FYDqY1pYurTPtT6o+z6msDU5rDuPRPVda7KCAeHSjvZXhy+ctKzCFWrPxBRKr7QNQkKKHMlAgFazrQkpnIz7JThTKOCLeQKA5F31SBEF3xD1VeCW9y6NA1tytisN/q+AUJjiqmqpaM6Lov9m3XAhZQQuIn87OHHq6RQTrC540sX1jro= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2b2b2941-f850-44c3-ef49-08db677c228b X-MS-Exchange-CrossTenant-AuthSource: TYZPR01MB5556.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 17:25:06.0928 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR01MB4396 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Restart is required after cold boot calibration on IPQ5018. Otherwise, we get the following exception: [ 14.412829] qcom-q6-mpd cd00000.remoteproc: fatal error received: err_smem_ver.2.1: [ 14.412829] QC Image Version : QC_IMAGE_VERSION_STRING=WLAN.HK.2.6.0.1-00974-QCAHKSWPL_SILICONZ-1 [ 14.412829] Image Variant : IMAGE_VARIANT_STRING=5018.wlanfw2.map_spr_spr_evalQ [ 14.412829] DALSysLogEvent.c:174 Assertion 0 failed param0 :zero,param1 :zero,param2 :zero [ 14.412829] Thread ID : 0x00000048 Thread name : WLAN RT0 Process ID : 0x00000001 Process name :wlan0 [ 14.412829] [ 14.412829] Registers: [ 14.412829] SP : 0x4c81c120 [ 14.412829] FP : 0x4c81c138 [ 14.412829] PC : 0xb022c590 [ 14.412829] SSR : 0x00000000 [ 14.412829] BADVA : 0x00000000 [ 14.412829] LR : 0xb0008490 [ 14.412829] [ 14.412829] StackDump [ 14.412829] from:0x4c81c120 [ 14.412829] to: 0x00000000: [ 14.412829] [ 14.463006] remoteproc remoteproc0: crash detected in cd00000.remoteproc: type fatal error Fixes: 8dfe875aa24a ("wifi: ath11k: update hw params for IPQ5018") Signed-off-by: Ziyang Huang --- drivers/net/wireless/ath/ath11k/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/wireless/ath/ath11k/core.c b/drivers/net/wireless/ath/ath11k/core.c index b1b90bd34d67..9de23c11e18b 100644 --- a/drivers/net/wireless/ath/ath11k/core.c +++ b/drivers/net/wireless/ath/ath11k/core.c @@ -664,6 +664,7 @@ static const struct ath11k_hw_params ath11k_hw_params[] = { .hal_params = &ath11k_hw_hal_params_ipq8074, .single_pdev_only = false, .cold_boot_calib = true, + .cbcal_restart_fw = true, .fix_l1ss = true, .supports_dynamic_smps_6ghz = false, .alloc_cacheable_memory = true, From patchwork Wed Jun 7 17:24:39 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ziyang Huang X-Patchwork-Id: 13271038 X-Patchwork-Delegate: kvalo@adurom.com Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 88834C7EE23 for ; Wed, 7 Jun 2023 17:25:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231831AbjFGRZq (ORCPT ); Wed, 7 Jun 2023 13:25:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58626 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230496AbjFGRZf (ORCPT ); Wed, 7 Jun 2023 13:25:35 -0400 Received: from APC01-SG2-obe.outbound.protection.outlook.com (mail-sgaapc01olkn2109.outbound.protection.outlook.com [40.92.53.109]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3152C1FFC; Wed, 7 Jun 2023 10:25:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oSjdaadQECMUkXwEnX+CSAEwtkZEtrAT0Yyd0vGOnZNtm+6vmVsTnSLKtcdSZogGZ2B2SNdW3L8ZeWpLc9+cVwx8QVX6y2LlSrsUfmPMrKYTUH5gBnEM50qbLUWMiuqVfXgeifvySPSi0slVGTjrB+9p/FuAhEHVfMFO/0+OWkP+5/59gk6op5w7bmBmNswugFezV+c3U+vUixKsgkgTFSu723zLLTxMT/YT5kYebx47ds1rpYcBRMkd8L2JVwZFnpLADxopBbHnnbczGsnF8LwDqwFNYYZN8vEztpRn/dpalvqwsrHx5dUFGRGfOjlMXLeL2nZQprooreSOjZ6tdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=bjsFZDOeFbXmZ/FHpET+aoUUHIz8zXWVptnl36q3kdk=; b=X7fWRoQY0xWozCBq/MEp6fRpIYpTa4BuOlE+bo4i9WI9+coacL2xGxFXx9L8YKyTNgtz7Xjl6TyNAE05hvgsKXE8tsPq969etvN16nS+vPIBJQivKWgY/RkVd4cZjGQGF2ko20sw7UkSpD5UzS29Sk5hZBQcmqUP1WgZ7HgQWwZ59C18pitWlpLieFDkJIQRtYvVdOr/TnQqFRQkoSMNf/ZSvnUsZIe0Ci/RTajNWRWiZ3uWbA321tqKYvTpBsxkYnK2ltZ2wV9wzIsDKLXVttLIRxSz+QW5YNNNM/6Pam7SPslbDUD1Ffeum9vvdKf0rCpxY7xQI/YZIKUIPOqAug== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bjsFZDOeFbXmZ/FHpET+aoUUHIz8zXWVptnl36q3kdk=; b=l9VYAJOhwGcaajqpRItul5um3z+0AMeSGRvvIK9yAvOyK2cuGmRG3QxETWs5dcridgpjz59du938ZOXpOqu3qEJplsmSqR0xAKqd5crYbcoX8aktQU0tKAiNPo+q3F9jUqj3+lPVhckhs30ZFNyvIO5UjtBkH5wgNmt2FJxLocUw4IqxobkB89axIuyxCNRwT0E+wLBQnBmE5a/cWLb1+3EpaxpD9CgOJlNN1mtn2jbCT5p0uSxX8yQORH3t7aiaG0R29FXt9sgpiI5lQEXWU5D3d7lz/d+FajBfbJNFji8IiWBiciZvk4m6pA0UhtB1u7SJXjaqLQW9sZ80f07zkQ== Received: from TYZPR01MB5556.apcprd01.prod.exchangelabs.com (2603:1096:400:363::9) by SI2PR01MB4396.apcprd01.prod.exchangelabs.com (2603:1096:4:1b3::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6455.32; Wed, 7 Jun 2023 17:25:10 +0000 Received: from TYZPR01MB5556.apcprd01.prod.exchangelabs.com ([fe80::5b31:f8db:585d:f204]) by TYZPR01MB5556.apcprd01.prod.exchangelabs.com ([fe80::5b31:f8db:585d:f204%7]) with mapi id 15.20.6411.021; Wed, 7 Jun 2023 17:25:10 +0000 From: Ziyang Huang To: kvalo@kernel.org Cc: quic_srirrama@quicinc.com, quic_kathirve@quicinc.com, ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Ziyang Huang Subject: [PATCH 3/3] wifi: ath11k: Add missing hw_ops->get_ring_selector() for IPQ5018 Date: Wed, 7 Jun 2023 17:24:39 +0000 Message-ID: X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230607172439.2258343-1-hzyitc@outlook.com> References: <20230607172439.2258343-1-hzyitc@outlook.com> X-TMN: [S1vJLvpyVh2ZDXzIU2XfyMIll0s/yY3wNMkNpYrMtzE=] X-ClientProxiedBy: PH7PR13CA0024.namprd13.prod.outlook.com (2603:10b6:510:174::10) To TYZPR01MB5556.apcprd01.prod.exchangelabs.com (2603:1096:400:363::9) X-Microsoft-Original-Message-ID: <20230607172439.2258343-3-hzyitc@outlook.com> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: TYZPR01MB5556:EE_|SI2PR01MB4396:EE_ X-MS-Office365-Filtering-Correlation-Id: c6b03e03-fec9-4ce7-512a-08db677c2533 X-MS-Exchange-SLBlob-MailProps: AZnQBsB9Xmoiyiq1W/GNGVw8decNWbLwvhgVJWAqOg6Loi2mrNdp7493WXjId/ZjOljL6/3gWVHZksCFo6DEsqFO9bOSq6MfuHlb0dZXM0jvaunchaTH7DQ1+QxZA74zEzHfYRY+at9KtI9aySzVpTUgGuOC/jQFlx1KlUFbjbUit3wQcjTpZ8aFDzhlFHWARhvNpThBRsBYAlcJ8EiLmGExWcOynCkEiGdIt+3DgGvQnUlrzqrnE0Upr90gR4bM5XMjN1RbQCNKq1vOTVGKBSMoNQebrDjVlP4PEndfdaYtW4Iw6XZEFOqcGJ/8wHRkOquhrELlDRTVBinD9vIJjGmpK9N9ywBS9Oiwo9CRhiR64aJcSx25W02l+eComIl9fyZkADb3gORCdxY3HkJoK7edazNF8WlLcU5yPqBUzRcsAY1djo4oBPLEm6o0wd/pDQg/c0tNHgRPTTaLSz2tyKtqOMenSqIzgiO0tQjzhIsLMM0UPe4zSo1EDyNLvIGXxbqQz7l5j6lecwqWU+x12IDdsicO2XyOE+mkyaW11M+oR3vwoMrQIxCjhNaw5e1FJl/eH95xwwpfgoa0Hb10u983eoLrI36ACtf5EjVqCVNy43e9i/MYJTh/v89Tb0GkDC1tR3IEdByt8f68jAK5sJVCAQXvoJmUiEEkmguwy02sCZ7hwL6Z+pIYFTlINVenjKZK3+2kNQxpfeHE0vvqji0CQp0Rc1RtwGnMCdXQF2ksK4ZTQYMwjwC7n8hUHm0oyfgwvbmKMiE= X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: K0pUCniQrpWtjCV4WSggYStx4Re7lDaXWiQ9x7+3Uhqpv/AbI0r8w2L/QOClC5crviAulRtyxWnwToH8jNhsDlveg5OtvTL1biuDjyp7YKkg+kqSEYav8kg8P5kjPEncGbcT3NcHK4NwkpPN/KT1T7BGRcXxpY1ts3cF7k11/Qp1SBE4ATaFvebFe5OL5VCV7CB+TQboY62BsrcmEmfkvvK5YES7yJMduLwAnep2wIWGnrmCDXI5m16AmJ4ofoupnGfZgLDGc7PpIBACvOcZ5zwAzncQ7YG+Lf0Zxu8QJ6zwTOkJKlFsmbl0rsjepI5YEtkT/cFgJzc3ZuxT5HdUPGhvQWAyL5i0FCnFoduR71rAuyefnUhZjM/0a2425K0Jjn3cVMa3COeT0+HqkiUppY8asVSJQR327NEuiul7UJYNzpn0EOhR4Osk4zLtGzcpgq2saIrcQqCO80pKheNoe5VGcFDosEzNR8wRvBHB1SFejCRMjV7i1OGOjm9GsSO8zwoy2aP0P1UFIgz/jojd+NCuZTQexbFzGm8Qd9Jy2iMnyrN4zCqTPGydul02mpQ1yzVFx+1nt+UZaBYdCHDUn1KUYDMEXGlhf0LF508YoL6PEqb/nIWrI9lJuRgPa5VF X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: SlS+rE8gquezvfY5B/geAvwAT53qV9rZr526ORx1dA7Q5chg7HFERfDebw87MnMpm4zDQjlEKL7yvs1J/wGYGCu57GnBG1bRR4A9OgpdsftQn+mpSkf7koq+urU1/90Klrp0Ut7c6aV1clSP4UYo0IBrM4f6G66upflxX6DLyAt1fnzhCGET0bvAMSUb6tPEnDtGKaGEVppkYCPuVhv/3vTs6IK0ZCa9TQKU+L+wJsKAusWEYPCh0WYMCw5epHauqzWmD6EiEjkHXFrKbg/Irkf8jHh8fJz90+9o0OpUhbkLEsmrKPIZzx9y+SnjJclBdj4i0oiJeQEzNH7ySKJMgaIaTrZSLEjB78QhVBp5zOREMhs6De7DU124q1/OJFpxFndsgYqOKBOBjlB5MA7NA2vlL/i8jFOdQO/jdR3FrZR4tIfMgb5RoFEQJM4ScRkbQGNnzL1H4wtF9hfPZQwKkU+c8dy3MGBsnHgxStqtffgJ1viWyRYRDaxC12M66hbIDkP8Xh0NE5Q3DtNJf614zp1AB38iqfYUfKwbIljvR7qnxGtMM/whKabEbnmnG1lVr8nlwvfqMymSCvbGaEUVk38+OUPbTe1hQteuSN4u67EoP8C5FBaidzmoy/bmAstmuW6KjR8Cwi2Slw5WfXQ677PbxG8M+CYuCEbqQcu2oCqgnKgfslMmxuKTwFeCV2HWXyNtAgUFbCbvVnkQqG5cXFvKGMupBxwH+d2bTcc8BDDjHN1g+s2iVru7oHbJAl70vlDKVVtO9VTIc2wCOwdyrkKkVoYF1NtagHEzXM2RVzSQauQTK3E0sFspTC+P9y7bl38flXR1vkZwlkbuFkvMSe3FyfhHCsfMN5pkMeBwq2Cj+e+HK+SRR00ozgM9tOM2dtGpNmsCs9O/sbLWKSKMyEWVpkM+86duekv9HuNDf2vkTmlsu7WK+z7BzSq5EXJvyqzDQvwYAcw24Tq8+3WIyvUHlK2SdNCOECFrbNr2P4MuoW7eoCufM3x0Ve10TiTVS4oG7B6n+bM52DzABAzGZ2a99mS4wv1gKg0++YsSCB3Agj60vs6dvUX8SFFnpFKkfSmidTOLU2Ls2ifhMdQ1u1YQvEMcAoVRQ6OcQmo3H9BiVdaG8RAbwJd0kWeOxh8sWkaH9mzF8dBNlnDrQmQAa43jaxe0biavx7oJMFqGokJzfsMWc/ymA0kgp//e+pNxQTo0+hy/NdwQfzSCtBR2NR2B/wSmQbCXfsjMffp4wVA= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: c6b03e03-fec9-4ce7-512a-08db677c2533 X-MS-Exchange-CrossTenant-AuthSource: TYZPR01MB5556.apcprd01.prod.exchangelabs.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Jun 2023 17:25:10.5394 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SI2PR01MB4396 Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org During sending data after clients connected, hw_ops->get_ring_selector() will be called. But for IPQ5018, this member isn't set, and the following NULL pointer exception will be occurred: [ 38.840478] 8<--- cut here --- [ 38.840517] Unable to handle kernel NULL pointer dereference at virtual address 00000000 ... [ 38.923161] PC is at 0x0 [ 38.927930] LR is at ath11k_dp_tx+0x70/0x730 [ath11k] ... [ 39.063264] Process hostapd (pid: 1034, stack limit = 0x801ceb3d) [ 39.068994] Stack: (0x856a9a68 to 0x856aa000) ... [ 39.438467] [<7f323804>] (ath11k_dp_tx [ath11k]) from [<7f314e6c>] (ath11k_mac_op_tx+0x80/0x190 [ath11k]) [ 39.446607] [<7f314e6c>] (ath11k_mac_op_tx [ath11k]) from [<7f17dbe0>] (ieee80211_handle_wake_tx_queue+0x7c/0xc0 [mac80211]) [ 39.456162] [<7f17dbe0>] (ieee80211_handle_wake_tx_queue [mac80211]) from [<7f174450>] (ieee80211_probereq_get+0x584/0x704 [mac80211]) [ 39.467443] [<7f174450>] (ieee80211_probereq_get [mac80211]) from [<7f178c40>] (ieee80211_tx_prepare_skb+0x1f8/0x248 [mac80211]) [ 39.479334] [<7f178c40>] (ieee80211_tx_prepare_skb [mac80211]) from [<7f179e28>] (__ieee80211_subif_start_xmit+0x32c/0x3d4 [mac80211]) [ 39.491053] [<7f179e28>] (__ieee80211_subif_start_xmit [mac80211]) from [<7f17af08>] (ieee80211_tx_control_port+0x19c/0x288 [mac80211]) [ 39.502946] [<7f17af08>] (ieee80211_tx_control_port [mac80211]) from [<7f0fc704>] (nl80211_tx_control_port+0x174/0x1d4 [cfg80211]) [ 39.515017] [<7f0fc704>] (nl80211_tx_control_port [cfg80211]) from [<808ceac4>] (genl_rcv_msg+0x154/0x340) [ 39.526814] [<808ceac4>] (genl_rcv_msg) from [<808cdb74>] (netlink_rcv_skb+0xb8/0x11c) [ 39.536446] [<808cdb74>] (netlink_rcv_skb) from [<808ce1d0>] (genl_rcv+0x28/0x34) [ 39.544344] [<808ce1d0>] (genl_rcv) from [<808cd234>] (netlink_unicast+0x174/0x274) [ 39.551895] [<808cd234>] (netlink_unicast) from [<808cd510>] (netlink_sendmsg+0x1dc/0x440) [ 39.559362] [<808cd510>] (netlink_sendmsg) from [<808596e0>] (____sys_sendmsg+0x1a8/0x1fc) [ 39.567697] [<808596e0>] (____sys_sendmsg) from [<8085b1a8>] (___sys_sendmsg+0xa4/0xdc) [ 39.575941] [<8085b1a8>] (___sys_sendmsg) from [<8085b310>] (sys_sendmsg+0x44/0x74) [ 39.583841] [<8085b310>] (sys_sendmsg) from [<80300060>] (ret_fast_syscall+0x0/0x40) ... [ 39.620734] Code: bad PC value [ 39.625869] ---[ end trace 8aef983ad3cbc032 ]--- Fixes: ba60f2793d3a ("wifi: ath11k: initialize hw_ops for IPQ5018") Signed-off-by: Ziyang Huang --- drivers/net/wireless/ath/ath11k/hw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/wireless/ath/ath11k/hw.c b/drivers/net/wireless/ath/ath11k/hw.c index eb995f9cf0fa..72797289b33e 100644 --- a/drivers/net/wireless/ath/ath11k/hw.c +++ b/drivers/net/wireless/ath/ath11k/hw.c @@ -1175,7 +1175,7 @@ const struct ath11k_hw_ops ipq5018_ops = { .mpdu_info_get_peerid = ath11k_hw_ipq8074_mpdu_info_get_peerid, .rx_desc_mac_addr2_valid = ath11k_hw_ipq9074_rx_desc_mac_addr2_valid, .rx_desc_mpdu_start_addr2 = ath11k_hw_ipq9074_rx_desc_mpdu_start_addr2, - + .get_ring_selector = ath11k_hw_ipq8074_get_tcl_ring_selector, }; #define ATH11K_TX_RING_MASK_0 BIT(0)