From patchwork Wed Jun 28 16:29:45 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13296054 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B771EB64DA for ; Wed, 28 Jun 2023 16:30:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D7A3F10E37C; Wed, 28 Jun 2023 16:29:57 +0000 (UTC) Received: from mail-lj1-x22c.google.com (mail-lj1-x22c.google.com [IPv6:2a00:1450:4864:20::22c]) by gabe.freedesktop.org (Postfix) with ESMTPS id 52AF110E377 for ; Wed, 28 Jun 2023 16:29:51 +0000 (UTC) Received: by mail-lj1-x22c.google.com with SMTP id 38308e7fff4ca-2b698dd515dso66344171fa.3 for ; Wed, 28 Jun 2023 09:29:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687969789; x=1690561789; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k9KnMtZLR40pDXGElESmmZUvDm4CZ/ghYZ4Hvek4pbQ=; b=m1/0vpJU7e/vmira8hvb7shwcPdAr25+sj5szdqtuv4qnL85+sOOo/xfk7nVR4wSbF 8cK9NOV8cxuLtUEDAnyiO+S4B0oPjEvOBGvy6r7HmD40YUyFOvf57zr/6ZZr5vKBFWo7 SdTrH7sqljfa9vtyGc9Oa+zOD9UPUKOAhP4xIBk+e4GxAzZCPw3XRDsPt8JufSTJ8N+2 ibbABJN6DcwG3X1McvSxXbbJknNaMyAuM4W+XL8TL2bP78Fe9B25xRScrpWCvGqr96V9 zjpxFkw4nFFWuvUlf/p2tZkmFFApu2xqbsyQeLJZcrVoMs3ejMNDWRv9cO4BjxgNCm68 LQ7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687969789; x=1690561789; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k9KnMtZLR40pDXGElESmmZUvDm4CZ/ghYZ4Hvek4pbQ=; b=HXOLRhwVZXjcTnnrWyrncXG7bOOJ1OrnnqWR/I85qQAOnd90cjYmIxsRSA7Liwcbmn jYuljtIcVGQMt0Y9zJMN2CBAVJPKpITcHv9+509e8csDCtceycakHp/pXZu9M3IAGGwr Ate4bolVBJ/x7ti3H04/n07cSd5U0tTA3VrydPKEJwfMsA05yc/8f/kkVdwApYk9AswL dXDFDesHdYMUORhNvomaw08JSrcM0P7gKaCYypl9IXCbqIqP5Y2oiVKyXx/rtNTbfEpM gX9605RWVeiMC1D2mtjZCQjwCuoY4qBZZxfP9ZPam6si/sLCbu55P8wexCi0bmHlOf51 sesg== X-Gm-Message-State: AC+VfDxMNRRZO1NBZP4cFaNtsjD0vPHoyXkpbnzLOmZ34LLx+AihKcUu wodLrFuRJhplY5+xpdMYCAf8ng== X-Google-Smtp-Source: ACHHUZ5DA8AehWO58Dkwqvm39GPuJsu46ahFH3l4cIqAJIyjqBRvcGw8M9F4RnDDYxcvk8eLPANVTg== X-Received: by 2002:ac2:4f07:0:b0:4f9:6528:fb15 with SMTP id k7-20020ac24f07000000b004f96528fb15mr14393398lfr.12.1687969788869; Wed, 28 Jun 2023 09:29:48 -0700 (PDT) Received: from [192.168.1.101] (abyk82.neoplus.adsl.tpnet.pl. [83.9.30.82]) by smtp.gmail.com with ESMTPSA id v28-20020a056512049c00b004faeedbb29dsm1678783lfq.64.2023.06.28.09.29.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 09:29:48 -0700 (PDT) From: Konrad Dybcio Date: Wed, 28 Jun 2023 18:29:45 +0200 Subject: [PATCH 1/4] dt-bindings: regulator: Describe Qualcomm REFGEN regulator MIME-Version: 1.0 Message-Id: <20230628-topic-refgen-v1-1-126e59573eeb@linaro.org> References: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> In-Reply-To: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> To: Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687969785; l=2253; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=E6OpwKaLxLMqeufp2J5Sb8wXLqiG8TBOqY/1j2yTMwM=; b=Fl3PQ2gQQ2JC6dxfvdudrWKD2Y7+XzJSj9IfqR6O8URn9dgYJuKM7wqNx30GKtD2rIIg/tfEy qr+tcyV4xcrAYut9JAKjPW+iBve7g+7t66P2/sjfsFVzrZkhOqZAd+H X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Konrad Dybcio , Marijn Suijten , freedreno@lists.freedesktop.org, Konrad Dybcio Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. It's controlled through MMIO and we can toggle it or read its state back. Describe it. Signed-off-by: Konrad Dybcio --- .../regulator/qcom,sdm845-refgen-regulator.yaml | 56 ++++++++++++++++++++++ 1 file changed, 56 insertions(+) diff --git a/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml new file mode 100644 index 000000000000..19d3eb9db98f --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/qcom,sdm845-refgen-regulator.yaml @@ -0,0 +1,56 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/qcom,sdm845-refgen-regulator.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm Technologies, Inc. REFGEN Regulator + +maintainers: + - Konrad Dybcio + +description: | + The REFGEN (reference voltage renegator) regulator provides reference + voltage for on-chip IPs (like PHYs) on some Qualcomm SoCs. + +allOf: + - $ref: regulator.yaml# + +properties: + compatible: + oneOf: + - items: + - enum: + - qcom,sc7180-refgen-regulator + - qcom,sc8180x-refgen-regulator + - qcom,sm8150-refgen-regulator + - const: qcom,sdm845-refgen-regulator + + - items: + - enum: + - qcom,sc7280-refgen-regulator + - qcom,sc8280xp-refgen-regulator + - qcom,sm6350-refgen-regulator + - qcom,sm6375-refgen-regulator + - qcom,sm8350-refgen-regulator + - const: qcom,sm8250-refgen-regulator + + - enum: + - qcom,sdm845-refgen-regulator + - qcom,sm8250-refgen-regulator + + reg: true + +required: + - compatible + - reg + +unevaluatedProperties: false + +examples: + - | + regulator@162f000 { + compatible = "qcom,sm8250-refgen-regulator"; + reg = <0 0x0162f000 0 0x84>; + }; +... From patchwork Wed Jun 28 16:29:46 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13296053 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F12BEB64D7 for ; Wed, 28 Jun 2023 16:29:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 476F610E37B; Wed, 28 Jun 2023 16:29:56 +0000 (UTC) Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3E89010E37B for ; Wed, 28 Jun 2023 16:29:53 +0000 (UTC) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b699a2fe86so67814341fa.3 for ; Wed, 28 Jun 2023 09:29:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687969791; x=1690561791; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=3O7/8dc5GSHiu5z4ltCF1O6EcsodTXplnyycC64HxP8=; b=sc7OSEXAmym4AYx+twt7Awti6LbhsI/Tf7SayEzAimJ37RTgR1C+ZvoK5uRqP17Bk+ 6tYC26hJoMwOkRHUddIyXEaYQX+fUzGf8w8efx7xFHwye/PXXZkOBktMWkJ3NKIndTo1 y041bAS200dAttLn9ORND4RzJWkXrPXu/LCHGso2bukyDVgLqyBf/kxLBGYSKcPQwA/s M+UtH55xtE5bcwdvOlHBbumf/rzI0fHyhDXlka3cUtLrLTht5inpM4p0UfkhofDte4eu JKtAFbYDB2aoYfCuvszi7kc+KTmlMBSW2RN9U2E7/hEDuKIL7M5v9jDBGamjmUz+c2OF bh8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687969791; x=1690561791; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=3O7/8dc5GSHiu5z4ltCF1O6EcsodTXplnyycC64HxP8=; b=FFHgemw10LC5Vi/nGDzQzTukDUphS9uqbLZZ/wsWNa+/7w/U4Iu5hPoku5Ms+MGmof AdaRp30ufD3pn1We0yH9EIzh+wK9pVnrQllHLKP2rcGAxBEyAaNT0kHslqzF9J0B4K73 ydfkN62O9PzDNIt5oxfb2xTy+WZzvPbRkzW99ola4eNi6v1RsqAfsEdHZiOaTaiciIln PYwgN96kcxQt9zYxoJWTCooLVYMQd4cr1bEbolyTejOVmPYsMVTVz87sZ3BWk14Usbpi 0NpgHvgODM4V334cb3zti4TVNipEnsK4CcTbYNOEGfQGk4CHR0aJ82R00bSIgQBklD9U xRDQ== X-Gm-Message-State: AC+VfDxdrNuungt6HXLzbJEjTPYNDUACkv/2lJ1hbuyWoxp68qlXriT8 +DvNaifbIs3b+l/pFmTtHtL04Q== X-Google-Smtp-Source: ACHHUZ5q8ETxboNpBER9trv4PZjsbiQVNkYRZRA2DMU/96YNvRV9S7QtW1GTNt4Xr68tMiJYV+mh9A== X-Received: by 2002:a05:6512:224f:b0:4fb:7b4c:d38c with SMTP id i15-20020a056512224f00b004fb7b4cd38cmr6687850lfu.60.1687969790950; Wed, 28 Jun 2023 09:29:50 -0700 (PDT) Received: from [192.168.1.101] (abyk82.neoplus.adsl.tpnet.pl. [83.9.30.82]) by smtp.gmail.com with ESMTPSA id v28-20020a056512049c00b004faeedbb29dsm1678783lfq.64.2023.06.28.09.29.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 09:29:50 -0700 (PDT) From: Konrad Dybcio Date: Wed, 28 Jun 2023 18:29:46 +0200 Subject: [PATCH 2/4] regulator: Introduce Qualcomm REFGEN regulator driver MIME-Version: 1.0 Message-Id: <20230628-topic-refgen-v1-2-126e59573eeb@linaro.org> References: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> In-Reply-To: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> To: Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687969785; l=7718; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=cLuCOydeuQxZpxQ1jarab69rCq1J+CL/0LN9pVBus9k=; b=z5Dv3I0gno4CqdlcpHcPFnKPKgajDU/Cm6GfWD4HwWQEu7jM2JBafkwMhhhLcdIqbLKnlIadh OFbUyw4EO7oCwfSVA179BDOQMJxmnzJzKj8957lrmXV4CEsnJowBbMe X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Konrad Dybcio , Marijn Suijten , freedreno@lists.freedesktop.org, Konrad Dybcio Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Modern Qualcomm SoCs have a REFGEN (reference voltage generator) regulator, providing reference voltage to on-chip IP, like PHYs. Add a driver to support toggling that regulator. This driver is based on the driver available in the downstream msm-5.4 kernel. It's been cleaned up and partly remade to match upstream standards. Signed-off-by: Konrad Dybcio --- drivers/regulator/Kconfig | 10 ++ drivers/regulator/Makefile | 1 + drivers/regulator/qcom-refgen-regulator.c | 187 ++++++++++++++++++++++++++++++ 3 files changed, 198 insertions(+) diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 2c2405024ace..ea5549d62825 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -978,6 +978,16 @@ config REGULATOR_PWM This driver supports PWM controlled voltage regulators. PWM duty cycle can increase or decrease the voltage. +config REGULATOR_QCOM_REFGEN + tristate "Qualcomm REFGEN regulator driver" + depends on REGMAP + help + This driver supports the MMIO-mapped reference voltage regulator, + used internally by some PHYs on many Qualcomm SoCs. + + Say M here if you want to include support for this regulator as + a module. The module will be named "qcom-refgen-regulator". + config REGULATOR_QCOM_RPM tristate "Qualcomm RPM regulator driver" depends on MFD_QCOM_RPM diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile index ebfa75379c20..a044ad20e202 100644 --- a/drivers/regulator/Makefile +++ b/drivers/regulator/Makefile @@ -107,6 +107,7 @@ obj-$(CONFIG_REGULATOR_MT6380) += mt6380-regulator.o obj-$(CONFIG_REGULATOR_MT6397) += mt6397-regulator.o obj-$(CONFIG_REGULATOR_MTK_DVFSRC) += mtk-dvfsrc-regulator.o obj-$(CONFIG_REGULATOR_QCOM_LABIBB) += qcom-labibb-regulator.o +obj-$(CONFIG_REGULATOR_QCOM_REFGEN) += qcom-refgen-regulator.o obj-$(CONFIG_REGULATOR_QCOM_RPM) += qcom_rpm-regulator.o obj-$(CONFIG_REGULATOR_QCOM_RPMH) += qcom-rpmh-regulator.o obj-$(CONFIG_REGULATOR_QCOM_SMD_RPM) += qcom_smd-regulator.o diff --git a/drivers/regulator/qcom-refgen-regulator.c b/drivers/regulator/qcom-refgen-regulator.c new file mode 100644 index 000000000000..854ab91f649c --- /dev/null +++ b/drivers/regulator/qcom-refgen-regulator.c @@ -0,0 +1,187 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* + * Copyright (c) 2017, 2019-2020, The Linux Foundation. All rights reserved. + * Copyright (c) 2023, Linaro Limited + */ + +#include +#include +#include +#include +#include +#include +#include + +#define REFGEN_REG_BIAS_EN 0x08 +#define REFGEN_BIAS_EN_MASK GENMASK(2, 0) + #define REFGEN_BIAS_EN_ENABLE 0x7 + #define REFGEN_BIAS_EN_DISABLE 0x6 + +#define REFGEN_REG_BG_CTRL 0x14 +#define REFGEN_BG_CTRL_MASK GENMASK(2, 1) + #define REFGEN_BG_CTRL_ENABLE 0x6 + #define REFGEN_BG_CTRL_DISABLE 0x4 + +#define REFGEN_REG_PWRDWN_CTRL5 0x80 +#define REFGEN_PWRDWN_CTRL5_MASK BIT(0) + #define REFGEN_PWRDWN_CTRL5_ENABLE 0x1 + #define REFGEN_PWRDWN_CTRL5_DISABLE 0x0 + +struct qcom_refgen { + struct regulator_desc rdesc; + struct regulator_dev *rdev; + void __iomem *base; +}; + +static int qcom_sdm845_refgen_enable(struct regulator_dev *rdev) +{ + struct qcom_refgen *vreg = rdev_get_drvdata(rdev); + + regmap_update_bits(vreg->base, REFGEN_REG_BG_CTRL, + REFGEN_BG_CTRL_MASK, REFGEN_BG_CTRL_ENABLE); + regmap_write(vreg->base, REFGEN_REG_BIAS_EN, REFGEN_BIAS_EN_ENABLE); + + return 0; +} + +static int qcom_sdm845_refgen_disable(struct regulator_dev *rdev) +{ + struct qcom_refgen *vreg = rdev_get_drvdata(rdev); + + regmap_write(vreg->base, REFGEN_REG_BIAS_EN, REFGEN_BIAS_EN_DISABLE); + regmap_update_bits(vreg->base, REFGEN_REG_BG_CTRL, + REFGEN_BG_CTRL_MASK, REFGEN_BG_CTRL_DISABLE); + + return 0; +} + +static int qcom_sdm845_refgen_is_enabled(struct regulator_dev *rdev) +{ + struct qcom_refgen *vreg = rdev_get_drvdata(rdev); + u32 val; + + regmap_read(vreg->base, REFGEN_REG_BG_CTRL, &val); + if (FIELD_GET(REFGEN_BG_CTRL_MASK, val) != REFGEN_BG_CTRL_ENABLE) + return 0; + + regmap_read(vreg->base, REFGEN_REG_BIAS_EN, &val); + if (FIELD_GET(REFGEN_BIAS_EN_MASK, val) != REFGEN_BIAS_EN_ENABLE) + return 0; + + return 1; +} + +static const struct regulator_ops sdm845_refgen_ops = { + .enable = qcom_sdm845_refgen_enable, + .disable = qcom_sdm845_refgen_disable, + .is_enabled = qcom_sdm845_refgen_is_enabled, +}; + +static int qcom_sm8250_refgen_enable(struct regulator_dev *rdev) +{ + struct qcom_refgen *vreg = rdev_get_drvdata(rdev); + + regmap_update_bits(vreg->base, REFGEN_REG_PWRDWN_CTRL5, + REFGEN_PWRDWN_CTRL5_MASK, REFGEN_PWRDWN_CTRL5_ENABLE); + + return 0; +} + +static int qcom_sm8250_refgen_disable(struct regulator_dev *rdev) +{ + struct qcom_refgen *vreg = rdev_get_drvdata(rdev); + + regmap_update_bits(vreg->base, REFGEN_REG_PWRDWN_CTRL5, + REFGEN_PWRDWN_CTRL5_MASK, REFGEN_PWRDWN_CTRL5_DISABLE); + + return 0; +} + +static int qcom_sm8250_refgen_is_enabled(struct regulator_dev *rdev) +{ + struct qcom_refgen *vreg = rdev_get_drvdata(rdev); + u32 val; + + regmap_read(vreg->base, REFGEN_REG_PWRDWN_CTRL5, &val); + + return FIELD_GET(REFGEN_PWRDWN_CTRL5_MASK, val) == REFGEN_PWRDWN_CTRL5_ENABLE; +} + +static const struct regulator_ops sm8250_refgen_ops = { + .enable = qcom_sm8250_refgen_enable, + .disable = qcom_sm8250_refgen_disable, + .is_enabled = qcom_sm8250_refgen_is_enabled, +}; + +static const struct regmap_config qcom_refgen_regmap_config = { + .reg_bits = 32, + .reg_stride = 4, + .val_bits = 32, + .fast_io = true, +}; + +static int qcom_refgen_probe(struct platform_device *pdev) +{ + struct regulator_init_data *init_data; + struct regulator_config config = {}; + struct device *dev = &pdev->dev; + struct regulator_desc *rdesc; + struct qcom_refgen *vreg; + void __iomem *base; + + vreg = devm_kzalloc(dev, sizeof(*vreg), GFP_KERNEL); + if (!vreg) + return -ENOMEM; + + vreg->rdesc.ops = of_device_get_match_data(dev); + if (!vreg->rdesc.ops) + return -ENODATA; + + base = devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(base)) + return PTR_ERR(base); + + vreg->base = devm_regmap_init_mmio(dev, base, &qcom_refgen_regmap_config); + if (IS_ERR(vreg->base)) + return PTR_ERR(vreg->base); + + init_data = of_get_regulator_init_data(dev, dev->of_node, &vreg->rdesc); + if (!init_data) + return -ENOMEM; + + rdesc = &vreg->rdesc; + + rdesc->name = "refgen"; + rdesc->owner = THIS_MODULE; + rdesc->type = REGULATOR_VOLTAGE; + rdesc->enable_time = 5; /* us */ + + config.dev = dev; + config.init_data = init_data; + config.driver_data = vreg; + config.of_node = dev->of_node; + + vreg->rdev = devm_regulator_register(dev, rdesc, &config); + if (IS_ERR(vreg->rdev)) + return PTR_ERR(vreg->rdev); + + return 0; +} + +static const struct of_device_id qcom_refgen_match_table[] = { + { .compatible = "qcom,sdm845-refgen-regulator", .data = &sdm845_refgen_ops }, + { .compatible = "qcom,sm8250-refgen-regulator", .data = &sm8250_refgen_ops }, + { } +}; + +static struct platform_driver qcom_refgen_driver = { + .probe = qcom_refgen_probe, + .driver = { + .name = "qcom-refgen-regulator", + .of_match_table = qcom_refgen_match_table, + }, +}; +module_platform_driver(qcom_refgen_driver); + +MODULE_LICENSE("GPL"); +MODULE_DESCRIPTION("Qualcomm REFGEN regulator driver"); From patchwork Wed Jun 28 16:29:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13296055 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 48CD3EB64DA for ; Wed, 28 Jun 2023 16:30:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4F45010E37E; Wed, 28 Jun 2023 16:29:58 +0000 (UTC) Received: from mail-lj1-x236.google.com (mail-lj1-x236.google.com [IPv6:2a00:1450:4864:20::236]) by gabe.freedesktop.org (Postfix) with ESMTPS id DEDF410E37B for ; Wed, 28 Jun 2023 16:29:54 +0000 (UTC) Received: by mail-lj1-x236.google.com with SMTP id 38308e7fff4ca-2b69f958ef3so62261471fa.1 for ; Wed, 28 Jun 2023 09:29:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687969793; x=1690561793; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=9eMvEkJ/XegETFODHiz62mk7KCxYtx3hl5+l1ieaHBA=; b=M2eG9b/rwLJbJ+ZYensGn99Z3sahqkhwgsICE+uWcaeCOhsMZixj0R91WrZhWHqvcT n077rgit6FDUr5nM+sZR6cA1yP9+24oT3o4DzuvO5+NGFm2ZSHsfTWKQSmmq2ClZweEH KU0lHXDJObPPbiBqKhxzrEB2ZPPFI8it67dn8IqsxVpiJmTQKFanRhkpwsx3UmQuQV6P FN0/+23yrw/BmMu+s+bAodxLNjgUYIK6dwYMMOG3TsEfZ5zhdfnvcisUm26xEq+oBd6v SElLQ5rIRNneoicmeE1ikfUOSowdZa11gUYoCWgqZo6j/h6BHzPhG0Fh1tzyJAUjIspc lUWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687969793; x=1690561793; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=9eMvEkJ/XegETFODHiz62mk7KCxYtx3hl5+l1ieaHBA=; b=Vj+x2tRZRylO+FUCwC58PEZVnVaTB1XUPR2vCKUbNcQi7eSEijQRRccgxbEtYqlRu0 Z7CaZJ6+6dGcP0883iaY6tMY5GGeCybGsJvcnJB2aTxD1f/xHvfeCBOSBjBQIr432BuC /xoPmJ7HEwCpL0J+0BE/M8lkcIAdEuS2Nm1r0H24C5xauXISOZkef7oL22v/bSOl7VLO yXYCy3lWisITLR28wj0MJQl57fIrFclklRfq3+ZAg0RWHMn3Y7cyNIRgu8AZvD4FszPK jU+jlZkT6r/MCLvIJDykT2EXg2065WNYU5vvvklNicg7UL8wOuu57Vpi2JBt9d0FaWbd Rd/w== X-Gm-Message-State: AC+VfDxVwcxsPEqMn1wyZa6nU/FE7sBZURemVVHyoUoiH+DbvOD6IZUf zywvm961f4tzLfdvbc+YZ69zyQ== X-Google-Smtp-Source: ACHHUZ51B3mrrRAOt7s7WF2oHJ0SQg/cpfsp3d3HETCr5iBgITcho1tWvUElbupu3H1F3zZdBZLC2g== X-Received: by 2002:a05:6512:2024:b0:4f9:dac6:2f41 with SMTP id s4-20020a056512202400b004f9dac62f41mr6940702lfs.2.1687969792904; Wed, 28 Jun 2023 09:29:52 -0700 (PDT) Received: from [192.168.1.101] (abyk82.neoplus.adsl.tpnet.pl. [83.9.30.82]) by smtp.gmail.com with ESMTPSA id v28-20020a056512049c00b004faeedbb29dsm1678783lfq.64.2023.06.28.09.29.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 09:29:52 -0700 (PDT) From: Konrad Dybcio Date: Wed, 28 Jun 2023 18:29:47 +0200 Subject: [PATCH 3/4] dt-bindings: display/msm: dsi-controller-main: Allow refgen-supply MIME-Version: 1.0 Message-Id: <20230628-topic-refgen-v1-3-126e59573eeb@linaro.org> References: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> In-Reply-To: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> To: Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687969785; l=919; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=PSg1b4zAMPXvW/Hco4OyLK9NQz9E7zBcyA/3he+DDzs=; b=+OPEQNKdq4VxxdpETYujbLytJ4CfZJo5uT5nocAXxJ+Eyh9ZqgvBwYThV/7U27B/FHOT38/Me IiuUpQ7aMsjCNHKV40ETBzW3EwM7J1JB/Vf8qqxL5H0O4LwU2c1qKah X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Konrad Dybcio , Marijn Suijten , freedreno@lists.freedesktop.org, Konrad Dybcio Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" DSI host needs REFGEN to be enabled (if it's present on a given platform). Allow consuming it. Signed-off-by: Konrad Dybcio Acked-by: Rob Herring --- .../devicetree/bindings/display/msm/dsi-controller-main.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml index 01848bdd5873..76270992305a 100644 --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml @@ -166,6 +166,10 @@ properties: description: Phandle to vdd regulator device node + refgen-supply: + description: + Phandle to REFGEN regulator device node + vcca-supply: description: Phandle to vdd regulator device node From patchwork Wed Jun 28 16:29:48 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Konrad Dybcio X-Patchwork-Id: 13296056 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 494BAEB64DA for ; Wed, 28 Jun 2023 16:30:07 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5185D10E377; Wed, 28 Jun 2023 16:30:06 +0000 (UTC) Received: from mail-lf1-x12c.google.com (mail-lf1-x12c.google.com [IPv6:2a00:1450:4864:20::12c]) by gabe.freedesktop.org (Postfix) with ESMTPS id D1A0010E37C for ; Wed, 28 Jun 2023 16:29:56 +0000 (UTC) Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-4fb8574a3a1so3425436e87.1 for ; Wed, 28 Jun 2023 09:29:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687969795; x=1690561795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SEhHQ8qdRfQQVMmnLHDVdeTjikaeU7SDTha8pASydDI=; b=DQZ8bQM6OK1Jdf9uCG5L3p0W5NUTxn2k5hoJpqJ89L7veP52vetsvHAr9/3u2T02s3 FwN4eefSkPJdvODiqNbplGuLRIWZ9Ug+o+/AbFNmiw3XMd8YQpmooiF/N1hUHh6vhSbk +ZrenMM5DtHlclnuBwZWPPEv3Ol5pFBCNQrhnDE8PhJzrMoTF3hwMBgVtWxIpX2LQ8Bh J8uqKwhu4k/HYE5Y5Jcu11vJbOynqrOf5likeOo+7J2v3/gC2Fd1cRt5h/ihwA/b/FZz zFCTB1P8rWz7AkjVdLLpogD/SCEe4jP4gZDSyaMdjoEdjth37IpwKnetCTIOvTGKKC7J ohjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687969795; x=1690561795; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SEhHQ8qdRfQQVMmnLHDVdeTjikaeU7SDTha8pASydDI=; b=SnUvhlDDcd9dOU6GUZTyyJKSLx5jyAJuM/qKt0XzWgVPHHfJdB6faIEf99x1wWBtQB 2s75930xsDrzZIqMyvOpGv4PAWk/HFmplYN6mu0PHdNAoVzPzLE9mEy6UOcOXwBzFEDX We++vcrihq94i+vduZ1mntODRDF1JqIZSbF7JXgjjHRXlO2LNCvN75nYp+vSObV2oF8/ Qnn0F4RLe7atQPkPouIkX+CtLZ3SgI8MEB5Zr82OJFkjTAeucgVPoHdH0QoeDcbedNXH W4QlUHhMnuZYkyBzXIrViduK9dY05kHboFvsuq55oa6DUCvD5X8msWaUpzwU3kduabei LkFA== X-Gm-Message-State: AC+VfDwrUcm9zvGWFPt4CG54DzWM2JS4K+ftGxSjUDpQwZxC37yBBRTU xTpwINNLtvqKVjEgy+op7dNRpw== X-Google-Smtp-Source: ACHHUZ4Lrm2R/nQcM5BRiDtkitE2zrl7ditARQnOGBg5dQFQzWYPnI075o/ZH3A36BQhfejWQM+KIg== X-Received: by 2002:a05:6512:3d26:b0:4fb:89c1:c209 with SMTP id d38-20020a0565123d2600b004fb89c1c209mr4023314lfv.62.1687969794861; Wed, 28 Jun 2023 09:29:54 -0700 (PDT) Received: from [192.168.1.101] (abyk82.neoplus.adsl.tpnet.pl. [83.9.30.82]) by smtp.gmail.com with ESMTPSA id v28-20020a056512049c00b004faeedbb29dsm1678783lfq.64.2023.06.28.09.29.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 09:29:54 -0700 (PDT) From: Konrad Dybcio Date: Wed, 28 Jun 2023 18:29:48 +0200 Subject: [PATCH 4/4] drm/msm/dsi: Hook up refgen regulator MIME-Version: 1.0 Message-Id: <20230628-topic-refgen-v1-4-126e59573eeb@linaro.org> References: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> In-Reply-To: <20230628-topic-refgen-v1-0-126e59573eeb@linaro.org> To: Andy Gross , Bjorn Andersson , Liam Girdwood , Mark Brown , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Clark , Abhinav Kumar , Dmitry Baryshkov , Sean Paul , David Airlie , Daniel Vetter , Krishna Manikandan X-Mailer: b4 0.12.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1687969785; l=1019; i=konrad.dybcio@linaro.org; s=20230215; h=from:subject:message-id; bh=bdVFkIHME+ksW97iOZJH0yeZoPTsVUfCpblAjJVbJjI=; b=k+jAhj46mh/Oof9GvJUQpt/J2u2Kf9BOt4qC0dCu0ivMbU0GBjjqGdhsVkkJrQVyrqAml8JoS YHTy+kjdBZUDW1wpX+4zBYjHF71ydli6DvpRMxSVeEkmb7N7RPRelKx X-Developer-Key: i=konrad.dybcio@linaro.org; a=ed25519; pk=iclgkYvtl2w05SSXO5EjjSYlhFKsJ+5OSZBjOkQuEms= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Konrad Dybcio , Marijn Suijten , freedreno@lists.freedesktop.org, Konrad Dybcio Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Consume the refgen supply on configurations that may use it. Signed-off-by: Konrad Dybcio --- drivers/gpu/drm/msm/dsi/dsi_cfg.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/msm/dsi/dsi_cfg.c b/drivers/gpu/drm/msm/dsi/dsi_cfg.c index 8a5fb6df7210..1f98ff74ceb0 100644 --- a/drivers/gpu/drm/msm/dsi/dsi_cfg.c +++ b/drivers/gpu/drm/msm/dsi/dsi_cfg.c @@ -160,6 +160,7 @@ static const char * const dsi_v2_4_clk_names[] = { static const struct regulator_bulk_data dsi_v2_4_regulators[] = { { .supply = "vdda", .init_load_uA = 21800 }, /* 1.2 V */ + { .supply = "refgen" }, }; static const struct msm_dsi_config sdm845_dsi_cfg = { @@ -191,6 +192,7 @@ static const struct msm_dsi_config sm8550_dsi_cfg = { static const struct regulator_bulk_data sc7280_dsi_regulators[] = { { .supply = "vdda", .init_load_uA = 8350 }, /* 1.2 V */ + { .supply = "refgen" }, }; static const struct msm_dsi_config sc7280_dsi_cfg = {