From patchwork Sun Jul 2 19:15:18 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 13299479 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DCF33EB64DA for ; Sun, 2 Jul 2023 19:15:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6125510E030; Sun, 2 Jul 2023 19:15:51 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0295510E01F for ; Sun, 2 Jul 2023 19:15:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688325347; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JDcEAV6QwSsPTLZL87iLrwMThHt45oSghNV/E5+yNmU=; b=Shbsp3SX/zV5slRa+k2Idn6v6O9oy715wMcpawUHMgDXHVc7LZHSLL+oFAFExYAHn0D/a+ 2LtZwOsWOdSeE/l6S22M76PHZnBRX2QN9MP+Sxe1gkmgtxbObtpPSY7l2Q+5H5vluZgzSe fRYTcZhcQgiUSukozqKYTM/xdWA3xBg= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-134-kNhlILF-MraMMffPgMlUog-1; Sun, 02 Jul 2023 15:15:44 -0400 X-MC-Unique: kNhlILF-MraMMffPgMlUog-1 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-313c930ee0eso1708292f8f.0 for ; Sun, 02 Jul 2023 12:15:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688325343; x=1690917343; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JDcEAV6QwSsPTLZL87iLrwMThHt45oSghNV/E5+yNmU=; b=YpFudtm8fZsLW41ETSaw6OnhJBB6HRDBHcRSErhvWTMs0S9euVqerDqG0V7T7Z12Zn v4a/FSxx+j2YqK4OzdEuNvwdXtmRYtI8W3VShPuc5hMUNizNTvvl0g7DUhgG6FdqAa35 ajkk7/998c0Egp2L0k71W2W8Yx+M+dBepCAzZzOdjdCM69wooh4Tx/aPFRZRGzbAjahc D1qQBsZirnHHoa7hJ1fWg36iDncs7aEO2bJEe8iFV9jmPjCqekuPLIRQZyWXGWCMqwLm x184ndUAkz553NUD8x3oRCl78HSg142/IUYsHiemJ1yfp/n8sZ3lggb0swzEfntPGQZu sgaA== X-Gm-Message-State: ABy/qLbkoguTMFw1rqhHu/FfYYSo3akL1/w7nTNpaSubUv5uCkae1ds1 6Em6GHygZAqxWza6R6F7y5p5k4jrbT8aMRKsl8cqii9wPJcJjd+X0q9bdlBH/2D0JxMBdHymo9N FVsY048Eyew9rsdH/9K7tqf8lmtwW X-Received: by 2002:adf:dd0a:0:b0:314:1a98:ebc0 with SMTP id a10-20020adfdd0a000000b003141a98ebc0mr6619304wrm.26.1688325343383; Sun, 02 Jul 2023 12:15:43 -0700 (PDT) X-Google-Smtp-Source: APBJJlEDpCbRzZteK5K4atZLapgedVl0F/kvFEX2HZm5FHmLp8U7TVJXppcUN0K6Sz/ypkNYMZhM6Q== X-Received: by 2002:adf:dd0a:0:b0:314:1a98:ebc0 with SMTP id a10-20020adfdd0a000000b003141a98ebc0mr6619298wrm.26.1688325343187; Sun, 02 Jul 2023 12:15:43 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g11-20020a7bc4cb000000b003fbab76165asm14144231wmk.48.2023.07.02.12.15.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 12:15:42 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH v3 1/3] drm: Improve Kconfig symbol prompt and help texts Date: Sun, 2 Jul 2023 21:15:18 +0200 Message-ID: <20230702191529.768248-2-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702191529.768248-1-javierm@redhat.com> References: <20230702191529.768248-1-javierm@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Arnd Bergmann , Javier Martinez Canillas , Maxime Ripard , Geert Uytterhoeven , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" The current text were not changed since the original Linux-2.6.12-rc2 git import. Let's improve it and make that more aligned with the DRM/KMS docs. Suggested-by: Geert Uytterhoeven Signed-off-by: Javier Martinez Canillas --- (no changes since v1) drivers/gpu/drm/Kconfig | 22 +++++++++++++--------- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index afb3b2f5f425..373f85e174c2 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -3,10 +3,11 @@ # Drm device configuration # # This driver provides support for the -# Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. +# Direct Rendering Infrastructure (DRI) that is composed of the Direct +# Rendering Manager (DRM) and Kernel Mode Settings (KMS) subsystems. # menuconfig DRM - tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)" + tristate "Direct Rendering Manager (DRM) and Kernel Mode Settings (KMS)" depends on (AGP || AGP=n) && !EMULATED_CMPXCHG && HAS_DMA select DRM_PANEL_ORIENTATION_QUIRKS select HDMI @@ -19,13 +20,16 @@ menuconfig DRM select VIDEO_CMDLINE select VIDEO_NOMODESET help - Kernel-level support for the Direct Rendering Infrastructure (DRI) - introduced in XFree86 4.0. If you say Y here, you need to select - the module that's right for your graphics card from the list below. - These modules provide support for synchronization, security, and - DMA transfers. Please see for more - details. You should also select and configure AGP - (/dev/agpgart) support if it is available for your platform. + Kernel-level support for the Direct Rendering Infrastructure (DRI), + that is composed of the Direct Rendering Manager (DRM) and Kernel + Mode Settings (KMS) subsystems. + + If you say Y here, you need to select the module that's right for + your graphics card from the list below. These modules provide support + for synchronization, security, and DMA transfers. + + Please see + for more details about the Linux DRM and KMS subsystems. config DRM_MIPI_DBI tristate From patchwork Sun Jul 2 19:15:19 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 13299480 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C0B92EB64DD for ; Sun, 2 Jul 2023 19:16:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 8C67110E04E; Sun, 2 Jul 2023 19:15:53 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0010E10E030 for ; Sun, 2 Jul 2023 19:15:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688325350; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O+OpQ8FhWL4vINUgdpBq2jtly/gGBeEwyQXrGSBuzmI=; b=EsCKDbMUWb8lYQ7lmJPVjtHWWJTyr/zBhS3A3aRSWuF23+Zc/qjILrjwUF5GPYS/+s/xzd jXW7gM9zpkq8BMJMi8WGnad8G5mfFIiO+C/3I+3XFDQVDQ+H2uRAhxd+GCMzudk/z1GFyA 57pslqcW9izYwdy4+j05sRfq3pOsN84= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-118-4smTHeNLMv6ZCHFjcsOB0w-1; Sun, 02 Jul 2023 15:15:49 -0400 X-MC-Unique: 4smTHeNLMv6ZCHFjcsOB0w-1 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-3fbb34f7224so22155875e9.2 for ; Sun, 02 Jul 2023 12:15:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688325348; x=1690917348; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=O+OpQ8FhWL4vINUgdpBq2jtly/gGBeEwyQXrGSBuzmI=; b=RESZRIK15ASS9lfIqU3PrbiBC3gntUw88BKsv2R4IeJKxlEnh2kIhQe4XkmwvMlH1W KIxg83JzmLtCxBQjeGESJDZf/oWbyOMIm6pTYQekLJ71kDPKfjvpIVzY/h/R9NG+keJ6 JsJfPlANgRK2HdrMj2L+Xog99bTm191dsT+4+CrHHA12Ugx/Ll0I+myEfSyrHtIOWMj1 Lq3TrBfPa2XETk+wtB5WH3wUV++mpcfRn+5JE2epnXztDy8Zo1zy0RIJtmYSveHogWAC 2DvODyU7OBnpAwsNdU06ZQ1nxeyaOaF7KcdFR4b1e3b6rfgNI+GiH9IkIZfhF3d3T6zs f5rw== X-Gm-Message-State: AC+VfDzsro2V4UcLYu37qJsGJYuVwbokBw2wYqCLYPh1npvHA0GRVPrL shUEG0pJOKDVras1grS2razVFIlKAZ7LdD8ACELbaPQ2fcqik2QsSs/NAcwv6XtZP6eu7Rn7sRI sm+kwuf41dU2luyTep77lDOlh9RB3 X-Received: by 2002:a1c:ed19:0:b0:3fb:407e:9b30 with SMTP id l25-20020a1ced19000000b003fb407e9b30mr6973012wmh.13.1688325347776; Sun, 02 Jul 2023 12:15:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6TEDx7mZMSKS0zMb7cTutew+fp0z6fzjfQL6TR1HiUxmFFKyKRmLqu7ujS36y1E7Z5uUniDA== X-Received: by 2002:a1c:ed19:0:b0:3fb:407e:9b30 with SMTP id l25-20020a1ced19000000b003fb407e9b30mr6972988wmh.13.1688325347442; Sun, 02 Jul 2023 12:15:47 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g11-20020a7bc4cb000000b003fbab76165asm14144231wmk.48.2023.07.02.12.15.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 12:15:47 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH v3 2/3] fbdev: Split frame buffer support in FB and FB_CORE symbols Date: Sun, 2 Jul 2023 21:15:19 +0200 Message-ID: <20230702191529.768248-3-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702191529.768248-1-javierm@redhat.com> References: <20230702191529.768248-1-javierm@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: x86@kernel.org, linux-fbdev@vger.kernel.org, Randy Dunlap , Arnd Bergmann , Greg Kroah-Hartman , Helge Deller , Dave Hansen , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, Sam Ravnborg , Ingo Molnar , Borislav Petkov , Thomas Zimmermann , "H. Peter Anvin" , Geert Uytterhoeven , Thomas Gleixner , Andy Shevchenko , Robert Jarzmik Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Currently the CONFIG_FB option has to be enabled even if no legacy fbdev drivers are needed (e.g: only to have support for framebuffer consoles). The DRM subsystem has a fbdev emulation layer, but depends on CONFIG_FB and so it can only be enabled if that dependency is enabled as well. That means fbdev drivers have to be explicitly disabled if users want to enable CONFIG_FB, only to use fbcon and/or the DRM fbdev emulation layer. This patch introduces a non-visible CONFIG_FB_CORE symbol that could be enabled just to have core support needed for CONFIG_DRM_FBDEV_EMULATION, allowing CONFIG_FB to be disabled (and automatically disabling all the fbdev drivers). Nothing from fb_backlight.o and fbmon.o is used by the DRM fbdev emulation layer so these two objects can be compiled out when CONFIG_FB is disabled. Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Really make a hidden symbol by removing the prompt (Arnd Bergmann). - Change FB_CORE to config instead of menuconfig (Arnd Bergmann). - Keep "depends on FB" for FIRMWARE_EDID (Arnd Bergmann). - Compile out fb_backlight.o and fbmon.o that are only needed for FB (Arnd Bergmann). - Make FB_DEVICE to depend on FB_CORE instead of selecting it. Changes in v2: - Keep "depends on FB" for FB_DDC, FB_HECUBA, FB_SVGALIB, FB_MACMODES, FB_BACKLIGHT, FB_MODE_HELPERS and FB_TILEBLITTING (Arnd Bergmann). - Don't change the fb.o object name (Arnd Bergmann). - Make FB_CORE a non-visible Kconfig symbol instead (Thomas Zimmermann). arch/x86/Makefile | 2 +- arch/x86/video/Makefile | 2 +- drivers/video/console/Kconfig | 2 +- drivers/video/fbdev/Kconfig | 40 +++++++++++++++++++------------ drivers/video/fbdev/core/Makefile | 8 +++---- 5 files changed, 32 insertions(+), 22 deletions(-) diff --git a/arch/x86/Makefile b/arch/x86/Makefile index b39975977c03..89a02e69be5f 100644 --- a/arch/x86/Makefile +++ b/arch/x86/Makefile @@ -259,7 +259,7 @@ drivers-$(CONFIG_PCI) += arch/x86/pci/ # suspend and hibernation support drivers-$(CONFIG_PM) += arch/x86/power/ -drivers-$(CONFIG_FB) += arch/x86/video/ +drivers-$(CONFIG_FB_CORE) += arch/x86/video/ #### # boot loader support. Several targets are kept for legacy purposes diff --git a/arch/x86/video/Makefile b/arch/x86/video/Makefile index 11640c116115..5ebe48752ffc 100644 --- a/arch/x86/video/Makefile +++ b/arch/x86/video/Makefile @@ -1,2 +1,2 @@ # SPDX-License-Identifier: GPL-2.0-only -obj-$(CONFIG_FB) += fbdev.o +obj-$(CONFIG_FB_CORE) += fbdev.o diff --git a/drivers/video/console/Kconfig b/drivers/video/console/Kconfig index a2a88d42edf0..1b5a319971ed 100644 --- a/drivers/video/console/Kconfig +++ b/drivers/video/console/Kconfig @@ -72,7 +72,7 @@ config DUMMY_CONSOLE_ROWS config FRAMEBUFFER_CONSOLE bool "Framebuffer Console support" - depends on FB && !UML + depends on FB_CORE && !UML select VT_HW_CONSOLE_BINDING select CRC32 select FONT_SUPPORT diff --git a/drivers/video/fbdev/Kconfig b/drivers/video/fbdev/Kconfig index cecf15418632..d436a4fd6f0a 100644 --- a/drivers/video/fbdev/Kconfig +++ b/drivers/video/fbdev/Kconfig @@ -6,10 +6,14 @@ config FB_NOTIFY bool +config FB_CORE + select VIDEO_CMDLINE + tristate + menuconfig FB - tristate "Support for frame buffer devices" + tristate "Support for frame buffer device drivers" + select FB_CORE select FB_NOTIFY - select VIDEO_CMDLINE help The frame buffer device provides an abstraction for the graphics hardware. It represents the frame buffer of some video hardware and @@ -33,6 +37,12 @@ menuconfig FB for more information. + This enables support for native frame buffer device (fbdev) drivers. + + The DRM subsystem provides support for emulated frame buffer devices + on top of KMS drivers, but this option allows legacy fbdev drivers to + be enabled as well. + Say Y here and to the driver for your graphics board below if you are compiling a kernel for a non-x86 architecture. @@ -59,7 +69,7 @@ config FIRMWARE_EDID config FB_DEVICE bool "Provide legacy /dev/fb* device" - depends on FB + depends on FB_CORE default y help Say Y here if you want the legacy /dev/fb* device file and @@ -75,7 +85,7 @@ config FB_DDC config FB_CFB_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the cfb_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own @@ -83,7 +93,7 @@ config FB_CFB_FILLRECT config FB_CFB_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the cfb_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated) @@ -91,7 +101,7 @@ config FB_CFB_COPYAREA config FB_CFB_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the cfb_imageblit function for generic software image blitting. This is used by drivers that don't provide their own @@ -99,7 +109,7 @@ config FB_CFB_IMAGEBLIT config FB_CFB_REV_PIXELS_IN_BYTE bool - depends on FB + depends on FB_CORE help Allow generic frame-buffer functions to work on displays with 1, 2 and 4 bits per pixel depths which has opposite order of pixels in @@ -107,7 +117,7 @@ config FB_CFB_REV_PIXELS_IN_BYTE config FB_SYS_FILLRECT tristate - depends on FB + depends on FB_CORE help Include the sys_fillrect function for generic software rectangle filling. This is used by drivers that don't provide their own @@ -115,7 +125,7 @@ config FB_SYS_FILLRECT config FB_SYS_COPYAREA tristate - depends on FB + depends on FB_CORE help Include the sys_copyarea function for generic software area copying. This is used by drivers that don't provide their own (accelerated) @@ -123,7 +133,7 @@ config FB_SYS_COPYAREA config FB_SYS_IMAGEBLIT tristate - depends on FB + depends on FB_CORE help Include the sys_imageblit function for generic software image blitting. This is used by drivers that don't provide their own @@ -162,22 +172,22 @@ endchoice config FB_SYS_FOPS tristate - depends on FB + depends on FB_CORE config FB_DEFERRED_IO bool - depends on FB + depends on FB_CORE config FB_IO_HELPERS bool - depends on FB + depends on FB_CORE select FB_CFB_COPYAREA select FB_CFB_FILLRECT select FB_CFB_IMAGEBLIT config FB_SYS_HELPERS bool - depends on FB + depends on FB_CORE select FB_SYS_COPYAREA select FB_SYS_FILLRECT select FB_SYS_FOPS @@ -185,7 +195,7 @@ config FB_SYS_HELPERS config FB_SYS_HELPERS_DEFERRED bool - depends on FB + depends on FB_CORE select FB_DEFERRED_IO select FB_SYS_HELPERS diff --git a/drivers/video/fbdev/core/Makefile b/drivers/video/fbdev/core/Makefile index 9150bafd9e89..2cd213716c12 100644 --- a/drivers/video/fbdev/core/Makefile +++ b/drivers/video/fbdev/core/Makefile @@ -1,10 +1,10 @@ # SPDX-License-Identifier: GPL-2.0 obj-$(CONFIG_FB_NOTIFY) += fb_notify.o -obj-$(CONFIG_FB) += fb.o -fb-y := fb_backlight.o \ - fb_info.o \ - fbmem.o fbmon.o fbcmap.o \ +obj-$(CONFIG_FB_CORE) += fb.o +fb-y := fb_info.o \ + fbmem.o fbcmap.o \ modedb.o fbcvt.o fb_cmdline.o fb_io_fops.o +fb-$(CONFIG_FB) += fb_backlight.o fbmon.o fb-$(CONFIG_FB_DEFERRED_IO) += fb_defio.o fb-$(CONFIG_FB_DEVICE) += fb_chrdev.o \ fb_procfs.o \ From patchwork Sun Jul 2 19:15:20 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 13299481 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E07DCEB64D9 for ; Sun, 2 Jul 2023 19:16:03 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7B42410E07C; Sun, 2 Jul 2023 19:15:55 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by gabe.freedesktop.org (Postfix) with ESMTPS id 31E4C10E048 for ; Sun, 2 Jul 2023 19:15:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1688325352; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BtebbbtsycpwEyNSye/8z5gGh26uqgxI4WhcsSrx/V0=; b=Fi/6/3SkBSBJkuTJ67jxVRigEW6AqKeSqSFF+jequoe1zoNq7ji2HZJr7e++de/kjAQyHN Ju/vW3dYlf1Y0BzEpndTQ8i+R65avSaiLBAvdVcU2WHt49WgiSe5WlnDPsehvy0w3a0eTr RIP41BiTVstHnpZCtY+IBxpRRiSVXa4= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-86-ktuMvFuPNSm1j3ZRNkCrHw-1; Sun, 02 Jul 2023 15:15:50 -0400 X-MC-Unique: ktuMvFuPNSm1j3ZRNkCrHw-1 Received: by mail-wr1-f72.google.com with SMTP id ffacd0b85a97d-31114af5e45so2116372f8f.1 for ; Sun, 02 Jul 2023 12:15:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688325349; x=1690917349; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=BtebbbtsycpwEyNSye/8z5gGh26uqgxI4WhcsSrx/V0=; b=glbLBwLhahfnAB58Kkus72wTV9mAIsPUr3UxQCdEFH4u45MF4ek70BNeZAs0EOKAUl W37bwW7XHSgnIFwgahtQPRZyiMRb9gzL8S38IpPJWNf7Va+1OFmSnAG1s5XyxJ4TcIvz WGI10F5GTRwKm4ygwIqaM31On0goyron1fKWBntMk116YRrTkCtrLOwq8Xb3a77uj1Sw eYy5XzxRkd7fZ4WN7s7bHSmUyMSwrB/Wx3/2q0SwXnt9RCe7VAw0wZNiP8VkIB1NtuGL VVW8pkrVcoVf++lz0b8oqNOZpoEIaFTLxGHVk0gV7EhyPF9VeEdajppOqScDBqw9qrts naUQ== X-Gm-Message-State: ABy/qLbizK034X82m94FvzpNl7DWyRFekLC0CnuweDATorIsylzKvc8P zb5geABvk89bO+ADBTFV0CZYYYlHn2LmNSjUwJQ4zakNbjVKdBKa+2m5yAVNFRES8XcUIH8gjpO l2tbQI/tn9+IAJmAbQ/C7H580YnDp X-Received: by 2002:adf:df03:0:b0:314:f88:4fea with SMTP id y3-20020adfdf03000000b003140f884feamr7089528wrl.8.1688325348942; Sun, 02 Jul 2023 12:15:48 -0700 (PDT) X-Google-Smtp-Source: APBJJlEyklTA8x1D+VHvsQUZVf1gre+qa/Wgc/bQ4CPKiC6Ihq07p7WS1Q0iaaxUngWXac/drZSALQ== X-Received: by 2002:adf:df03:0:b0:314:f88:4fea with SMTP id y3-20020adfdf03000000b003140f884feamr7089512wrl.8.1688325348614; Sun, 02 Jul 2023 12:15:48 -0700 (PDT) Received: from minerva.home (205.pool92-176-231.dynamic.orange.es. [92.176.231.205]) by smtp.gmail.com with ESMTPSA id g11-20020a7bc4cb000000b003fbab76165asm14144231wmk.48.2023.07.02.12.15.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 02 Jul 2023 12:15:48 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Subject: [PATCH v3 3/3] drm: Make FB_CORE to be selected if DRM fbdev emulation is enabled Date: Sun, 2 Jul 2023 21:15:20 +0200 Message-ID: <20230702191529.768248-4-javierm@redhat.com> X-Mailer: git-send-email 2.41.0 In-Reply-To: <20230702191529.768248-1-javierm@redhat.com> References: <20230702191529.768248-1-javierm@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas Zimmermann , Arnd Bergmann , Javier Martinez Canillas , Maxime Ripard , Geert Uytterhoeven , dri-devel@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Now that fbdev core has been split in FB_CORE and FB, make the DRM symbol to select the FB_CORE option if the DRM fbdev emulation layer is enabled. This allows to disable the CONFIG_FB option if is not needed, which will avoid the need to explicitly disable each of the legacy fbdev drivers. Signed-off-by: Javier Martinez Canillas --- Changes in v3: - Make the DRM symbol to select FB_CORE if DRM_FBDEV_EMULATION is enabled (Arnd Bergmann). - Also make DRM select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION - Make DRM_FBDEV_EMULATION to depend on DRM instead of DRM_KMS_HELPER. Changes in v2: - Make CONFIG_DRM_FBDEV_EMULATION to select FB_CORE (Thomas Zimmermann). drivers/gpu/drm/Kconfig | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/Kconfig b/drivers/gpu/drm/Kconfig index 373f85e174c2..07077708efd8 100644 --- a/drivers/gpu/drm/Kconfig +++ b/drivers/gpu/drm/Kconfig @@ -10,6 +10,9 @@ menuconfig DRM tristate "Direct Rendering Manager (DRM) and Kernel Mode Settings (KMS)" depends on (AGP || AGP=n) && !EMULATED_CMPXCHG && HAS_DMA select DRM_PANEL_ORIENTATION_QUIRKS + select DRM_KMS_HELPER if DRM_FBDEV_EMULATION + select FB_CORE if DRM_FBDEV_EMULATION + select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION select HDMI select I2C select DMA_SHARED_BUFFER @@ -99,7 +102,6 @@ config DRM_KUNIT_TEST config DRM_KMS_HELPER tristate depends on DRM - select FB_SYS_HELPERS_DEFERRED if DRM_FBDEV_EMULATION help CRTC helpers for KMS drivers. @@ -135,8 +137,7 @@ config DRM_DEBUG_MODESET_LOCK config DRM_FBDEV_EMULATION bool "Enable legacy fbdev support for your modesetting driver" - depends on DRM_KMS_HELPER - depends on FB=y || FB=DRM_KMS_HELPER + depends on DRM select FRAMEBUFFER_CONSOLE if !EXPERT select FRAMEBUFFER_CONSOLE_DETECT_PRIMARY if FRAMEBUFFER_CONSOLE default y