From patchwork Wed Jul 5 06:48:21 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13301712 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 41F27EB64DD for ; Wed, 5 Jul 2023 06:49:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cBaCqpDhD9UbPn3enPP9oVmLeHk5O2yMEh6ic9uU6Q8=; b=yVMgkR+oM3tkUg UDhyjozJSNg8NUgYVJOVdM+PcoH+llKE1uUKRd/iOhE4ZElR/1MQnsR0KswveyXsz1LnaqI8GQywE N2QzKRm4mroZSfAF9lEdFrVRXsns3irtfLAqMPw3VL3KfyyblLI27hmxT0pRVmCATvtNsysEx9Bk+ +NwFxZUaOD8WzY9XSc9tUKa9dJjY3uO+0MhzA85mT8thV+VIldw+rD2FQpeWGsOyywyBGorP9c5Z9 jUpDn/4zi7VIjqxP6O65jEaN6Bza/kt5rg0jxND/G4/dAGZXK5n2xkPIzORj4rV7NgnNyipv3hAWv 9A6pwBfO9HD/y6Uc3J3Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJp-00Ew3Q-2D; Wed, 05 Jul 2023 06:48:53 +0000 Received: from mail-ej1-x62c.google.com ([2a00:1450:4864:20::62c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJm-00Ew1G-1j for linux-rockchip@lists.infradead.org; Wed, 05 Jul 2023 06:48:51 +0000 Received: by mail-ej1-x62c.google.com with SMTP id a640c23a62f3a-992e22c09edso432915866b.2 for ; Tue, 04 Jul 2023 23:48:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688539728; x=1691131728; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=4BLpQcyu9Z+TkFkMMBNPXxj0TsUd7XYOG3VtXDiVEos=; b=hd2auJm2gJxE4NaPzfdgf5PK1CXoj2u+Yk2TzKUjTKUuiTR57+YdVsmoPUOSVY3uHK nZIqRZP+CHOzMM+ajppHFqCX2bLcbnAH7p6kiFs4MN/ffNpLpVGUotjq+IEdg22Y+aFJ gZAArYBhp5Y9VrkANFgq0PDYvXjoMqtwHnq9Xt8N+PWQRBOAKXfDP/ls1ItbOKLcLyfR FWKgS8WumdEdYJsGaa/MLDzxYJbixjGpIxKA3h2j8Gx0141ogqoRiYBhNs1piK6eNZiK +iv4iHQHsfbW+cAaLGb8Ax7bzq27wMHWMlI1I9nfGIsFNAmqV2HX4QwNjg85ETb15k5V dOlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688539728; x=1691131728; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=4BLpQcyu9Z+TkFkMMBNPXxj0TsUd7XYOG3VtXDiVEos=; b=VpOkWriCj050wwRWCsXJXg/n1izhfX6mZ6KCvC9rB3lBFqXz/k+QwfuGDtRt0tK6B9 h0jmAPuLDcX3D2fDpuTN1W8Z4MvdLHzPuueawWGkp1vUhmCutCvw2iR6ihh7yFNuhpLv IFtfE9yelhNzvQAGoJm085ePP++t5Me7FLFIVOcStKMzZBqMpYM7qFWKC2eV4crnFM3a fWChBHN54qxnvThyGlmDMsnmb9cDqxA6uZeFo4Eq/hICS9yFsUwluqz0dxXHJhbMbVbo A/jBfavSd9VK/DF6fCufY2sYPxfheVxgj/eFncQ7Osm9yaOiq/V4NmbBkv/5DZQ7uBzE Qgew== X-Gm-Message-State: ABy/qLbRUExlLa4IGVvZbTsQHv6Er76MwjdPhLfdM22dFEK8ClnTE/uP IjDCUzGKbef71etbIAeDXVMrBA== X-Google-Smtp-Source: APBJJlFdr/JqlYyk0Iw3f97ZqtublI4upHtqJRPCgBSEDqIv2RXPje/WG4Qau16mX2OZcIDrN04zeQ== X-Received: by 2002:a17:906:57ca:b0:96f:8666:5fc4 with SMTP id u10-20020a17090657ca00b0096f86665fc4mr11686557ejr.50.1688539728502; Tue, 04 Jul 2023 23:48:48 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lj14-20020a170906f9ce00b00992bea2e9d2sm7504836ejb.62.2023.07.04.23.48.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:48:48 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610 Date: Wed, 5 Jul 2023 08:48:21 +0200 Message-Id: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_234850_677226_89D538E2 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts index d1f343345f67..6464ef4d113d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-eaidk-610.dts @@ -773,7 +773,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Wed Jul 5 06:48:22 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13301713 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2F121C001B3 for ; Wed, 5 Jul 2023 06:49:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dKxGa6UOnbukBfxjgkGoKbTXYrrfKJ6HuQm4iVuzdPo=; b=3jxXaKgSDO0JHI EkEDzVrf5OG58VGYDCwscl3POU3xjmExdEibCZyfxnvHn738xcVV8zEwKLW7Wjq1iiY78A164sbSE rSOFLXoZkjm4DwVhUCM0Uc5i1TR8wkzxOUl3jTKQgAcPXpTec2b7skoeCaFemus9aDIrZDnrMPVx7 I1MLoFw3zmbedkHpreoq+P41jaa5ATsdok3zz8W+mftaCJFwImKYuDkqqrKrI1n60y/uNHA8QGB4U LaRvq9JcH/6z48nAy3hTEoPKDgYrCgYlv8muCBqbIDIPvcpgCMVoP7vlW6eKZWm9oozAxm4/ygK8o CaUBS1LdhpEZ8GnixdyA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJs-00Ew40-2C; Wed, 05 Jul 2023 06:48:56 +0000 Received: from mail-ej1-x62d.google.com ([2a00:1450:4864:20::62d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJn-00Ew1L-0h for linux-rockchip@lists.infradead.org; Wed, 05 Jul 2023 06:48:53 +0000 Received: by mail-ej1-x62d.google.com with SMTP id a640c23a62f3a-992acf67388so608430466b.1 for ; Tue, 04 Jul 2023 23:48:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688539729; x=1691131729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=u+MkrFMagkeIVy8ddwJ2oj2EHTlEbXRG0oh1YfYd/3Q=; b=iiIjNFLGPfjNj1fI30V62Stc1tnzX5ajqXD6ASSEccaJfwC3Z8MJ2KpUhYDD5cH0a7 onLqb4b4fXe9mNW+xfaqEI4MFTjKn+nuLKx6lpj5To7cIzsG4YDHiwXMTR7n69zXpCJB yonJuaE21eWHaezgbQTi2qw/ds0JHwuwXTF6ODm8TfMkrLwJgGHXovis3SfvqDlv25qD fmMpPRQxEEfi9CVKpPCkmtxz0dmFVYi7NZq4CY/bB0qcle6THyLWn5H9+U5AfD0toC9S anMvmvEaSgM1osViu/yAINGF3cWluHzXriqR79J9LKnm7kGgmq/pMQsrVQnkZMc7gABq gcPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688539729; x=1691131729; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=u+MkrFMagkeIVy8ddwJ2oj2EHTlEbXRG0oh1YfYd/3Q=; b=ibFQ/PmDDQzd5YAGeNf6w7MPkpqEbhLV9EcnNzg/NbpxgkB5NrXAyylAkYJPnGtEVX oJO644x5dkMkBRiSqunZRChKPR3N0ICiEUu6eRjNhdyw+Ayk2UweoYpetSeZnIhazMNN BCTczAhbAuzvAfvLytrIu+PWH+cqMz13em55unFzGLTyiOOnpq8y0n0nmdFJk12fRKBP J1MEMF9de5GRc+P9VeqgVOrd3uaDryM/IgMgEEbu332IPbBETnZuN8CJ2lfcfuCMWRI6 NoY6sfq3gWqsaszBllPOYgwKl85n9L26TS0Xw+O/INOFmCsA6kOioi4wsD40Tnbwr4P0 ucBw== X-Gm-Message-State: ABy/qLbtYG4EIlRroTo9klWb8qZiFuYgng+lk8mQeVfqow7nv2Lw6Wpd LIN/wDAhSc05/MzenDT58nqxhg== X-Google-Smtp-Source: APBJJlHZl5PdNH0abYjBIDke2wCYFd5fP0UDSLJrYwlY2J0QoorN8lhH7IR9wBK+aqDps2wJxkgQKQ== X-Received: by 2002:a17:906:37cc:b0:973:cc48:f19c with SMTP id o12-20020a17090637cc00b00973cc48f19cmr8818117ejc.56.1688539729764; Tue, 04 Jul 2023 23:48:49 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lj14-20020a170906f9ce00b00992bea2e9d2sm7504836ejb.62.2023.07.04.23.48.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:48:49 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 2/3] arm64: dts: rockchip: correct audio-codec interrupt flag in Rock Pi 4B Date: Wed, 5 Jul 2023 08:48:22 +0200 Message-Id: <20230705064823.9210-2-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> References: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_234851_250248_28B2DFEC X-CRM114-Status: GOOD ( 13.66 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW Signed-off-by: Krzysztof Kozlowski Tested-by: Christopher Obbard --- arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts index cec3b7b1b947..8a17c1eaae15 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts @@ -31,7 +31,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>; From patchwork Wed Jul 5 06:48:23 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 13301714 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E244DC001B0 for ; Wed, 5 Jul 2023 06:49:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=HLRsUavShXFG56nAxgLNwrRO4vMe5U3Zd/2TPkbZhQ4=; b=EPxaAEud13KmMc gI/duB8tGqGk7ZwfKMRRbY/Gqv9a6rI7igbvEDS8rcJbu26BTHrKiNxO/XtTWr4eEElpJDNLFJBBK yMVFcwBO57//rWCo7S0AxljssinmZZOcaRrZDz5BDfXg47ynKponhCdxNDbys03etOeRgzCaPQlPn diTvp1r9JodMAqcO8j0e0lBQnqmsVsCHZYNKUpV2viL/nhY3LTWP9R7uYBtYvJJcUe2Y/ChPtxOiX lmfGt+GcMHhn06kYbOf9w+JDy0tAtfz+IwQIOLV2WdjLxBidWUo1I8XS/UpC6lMfwqJG4I78lG8VR jd/C6unROGA4m+DytW5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJt-00Ew4Y-1t; Wed, 05 Jul 2023 06:48:57 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qGwJo-00Ew2J-1n for linux-rockchip@lists.infradead.org; Wed, 05 Jul 2023 06:48:53 +0000 Received: by mail-ed1-x52c.google.com with SMTP id 4fb4d7f45d1cf-51d9890f368so7052971a12.2 for ; Tue, 04 Jul 2023 23:48:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1688539731; x=1691131731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GB4bpNO3SAJRb4aZuiOoT5tlPntO7wrJyRlzhpgfep0=; b=D6HXcgpHibNmK6NkqhcOhTtIW5+ekU9iXxP97snkK3BNydz/RuVs6uGiuGiUOotYHc pJIMnec7dx93W7yNBm7gBJ3WuDLzdOM2JoWQ2C+Pf2fCE2T7VPbT5j8BpE5dOqkA9NF9 oaYY7rFY0iPy7STFlXVDbPz38v8etgYx4yYI28cBb7HWdymSgzfqiXV8Lu+HZ15cRyuk +A2aRwh8w+E1aGoNFZaf610DUh9YoIdypgtHu7f7p+jlvISmjSsVqJhQolms0NBmP/hb QzCP/CYVepxNleUQvOreWm4BGHNJfQWNAOYLBgqmzgBtfokh8u7Ug0VpQUtv6xipPxY/ lyag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688539731; x=1691131731; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GB4bpNO3SAJRb4aZuiOoT5tlPntO7wrJyRlzhpgfep0=; b=Y0WgHt4YsyFJo4B6uOvysviMqgBz/D7F92wy6nx2cExj3j7b+pIno/QxdYdg3DTnGj GqqejilvBWdiIMycqMvPFphVBHxgPU29MGIjYiEeQI3giibkWAgXLGr+w/sjxGhaVx5v jfjUP9sGDEr75+IRN/WiSo1+t5hPZRXFtnK6hUuS78LUlQHCxMrbWH32I48nB3FamZd7 /LZ1JQrUZXvkUK0g1NFoCSVrIgfi4XgCrbWFo1YrL259lBx/jnnjT6QdhNNROntEG54d 8ojEeUe5N8tmfQ+7uu76Fg9QTJfF4ZAIOw6I7xJYHXhTcL5MtY4/SlQywoxyX/252oLz 6I6A== X-Gm-Message-State: ABy/qLZkqPG1G4nyKlQaSA9jEsYKToseLir4j/LWpcZ9BMYrcJq4yi08 C8GCGiuHCW/4mADawpbXigazGQ== X-Google-Smtp-Source: APBJJlGqxp0nR/roJ4vSdQwDqZktpU71hnPcawgc4zAU5CBltXqnjOabo4Kgh5z0KdGtSqmZXiPVgg== X-Received: by 2002:a17:906:c28f:b0:978:90cc:bf73 with SMTP id r15-20020a170906c28f00b0097890ccbf73mr10185458ejz.48.1688539730997; Tue, 04 Jul 2023 23:48:50 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id lj14-20020a170906f9ce00b00992bea2e9d2sm7504836ejb.62.2023.07.04.23.48.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jul 2023 23:48:50 -0700 (PDT) From: Krzysztof Kozlowski To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Heiko Stuebner , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski Subject: [RFT PATCH 3/3] arm64: dts: rockchip: correct audio-codec interrupt flag in Box Demo Date: Wed, 5 Jul 2023 08:48:23 +0200 Message-Id: <20230705064823.9210-3-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> References: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230704_234852_594174_9498735A X-CRM114-Status: GOOD ( 13.60 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. These are simple defines so they could be used in DTS but they will not have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. Correct the interrupt flags, assuming the author of the code wanted same logical behavior behind the name "ACTIVE_xxx", this is: ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW Signed-off-by: Krzysztof Kozlowski --- arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts index 322f3e809f15..0c18406e4c59 100644 --- a/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts +++ b/arch/arm64/boot/dts/rockchip/rk3566-box-demo.dts @@ -416,7 +416,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio2>; - interrupts = ; + interrupts = ; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_h>;