From patchwork Sat Jul 8 14:06:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Simon Horman X-Patchwork-Id: 13305670 X-Patchwork-Delegate: kuba@kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 09AB03C04 for ; Sat, 8 Jul 2023 14:06:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A6834C433C7; Sat, 8 Jul 2023 14:06:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1688825202; bh=GemB8oDF11KrRtnmNhpuuDODQkHivxkHcWaUZbHnVPw=; h=From:Date:Subject:To:Cc:From; b=fxlV24v+e+/KiTmdjNI23U7pH4XQNhA0g0GbWnwBNK6HJnGw/W2qdn0LMRg6/3+cW U3kkZ7KDrFx2UgsPKLJ6jGzMnKRYj6PfWpf13QtcOdYFO4YPVnBI2rS8AW9gy11xpb dhnhQ+oyiEI2Mt0d46FcfDb916BIGAHZdPX+vWC5ZMuGnTQLvCtY8F/xDAirqgZRaj 2YaGewMGs+eGem7q5fkO2z/vdGrbGT4ssXnJJzziSDY0eziFzITFCVXvZ/odvP4wEA pXWkkVN14zP8ronpp6C492y+PfcOqF+jEnswf4jMjjXy76YV5XaTsNNWgaOI3fWOu+ VrHOGkR7yqArA== From: Simon Horman Date: Sat, 08 Jul 2023 15:06:25 +0100 Subject: [PATCH net] net: lan743x: select FIXED_PHY Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20230708-lan743x-fixed-phy-v1-1-3fd19580546c@kernel.org> X-B4-Tracking: v=1; b=H4sIAGBtqWQC/xXN0QrCMAyF4VcZuTZQ27GqryJeZGu0gRJHO2Uy9 u5ml/+Bj7NB4yrc4NZtUPkrTd5qcT51MGXSF6Mka/DOBxfdBQtp7MOKT1k54Zx/GHwcfOqvaaA A5kZqjGMlnbJJ/ZRi41z5EMfRHZQXeOz7H5vZ7Dh9AAAA To: "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni Cc: Pavithra Sathyanarayanan , Randy Dunlap , stable@vger.kernel.org, netdev@vger.kernel.org X-Mailer: b4 0.12.2 X-Patchwork-Delegate: kuba@kernel.org The blamed commit introduces usage of fixed_phy_register() but not a corresponding dependency on FIXED_PHY. This can result in a build failure. s390-linux-ld: drivers/net/ethernet/microchip/lan743x_main.o: in function `lan743x_phy_open': drivers/net/ethernet/microchip/lan743x_main.c:1514: undefined reference to `fixed_phy_register' Fixes: 624864fbff92 ("net: lan743x: add fixed phy support for LAN7431 device") Cc: stable@vger.kernel.org Reported-by: Randy Dunlap Closes: https://lore.kernel.org/netdev/725bf1c5-b252-7d19-7582-a6809716c7d6@infradead.org/ Reviewed-by: Randy Dunlap Tested-by: Randy Dunlap # build-tested Signed-off-by: Simon Horman --- drivers/net/ethernet/microchip/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/microchip/Kconfig b/drivers/net/ethernet/microchip/Kconfig index 24c994baad13..329e374b9539 100644 --- a/drivers/net/ethernet/microchip/Kconfig +++ b/drivers/net/ethernet/microchip/Kconfig @@ -46,7 +46,7 @@ config LAN743X tristate "LAN743x support" depends on PCI depends on PTP_1588_CLOCK_OPTIONAL - select PHYLIB + select FIXED_PHY select CRC16 select CRC32 help